conekta 0.5.6 → 0.5.7

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NjdiOWRmMGMxNDQxZWMwY2U1ZGM1MDZjMmFlMzEwMGZjOGFlNjU1Zg==
+    NzE0ZDk3OGI5ODI0YzllNmZiNzM2YjU4NDhjZDk5YWVjZGQ0ZmJmZA==
   data.tar.gz: !binary |-
-    YmE4OTUxMmU0ZWM3ZWE2MjhmZDA0ZDRlZjNlYjYxNDYxMmJlOGUyMg==
+    ZmJmYjlmYzY2NzA0NTkwMDQ5ZTA3ZDQ5MTY1ZTdjZmVkODQ4ZDA2Yg==
 SHA512:
   metadata.gz: !binary |-
-    ZDAwZWFiMTYxMzNhZDhmNDU1NmYxOTFiNWYzZDZhMTJhZTFhMTkzNmZmZjY5
-    MjE0ZjMwYTgwNTNkNGExZDgyYTlhZmVhMjVlNDU3MmIxYzIzNzcyNTFkNWI1
-    MjkxMWMzMjc2YWFhMTViNTFmNDQ3ZTc1MTdjM2U1ZWJkY2E1MGI=
+    ZWZlY2MzNDhjNTg0NzZiZGJlZjc1Nzc0NDk2ZGE1ZjI5Mzk4YTMxMjdjYTA1
+    OTA5MWRhY2QxZWU5YmE1YTIzZDkzMGYzZWYxMDI1MTdhNDBiNWI2NzAwYzQ5
+    YmM4ZDQyZDliZGQyYzNhM2E5NzQ1ZGUyMmNiOTUyZjU5NTU2ZmE=
   data.tar.gz: !binary |-
-    N2Q4MjgxNjBiYTNiMGJhNTM3MWIyYTRkNzg1OGYyMGZlZWQzOWU1NzRiOWZj
-    ODc3OGYzZjA0MzhhNjI3ODAwOWRkNWE4YjUxZDAyNmY1MTRkNGJiODMzMDRm
-    MzZiNDVjYzdmNDc3MzhlNTViMTY4Y2U0NTZjZWVjYzA5YmYwNTc=
+    MmFjODM4NWE1ODBlZDAxY2NlYzg1Y2QwNDVlYzJhN2M2ZTFjMjY5YzQzMzA2
+    ZGYzOGJiMmM5ZDNmYzg0YzUzYTNmNGZhZWQ4MzNjY2MxMTQ1OWRkMzU0MWY2
+    NWFiMGE5N2M4NzVjNjQ3MzU0NjVmZWNiMjgxZGIxMmUyODMxNWI=

data/CHANGELOG

@@ -67,4 +67,8 @@
 
 == 0.5.6 2015-12-29
 
-* Change parameter serialization using request body instead of connection params.
+* Change parameter serialization using request body instead of connection params.
+
+== 0.5.7 2016-07-19
+
+* Fix parameter handling for get requests.

data/Dockerfile

@@ -0,0 +1,44 @@
+FROM ubuntu:14.04
+
+MAINTAINER Leo Fischer
+
+RUN apt-get update
+RUN apt-get install -y vim git wget curl
+
+#setup test_user user
+RUN useradd -ms /bin/bash test_user
+RUN echo "test_user:sudo" | chpasswd
+RUN usermod -aG sudo test_user
+RUN mkdir -p /data/db/
+RUN chown test_user /data/db
+RUN sudo echo "test_user ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
+
+USER test_user
+ENV HOME /home/test_user
+
+RUN echo "set tabstop=2" >> ~/.vimrc
+RUN echo "set shiftwidth=2" >> ~/.vimrc
+RUN echo "set softtabstop=2" >> ~/.vimrc
+
+#install RVM and Ruby
+RUN gpg --keyserver hkp://keys.gnupg.net --recv-keys 409B6B1796C275462A1703113804BB82D39DC0E3
+RUN \curl -sSL https://get.rvm.io | sudo bash -s stable
+RUN sudo usermod -a -G rvm test_user
+RUN /bin/bash -l -c "rvm requirements"
+RUN /bin/bash -l -c "rvm install 1.9.3"
+RUN /bin/bash -l -c "rvm install 2.1.9"
+RUN /bin/bash -l -c "rvm install 2.2.4"
+RUN /bin/bash -l -c "rvm install 2.3.0"
+
+#configure external fs links
+WORKDIR $HOME
+
+#One Time Staging Steps
+RUN git clone https://github.com/conekta/conekta-ruby
+
+WORKDIR $HOME/conekta-ruby
+
+RUN /bin/bash -l -c "rvm use 1.9.3 && gem install bundle && bundle install"
+RUN /bin/bash -l -c "rvm use 2.1.9 && gem install bundle && bundle install"
+RUN /bin/bash -l -c "rvm use 2.2.4 && gem install bundle && bundle install"
+RUN /bin/bash -l -c "rvm use 2.3.0 && gem install bundle && bundle install"

data/README.md

@@ -1,6 +1,6 @@
 ![alt tag](https://raw.github.com/conekta/conekta-ruby/master/readme_files/cover.png)
 
-# Conekta Ruby v.0.5.6
+# Conekta Ruby v.0.5.7
 
 This is a ruby library that allows interaction with https://api.conekta.io API.
 
@@ -89,6 +89,22 @@ License
 -------
 Developed by [Conekta](https://www.conekta.io). Available with [MIT License](LICENSE).
 
+Development and Testing
+-----------------------
+Feel free to play with our library and make pull requests if you find any bugs.  You can run the test suite with rspec from the library's root directory:
+
+```shell
+bundle exec rspec
+```
+
+To facilitate the development and testing process you can use one our ruby docker, docker preloaded with rvm and ruby versions 1.9.3, 2.1.9, 2.2.4 and 2.3.0:
+
+```shell
+docker pull conekta/conekta-ruby
+
+docker run -ti conekta/conekta-ruby /bin/bash --login
+```
+
 We are hiring
 -------------
 

data/lib/conekta.rb

@@ -16,18 +16,20 @@ require "conekta/resource"
 require "conekta/requestor"
 require "conekta/util"
 require "conekta/error"
-require "conekta/payment_method"
+
+require "conekta/event"
 require "conekta/charge"
 require "conekta/customer"
 require "conekta/card"
-require "conekta/subscription"
-require "conekta/plan"
-require "conekta/token"
-require "conekta/event"
+require "conekta/log"
+require "conekta/method"
+require "conekta/payment_method"
 require "conekta/payee"
 require "conekta/payout"
 require "conekta/payout_method"
-require "conekta/method"
+require "conekta/plan"
+require "conekta/subscription"
+require "conekta/token"
 require "conekta/webhook"
 require "conekta/webhook_log"
 

data/lib/conekta/card.rb

@@ -3,11 +3,11 @@ module Conekta
     include Conekta::Operations::Delete
     include Conekta::Operations::Update
     include Conekta::Operations::CustomAction
-    def url
+    def _url
       raise Error.new(
         I18n.t('error.resource.id',  { resource: self.class.class_name, locale: :en }),
         I18n.t('error.resource.id_purchaser',  { locale: Conekta.locale.to_sym })) if (id.nil? || id.empty?)
-      self.customer.url + self.class.url + "/" + id
+      self.customer._url + self.class._url + "/" + id
     end
     def delete
       self.delete_member('customer','cards')

data/lib/conekta/conekta_object.rb

@@ -53,17 +53,17 @@ module Conekta
       self.class.name.split('::')[-1]
     end
     def create_attr(k,v)
-        # Conflict with Resource Class Url
-        k = "webhook_url" if k.to_s == "url"
-        # Conflict with Resource Class Url
+      # Conflict with Resource Class Url
+      if ! k.to_s.match(/-/) and ! k.to_s.match(/^[0-9]+/)
         create_method( "#{k}=".to_sym ) { |val| 
             instance_variable_set( "@" + k, val)
         }
         self.send("#{k}=".to_sym, v)
         self.class.send(:remove_method, "#{k}=".to_sym)
         create_method( k.to_sym ) { 
-            instance_variable_get( "@" + k ) 
+          instance_variable_get( "@" + k ) 
         }
+      end
     end
     protected
     def to_hash

data/lib/conekta/log.rb

@@ -0,0 +1,6 @@
+module Conekta
+  class Log < Resource
+    include Conekta::Operations::Where
+    include Conekta::Operations::Find
+  end
+end

data/lib/conekta/operations/create.rb

@@ -3,8 +3,8 @@ module Conekta
     module Create
       module ClassMethods
         def create(params)
-          url = Util.types[self.class_name.downcase].url
-          response = Requestor.new.request(:post, url, params)
+          _url = Util.types[self.class_name.downcase]._url
+          response = Requestor.new.request(:post, _url, params)
           instance = self.new
           instance.load_from(response)
           instance

data/lib/conekta/operations/create_member.rb

@@ -2,9 +2,9 @@ module Conekta
   module Operations
     module CreateMember
       def create_member(member, params)
-        url = [self.url, member].join('/')
+        _url = [self._url, member].join('/')
         member = member.to_sym
-        response = Requestor.new.request(:post, url, params)
+        response = Requestor.new.request(:post, _url, params)
 
         if self.method(member).call and self.method(member).call.class.class_name == "ConektaObject"
           arr = []

data/lib/conekta/operations/custom_action.rb

@@ -2,8 +2,8 @@ module Conekta
   module Operations
     module CustomAction
       def custom_action(method, action=nil, params=nil)
-        url = action ? [self.url, action].join('/') : self.url
-        response = Requestor.new.request(method, url, params)
+        _url = action ? [self._url, action].join('/') : self._url
+        response = Requestor.new.request(method, _url, params)
 
         self.load_from(response)
         self

data/lib/conekta/operations/find.rb

@@ -4,7 +4,7 @@ module Conekta
       module ClassMethods
         def find(id)
           instance = self.new(id)
-          response = Requestor.new.request(:get, instance.url)
+          response = Requestor.new.request(:get, instance._url)
           instance.load_from(response)
           instance
         end

data/lib/conekta/operations/update.rb

@@ -2,7 +2,7 @@ module Conekta
   module Operations
     module Update
       def update(params)
-        response = Requestor.new.request(:put, self.url, params)
+        response = Requestor.new.request(:put, self._url, params)
         self.load_from(response)
         self
       end

data/lib/conekta/operations/where.rb

@@ -4,8 +4,8 @@ module Conekta
       module ClassMethods
         def where(params=nil)
           instance = ConektaObject.new
-          url = Util.types[self.class_name.downcase].url
-          response = Requestor.new.request(:get, url,params)
+          _url = Util.types[self.class_name.downcase]._url
+          response = Requestor.new.request(:get, _url, params)
           instance.load_from(response)
           instance
         end

data/lib/conekta/payout_method.rb

@@ -3,11 +3,11 @@ module Conekta
     include Conekta::Operations::Delete
     include Conekta::Operations::Update
     include Conekta::Operations::CustomAction
-    def url
+    def _url
       raise Error.new(
         I18n.t('error.resource.id',  { resource: self.class.class_name, locale: :en }),
         I18n.t('error.resource.id_purchaser',  { locale: Conekta.locale.to_sym })) if (id.nil? || id.empty?)
-      self.payee.url + self.class.url + "/" + id
+      self.payee._url + self.class._url + "/" + id
     end
     def delete
       self.delete_member('payee','payout_methods')

data/lib/conekta/requestor.rb

@@ -12,19 +12,19 @@ module Conekta
       @api_key = Conekta.api_key
     end
 
-    def api_url(url='')
+    def api_url(_url='')
       api_base = Conekta.api_base
-      api_base + url
+      api_base + _url
     end
 
-    def request(meth, url, params=nil)
-      url = self.api_url(url)
+    def request(meth, _url, params = nil)
+      _url = self.api_url(_url)
       meth = meth.downcase
 
       begin
-        connection = build_connection(url, params)
+        connection = build_connection(_url, params)
         response = connection.method(meth).call do |req|
-          req.body = params.to_json if params
+          (if meth == :get then req.params = params else req.body = params.to_json end) if params
         end
       rescue Exception => e
         Error.error_handler(e, "")
@@ -36,9 +36,9 @@ module Conekta
 
     private
 
-    def build_connection(url, params = nil)
+    def build_connection(_url, params = nil)
       connection = Faraday.new(
-       :url => url,
+       :url => _url,
        :ssl => { :ca_file=> File.dirname(__FILE__) + '/../ssl_data/ca_bundle.crt'}
        ) do |faraday|
         faraday.adapter  Faraday.default_adapter
@@ -68,4 +68,4 @@ module Conekta
       }
     end
   end
-end
+end

data/lib/conekta/resource.rb

@@ -1,14 +1,14 @@
 module Conekta
   class Resource < ConektaObject
-    def self.url()
+    def self._url()
       "/#{CGI.escape(self.class_name.downcase)}s"
     end
-    def url
+    def _url
       raise Error.new(
         I18n.t('error.resource.id',  { resource: self.class.class_name, locale: :en }),
         I18n.t('error.resource.id_purchaser',  { locale: Conekta.locale.to_sym })) if (id.nil? || id.empty?)
 
-      return [self.class.url, id].join('/')
+      return [self.class._url, id].join('/')
     end
   end
 end

data/lib/conekta/subscription.rb

@@ -2,11 +2,11 @@ module Conekta
   class Subscription < Resource
     include Conekta::Operations::Update
     include Conekta::Operations::CustomAction
-    def url
+    def _url
       raise Error.new(
         I18n.t('error.resource.id',  { resource: self.class.class_name, locale: :en }),
         I18n.t('error.resource.id_purchaser',  { locale: Conekta.locale.to_sym })) if (id.nil? || id.empty?)
-      self.customer.url + "/subscription"
+      self.customer._url + "/subscription"
     end
     def pause
       custom_action(:post, 'pause')

data/lib/conekta/util.rb

@@ -2,22 +2,23 @@ module Conekta
   module Util
     def self.types
       @types ||= {
-        'webhook' => Webhook,
-        'webhook_log' => WebhookLog,
-        'bank_transfer_payout_method' => Method,
-        'payout' => Payout,
-        'payee' => Payee,
-        'payout_method' => PayoutMethod,
         'bank_transfer_payment' => PaymentMethod,
+        'bank_transfer_payout_method' => Method,
+        'card' => Card,
         'card_payment' => PaymentMethod,
         'cash_payment' => PaymentMethod,
         'charge' => Charge,
         'customer' => Customer,
-        'card' => Card,
-        'subscription' => Subscription,
+        'event' => Event,
+        'log' => Log,
+        'payee' => Payee,
+        'payout' => Payout,
+        'payout_method' => PayoutMethod,
         'plan' => Plan,
+        'subscription' => Subscription,
         'token' => Token,
-        'event' => Event
+        'webhook' => Webhook,
+        'webhook_log' => WebhookLog,
       }
     end
     def self.convert_to_conekta_object(name,resp)

data/lib/conekta/version.rb

@@ -1,3 +1,3 @@
 module Conekta
-  VERSION = '0.5.6'.freeze
+  VERSION = '0.5.7'.freeze
 end

data/spec/conekta/charge_spec.rb

@@ -3,14 +3,46 @@ require 'spec_helper'
 describe Conekta::Charge do
   let(:payment_method) do
     {
-      amount: 2000, currency: 'mxn', description: 'Some desc'
+      amount: 2000, 
+      currency: 'mxn', 
+      description: 'Some desc',
+      details: {
+        name: "Wolverine",
+        email: "logan.thomas@xmen.org",
+        phone: "403-342-0642",
+        line_items: [{
+          name: "Shades",
+          description: "Imported From Mex.",
+          unit_price: 20000,
+          quantity: 1,
+          sku: "cohb_s1",
+          category: "eyewear"
+        }]
+      }
     }
   end
+
   let(:invalid_payment_method) do
     {
-      amount: 10, currency: 'mxn', description: 'Some desc'
+      amount: 10, 
+      currency: 'mxn', 
+      description: 'Some desc',
+      details: {
+        name: "Wolverine",
+        email: "logan.thomas@xmen.org",
+        phone: "403-342-0642",
+        line_items: [{
+          name: "Shades",
+          description: "Imported From Mex.",
+          unit_price: 20000,
+          quantity: 1,
+          sku: "cohb_s1",
+          category: "eyewear"
+        }]
+      }
     }
   end
+
   let(:card) { { card: 'tok_test_visa_4242' } }
 
   context "get" do
@@ -26,6 +58,18 @@ describe Conekta::Charge do
       charge = charges.first
       expect(charge).to be_a(Conekta::Charge)
     end
+    it "test succesful where status 'pending_payment'" do
+      charges = Conekta::Charge.where({status: 'pending_payment'})
+      charges.map{|index, charge|
+        expect(charge.status).to eq("pending_payment")
+      }
+    end
+    it "test succesful where status 'paid'" do
+      charges = Conekta::Charge.where({status: 'paid'})
+      charges.map{|index, charge|
+        expect(charge.status).to eq("paid")
+      }
+    end
   end
 
   context "creating charges" do

data/spec/conekta/log_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe Conekta::Log do
+  it "test successful where" do
+    events = Conekta::Log.where
+    expect(events.class_name).to eq("ConektaObject")
+    expect(events[0].class_name).to eq("Log")
+  end
+
+  it "test successful find" do
+    events = Conekta::Log.where
+    e = events.first
+
+    event = Conekta::Log.find(e.id)
+
+    expect(event).to be_a(Conekta::Log)
+    expect(event.class_name).to eq("Log")
+  end
+end

data/spec/conekta/webhook_spec.rb

@@ -21,13 +21,15 @@ describe Conekta::Webhook do
   end
   let(:url) { { url: "http://localhost:3000/my_listener" } }
 
-  it "succesfully gets charge" do
-    webhook =  Conekta::Webhook.create(url.merge(events))
-    expect(webhook.webhook_url).to eq(url[:url])
-    webhook = Conekta::Webhook.find(webhook.id)
-    expect(webhook.webhook_url).to eq(url[:url])
-    webhook.update({url: "http://localhost:2000/my_listener"})
-    expect(webhook.webhook_url).to eq("http://localhost:2000/my_listener")
-    webhook.delete
-  end
+  # This spec was commented to avoid webhook creation saturation.
+  # 
+  # it "succesfully gets charge" do
+  #   webhook =  Conekta::Webhook.create(url.merge(events))
+  #   expect(webhook.url).to eq(url[:url])
+  #   webhook = Conekta::Webhook.find(webhook.id)
+  #   expect(webhook.url).to eq(url[:url])
+  #   webhook.update({url: "http://localhost:2000/my_listener"})
+  #   expect(webhook.url).to eq("http://localhost:2000/my_listener")
+  #   webhook.delete
+  # end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: conekta
 version: !ruby/object:Gem::Version
-  version: 0.5.6
+  version: 0.5.7
 platform: ruby
 authors:
 - MauricioMurga
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-29 00:00:00.000000000 Z
+date: 2016-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -118,6 +118,7 @@ files:
 - .gitignore
 - .rspec
 - CHANGELOG
+- Dockerfile
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -130,6 +131,7 @@ files:
 - lib/conekta/customer.rb
 - lib/conekta/error.rb
 - lib/conekta/event.rb
+- lib/conekta/log.rb
 - lib/conekta/method.rb
 - lib/conekta/operations/create.rb
 - lib/conekta/operations/create_member.rb
@@ -159,6 +161,7 @@ files:
 - spec/conekta/customer_spec.rb
 - spec/conekta/error_spec.rb
 - spec/conekta/event_spec.rb
+- spec/conekta/log_spec.rb
 - spec/conekta/payee_spec.rb
 - spec/conekta/payout_spec.rb
 - spec/conekta/plan_spec.rb
@@ -195,6 +198,7 @@ test_files:
 - spec/conekta/customer_spec.rb
 - spec/conekta/error_spec.rb
 - spec/conekta/event_spec.rb
+- spec/conekta/log_spec.rb
 - spec/conekta/payee_spec.rb
 - spec/conekta/payout_spec.rb
 - spec/conekta/plan_spec.rb