conduit 1.0.3 → 1.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ff4f0e5f7f702375659f970ab9ed86f2ce673ca7
-  data.tar.gz: 88ebd51ff6273ba6dad93c01d60f0b78851ddfec
+  metadata.gz: 3bb1b8f51e94f9a01e34b93b204ddcc665f0fa97
+  data.tar.gz: 83f0645c72bea202ad14ee8feda10aeb2a343847
 SHA512:
-  metadata.gz: 6106383b60779d51424c96d3319c439a76498c6bc33918f4cdf5363deb6da42666144054210b93bcc0bdb44f4f24e75aa80b9cfd2138f2472d65c977b596a129
-  data.tar.gz: 2b6eeb302b22fc3d3e91eb46555d3ad5eeb3c6e698288f2c1624733b02cf39de54a22456a833f5fef969d9ac1e815fcd2d0d5b1d65ce696e9fcafd5669aedc37
+  metadata.gz: 017b4f44d22ef1b74dd5d032ca1a8f52978e4e27abf59e730144d6a818891425613433b3a8e360174d7e06dbd4c4dfed0568b92a0a4fa7ce479136f474d47835
+  data.tar.gz: 41918d02a479a3fc530ca6061dc54d2982543f37cf7ac43b79ea4e43f5fdc64f48eb8fd9ad5f375f92dc70d6883c10480fe739742fa9849a6372345d7119cb3a

data/lib/conduit/blueprints/generators/action.tt

@@ -1,6 +1,5 @@
 require "thor/group"
 require "active_support"
-require "byebug"
 
 module Conduit
   module <%= classified_name %>

data/lib/conduit/blueprints/generators/blueprints/action.tt

@@ -2,8 +2,6 @@ require_relative "base"
 
 module Conduit::Driver::<%= classified_name %>
   class <%%= classified_name %> < Conduit::Driver::<%= classified_name %>::Base
-    operation :<%%= underscored_name %>
-
     # Required attributes go here
     # required_attributes :required_attribute_name
 

data/lib/conduit/blueprints/parsers/base.tt

@@ -18,7 +18,7 @@ module Conduit::Driver::<%= classified_name %>
       # Extracts the camelized attribute from the xml response
       def self.attribute(attr_name, &block)
         block ||= lambda do
-          content_for "//#{ActiveSupport::Inflector.camelize(attr_name, false)}"
+          content_for "//#{inflector_method(attr_name)}"
         end
         super(attr_name, &block)
       end
@@ -57,12 +57,8 @@ module Conduit::Driver::<%= classified_name %>
       # Returns normalized request errors if present.
       def response_errors
         if response_content?
-          if !content_for("//Fault").nil?
-            [normalized_fault]
-          else
-            # Returns empty array if no errors
-            normalized_errors
-          end
+          # Returns empty array if no errors
+          normalized_errors
         else
           [Conduit::Error.new(message: "Unexpected response from server.")]
         end
@@ -76,42 +72,29 @@ module Conduit::Driver::<%= classified_name %>
 
       private
 
+      # Camelize `attr_name` while keeping first character lower case
+      def inflector_method attr_name
+        ActiveSupport::Inflector.camelize(attr_name, false)
+      end
+
       # Indicates if a request is in progress. Used for async requests.
       # Should be overwritten in the action's parser in case true.
       def in_progress?
         false
       end
 
-      # Returns a new `Conduit::Error` instance containing the fault text
-      # and the fault code.
-      def normalized_fault
-        # TODO: replace this if error message and code not present in the
-        # below paths
-        Conduit::Error.new({
-          message: content_for("//Fault//Text"),
-          code: content_for("//Fault//Code//Value")
-        })
-      end
-
-      # Extracts the error from either `errorMessage` or `errorText`
-      def error_response
-        # TODO: replace this if error response not present in any of the following
-        # paths.
-        content_for("//errorMessage") || content_for("//errorText")
-      end
-
-      # Returns a new `Conduit::Error` instance containing the error message and
-      # its code.
+      # Returns an array of `Conduit::Error` instances containing the error
+      # messages and codes.
       def normalized_errors
-        # TODO: replace this if error not present in `error_message` and code
-        # not present in `errorNumber`
-        if error_response && !error_response.empty?
-          [
+        # TODO: replace this if error not present in `error` node or `code` and
+        # `message` paths different.
+        if content_for("//error")
+          root.xpath("//error").map do |error|
             Conduit::Error.new({
-              message: error_response,
-              code: content_for("errorNumber")
+              message: content_for("message", error),
+              code: content_for("code", error)
             })
-          ]
+          end
         else
           []
         end

data/lib/conduit/cli.rb

@@ -113,7 +113,7 @@ module Conduit
       # add gemspec dependencies
       str = "  # Dependencies\n"\
             "  #\n"\
-            "  spec.add_dependency \"conduit\", \"~> 1.0.3\"\n"\
+            "  spec.add_dependency \"conduit\", \"~> 1.0.4\"\n"\
             "  # xml parser\n"\
             "  spec.add_dependency \"nokogiri\"\n"\
             "  # to get string inflectors\n"\

data/lib/conduit/core/action.rb

@@ -136,7 +136,7 @@ module Conduit
         #
         def perform_request
           response = request(body: view, method: :post)
-          parser_instance = parser.new(response.body)
+          parser_instance = parser_class.new(response.body)
 
           Conduit::ApiResponse.new(raw_response: response, parser: parser_instance)
         end
@@ -189,7 +189,7 @@ module Conduit
         # Returns the parser for this action subclasses responsible for providing
         # the response_body and response_status.
         #
-        def parser
+        def parser_class
           self.class.const_get(:Parser)
         end
 

data/lib/conduit/version.rb

@@ -1,3 +1,3 @@
 module Conduit
-  VERSION = '1.0.3'
+  VERSION = '1.0.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: conduit
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
 platform: ruby
 authors:
 - Mike Kelley
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-10-05 00:00:00.000000000 Z
+date: 2016-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -237,7 +237,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Conduit is an interface for debit platforms.