conductor 0.8.1 → 0.8.3

data/VERSION

@@ -1 +1 @@
-0.8.1
+0.8.3

data/lib/conductor.rb

@@ -1,17 +1,7 @@
-require 'conductor/experiment'
-require 'conductor/roll_up'
-require 'conductor/weights'
-require 'conductor/experiment/raw'
-require 'conductor/experiment/daily'
-require 'conductor/experiment/weight'
-require 'conductor/experiment/history'
-require 'conductor/controller/dashboard'
-require 'conductor/helpers/dashboard_helper'
-
-
 class Conductor
   MAX_WEIGHTING_FACTOR = 1.25
   EQUALIZATION_PERIOD_DEFAULT = 7
+  MINIMUM_CONVERSIONS_PER_GROUP_DEFAULT = 10
   DBG = false
 
   cattr_writer :cache
@@ -45,6 +35,19 @@ class Conductor
       return (@inclusion_period || 14)
     end
     
+    # The minimum number of conversions that a group needs to have in TOTAL before 
+    # weighting is allowed.  
+    #
+    # TODO: trigger a notification if a post equalized group hits below this number
+    def minimum_conversions_per_group=(value)
+      raise "Conductor.minimum_conversions_per_group must be a positive number > 0" unless value.is_a?(Numeric) && value > 0
+      @minimum_conversions_per_group = value
+    end
+    
+    def minimum_conversions_per_group
+      return (@minimum_conversions_per_group || MINIMUM_CONVERSIONS_PER_GROUP_DEFAULT)
+    end
+    
     # The equalization period is the initial amount of time, in days, that conductor 
     # should apply the max_weighting_factor towards a new alternative to ensure 
     # that it receives a far shot of performing.
@@ -62,16 +65,16 @@ class Conductor
     end
     
     # The attribute for weighting specifies if the conversion_value OR number of conversions 
-    # should be used to calculate the weight.  The default is conversion_value.
+    # should be used to calculate the weight.  The default is conversions.
     #
-    # TODO: Allow of avg_conversion_value where acv = conversion_value / conversions
+    # TODO: Change this to only use conversion rate when normalization is figured out
     def attribute_for_weighting=(value)
       raise "Conductor.attribute_for_weighting must be either :views, :conversions or :conversion_value (default)" unless [:views, :conversions, :conversion_value].include?(value) 
       @attribute_for_weighting = value
     end
     
     def attribute_for_weighting
-      return (@attribute_for_weighting || :conversion_value)
+      return (@attribute_for_weighting || :conversions)
     end
 
     def log(msg)

data/lib/conductor/roll_up.rb

@@ -20,7 +20,7 @@ class Conductor
           end
           
           # delete the cache for this group so it can be recreated with the new values
-          Conductor.cache.delete("Conductor::Experiment::#{group_name}::Alternatives")
+          Conductor.cache.delete("Conductor::Experiment::#{Conductor.attribute_for_weighting}::#{group_name}::Alternatives")
         end
       end
     end

data/lib/conductor/weights.rb

@@ -1,5 +1,5 @@
 class Conductor
-  class Weights
+  class Weights 
     class << self
 
       # Returns all the weights for a given group.  In the event that the alternatives specified for the
@@ -42,7 +42,7 @@ class Conductor
         max_weight = 0
         unless post_equalization_data.empty?
           total = post_equalization_data.sum_it(Conductor.attribute_for_weighting)
-          data = (total > 0) ? compute_weights(post_equalization_data, total, max_weight) : assign_equal_weights(post_equalization_data)
+          data = (total >= Conductor.minimum_conversions_per_group) ? compute_weights(post_equalization_data, total, max_weight) : assign_equal_weights(post_equalization_data)
         end
 
         # add weights for recently launched

data/rails/init.rb

@@ -1,4 +1,6 @@
-require 'conductor'
+# require all files in lib directory
+Dir["#{File.dirname(__FILE__)}/../lib/**/*.rb"].each { |f| require f }
+
 require 'gchart'
 
 ActionView::Base.send :include, DashboardHelper

data/test/test_conductor.rb

@@ -187,11 +187,12 @@ class TestConductor < Test::Unit::TestCase
       # hit after rollup to populare weight table
       Conductor.identity = ActiveSupport::SecureRandom.hex(16)
       Conductor.equalization_period = 7
-      selected = Conductor::Experiment.pick('a_group', ["a", "b", "c"])
+      weights = Conductor::Experiment.weights('a_group', ["a", "b", "c"])
 
       # each weight will be equal to 0.18
       assert_equal 7, Conductor.equalization_period
-      assert_equal 0.54, Conductor::Experiment::Weight.all.sum_it(:weight).to_f
+      assert_equal weights['a'], weights['b']
+      assert_equal weights['c'], weights['b']
     end
   end
 
@@ -282,6 +283,45 @@ class TestConductor < Test::Unit::TestCase
       assert_not_equal weights_cv, weights_c
     end
   end
+  
+  context "conductor" do
+    setup do
+      seed_raw_data(500, 30)
+
+      # rollup
+      Conductor::RollUp.process
+    end
+
+    should "weight everything equally if the minimum number of conversions per group has not been hit" do
+      Conductor::Experiment::Daily.update_all('conversion_value = 0.00, conversions = 0')
+      Conductor::Experiment::Daily.update_all('conversion_value = 1.00, conversions = 1', '', :limit => 10)
+      
+      Conductor.identity = ActiveSupport::SecureRandom.hex(16)
+      Conductor.attribute_for_weighting = :conversions
+      Conductor.minimum_conversions_per_group = 15
+      
+      weights = Conductor::Experiment.weights('a_group', ["a", "b", "c"])
+      assert_equal weights['a'], weights['b']
+      assert_equal weights['c'], weights['b']
+    end
+    
+    should "weight everything correctly if the minimum number of conversions per group HAS been hit" do
+      Conductor::Experiment::Daily.update_all('conversion_value = 0.00, conversions = 0')
+      Conductor::Experiment::Daily.all.each_with_index {|x,ndx|
+          if ndx < 10
+            x.update_attributes(:conversion_value => rand(100), :conversions => rand(20))
+          end
+        }
+      
+      Conductor.identity = ActiveSupport::SecureRandom.hex(16)
+      Conductor.attribute_for_weighting = :conversions
+      
+      weights = Conductor::Experiment.weights('a_group', ["a", "b", "c"])
+      assert_not_equal weights['a'], weights['b']
+      assert_not_equal weights['c'], weights['b']
+    end
+  end
+  
 
 
   private

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 8
-  - 1
-  version: 0.8.1
+  - 3
+  version: 0.8.3
 platform: ruby
 authors: 
 - Noctivity
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-03 00:00:00 -04:00
+date: 2010-10-04 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -63,20 +63,20 @@ files:
 - generators/conductor/templates/migration.rb
 - init.rb
 - lib/conductor.rb
-- lib/conductor/controller/dashboard.rb
 - lib/conductor/experiment.rb
-- lib/conductor/experiment/daily.rb
-- lib/conductor/experiment/history.rb
-- lib/conductor/experiment/raw.rb
-- lib/conductor/experiment/weight.rb
-- lib/conductor/helpers/dashboard_helper.rb
+- lib/conductor/rails/controllers/dashboard.rb
+- lib/conductor/rails/helpers/dashboard_helper.rb
+- lib/conductor/rails/models/daily.rb
+- lib/conductor/rails/models/history.rb
+- lib/conductor/rails/models/raw.rb
+- lib/conductor/rails/models/weight.rb
+- lib/conductor/rails/views/dashboard/_current_weights.html.haml
+- lib/conductor/rails/views/dashboard/_daily_stats.html.haml
+- lib/conductor/rails/views/dashboard/_group_stats.html.haml
+- lib/conductor/rails/views/dashboard/_top_nav.html.haml
+- lib/conductor/rails/views/dashboard/_weight_history.html.haml
+- lib/conductor/rails/views/dashboard/index.html.haml
 - lib/conductor/roll_up.rb
-- lib/conductor/views/dashboard/_current_weights.html.haml
-- lib/conductor/views/dashboard/_daily_stats.html.haml
-- lib/conductor/views/dashboard/_group_stats.html.haml
-- lib/conductor/views/dashboard/_top_nav.html.haml
-- lib/conductor/views/dashboard/_weight_history.html.haml
-- lib/conductor/views/dashboard/index.html.haml
 - lib/conductor/weights.rb
 - rails/init.rb
 - test/db/schema.rb