conductor 0.7.1 → 0.7.2

data/VERSION

@@ -1 +1 @@
-0.7.1
+0.7.2

data/lib/conductor/weights.rb

@@ -24,6 +24,13 @@ class Conductor
         end
       end
 
+      # Computes the weights for a group based on the attribute for weighting and 
+      # activity for the last two weeks.
+      #
+      # If no conversions have taken place yet for a group, all alternatives are weighted 
+      # equally.
+      #
+      # TODO: add notification table and all notification if there are no conversions and we are out of the equalization period
       def compute(group_name, alternatives)
         # create the conditions after sanitizing sql.
         alternative_filter = alternatives.inject([]) {|res,x| res << "alternative = '#{Conductor.sanitize(x)}'"}.join(' OR ')
@@ -34,7 +41,7 @@ class Conductor
         unless group_rows.empty?
           Conductor::Experiment::Weight.delete_all(:group_name => group_name) # => remove all old data for group
           total = group_rows.sum_it(Conductor.attribute_for_weighting)
-          data = total ? compute_weights_for_group(group_name, group_rows, total) : assign_equal_weights(group_rows)
+          data = total > 0 ? compute_weights_for_group(group_name, group_rows, total) : assign_equal_weights(group_rows)
           update_weights_in_db(group_name, data)
         end
       end

data/test/test_conductor.rb

@@ -250,6 +250,22 @@ class TestConductor < Test::Unit::TestCase
       # rollup
       Conductor::RollUp.process
     end
+    
+    should "correctly calculate weights even if there are no conversions" do
+      Conductor::Experiment::Daily.update_all('conversion_value = 0.00, conversions = 0')
+      Conductor.identity = ActiveSupport::SecureRandom.hex(16)
+      
+      assert_nil Conductor::Experiment::Daily.all.detect {|x| x.conversions > 0 || x.conversion_value > 0}
+      assert_equal 3, Conductor::Experiment.weights('a_group', ["a", "b", "c"]).values.sum
+    end
+    
+    should "correctly calculate weights even if an alternative has no conversions" do
+      Conductor::Experiment::Daily.update_all('conversion_value = 0.00, conversions = 0', "alternative = 'a'")
+      Conductor.identity = ActiveSupport::SecureRandom.hex(16)
+
+      assert_nil Conductor::Experiment::Daily.find_all_by_alternative('a').detect {|x| x.conversions > 0 || x.conversion_value > 0}
+      assert_equal 0, Conductor::Experiment.weights('a_group', ["a", "b", "c"])['a']
+    end
 
     should "allow for the number of conversions to be used for weighting instead of conversion_value" do
       Conductor.identity = ActiveSupport::SecureRandom.hex(16)

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 7
-  - 1
-  version: 0.7.1
+  - 2
+  version: 0.7.2
 platform: ruby
 authors: 
 - Noctivity