composite_primary_keys 7.0.0 → 7.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b533cad3bf71d1945db74c8626cac9731a5a6d35
-  data.tar.gz: c117bd2a65a362c69d36f0b2fe4e2495a9811933
+  metadata.gz: 67949f62c5795509a482f74ac109193f0d6e294a
+  data.tar.gz: 1705dca290c512bd57401db0d61cc58e2c13d6d1
 SHA512:
-  metadata.gz: a08e6c2dafa9d5570a22ccc4cd12d4b9c598f3b8b463e1719d398408e76a3d05bf15278c620f3dad04939e63964f493f99c5efafa28d6cfab52bc4a06d15a50b
-  data.tar.gz: 114d12d9f174d079a6172ac33748c25110c12f4400274f283f677eab664e2d77a868864b643080e1976fcc8c56e67e08b5fea9807b6eaa71f01d60f02339f549
+  metadata.gz: ebead783540875cd89cfefce57b3113b85d76295753d4029f54c5b866598a6a5961d1f0bb247fff7279716b1e9989bea4607c1be247e884b662ec934adcd08ef
+  data.tar.gz: 563cf8163a7526483b14018b4438134c7ca4cbac0b1868003d864d7f55348f61e686c472afed787db5ef8aed0377ee886a09d7167caf3a8623025ef21b106532

data/History.rdoc

@@ -1,7 +1,21 @@
+== 7.0.1 (2014-05-27)
+
+* Fix setting of timestamps automatically by Rails (Charlie Savage)
+
 == 7.0.0 (2014-05-26)
 
 * Active Record 4.1 support! (Charlie Savage, Tom Hughes, Simon South)
 
+Note there is one big api change.  Previously, CPK supported both of these calls:
+
+  Membership.find(1,1)
+  Membership.find([1,1])
+
+The first one no longer works.  It was removed because it made the internal code simpler
+and makes the intention of the code clearer (especially when finding multiple records).
+If this change causes too much pain then please submit a ticket on Github.
+
+
 == 6.0.6 (2014-05-26)
 
 * Don't refer to deprecated set_primary_keys in README (Henare Degan)

data/README.rdoc

@@ -88,9 +88,7 @@ See test/README_tests.rdoc
 
 == Questions, Discussion and Contributions
 
-The CPK home page is hosted at https://github.com/composite-primary-keys/composite_primary_keys.  There
-is also a Google group at https://groups.google.com/forum/#!forum/compositekeys,
-but you'll have better luck getting support using GitHub.
+For help please visit https://github.com/composite-primary-keys/composite_primary_keys.
 
 == Author
 

data/lib/composite_primary_keys.rb

@@ -68,11 +68,9 @@ require 'active_record/relation/query_methods'
 
 require 'active_record/validations/uniqueness'
 
-
 # CPK files
 require 'composite_primary_keys/active_model/dirty'
 require 'composite_primary_keys/persistence'
-require 'composite_primary_keys/active_record_overides'
 require 'composite_primary_keys/base'
 require 'composite_primary_keys/core'
 require 'composite_primary_keys/composite_arrays'

data/lib/composite_primary_keys/base.rb

@@ -34,7 +34,6 @@ module ActiveRecord
         class_eval <<-EOV
           extend  CompositeClassMethods
           include CompositeInstanceMethods
-          include CompositePrimaryKeys::ActiveRecord::Overides
         EOV
       end
       alias_method_chain :primary_key=, :composite_key_support

data/lib/composite_primary_keys/persistence.rb

@@ -53,16 +53,6 @@ module CompositePrimaryKeys
           true
         end
       end
-
-      def create_record(attribute_names = @attributes.keys)
-        attributes_values = arel_attributes_with_values_for_create(attribute_names)
-
-        new_id = self.class.unscoped.insert attributes_values
-        self.id ||= new_id if self.class.primary_key
-
-        @new_record = false
-        id
-      end
     end
   end
 end

data/lib/composite_primary_keys/version.rb

@@ -2,7 +2,7 @@ module CompositePrimaryKeys
   module VERSION
     MAJOR = 7
     MINOR = 0
-    TINY  = 0
+    TINY  = 1
     STRING = [MAJOR, MINOR, TINY].join('.')
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: composite_primary_keys
 version: !ruby/object:Gem::Version
-  version: 7.0.0
+  version: 7.0.1
 platform: ruby
 authors:
 - Charlie Savage
@@ -38,7 +38,6 @@ files:
 - install.rb
 - lib/composite_primary_keys.rb
 - lib/composite_primary_keys/active_model/dirty.rb
-- lib/composite_primary_keys/active_record_overides.rb
 - lib/composite_primary_keys/associations/association.rb
 - lib/composite_primary_keys/associations/association_scope.rb
 - lib/composite_primary_keys/associations/has_and_belongs_to_many_association.rb

data/lib/composite_primary_keys/active_record_overides.rb

@@ -1,42 +0,0 @@
-module CompositePrimaryKeys
-  module ActiveRecord
-    module Overides
- 
-      # This override ensures that pkeys are set on the instance when records are created.
-      # However, while ActiveRecord::Persistence defines a create_record method
-      # the call in create_or_update is actually calling the method create_record in the Dirty concern
-      # which removes the pkey attrs and also sets updated/created at timestamps
-      # For some reason when we overide here we lose dirty!
-      # So, for now, timestamps are recorded explicitly
-      def create_record(attribute_names = nil)
-        run_callbacks(:create) do
-          record_timestamps!
-          attribute_names ||= keys_for_partial_write
-          attributes_values = arel_attributes_with_values_for_create(attribute_names)
-
-          new_id = self.class.unscoped.insert attributes_values
-
-          # DB like MySQL doesn't return the newly inserted result.
-          # self.id cannot be updated for this case.
-          self.id = new_id if self.class.primary_key and new_id.kind_of?(Array)
-          
-          @new_record = false
-          id
-        end
-      end
-
-      def record_timestamps!
-        if self.record_timestamps
-          current_time = current_time_from_proper_timezone
-
-          all_timestamp_attributes.each do |column|
-            if respond_to?(column) && respond_to?("#{column}=") && self.send(column).nil?
-              write_attribute(column.to_s, current_time)
-            end
-          end
-        end
-      end
-    end
-  end
-end
-