completion-kit 0.20.0 → 0.20.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 44b946858390ad2aa5d3a3bcb2a68ba666a6725ba5e77725887f99087603e322
-  data.tar.gz: 52499c569d0a73b0b714547e9aeed1535abe452cfd093288356d1580ee83d7ce
+  metadata.gz: cac78086fc976119ea178522cac6da086f68361ba85cbf77d8f70fa95e4fb4c2
+  data.tar.gz: ad85761d75484cf33d3043261cb6aba30f82c65b2d81bea2e7e297d12e14d610
 SHA512:
-  metadata.gz: 406ae145ee5963e7a1a1a32b7669591f8c04ae49cb1166d6e054d657a77aa0fca218c78a4d2f7b31dc5518ee9aa75a7f5bae28889f81753ccdcdf86822b4dfb7
-  data.tar.gz: 2c9f542f56209a7fde4d8d6cc822e7096b43b178d7fef9ef5c65cc95e971c512ad91b14c1713fefd7d076164bff99e74ec587600c9900ce55994e67ff4a273b2
+  metadata.gz: 5a197c30cf0d176054a05acaeb2e0e52cff1498dd6e09f709dbb696f31a437a307903d5855a406d784fbe4a8cf4c8bd58eff206677eadc83888da511bb27ca23
+  data.tar.gz: f91ffc1f03adf3801dccbef84c74022b9b946c359af5ce914dde957f78ef0101a2888998d14047450a827fad275e608a694fb7fcf691371849392d6701aa927f

data/app/controllers/completion_kit/api/v1/metrics_controller.rb

@@ -42,7 +42,7 @@ module CompletionKit
             return
           end
 
-          disagreement_count = Agreement.where(metric_id: @metric.id, verdict: "disagree").count
+          disagreement_count = Agreement.where(metric_id: @metric.id, verdict: "disagree", run_id: CompletionKit::Run.visible_run_ids).count
           if disagreement_count.zero?
             render_error("Mark at least one case as Disagree before asking the model to suggest a change.", status: :unprocessable_entity)
             return

data/app/controllers/completion_kit/metrics_controller.rb

@@ -46,7 +46,7 @@ module CompletionKit
         @improve_disagreement_count = 0
         @guiding_examples = []
       else
-        @improve_disagreement_count = Agreement.where(metric_id: @metric.id, verdict: "disagree").count
+        @improve_disagreement_count = Agreement.where(metric_id: @metric.id, verdict: "disagree", run_id: CompletionKit::Run.visible_run_ids).count
         @guiding_examples = CompletionKit.config.judge_examples_from_reviews ? MetricAgreementExamples.judge_examples_for(@metric) : []
       end
     end
@@ -59,7 +59,7 @@ module CompletionKit
       @suggestion_draft = MetricVersion.drafts.where(metric_id: @metric.id, source: "suggestion").order(created_at: :desc).first
       @edit_draft = MetricVersion.drafts.where(metric_id: @metric.id, source: "edit").order(created_at: :desc).first
       @published_metric_version = MetricVersion.published.where(metric_id: @metric.id, current: true).first
-      @improve_disagreement_count = @metric.check? ? 0 : Agreement.where(metric_id: @metric.id, verdict: "disagree").count
+      @improve_disagreement_count = @metric.check? ? 0 : Agreement.where(metric_id: @metric.id, verdict: "disagree", run_id: CompletionKit::Run.visible_run_ids).count
 
       if @edit_draft
         @metric.instruction = @edit_draft.instruction
@@ -103,7 +103,7 @@ module CompletionKit
       end
 
       target = params[:back_to] == "edit" ? edit_metric_path(@metric) : metric_path(@metric)
-      counts = Agreement.where(metric_id: @metric.id, verdict: %w[agree disagree]).group(:verdict).count
+      counts = Agreement.where(metric_id: @metric.id, verdict: %w[agree disagree], run_id: CompletionKit::Run.visible_run_ids).group(:verdict).count
       if counts["disagree"].to_i.zero?
         redirect_to target, alert: "Mark at least one case as Disagree before asking the model to suggest a change."
         return

data/app/services/completion_kit/dashboard_stats.rb

@@ -7,7 +7,7 @@ module CompletionKit
     # can render a fixed-width sparkline.
     def self.activity(days: 14)
       since = (days - 1).days.ago.to_date
-      counts = Run.where("created_at >= ?", since.beginning_of_day)
+      counts = Run.display_scoped.where("created_at >= ?", since.beginning_of_day)
                   .group("DATE(created_at)")
                   .count
       (0...days).map do |offset|
@@ -62,6 +62,7 @@ module CompletionKit
       resolved = Review.joins(:response)
                        .where(metric_id: metric_id)
                        .where("completion_kit_reviews.created_at >= ?", since)
+                       .where(completion_kit_responses: { run_id: Run.visible_run_ids })
                        .where.not(passed: nil)
       total = resolved.count
       return nil if total.zero?
@@ -72,6 +73,8 @@ module CompletionKit
     def self.failing_checks(since:)
       reviews = Review.where(passed: false)
                       .where("completion_kit_reviews.created_at >= ?", since)
+                      .joins(:response)
+                      .where(completion_kit_responses: { run_id: Run.visible_run_ids })
                       .includes(response: :run)
                       .order(updated_at: :desc)
       items = reviews.map do |review|
@@ -89,7 +92,7 @@ module CompletionKit
       dismissed = failure_dismissal_keys
       items = []
 
-      Run.where(status: "failed").where("created_at >= ?", since).find_each do |run|
+      Run.display_scoped.where(status: "failed").where("created_at >= ?", since).find_each do |run|
         next if dismissed.include?(["CompletionKit::Run", run.id])
         items << {
           surface: "run", record: run, run: run,
@@ -98,6 +101,7 @@ module CompletionKit
       end
 
       Response.where(status: "failed").where("created_at >= ?", since)
+              .where(run_id: Run.visible_run_ids)
               .includes(:run).find_each do |response|
         next if dismissed.include?(["CompletionKit::Response", response.id])
         items << {
@@ -107,6 +111,8 @@ module CompletionKit
       end
 
       Review.where(status: "failed").where("completion_kit_reviews.created_at >= ?", since)
+            .joins(:response)
+            .where(completion_kit_responses: { run_id: Run.visible_run_ids })
             .includes(response: :run).find_each do |review|
         next if dismissed.include?(["CompletionKit::Review", review.id])
         items << {
@@ -132,6 +138,7 @@ module CompletionKit
       scores = Review.joins(response: :run)
                      .where(status: "succeeded")
                      .where.not(ai_score: nil)
+                     .where(completion_kit_responses: { run_id: Run.visible_run_ids })
                      .group("completion_kit_runs.prompt_id")
                      .average(:ai_score)
       return [] if scores.empty?
@@ -167,6 +174,7 @@ module CompletionKit
       Review.joins(:response)
             .where(status: "succeeded")
             .where("completion_kit_reviews.created_at >= ?", since)
+            .where(completion_kit_responses: { run_id: Run.visible_run_ids })
             .where.not(ai_score: nil)
     end
     private_class_method :scored_reviews_since

data/lib/completion_kit/version.rb

@@ -1,3 +1,3 @@
 module CompletionKit
-  VERSION = "0.20.0"
+  VERSION = "0.20.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: completion-kit
 version: !ruby/object:Gem::Version
-  version: 0.20.0
+  version: 0.20.1
 platform: ruby
 authors:
 - Damien Bastin