completeness-fu 0.5.0 → 0.5.1

data/VERSION.yml

@@ -1,4 +1,4 @@
----
+--- 
+:patch: 1
 :major: 0
 :minor: 5
-:patch: 0

data/lib/completeness-fu.rb

@@ -10,11 +10,11 @@ end
 
 CompletenessFu.common_weightings  = { :low => 20, :medium => 40, :high => 60 }
 
-CompletenessFu.default_weightings = 40
+CompletenessFu.default_weighting  = 40
 
 CompletenessFu.default_i18n_namespace = [:completeness_scoring, :models]
 
-CompletenessFu.default_grading    = { :poor => 0..24, 
+CompletenessFu.default_gradings   = { :poor => 0..24, 
                                       :low =>  25..49, 
                                       :medium => 50..79, 
                                       :high => 80..100 }

data/lib/completeness-fu/active_record_additions.rb

@@ -2,11 +2,12 @@ module CompletenessFu
   
   class << self
     attr_accessor :common_weightings
-    attr_accessor :default_weightings
+    attr_accessor :default_weighting
     attr_accessor :default_i18n_namespace
-    attr_accessor :default_grading
+    attr_accessor :default_gradings
   end
     
+  class CompletenessFuError < Exception; end
   
   module ActiveRecordAdditions
     
@@ -41,24 +42,12 @@ module CompletenessFu
     module InstanceMethods
       # returns an array of hashes with the translated name, description + weighting
       def failed_checks
-        self.completeness_checks.inject([]) do |failures, check| 
-          failures << translate_check_details(check) if not check[:check].call(self)
-          failures
-        end
+        all_checks_which_pass(false)
       end
       
       # returns an array of hashes with the translated name, description + weighting
       def passed_checks
-        self.completeness_checks.inject([]) do |passed, check| 
-          case check[:check]
-          when Proc
-            passed << translate_check_details(check) if check[:check].call(self)
-          when Symbol
-            passed << translate_check_details(check) if self.send check[:check]
-          end
-          
-          passed
-        end
+        all_checks_which_pass
       end
       
       # returns the absolute complete score
@@ -75,14 +64,34 @@ module CompletenessFu
       
       # returns a basic 'grading' based on percent_complete, defaults are :high, :medium, :low, and :poor
       def completeness_grade
-        CompletenessFu.default_grading.each do |grading| 
-          return grading.first if grading.last.include?(self.percent_complete) 
+        CompletenessFu.default_gradings.each do |grading| 
+          return grading.first if grading.last.include?(self.percent_complete.round) 
         end
+        raise CompletenessFuError, "grade could not be determined with percent complete #{self.percent_complete.round}"
       end
       
       
       private 
       
+        def all_checks_which_pass(should_pass = true)
+          self.completeness_checks.inject([]) do |results, check|
+            check_result = run_check(check[:check]) 
+            results << translate_check_details(check) if (should_pass ? check_result : !check_result)
+            results
+          end
+        end
+        
+        def run_check(check)
+          case check
+          when Proc
+            return check.call(self)
+          when Symbol
+            return self.send check
+          else
+            raise CompletenessFuError, "check of type #{check.class} not acceptable"
+          end
+        end
+        
         def translate_check_details(full_check)
           namespace = CompletenessFu.default_i18n_namespace + [self.class.name.downcase.to_sym, full_check[:name]]
           

data/lib/completeness-fu/scoring_builder.rb

@@ -9,7 +9,7 @@ module CompletenessFu
       sb = ScoringBuilder.new
       
       sb.completeness_checks = []
-      sb.default_weighting   = CompletenessFu.default_weightings
+      sb.default_weighting   = CompletenessFu.default_weighting
       sb.model_weightings    = CompletenessFu.common_weightings
       
       sb.instance_eval(&block)

data/test/scoring_test.rb

@@ -134,21 +134,35 @@ class ScoringTest < Test::Unit::TestCase
       ScoringTest.class_eval do
         define_completeness_scoring do
           check :title, :title_present?, :high
+          check :name, :name_present?, :high
         end
-        
+
         private
           def title_present?
             self.title.present?
           end
+
+          def name_present?
+            false
+          end
+
       end
       @st = ScoringTest.new
       @st.title = 'I have a title'
     end
-    
+
+    should "have the correct failing checks" do
+      assert_equal 1, @st.passed_checks.size
+      assert_equal 1, @st.failed_checks.size
+      assert_equal 60, @st.completeness_score
+      assert_equal 50.0, @st.percent_complete
+    end
+
     should "have a scoring from the common_weightings hash used used" do
       assert_equal 1, @st.passed_checks.size
       assert_equal 60, @st.completeness_score
     end
+
   end
   
   

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: completeness-fu
 version: !ruby/object:Gem::Version 
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors: 
 - Josh Kalderimis
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-10-03 00:00:00 +01:00
+date: 2009-10-15 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency