companies_house_hub 0.1.8 → 0.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d0674550a52a10c0f5cc3213fc68b1f2de77eb0c855c4dd461e4cb2ee5abaa90
-  data.tar.gz: f10d683fde4a56667b020fe5eab40174d4eea7caccb609efe71d1c781b4cd648
+  metadata.gz: 29c2c6ef2a7320dce0f29392bc87d82a6458c67eeb8637ecc4e3abf3b493e223
+  data.tar.gz: 961885964947c2a58fc6ed08342af17cd0c113873f2484b4150580496573c71e
 SHA512:
-  metadata.gz: c701167997705f15cfa20dd41110011aa17a8cc780e72b83d26127160e3d08a5d0484efb651f6c69b4416b2a3d2eadd3377a81691716a58d7efdc0d807ebc139
-  data.tar.gz: af55ae20564e2abc7f2337fab7e7c83410f26fc49264be4e00298f15306771d68bd3aa6095cae27084a415bcc685e02ed3eb7c9b1e21d55f4d0721eb80103f5b
+  metadata.gz: d319f8a46e9d1187a34b5f69b04098b6de552013a549501598018f060f970faa10fd6cbc0098ec161f43cebe25f45e4bf7de099df75371b890b1f1b98ad6d98e
+  data.tar.gz: bee69f4ce39a230a3a66399cbd4ef53787ebe2d77c1b0823d6d1c2e51c002f0e553b2471497f25dce7cce3ab11398c18524cbe7f8b6999ddb55667c35e363d66

data/bin/console

@@ -14,6 +14,7 @@ Dotenv.load
 
 CompaniesHouseHub.configure do |config|
   config.api_key = ENV['API_KEY']
+  config.debug = true
 end
 
 # Allow direct access to CompaniesHouseHub classes

data/lib/companies_house_hub/models/filing_history.rb

@@ -20,11 +20,13 @@ module CompaniesHouseHub
 
       result = get(format_url(FIND_PATH, company_number: company_number), options)
 
-      return [] unless result.body[:items].any?
+      items = result.body.dig(:items) || []
+
+      return [] unless items.any?
 
       # Get all items and create a new history. If the description is 'legacy' then we can safely
       # ignore that document.
-      filing_histories = result.body[:items].map do |filing_json|
+      filing_histories = items.map do |filing_json|
         next if filing_json.dig(:description) == LEGACY_DOC_DESCRIPTION
 
         new(filing_json, company_number)

data/lib/companies_house_hub/models/person.rb

@@ -15,11 +15,20 @@ module CompaniesHouseHub
 
       result = get(format_url(FIND_PATH, company_number: company_number), options)
 
-      return [] unless result.body[:items].any?
-
-      result.body[:items].map do |person_json|
-        new(person_json)
-      end
+      # For some companies, for some reason, this endpoint returns an error, like this:
+      # {
+      #   "errors": [
+      #     {
+      #       "error": "company-psc-not-found",
+      #       "type": "ch:service"
+      #     }
+      #   ]
+      # }
+      items = result.body.dig(:items) || []
+
+      return [] unless items.any?
+
+      items.map { |person_json| new(person_json) }
     end
 
     def initialize(json = {})

data/lib/companies_house_hub/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CompaniesHouseHub
-  VERSION = '0.1.8'
+  VERSION = '0.1.9'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: companies_house_hub
 version: !ruby/object:Gem::Version
-  version: 0.1.8
+  version: 0.1.9
 platform: ruby
 authors:
 - Ricardo Otero