communique 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83a7e5be37e23918ac8477417e6bb769d3e0d524
-  data.tar.gz: 9e754661e47632b80ab8e1076941141ad0b37e8a
+  metadata.gz: 774bcaa4e9e2bec498fa64ed09171d390e84aa19
+  data.tar.gz: 300cb9f363f5a590e50b4252c62dc7e14d6159d1
 SHA512:
-  metadata.gz: 627f1c1c594e0484808169074b956f1cd80fc26856192087db062d891696d97223c8d270998405d3aa123b855f136a3f45a8792b494fb0c9602a4bcecfc9e7d7
-  data.tar.gz: 16278c48625816efe4083323d06e782b1392a4834aac19589502ceafc6cc59aaa0c0e830ed96aaaabd233993cf57686afb027da51dfa4c19ab71df5a6352410a
+  metadata.gz: 5b88e73ec989d41c2e7afd8cf388c1384a53b151027a13d57e9faac9c16d7ceab96b04391ae93ac3ae160f1620c6d570190230471626666715f702bdfda55615
+  data.tar.gz: b6dc54ce9f0ccee9012b25ede6bc86ceb35e989d78d03d8ee262dd36725027e703ca98839cee64aed3ecef6c5b5306b254b96fe6e9bb4629cf85278d97b39119

data/lib/communique/configuration.rb

@@ -13,6 +13,7 @@ module Communique
   class Configuration
     attr_accessor :user_klass
     attr_accessor :notification_handler
+    attr_accessor :prevent_unseen_duplicates
 
     def set_notification_handler(&block)
       @notification_handler = block

data/lib/communique/version.rb

@@ -1,4 +1,4 @@
 # gem version
 module Communique
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/lib/communique.rb

@@ -10,13 +10,14 @@ module Communique
   def self.notify(notifiable, action_key, context_info = nil)
     action = Action.find_or_create_by(key: action_key)
 
-    notification = Notification.create(
-      notifiable: notifiable,
-      context_info: context_info,
-      action_key: action_key,
-      action: action
-    )
-
+    if prevent_unseen_duplicates?
+      existing_notification = find_existing_notifications(notifiable, action_key)
+      if existing_notification
+        existing_notification.update_attributes(context_info: context_info)
+        return existing_notification.id.to_s
+      end
+    end
+    notification = create_notification(notifiable, context_info, action_key, action)
     Handler.external_services notification
 
     notification.id.to_s
@@ -37,4 +38,31 @@ module Communique
   def self.count_unseen(notifiable)
     Notification.count_unseen notifiable
   end
+
+  def self.prevent_unseen_duplicates?
+    !Communique.config.nil? && Communique.config.prevent_unseen_duplicates
+  end
+
+  def self.find_existing_notifications(notifiable, action_key)
+    Notification.where(
+      notifiable: notifiable,
+      action_key: action_key,
+      seen: false
+    ).order_by(updated_at: :desc).first
+  end
+
+  def self.create_notification( notifiable, context_info, action_key, action)
+    Notification.create(
+      notifiable: notifiable,
+      context_info: context_info,
+      action_key: action_key,
+      action: action
+    )
+  end
+
+  private_class_method(
+    :prevent_unseen_duplicates?,
+    :find_existing_notifications,
+    :create_notification
+  )
 end

data/spec/communique_spec.rb

@@ -21,4 +21,37 @@ describe Communique do
       )
     end
   end
+  describe 'config.prevent_unseen_duplicates' do
+    it 'creates notifications when prevent_unseen_duplicates if false' do
+      Communique.configure { |config| config.prevent_unseen_duplicates = false }
+
+      dummy = NotifiableDummy.create
+      2.times do
+        Communique.notify(
+          dummy,
+          '3CPO_fell_down_and_hit_his_head',
+          name: 'broken robot',
+          location: 'nginx caching issue'
+        )
+      end
+      expect(dummy.notifications.count).to be 2
+
+    end
+
+    it 'updates notifications when prevent_unseen_duplicates if true' do
+      Communique.configure { |config| config.prevent_unseen_duplicates = true }
+
+      dummy = NotifiableDummy.create
+      2.times do
+        Communique.notify(
+          dummy,
+          '3CPO_fell_down_and_hit_his_head',
+          name: 'broken robot',
+          location: 'nginx caching issue'
+        )
+      end
+      expect(dummy.notifications.count).to be 1
+    end
+
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: communique
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Michael Polycarpou
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-02 00:00:00.000000000 Z
+date: 2016-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -172,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Simple way to store warnings and errors affecting users as messages. Stored