common_repository_model 0.0.3 → 0.0.4

data/Rakefile

@@ -7,3 +7,5 @@ Rake::TestTask.new do |t|
   t.test_files = FileList['spec/**/*_spec.rb']
   t.verbose = true
 end
+
+task :default => :test

data/lib/common_repository_model/area.rb

@@ -21,7 +21,16 @@ module CommonRepositoryModel
       find({name_s: name}).first
     end
 
+    def self.find_by_name!(name)
+      find({name_s: name.to_s}).first ||
+      raise(
+        CommonRepositoryModel::ObjectNotFoundError.new(
+          "#{self.class} with name: #{name.to_s} not found"
+        )
+      )
+    end
+
     # We shouldn't be calling these
     protected :save, :save!
   end
-end
+end

data/lib/common_repository_model/persistence_base.rb

@@ -1,5 +1,8 @@
 require 'active_fedora'
 module CommonRepositoryModel
+  class ObjectNotFoundError < ActiveFedora::ObjectNotFoundError
+  end
+
   class PersistenceBase < ActiveFedora::Base
   end
 end

data/lib/common_repository_model/version.rb

@@ -1,3 +1,3 @@
 module CommonRepositoryModel
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/common_respository_model/area_spec.rb

@@ -3,10 +3,6 @@ require 'common_repository_model/area'
 require 'common_repository_model/collection'
 
 describe CommonRepositoryModel::Area do
-  after(:each) do
-    subject.delete if subject.persisted?
-  end
-
   describe 'without persisting' do
     subject { FactoryGirl.build(:area, name: name) }
     let(:name) { 'My Area Name'}
@@ -34,21 +30,28 @@ describe CommonRepositoryModel::Area do
   end
 
   describe 'integration (with persistence)' do
-    subject { FactoryGirl.create(:area) }
     let(:collection) { FactoryGirl.build(:collection, area: nil) }
-    it 'should find by name' do
-      CommonRepositoryModel::Area.find_by_name(subject.name).must_equal subject
-      CommonRepositoryModel::Area.
-        find_by_name("#{subject.name}-tmp").must_equal nil
+    it 'should .find_by_name and .find_by_name!' do
+      with_persisted_area do |area|
+        CommonRepositoryModel::Area.find_by_name(area.name).must_equal area
+        CommonRepositoryModel::Area.
+          find_by_name("#{area.name}-tmp").must_equal nil
+
+        CommonRepositoryModel::Area.find_by_name!(area.name).must_equal area
+        lambda {
+          CommonRepositoryModel::Area.find_by_name!("#{area.name}-tmp")
+        }.must_raise(CommonRepositoryModel::ObjectNotFoundError)
+      end
     end
     it 'should save' do
-      # Before we can add a collection, the containing object
-      # must be saved
-      subject.collections << collection
-      subject.send(:save).must_equal true
-      new_subject = subject.class.find(subject.pid)
-
-      new_subject.collections.size.must_equal 1
+      with_persisted_area do |area|
+        # Before we can add a collection, the containing object
+        # must be saved
+        area.collections << collection
+        area.send(:save).must_equal true
+        new_area = area.class.find(area.pid)
+        new_area.collections.size.must_equal 1
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: common_repository_model
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-11-15 00:00:00.000000000 Z
+date: 2012-11-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport