committee 2.0.0.pre6 → 2.0.0.pre7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d9c150399d562ad7e8daafbf27c82044a2e3c639
-  data.tar.gz: f2879d489c219d68a9191c9ce7ce31972107334e
+  metadata.gz: 5e47c09e8ea8d73d5c06992555c2c02671be06ac
+  data.tar.gz: c3671183b4ccbf5d6b69bcd89a74c8828a84e7f9
 SHA512:
-  metadata.gz: a019bde4a85727e0bbb676376ece423d4731645bb1a49309f57d178c7bd0eac11049acef972923b7907f2cf3e331c84b968a784fc3d24084a8c9e73db36f0817
-  data.tar.gz: dcb6b47b74931ea684c6e9f92004923e09f72755be7abdfb9381cf1b457286f44b02c6fd3741902901aa2843cadac9b8a984d336d25b931ec3f9b0c92e11a5cc
+  metadata.gz: c51f69cf118128c3bf0f8f3df13a89d282a8a997a3ebdedb84c579ebad3fbe773471e0f8e1ad025631774d229f854df3bd38863e32ea78a99daf9bb70f416559
+  data.tar.gz: 50265b73bee7f7ef9f53e4b412ac2b9b85dae0733c7a5a4d30bafeee863e56d8a86a6f578e7154866c53d475a9d42afa6f393430461bfa22308a17cd427e2bcc

data/lib/committee/middleware/request_validation.rb

@@ -73,19 +73,19 @@ module Committee::Middleware
 
         @app.call(request.env)
       elsif @strict
-        raise Committee::NotFound
+        raise Committee::NotFound, "That request method and path combination isn't defined."
       else
         @app.call(request.env)
       end
     rescue Committee::BadRequest, Committee::InvalidRequest
       raise if @raise
       @error_class.new(400, :bad_request, $!.message).render
-    rescue Committee::NotFound
+    rescue Committee::NotFound => e
       raise if @raise
       @error_class.new(
         404,
         :not_found,
-        "That request method and path combination isn't defined."
+        e.message
       ).render
     rescue JSON::ParserError
       raise Committee::InvalidRequest if @raise

data/lib/committee/string_params_coercer.rb

@@ -37,8 +37,8 @@ module Committee
                 raise e unless e.message =~ /invalid value for Float/
               end
             when "boolean"
-              coerced[k] = true if original_val == "true"
-              coerced[k] = false if original_val == "false"
+              coerced[k] = true if original_val == "true" || original_val == "1"
+              coerced[k] = false if original_val == "false" || original_val == "0"
             end
             break if coerced.key?(k)
           end

data/test/drivers/open_api_2_test.rb

@@ -89,8 +89,8 @@ describe Committee::Drivers::OpenAPI2 do
 
     schema = @driver.parse(schema_data)
     link = schema.routes['GET'][0][1]
-    assert_equal nil, link.status_success
-    assert_equal nil, link.target_schema
+    assert_nil link.status_success
+    assert_nil link.target_schema
   end
 
   it "refuses to parse other version of OpenAPI" do
@@ -203,7 +203,7 @@ describe Committee::Drivers::OpenAPI2::ParameterSchemaBuilder do
     }
     schema, schema_data = call(data)
 
-    assert_equal nil, schema_data
+    assert_nil schema_data
     assert_equal ["limit"], schema.properties.keys
     assert_equal [], schema.required
     assert_equal ["integer"], schema.properties["limit"].type
@@ -220,7 +220,7 @@ describe Committee::Drivers::OpenAPI2::ParameterSchemaBuilder do
     }
     schema, schema_data = call(data)
 
-    assert_equal nil, schema_data
+    assert_nil schema_data
     assert_equal ["limit"], schema.required
   end
 
@@ -238,7 +238,7 @@ describe Committee::Drivers::OpenAPI2::ParameterSchemaBuilder do
     }
     schema, schema_data = call(data)
 
-    assert_equal nil, schema_data
+    assert_nil schema_data
     assert_equal ["array"], schema.properties["tags"].type
     assert_equal({ "type" => "string" }, schema.properties["tags"].items)
   end
@@ -257,7 +257,7 @@ describe Committee::Drivers::OpenAPI2::ParameterSchemaBuilder do
     }
     schema, schema_data = call(data)
 
-    assert_equal nil, schema
+    assert_nil schema
     assert_equal({ "$ref" => "#/definitions/foo" }, schema_data)
   end
 

data/test/response_generator_test.rb

@@ -89,7 +89,7 @@ describe Committee::ResponseGenerator do
 
     link.target_schema.type = ["null"]
     data, _schema = Committee::ResponseGenerator.new.call(link)
-    assert_equal nil, data
+    assert_nil data
 
     link.target_schema.type = ["string"]
     data, _schema = Committee::ResponseGenerator.new.call(link)

data/test/string_params_coercer_test.rb

@@ -23,6 +23,10 @@ describe Committee::StringParamsCoercer do
     assert_equal({"deleted" => true}, call(data))
     data = {"deleted" => "false"}
     assert_equal({"deleted" => false}, call(data))
+    data = {"deleted" => "1"}
+    assert_equal({"deleted" => true}, call(data))
+    data = {"deleted" => "0"}
+    assert_equal({"deleted" => false}, call(data))
   end
 
   it "skips invalid values for boolean param" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: committee
 version: !ruby/object:Gem::Version
-  version: 2.0.0.pre6
+  version: 2.0.0.pre7
 platform: ruby
 authors:
 - Brandur
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-01 00:00:00.000000000 Z
+date: 2017-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_schema