committee 1.9.1 → 1.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 61aa6eb2eafba5024a4b2997cd03e9eb155164a8
-  data.tar.gz: a1358fedddf122a4fcac87c89ad495b81ba89304
+  metadata.gz: 31054e2caff7ac27297eb960c4468de3c182f41e
+  data.tar.gz: d1ce477e98f2590d58b499bf320ac10d3907424c
 SHA512:
-  metadata.gz: ee0095ed081a1001db287f09be35c61b3823bd81e04e504fafe9ec8d585f5b9383b66f527b168a5683544c10324327d7c003e6d0ad7879266c0351ec89ce5c4a
-  data.tar.gz: 1dcb383234b5ea013fba693250ce976f974726411a16302f9384e06ce984003ae9f46636b2a78ee67f7f7b5064081b1860a6c716201c666e92f666ee531e2df9
+  metadata.gz: f5a05732e09b0c1c97e18cccdc3cabb587a6ed20507b49cc18ff5593721120b647ef56135ae0e9d450b16e7f65f733da3bbf3b135a7e8200d29b1652acc53ee9
+  data.tar.gz: 470050b4314be6de778b53b1a3f84f9f762c85b00010abc6612221daaddac123ffb94addc45ea4e07769976f4f5b6ef559018c7e5053e8085385f7605d42a66d

data/lib/committee/response_generator.rb

@@ -12,25 +12,24 @@ module Committee
     private
 
     def generate_properties(schema)
-      data = {}
-      schema.properties.each do |key, value|
-        data[key] = if !value.properties.empty?
-          generate_properties(value)
-        else
-          # special example attribute was included; use its value
-          if !value.data["example"].nil?
-            value.data["example"]
-          # null is allowed; use that
-          elsif value.type.include?("null")
-            nil
-          # otherwise we don't know what to do (we could eventually generate
-          # random data based on type/format
-          else
-            raise(%{At "#{schema.id}"/"#{key}": no "example" attribute and "null" is not allowed; don't know how to generate property.})
-          end
+      # special example attribute was included; use its value
+      if !schema.data["example"].nil?
+        schema.data["example"]
+      # null is allowed; use that
+      elsif schema.type.include?("null")
+        nil
+      elsif schema.type.include?("array") && !schema.items.nil?
+        [generate_properties(schema.items)]
+      elsif !schema.properties.empty?
+        data = {}
+        schema.properties.map do |key, value|
+          data[key] = generate_properties(value)
         end
+        data
+      else
+        raise(%{At "#{schema.pointer}": no "example" attribute and "null" } +
+          %{is not allowed; don't know how to generate property.})
       end
-      data
     end
   end
 end

data/test/response_generator_test.rb

@@ -27,6 +27,34 @@ describe Committee::ResponseGenerator do
     assert data.is_a?(Array)
   end
 
+  it "wraps list data in an array" do
+    @link = @list_link
+
+    @link.rel = nil
+
+    data = call
+    assert data.is_a?(Array)
+  end
+
+  it "errors with no known route for generation" do
+    @link = @get_link
+
+    # tweak the schema so that it can't be generated
+    property = @schema.properties["app"].properties["maintenance"]
+    property.data["example"] = nil
+    property.type = []
+
+    e = assert_raises(RuntimeError) do
+      call
+    end
+
+    expected = <<-eos.gsub(/\n +/, "").strip
+      At "#/definitions/app/properties/maintenance": no "example" attribute and 
+      "null" is not allowed; don't know how to generate property.
+    eos
+    assert_equal expected, e.message
+  end
+
   def call
     Committee::ResponseGenerator.new.call(@link)
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: committee
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.10.0
 platform: ruby
 authors:
 - Brandur
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-24 00:00:00.000000000 Z
+date: 2015-10-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json_schema
@@ -169,8 +169,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A collection of Rack middleware to support JSON Schema.
 test_files: []
+has_rdoc: