commendo 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c06ab16ac48b29a9d47748e6b02b5a202faf2ed8
-  data.tar.gz: 70f8a0e9790b493fa50498026ad79752a9b8530c
+  metadata.gz: f4346b4b053e4b910efdd819476fae6e18db6b45
+  data.tar.gz: faeee86f961b6e576888accd047b6adfe4dcd54e
 SHA512:
-  metadata.gz: 27e4704a857bb1d83a73f5fe2f2069a560bd0f6ca751fea5a8a321b577ffabb673f91505e3ccfde6727768a7312eb561eefea827d5e6f57ae5b14618733675ae
-  data.tar.gz: 68bc522acf88756c312584955622964361824d1f37c91ba065eb60f55daebef95c52e6c11ed11abe9f97c2a6a7323f8933cb255460be83cd7504452243ebf059
+  metadata.gz: ad4356a6a14f35713ab2eee837b69e78e6ed7995c4131968ce8356df45630fc290817a670a2aa29135f02ff9a9a18928437b3a5263c551065912c5689ebb280d
+  data.tar.gz: b4db90f586213d1174810081d1e18335572f97c51ca351ffd11f3ea395562b9674781375e2c62d8cc16c0926932dc8479a273e556f38b669acf4f2866250cf9a

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 1.2.4 / 2015-12-09
+* [BUGFIX] Fixed bug with TagSet#empty? reporting empty when only one key present
+
 # 1.2.3 / 2015-10-07
 * [BUGFIX] Fix exception when calculating similarity on empty resources
 

data/lib/commendo/tag_set.rb

@@ -10,7 +10,7 @@ module Commendo
 
     def empty?
       cursor, keys = redis.scan(0, match: "#{key_base}:*", count: 1)
-      cursor.to_i == 0
+      cursor.to_i == 0 && keys.empty?
     end
 
     def get(resource)

data/lib/commendo/version.rb

@@ -1,3 +1,3 @@
 module Commendo
-  VERSION = '1.2.3'
+  VERSION = '1.2.4'
 end

data/test/tag_set_test.rb

@@ -18,9 +18,9 @@ module Commendo
     def test_adds_tags_for_resource
       assert_equal [], @ts.get(1)
       @ts.add(1, 'foo', 'bar', 'baz')
-      assert_equal ['bar', 'baz','foo'], @ts.get(1)
+      assert_equal %w(bar baz foo), @ts.get(1)
       @ts.add(1, 'qux', 'qip')
-      assert_equal ['bar', 'baz', 'foo', 'qip', 'qux'], @ts.get(1)
+      assert_equal %w(bar baz foo qip qux), @ts.get(1)
     end
 
     def test_empty?
@@ -35,36 +35,36 @@ module Commendo
     def test_sets_tags_for_resource
       assert_equal [], @ts.get(1)
       @ts.set(1, 'foo', 'bar', 'baz')
-      assert_equal ['bar', 'baz', 'foo'], @ts.get(1)
+      assert_equal %w(bar baz foo), @ts.get(1)
       @ts.set(1, 'qux', 'qip')
-      assert_equal ['qip', 'qux'], @ts.get(1)
+      assert_equal %w(qip qux), @ts.get(1)
     end
 
     def test_sets_tags_when_empty
       @ts.set(1, 'foo', 'bar', 'baz')
       @ts.set(2, 'qux', 'qip')
-      assert_equal ['bar', 'baz', 'foo'], @ts.get(1)
-      assert_equal ['qip', 'qux'], @ts.get(2)
+      assert_equal %w(bar baz foo), @ts.get(1)
+      assert_equal %w(qip qux), @ts.get(2)
       @ts.set(1, *[])
       assert_equal [], @ts.get(1)
-      assert_equal ['qip', 'qux'], @ts.get(2)
+      assert_equal %w(qip qux), @ts.get(2)
     end
 
     def test_deletes_all_tags_for_resource
       @ts.set(1, 'foo', 'bar', 'baz')
       @ts.set(2, 'qux', 'qip')
-      assert_equal ['bar', 'baz', 'foo'], @ts.get(1)
-      assert_equal ['qip', 'qux'], @ts.get(2)
+      assert_equal %w(bar baz foo), @ts.get(1)
+      assert_equal %w(qip qux), @ts.get(2)
       @ts.delete(1)
       assert_equal [], @ts.get(1)
-      assert_equal ['qip', 'qux'], @ts.get(2)
+      assert_equal %w(qip qux), @ts.get(2)
     end
 
     def test_deletes_given_tags_for_resource
       assert_equal [], @ts.get(1)
       @ts.set(1, 'foo', 'bar', 'baz', 'qux', 'qip')
       @ts.delete(1, 'qux', 'qip')
-      assert_equal ['bar', 'baz', 'foo'], @ts.get(1)
+      assert_equal %w(bar baz foo), @ts.get(1)
     end
 
     def test_matches_tags
@@ -72,15 +72,15 @@ module Commendo
       @ts.set(2, 'qux', 'qip')
 
       assert @ts.matches(1, ['foo'])
-      assert @ts.matches(1, ['bar', 'baz'])
-      assert @ts.matches(1, ['bar', 'baz', 'foo'])
+      assert @ts.matches(1, %w(bar baz))
+      assert @ts.matches(1, %w(bar baz foo))
       refute @ts.matches(1, ['qux'])
       refute @ts.matches(1, ['qip'])
 
       refute @ts.matches(2, ['foo'])
-      refute @ts.matches(2, ['bar', 'baz'])
-      refute @ts.matches(2, ['bar', 'baz', 'foo'])
-      assert @ts.matches(2, ['qux', 'qip'])
+      refute @ts.matches(2, %w(bar baz))
+      refute @ts.matches(2, %w(bar baz foo))
+      assert @ts.matches(2, %w(qux qip))
       assert @ts.matches(2, ['qux'])
       assert @ts.matches(2, ['qip'])
     end
@@ -91,16 +91,16 @@ module Commendo
 
       refute @ts.matches(1, nil, ['foo'])
       refute @ts.matches(1, [], ['foo'])
-      refute @ts.matches(1, [], ['bar', 'baz'])
-      refute @ts.matches(1, [], ['bar', 'baz', 'foo'])
+      refute @ts.matches(1, [], %w(bar baz))
+      refute @ts.matches(1, [], %w(bar baz foo))
       assert @ts.matches(1, [], ['qux'])
       assert @ts.matches(1, [], ['qip'])
 
       assert @ts.matches(2, nil, ['foo'])
       assert @ts.matches(2, [], ['foo'])
-      assert @ts.matches(2, [], ['bar', 'baz'])
-      assert @ts.matches(2, [], ['bar', 'baz', 'foo'])
-      refute @ts.matches(2, [], ['qux', 'qip'])
+      assert @ts.matches(2, [], %w(bar baz))
+      assert @ts.matches(2, [], %w(bar baz foo))
+      refute @ts.matches(2, [], %w(qux qip))
       refute @ts.matches(2, [], ['qux'])
       refute @ts.matches(2, [], ['qip'])
     end
@@ -117,9 +117,9 @@ module Commendo
       assert @ts.matches(1, ['foo'], ['qux'])
 
       assert @ts.matches(2, ['qip'], ['foo'])
-      assert @ts.matches(2, ['qux'], ['bar', 'baz'])
-      assert @ts.matches(2, ['qip'], ['bar', 'baz', 'foo'])
-      refute @ts.matches(2, ['qip'], ['qux', 'qip'])
+      assert @ts.matches(2, ['qux'], %w(bar baz))
+      assert @ts.matches(2, ['qip'], %w(bar baz foo))
+      refute @ts.matches(2, ['qip'], %w(qux qip))
       refute @ts.matches(2, ['qip'], ['qux'])
       refute @ts.matches(2, ['qux'], ['qip'])
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: commendo
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Rob Styles
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-07 00:00:00.000000000 Z
+date: 2015-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -164,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.5.0
 signing_key: 
 specification_version: 4
 summary: A Jaccard-similarity recommender using Redis sets