commander 4.4.3 → 4.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1fab0ac21561072424d7bf0d3e3ae8c07f00c721
-  data.tar.gz: a5e55123decc318877105e073ad5519a1d7e08c5
+SHA256:
+  metadata.gz: 44969cb91e63472555ff36e2d39513cb5ac4c0f8f9c626f8b85bcd836e1a8227
+  data.tar.gz: '00957023e0b9d380efab260b267082dd15c11c8a7f5e9b536f65bd8a0719b370'
 SHA512:
-  metadata.gz: 0b99a7f4c91b1fb9deee588616aadcd56dee44db34d6d99b8efd6efcc199097f94df8fec3947eeb48270da6b18df176be252fd2e9025b58a2c11df6d687bce55
-  data.tar.gz: cdd0930f1ce730579c1f1572643ea6632683262df7bf5438b107994a7523fe0a7d71505e77304eda1e6f442ad8a9b98d710e7043cb761237bb024f8d503001d5
+  metadata.gz: 0c71a8f9f030be8c93267a75027cfeac2712d31cc8907bfcfc1534f190d3f4615a930e13fbc0f1cb7cbbd7eae73cffa6136b2d63657193639064a4fde6d95f7c
+  data.tar.gz: 12e7152d828da458b7ca79a10ce08d8a8ef00d815feaf86a394b68da8892b64ce8422df0530a6c470a2784fcd23ae561abefbeb33e6e7ddddd47ea64c0cd4545

data/.rubocop.yml

@@ -1,5 +1,12 @@
 inherit_from: .rubocop_todo.yml
 
+AllCops:
+  TargetRubyVersion: 1.9
+
+# not Ruby 1.9.3 compatible
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
 # Offense count: 5
 Encoding:
   Enabled: false
@@ -23,10 +30,10 @@ Style/NumericLiteralPrefix:
 Style/MethodMissing:
   Enabled: false
 
-Style/SpaceInsideStringInterpolation:
+Layout/SpaceInsideStringInterpolation:
   Enabled: false
 
-Style/MultilineOperationIndentation:
+Layout/MultilineOperationIndentation:
   Enabled: false
 
 Style/EmptyMethod:

data/.rubocop_todo.yml

@@ -6,7 +6,7 @@
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 2
-Lint/Eval:
+Security/Eval:
   Enabled: false
 
 # Offense count: 2

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
+cache: bundler
 before_install:
   - gem update --system
   - gem update bundler
@@ -6,7 +7,8 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.10
-  - 2.2.6
-  - 2.3.3
-  - 2.4.0
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
   - jruby-19mode

data/History.rdoc

@@ -1,3 +1,7 @@
+=== 4.4.4 / 2018-01-18
+
+* Fix deprecated constant warnings on Ruby 2.5. (@mattbrictson)
+
 === 4.4.3 / 2016-12-28
 
 * Fix deprecated constant warnings on Ruby 2.4.

data/README.md

@@ -1,5 +1,5 @@
-[<img src="https://secure.travis-ci.org/commander-rb/commander.png?branch=master" alt="Build Status" />](http://travis-ci.org/commander-rb/commander)
-[![Inline docs](http://inch-ci.org/github/commander-rb/commander.png)](http://inch-ci.org/github/commander-rb/commander)
+[<img src="https://api.travis-ci.org/commander-rb/commander.svg" alt="Build Status" />](http://travis-ci.org/commander-rb/commander)
+[![Inline docs](http://inch-ci.org/github/commander-rb/commander.svg)](http://inch-ci.org/github/commander-rb/commander)
 
 # Commander
 
@@ -339,6 +339,21 @@ $ foo install gem
 # => installing  to
 ```
 
+### Long descriptions
+
+If you need to have a long command description, keep your short description under `summary`, and consider multi-line strings for `description`:
+
+```ruby
+  program :summary, 'Stupid command that prints foo or bar.'
+  program :description, %q(
+#{c.summary}
+
+More information about that stupid command that prints foo or bar.
+
+And more
+  )
+```
+
 ### Additional Global Help
 
 Arbitrary help can be added using the following `#program` symbol:

data/commander.gemspec

@@ -1,4 +1,5 @@
 # -*- encoding: utf-8 -*-
+
 $LOAD_PATH.push File.expand_path('../lib', __FILE__)
 require 'commander/version'
 
@@ -26,6 +27,6 @@ Gem::Specification.new do |s|
     s.add_development_dependency('rubocop', '~> 0.41.1')
     s.add_development_dependency('json', '< 2.0')
   else
-    s.add_development_dependency('rubocop', '~> 0.46')
+    s.add_development_dependency('rubocop', '~> 0.49.1')
   end
 end

data/lib/commander/user_interaction.rb

@@ -324,22 +324,45 @@ module Commander
     # Implements ask_for_CLASS methods.
 
     module AskForClass
-      DEPRECATED_CONSTANTS = [:Config, :TimeoutError, :MissingSourceFile, :NIL, :TRUE, :FALSE, :Fixnum, :Bignum].freeze
-      # All special cases in HighLine::Question#convert, except those that implement #parse
-      (
-        [Float, Integer, String, Symbol, Regexp, Array, File, Pathname] +
-        # All Classes that respond to #parse
-        # Ignore constants that trigger deprecation warnings
-        (Object.constants - DEPRECATED_CONSTANTS).map do |const|
-          Object.const_get(const)
-        end.select do |const|
-          const.class == Class && const.respond_to?(:parse)
-        end
-      ).each do |klass|
+      DEPRECATED_CONSTANTS = [:Config, :TimeoutError, :MissingSourceFile, :NIL, :TRUE, :FALSE, :Fixnum, :Bignum, :Data].freeze
+
+      # define methods for common classes
+      [Float, Integer, String, Symbol, Regexp, Array, File, Pathname].each do |klass|
         define_method "ask_for_#{klass.to_s.downcase}" do |prompt|
           $terminal.ask(prompt, klass)
         end
       end
+
+      def method_missing(method_name, *arguments, &block)
+        if method_name.to_s =~ /^ask_for_(.*)/
+          if arguments.count != 1
+            fail ArgumentError, "wrong number of arguments (given #{arguments.count}, expected 1)"
+          end
+          prompt = arguments.first
+          requested_class = Regexp.last_match[1]
+
+          # All Classes that respond to #parse
+          # Ignore constants that trigger deprecation warnings
+          available_classes = (Object.constants - DEPRECATED_CONSTANTS).map do |const|
+            Object.const_get(const)
+          end.select do |const|
+            const.class == Class && const.respond_to?(:parse)
+          end
+
+          klass = available_classes.find { |k| k.to_s.downcase == requested_class }
+          if klass
+            $terminal.ask(prompt, klass)
+          else
+            super
+          end
+        else
+          super
+        end
+      end
+
+      def respond_to_missing?(method_name, include_private = false)
+        method_name.to_s.start_with?('ask_for_') || super
+      end
     end
 
     ##

data/lib/commander/version.rb

@@ -1,3 +1,3 @@
 module Commander
-  VERSION = '4.4.3'.freeze
+  VERSION = '4.4.4'.freeze
 end

data/spec/methods_spec.rb

@@ -6,8 +6,49 @@ describe Commander::Methods do
     expect(subject.ancestors).to include(Commander::UI)
   end
 
-  it 'includes Commander::UI::AskForClass' do
-    expect(subject.ancestors).to include(Commander::UI::AskForClass)
+  describe 'AskForClass' do
+    it 'includes Commander::UI::AskForClass' do
+      expect(subject.ancestors).to include(Commander::UI::AskForClass)
+    end
+
+    describe 'defining methods' do
+      let(:terminal) { double }
+
+      before do
+        allow(terminal).to receive(:ask)
+        $_old_terminal = $terminal
+        $terminal = terminal
+      end
+
+      after do
+        $terminal = $_old_terminal
+      end
+
+      subject do
+        Class.new do
+          include Commander::UI::AskForClass
+        end.new
+      end
+
+      it 'defines common "ask_for_*" methods' do
+        expect(subject.respond_to?(:ask_for_float)).to be_truthy
+      end
+
+      it 'responds to "ask_for_*" methods for classes that implement #parse' do
+        expect(subject.respond_to?(:ask_for_datetime)).to be_truthy
+      end
+
+      it 'fails "ask_for_*" method invocations without a prompt' do
+        expect do
+          subject.ask_for_datetime
+        end.to raise_error(ArgumentError)
+      end
+
+      it 'implements "ask_for_*"' do
+        expect(terminal).to receive(:ask)
+        subject.ask_for_datetime('hi')
+      end
+    end
   end
 
   it 'includes Commander::Delegates' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: commander
 version: !ruby/object:Gem::Version
-  version: 4.4.3
+  version: 4.4.4
 platform: ruby
 authors:
 - TJ Holowaychuk
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-28 00:00:00.000000000 Z
+date: 2018-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -73,14 +73,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: 0.49.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: 0.49.1
 description: The complete solution for Ruby command-line executables. Commander bridges
   the gap between other terminal related libraries you know and love (OptionParser,
   HighLine), while providing many new features, and an elegant API.
@@ -157,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: The complete solution for Ruby command-line executables