commander 4.4.1 → 4.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6f99aeb41258777769c560127ccfc168d2c673e1
-  data.tar.gz: e374077ade7007619a37e26bb587c0d7be336df6
+  metadata.gz: ea8a3adb031f870cf34d2f8bc700fe79fdaa8dc1
+  data.tar.gz: 185b443d300a91265e8c5ccede6af243acb0001d
 SHA512:
-  metadata.gz: 75c44b69d218b6843b2c30a1ee8ebeadb9867d797323bcd00c261628005b1c772c3990a16d78df93dc5494bd099ea04af7027ccaa81026b920b8c29a5440b795
-  data.tar.gz: b1e6fb8f2aa3bdccffb093aa49c107d37370106638b9a12f04f9a8320ce5e597fd3044834b941c5556128cca82bfe1e0ad5048d1a159f7b12617b75f05df6995
+  metadata.gz: 7591ef4b0a0f8b3843576a9c34a5d53dc0d10031fb8d22e95180c655b4d90ee05998c959f771f5334550c8781368201a6c89d5a81165ae15cca77d0226f9ff0f
+  data.tar.gz: 5ab3f6ec15fe1d6febfbc02395fe6b2f9985b273f30e699fa7b56fd2fa218c853855f054e92ed81db747e61e0ce15a7841cf14922c7ed6f39d8997e5b69ff6c8

data/.rubocop.yml

@@ -5,5 +5,33 @@ Encoding:
   Enabled: false
 
 # Enforce trailing comma after last item of multiline hashes.
-Style/TrailingComma:
+Style/TrailingCommaInLiteral:
   EnforcedStyleForMultiline: comma
+
+Metrics/BlockLength:
+  Enabled: false
+
+Style/SignalException:
+  EnforcedStyle: only_fail
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/NumericLiteralPrefix:
+  EnforcedOctalStyle: zero_only
+
+Style/MethodMissing:
+  Enabled: false
+
+Style/SpaceInsideStringInterpolation:
+  Enabled: false
+
+Style/MultilineOperationIndentation:
+  Enabled: false
+
+Style/EmptyMethod:
+  EnforcedStyle: expanded
+
+Metrics/ModuleLength:
+  CountComments: false  # count full line comments?
+  Max: 150

data/History.rdoc

@@ -1,3 +1,7 @@
+=== 4.4.2 / 2016-12-20
+
+* Add `help_paging` program flag so that help paging may be disabled. (@gogiel)
+
 === 4.4.1 / 2016-12-02
 
 * Fix #36 - Warning about MissingSourceFile (@fallwith)

data/commander.gemspec

@@ -22,8 +22,10 @@ Gem::Specification.new do |s|
   s.add_development_dependency('rspec', '~> 3.2')
   s.add_development_dependency('rake')
   s.add_development_dependency('simplecov')
-  s.add_development_dependency('rubocop', '~> 0.29.1')
   if RUBY_VERSION < '2.0'
+    s.add_development_dependency('rubocop', '~> 0.41.1')
     s.add_development_dependency('json', '< 2.0')
+  else
+    s.add_development_dependency('rubocop', '~> 0.46')
   end
 end

data/lib/commander/command.rb

@@ -140,7 +140,7 @@ module Commander
       fail ArgumentError, 'must pass an object, class, or block.' if args.empty? && !block
       @when_called = block ? [block] : args
     end
-    alias_method :action, :when_called
+    alias action when_called
 
     ##
     # Run the command with _args_.

data/lib/commander/runner.rb

@@ -134,6 +134,7 @@ module Commander
     #   :name            Program name, defaults to basename of executable
     #   :help_formatter  Defaults to Commander::HelpFormatter::Terminal
     #   :help            Allows addition of arbitrary global help blocks
+    #   :help_paging     Flag for toggling help paging
     #   :int_message     Message to display when interrupted (CTRL + C)
     #
 
@@ -147,7 +148,7 @@ module Commander
         @program[key] = block
       else
         unless args.empty?
-          @program[key] = (args.count == 1 && args[0]) || args
+          @program[key] = args.count == 1 ? args[0] : args
         end
         @program[key]
       end
@@ -246,7 +247,7 @@ module Commander
 
     def valid_command_names_from(*args)
       arg_string = args.delete_if { |value| value =~ /^-/ }.join ' '
-      commands.keys.find_all { |name| name if /^#{name}\b/.match arg_string }
+      commands.keys.find_all { |name| name if arg_string =~ /^#{name}\b/ }
     end
 
     ##
@@ -283,6 +284,7 @@ module Commander
       {
         help_formatter: HelpFormatter::Terminal,
         name: File.basename($PROGRAM_NAME),
+        help_paging: true,
       }
     end
 
@@ -297,7 +299,7 @@ module Commander
         c.example 'Display global help', 'command help'
         c.example "Display help for 'foo'", 'command help foo'
         c.when_called do |args, _options|
-          UI.enable_paging
+          UI.enable_paging if program(:help_paging)
           if args.empty?
             say help_formatter.render
           else

data/lib/commander/user_interaction.rb

@@ -181,7 +181,7 @@ module Commander
           #{statement}
           end if
         end tell
-        ),
+        )
       ).strip.to_sym
     end
 

data/lib/commander/version.rb

@@ -1,3 +1,3 @@
 module Commander
-  VERSION = '4.4.1'
+  VERSION = '4.4.2'.freeze
 end

data/spec/runner_spec.rb

@@ -407,6 +407,23 @@ describe Commander do
     it 'can be used before or after the command and options' do
       expect(run('test', '--help')).to eq("Implement help for test here\n")
     end
+
+    describe 'help_paging program information' do
+      it 'enables paging when enabled' do
+        run('--help') { program :help_paging, true }
+        expect(Commander::UI).to have_received(:enable_paging)
+      end
+
+      it 'is enabled by default' do
+        run('--help')
+        expect(Commander::UI).to have_received(:enable_paging)
+      end
+
+      it 'does not enable paging when disabled' do
+        run('--help') { program :help_paging, false }
+        expect(Commander::UI).not_to have_received(:enable_paging)
+      end
+    end
   end
 
   describe 'with invalid options' do

data/spec/spec_helper.rb

@@ -58,6 +58,7 @@ end
 def run(*args)
   new_command_runner(*args) do
     program :help_formatter, Commander::HelpFormatter::Base
+    yield if block_given?
   end.run!
   @output.string
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: commander
 version: !ruby/object:Gem::Version
-  version: 4.4.1
+  version: 4.4.2
 platform: ruby
 authors:
 - TJ Holowaychuk
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-02 00:00:00.000000000 Z
+date: 2016-12-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -73,14 +73,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.29.1
+        version: '0.46'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.29.1
+        version: '0.46'
 description: The complete solution for Ruby command-line executables. Commander bridges
   the gap between other terminal related libraries you know and love (OptionParser,
   HighLine), while providing many new features, and an elegant API.