commander-fastlane 4.4.5 → 4.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d28d59a6cc9f6f509e7dd975c6e9810f79d68168
-  data.tar.gz: a95fa24aec357f85c10f69dc93fe7e4553317c8a
+  metadata.gz: c1acebe7b301cf71ef0f7eff8892ed12b88141cc
+  data.tar.gz: 16626d950688e20d17bc622eccd547a6f596f9e0
 SHA512:
-  metadata.gz: 90c988f320592c8ab3751eb768bdf6531b4d0aee84f1c9b90ce925760d9a59a111fe92ed9805ebd282500f903c7d746b1531abd993abc084a2e466107c86623a
-  data.tar.gz: fee955eb147ce3009f1c8c5eccf1c595b32e0efe26aec732f1a503287fe9cad0c94d740e80386ae19b21953e134d1dea26c50b02b2b4bc4a12da03ccaeeb2b25
+  metadata.gz: 9ed0298cd50d03ce6270ff0861e6851b1bf8e8e72cf08b25ecf208b80e02178536b722cd96d576490ceaa4ce525eaeef64a171b90998f596cde819658a3b2439
+  data.tar.gz: 42e12d399600e729efbeeda880271bea06529a1b0ba25dccd856ff3c5c46114fef7e83f3c2cbc963df2806233e85d0454d5d44ee259e33218f55dc6eca48b4ef

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
+cache: bundler
 before_install:
   - gem update --system
   - gem update bundler
@@ -6,7 +7,8 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.10
-  - 2.2.6
-  - 2.3.3
-  - 2.4.0
+  - 2.2.9
+  - 2.3.6
+  - 2.4.3
+  - 2.5.0
   - jruby-19mode

data/README.md

@@ -11,7 +11,7 @@ To ship a new release, just do the following
 
 - Increment the version number in `version.rb`
 - Run `bundle update && rake install`
-- Run `gem push pkg/commander-fastlane-[version].gem`
+- Run `gem push ./pkg/....pkg`
 
 💥
 

data/commander.gemspec

@@ -25,6 +25,6 @@ Gem::Specification.new do |s|
     s.add_development_dependency('rubocop', '~> 0.41.1')
     s.add_development_dependency('json', '< 2.0')
   else
-    s.add_development_dependency('rubocop', '~> 0.46')
+    s.add_development_dependency('rubocop', '~> 0.49.1')
   end
 end

data/lib/commander/runner.rb

@@ -76,7 +76,7 @@ module Commander
           OptionParser::InvalidOption,
           OptionParser::InvalidArgument,
           OptionParser::MissingArgument => e
-          abort e.to_s
+          # abort e.to_s
         rescue => e
           if @never_trace
             abort "error: #{e}."

data/lib/commander/user_interaction.rb

@@ -324,22 +324,45 @@ module Commander
     # Implements ask_for_CLASS methods.
 
     module AskForClass
-      DEPRECATED_CONSTANTS = [:Config, :TimeoutError, :MissingSourceFile, :NIL, :TRUE, :FALSE, :Fixnum, :Bignum].freeze
-      # All special cases in HighLine::Question#convert, except those that implement #parse
-      (
-        [Float, Integer, String, Symbol, Regexp, Array, File, Pathname] +
-        # All Classes that respond to #parse
-        # Ignore constants that trigger deprecation warnings
-        (Object.constants - DEPRECATED_CONSTANTS).map do |const|
-          Object.const_get(const)
-        end.select do |const|
-          const.class == Class && const.respond_to?(:parse)
-        end
-      ).each do |klass|
+      DEPRECATED_CONSTANTS = [:Config, :TimeoutError, :MissingSourceFile, :NIL, :TRUE, :FALSE, :Fixnum, :Bignum, :Data].freeze
+
+      # define methods for common classes
+      [Float, Integer, String, Symbol, Regexp, Array, File, Pathname].each do |klass|
         define_method "ask_for_#{klass.to_s.downcase}" do |prompt|
           $terminal.ask(prompt, klass)
         end
       end
+
+      def method_missing(method_name, *arguments, &block)
+        if method_name.to_s =~ /^ask_for_(.*)/
+          if arguments.count != 1
+            fail ArgumentError, "wrong number of arguments (given #{arguments.count}, expected 1)"
+          end
+          prompt = arguments.first
+          requested_class = Regexp.last_match[1]
+
+          # All Classes that respond to #parse
+          # Ignore constants that trigger deprecation warnings
+          available_classes = (Object.constants - DEPRECATED_CONSTANTS).map do |const|
+            Object.const_get(const)
+          end.select do |const|
+            const.class == Class && const.respond_to?(:parse)
+          end
+
+          klass = available_classes.find { |k| k.to_s.downcase == requested_class }
+          if klass
+            $terminal.ask(prompt, klass)
+          else
+            super
+          end
+        else
+          super
+        end
+      end
+
+      def respond_to_missing?(method_name, include_private = false)
+        method_name.to_s.start_with?('ask_for_') || super
+      end
     end
 
     ##

data/lib/commander/version.rb

@@ -1,3 +1,3 @@
 module Commander
-  VERSION = '4.4.5'.freeze
+  VERSION = '4.4.6'.freeze
 end

data/spec/methods_spec.rb

@@ -6,8 +6,49 @@ describe Commander::Methods do
     expect(subject.ancestors).to include(Commander::UI)
   end
 
-  it 'includes Commander::UI::AskForClass' do
-    expect(subject.ancestors).to include(Commander::UI::AskForClass)
+  describe 'AskForClass' do
+    it 'includes Commander::UI::AskForClass' do
+      expect(subject.ancestors).to include(Commander::UI::AskForClass)
+    end
+
+    describe 'defining methods' do
+      let(:terminal) { double }
+
+      before do
+        allow(terminal).to receive(:ask)
+        $_old_terminal = $terminal
+        $terminal = terminal
+      end
+
+      after do
+        $terminal = $_old_terminal
+      end
+
+      subject do
+        Class.new do
+          include Commander::UI::AskForClass
+        end.new
+      end
+
+      it 'defines common "ask_for_*" methods' do
+        expect(subject.respond_to?(:ask_for_float)).to be_truthy
+      end
+
+      it 'responds to "ask_for_*" methods for classes that implement #parse' do
+        expect(subject.respond_to?(:ask_for_datetime)).to be_truthy
+      end
+
+      it 'fails "ask_for_*" method invocations without a prompt' do
+        expect do
+          subject.ask_for_datetime
+        end.to raise_error(ArgumentError)
+      end
+
+      it 'implements "ask_for_*"' do
+        expect(terminal).to receive(:ask)
+        subject.ask_for_datetime('hi')
+      end
+    end
   end
 
   it 'includes Commander::Delegates' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: commander-fastlane
 version: !ruby/object:Gem::Version
-  version: 4.4.5
+  version: 4.4.6
 platform: ruby
 authors:
 - TJ Holowaychuk
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-27 00:00:00.000000000 Z
+date: 2018-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: highline
@@ -73,14 +73,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: 0.49.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.46'
+        version: 0.49.1
 description: The complete solution for Ruby command-line executables. Commander bridges
   the gap between other terminal related libraries you know and love (OptionParser,
   HighLine), while providing many new features, and an elegant API.
@@ -156,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: The complete solution for Ruby command-line executables
@@ -171,4 +171,3 @@ test_files:
 - spec/runner_spec.rb
 - spec/spec_helper.rb
 - spec/ui_spec.rb
-has_rdoc: