command_service_object 0.5.11 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71a2cbd62d96248cddea4dc3cfbdeb6f07d1d43b62582eb573ca3e689322af01
-  data.tar.gz: 333ecebd2230edf5c67967d4fcfd526a81e0f51d50111ca95f264c543ae12d14
+  metadata.gz: ff8e0861e9c53cbdb7c31094d4f7ec6a65b0e689427f113a02a9eae8bd405204
+  data.tar.gz: 32cfeb41eec29241fd214c7093db7b3c7b7221bbe7ab26d9d617e249d6b2b960
 SHA512:
-  metadata.gz: af30bd8432c0a1a045c152992e038381f64dc5cbd8882aff7bcc483ad8e5e86d24768df660c8502d2afeb2fad756f75edaeb9e12f28c67c40b604ff289906b42
-  data.tar.gz: dcace53060dc60e462025ca5dcb3d6ca93e440fc5f1ada54e587103ce18a6a35aa4dc50705a109d605c72212b8ec96600d1629edfd9d3cc39536568e0c147732
+  metadata.gz: 65e7ab0f19a4efed68b825b872a663ef6017264c877972dda8b13b5e17579d80600f312ab04b106847c46aa29643c5e3a09ad3e1dd88002999c51cf26e2551fa
+  data.tar.gz: 8ae43eac9b7b7960ac65626122bdc04038451d58e1254f951fbebae01c716806ba936af30cdebe9ab8f6e7ab04e356e4bfb9b67ebed21b9946f3ec82c83f1f6a

data/.github/workflows/gempush.yml

@@ -0,0 +1,44 @@
+name: Ruby Gem
+
+on:
+  pull_request:
+    branches:
+      - master
+  push:
+    branches:
+      - master
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@master
+    - name: Set up Ruby 2.6
+      uses: actions/setup-ruby@v1
+      with:
+        version: 2.6.x
+
+    - name: Publish to GPR
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:github: Bearer ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push --KEY github --host https://rubygems.pkg.github.com/${OWNER} *.gem
+      env:
+        GEM_HOST_API_KEY: ${{secrets.GPR_AUTH_TOKEN}}
+        OWNER: username
+
+    - name: Publish to RubyGems
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push *.gem
+      env:
+        GEM_HOST_API_KEY: ${{secrets.RUBYGEMS_AUTH_TOKEN}}

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    command_service_object (0.5.11)
+    command_service_object (0.6.0)
       virtus (~> 1.0, >= 1.0.5)
 
 GEM
@@ -81,7 +81,7 @@ GEM
     mini_portile2 (2.4.0)
     minitest (5.11.3)
     nio4r (2.3.1)
-    nokogiri (1.10.2)
+    nokogiri (1.10.4)
       mini_portile2 (~> 2.4.0)
     rack (2.0.7)
     rack-test (1.1.0)
@@ -144,4 +144,4 @@ DEPENDENCIES
   thor (~> 0.20.3)
 
 BUNDLED WITH
-   2.0.1
+   2.0.2

data/lib/command_service_object/version.rb

@@ -1,3 +1,3 @@
 module CommandServiceObject
-  VERSION = '0.5.11'.freeze
+  VERSION = '0.6.0'.freeze
 end

data/lib/generators/service/command/templates/command.rb.erb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
 
 module <%= service_name.classify %>::Commands
-  class <%= @command %>
-    include Virtus.model
-    include ActiveModel::Validations
+  class <%= @command %> < CommandBase
     # You can read Virtus gem doc for more info.
     # https://github.com/solnic/virtus
 

data/lib/generators/service/install/templates/services/application_service.rb

@@ -6,7 +6,9 @@ class ApplicationService
       raise Errors::InvalidCommand, cmd.class if cmd.invalid?
 
       usecase = usecase_for(cmd).new(cmd)
-      result  = ServiceResult.new { usecase.call }
+      raise Errors::NotAuthorizedError, cmd.class unless usecase.allowed?
+
+      result = ServiceResult.new { usecase.call }
 
       rollback(usecase, result, cmd) if result.error.present?
       result

data/lib/generators/service/install/templates/services/case_base.rb

@@ -10,5 +10,9 @@ class CaseBase
     @cmd = cmd
   end
 
+  def allowed?
+    true
+  end
+
   def rollback; end
 end

data/lib/generators/service/install/templates/services/command_base.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+
+class CommandBase
+  include Virtus.model
+  include ActiveModel::Validations
+
+  # if you need to enable policies add issuer attribute
+  # attribute :issuer, User
+  # validates :issuer, presence: true
+end

data/lib/generators/service/policies.rb

@@ -0,0 +1,5 @@
+class
+  def initialize(*args)
+
+  end
+end

data/lib/generators/service/test/templates/{rspec.rb.erb → rspec/usecase.rb.erb}

@@ -2,17 +2,25 @@
 
 require 'rails_helper'
 
-describe <%= service_name.classify %>::Usecases::<%= @usecase %> do
-  let(:cmd) { <%= service_name.classify %>::Usecases::<%= @usecase %>.new(cmd_params) }
+describe <%= service_name.classify %>::Usecases::<%= @test %> do
+  let(:cmd) { <%= service_name.classify %>::Commands::<%= @test %>.new(cmd_params) }
   let(:cmd_default_params) {{ name: 'test_name' }}
 
   context "when success" do
     let(:cmd_params) { cmd_default_params.merge!({ name: 'valid_name' }) }
     let!(:result) { ApplicationService.call(cmd) }
+
+    it 'should be okay?' do
+      expect(result.ok?).to be true
+    end
   end
 
   context 'when failure' do
     let(:cmd_params) { cmd_default_params.merge!({ name: 'invalid_name' }) }
     let!(:result) { ApplicationService.call(cmd) }
+
+    it 'should not be okay?' do
+      expect(result.ok?).to be false
+    end
   end
 end

data/lib/generators/service/test/test_generator.rb

@@ -23,27 +23,43 @@ module Service
 
         tests.each do |t|
           @test = t.classify
-          path  = "#{dir}/#{t.underscore}_test.rb"
-          template 'minitest.rb.erb', path
+          path  = "#{dir}/usecases/#{t.underscore}_test.rb"
+          template 'minitest/usecase.rb.erb', path
         end
       end
 
       def rspec_test
         dir = create_test_dir('spec')
+        create_usecase_test(dir)
+        create_command_test(dir)
+      end
+
+      def create_usecase_test(dir)
+        tests.each do |t|
+          @test = t.classify
+          path  = "#{dir}/usecases/#{t.underscore}_spec.rb"
+          template 'rspec/usecase.rb.erb', path
+        end
+      end
 
+      def create_command_test(dir)
         tests.each do |t|
           @test = t.classify
-          path  = "#{dir}/#{t.underscore}_spec.rb"
-          template 'rspec.rb.erb', path
+          path  = "#{dir}/commands/#{t.underscore}_spec.rb"
+          template 'rspec/command.rb.erb', path
         end
       end
 
       def create_test_dir(path)
         test_path    = "#{path}/services"
         service_test = "#{test_path}/#{service_name}"
+        usecases_path = "#{test_path}/#{service_name}/usecases"
+        commands_path = "#{test_path}/#{service_name}/commands"
 
         empty_directory(test_path)    unless File.exist?(test_path)
         empty_directory(service_test) unless File.exist?(service_test)
+        empty_directory(usecases_path) unless File.exist?(usecases_path)
+        empty_directory(commands_path) unless File.exist?(commands_path)
 
         service_test
       end

data/lib/generators/service/usecase/templates/usecase.rb.erb

@@ -16,6 +16,15 @@ module <%= service_name.classify %>::Usecases
       # rollback logic
     end
 
+    def allowed?
+      # policies loginc for issuer
+      # ex:
+      #
+      #   return false if issuer.role != :admin
+
+      true
+    end
+
     private
 
       def replace_me

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: command_service_object
 version: !ruby/object:Gem::Version
-  version: 0.5.11
+  version: 0.6.0
 platform: ruby
 authors:
 - Adham EL-Deeb
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-08-17 00:00:00.000000000 Z
+date: 2019-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -130,6 +130,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/gempush.yml"
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
@@ -163,14 +164,17 @@ files:
 - lib/generators/service/install/templates/initializer.rb
 - lib/generators/service/install/templates/services/application_service.rb
 - lib/generators/service/install/templates/services/case_base.rb
+- lib/generators/service/install/templates/services/command_base.rb
 - lib/generators/service/install/templates/services/service_result.rb
 - lib/generators/service/micro/micro_generator.rb
 - lib/generators/service/micro/templates/micro.rb.erb
+- lib/generators/service/policies.rb
 - lib/generators/service/service_generator.rb
 - lib/generators/service/setup/setup_generator.rb
 - lib/generators/service/test/USAGE
-- lib/generators/service/test/templates/minitest.rb.erb
-- lib/generators/service/test/templates/rspec.rb.erb
+- lib/generators/service/test/templates/minitest/usecase.rb.erb
+- lib/generators/service/test/templates/rspec/command.rb.erb
+- lib/generators/service/test/templates/rspec/usecase.rb.erb
 - lib/generators/service/test/test_generator.rb
 - lib/generators/service/usecase/USAGE
 - lib/generators/service/usecase/templates/usecase.rb.erb