comgate_ruby 0.8.2 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d020da6b1614a32495b473b497b9931406275e575a5be5012b70c46313a60041
-  data.tar.gz: ff070de8de6f549aaf6482c3a00f07cf7d496e683a6829cbdca7a40854ee8049
+  metadata.gz: f70dc5da596b91029a905c8cdb1987b96e805d9d222f54c3a8896947119ca0c8
+  data.tar.gz: 6ffc03ac6e2e119c35bce6aa561bab416c20f63dd8b8748c186969952e3f82ce
 SHA512:
-  metadata.gz: cde1b8d7a8b37148cfa1af8afd799ca9858b565f52a34d265651233ac49a5dd90879ebc2c602097ed654aa1c79ae4cc764b08af0bda7a2047f9a7e3943a6d16d
-  data.tar.gz: 56490bc816c7e2a5afa3b9ca30d36d4603ae388853d157d078b43ffe1e42376e627541e4b8e4b95eb9edccb0d00c96e2304486365f1d286dd7dbbbb01fbab973
+  metadata.gz: 994a8c9c9450d07e709da2dfe4e7787cffc72e3176b18ec0a1ac8b10718c6b6f9b848fb83e83a28017c5fc06d36ebf87d51b02b8a7720fe7600a2e40cc3fab9d
+  data.tar.gz: 5f512b4a460484552f42304cd539a45dbb233e8c2344f037b8ab5712537e5139f5607293f735e069fb064ca36084b273d199ed10abf9f5e0d1cf4fd9688756e4

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## [0.8.3] - 2023-06-27
+- If response from Comgate API is error, but containt "transId" we do not raise exception but pass info up to stack
+
 ## [0.8.2] - 2023-06-20
 - If ENV["COMGATE_MIN_LOG_LEVEL"] is set, calls and responses to Comgate are logged at that level. Otherwise `:debug` is used.
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    comgate_ruby (0.8.1)
+    comgate_ruby (0.8.3)
 
 GEM
   remote: https://rubygems.org/

data/lib/comgate/api_caller.rb

@@ -122,9 +122,10 @@ module Comgate
     def record_api_error
       return unless api_error?
 
-      errors[:api] = ["[Error ##{result[:response_body]["error"]}] #{result[:response_body]["message"]}"]
+      msg = [result[:response_body]["message"], result[:response_body]["extraMessage"]].compact.join(" ")
+      errors[:api] = ["[Error ##{result[:response_body]["error"]}] #{msg}"]
       @result[:errors] = { api: { code: result[:response_body]["error"].to_i,
-                                  message: result[:response_body]["message"] } }
+                                  message: msg } }
     end
 
     def api_error?

data/lib/comgate/gateway.rb

@@ -42,6 +42,7 @@ module Comgate
       transferId: %i[transfer_id],
       code: %i[code],
       message: %i[message],
+      extraMessage: %i[extra_message],
       payerId: %i[payer id],
       payerName: %i[payer account_name],
       payer_name: %i[payer account_name],
@@ -148,7 +149,7 @@ module Comgate
     def process_callback(comgate_params)
       Comgate::Response.new({ response_body: comgate_params }, DATA_CONVERSION_HASH)
     end
-    alias process_payment_callback process_callback  # backward compatibility
+    alias process_payment_callback process_callback # backward compatibility
 
     def allowed_payment_methods(payment_data)
       ph = gateway_params.merge(convert_data_to_comgate_params(%i[curr lang country], payment_data, required: false))
@@ -181,7 +182,7 @@ module Comgate
       if srv.success?
         Comgate::Response.new(srv.result, conversion_hash)
       else
-        handle_failure_from(srv.errors)
+        handle_failure_from(srv)
       end
     end
 
@@ -189,8 +190,11 @@ module Comgate
       test_from_data.nil? ? test_calls_used? : (test_from_data == true)
     end
 
-    def handle_failure_from(errors)
-      raise errors.to_s
+    def handle_failure_from(srv)
+      raise srv.errors.to_s unless srv.result.dig(:response_body, "transId").present?
+
+      # pretends to be a successfull response, and keep payment check to decide what to do next
+      Comgate::Response.new(srv.result, conversion_hash)
     end
 
     def single_payment_payload(payment_data)

data/lib/comgate/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Comgate
-  VERSION = "0.8.2"
+  VERSION = "0.8.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: comgate_ruby
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.3
 platform: ruby
 authors:
 - Petr Mlčoch
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-20 00:00:00.000000000 Z
+date: 2023-06-27 00:00:00.000000000 Z
 dependencies: []
 description: Write a longer description or delete this line.
 email: