comee_core 0.3.62 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a8f23f1d28138a9c1ea5c7b1d3db24677b6e19f65ca0f6a51f33ce71ed8cb96a
-  data.tar.gz: 102f6fdcc04f3d4fbcb16001bb40d506aa3b696bfae706ead07145b404bb1dcd
+  metadata.gz: ca0bf8df6ae7657e0a6c77cee48a1da4268ba89529e6619f662de9975b60aa47
+  data.tar.gz: 8717fbcce6807e2c483e1df297c94fe438508f6e10d2e0d7990de1be9a1adaf8
 SHA512:
-  metadata.gz: 39b430f64502160a7e1fceef29d9915bb585475f1f8d8649891cbb4bbbcf18d70486b82d02e76d2192bf3bf1cc740778b85b0357767fd2f389086e9d65a47862
-  data.tar.gz: 7fc899f05efd56ea1046d0066a3e6c27e076ef909f5c804a5bdd2dc353acb18310636ce94667b3fa7873395b49f056011185e31dfecda32ce987efd5c1e3fc06
+  metadata.gz: fb999522604cbeb2e2a852786ee940a922d5b0d65ed03399d1f0ec9db96baf54644295abbb8b101f3f002f5745c83eb683af417b2d76c517f279268bd7f0ae00
+  data.tar.gz: 164e68de1f86011ac8296fb0e2f6cd99d1d6ec1bb942e68098cb3b436b7a0768b40d6e4f580f85e0a63dc2b5c4e9f293762e1f9175306be2852adf52d2b319da

data/app/controllers/comee/core/access_controller.rb

@@ -16,7 +16,7 @@ module Comee
               id: user.id,
               name: user.name,
               email: user.email,
-              roles: roles
+              roles:
             }
             jwt = TokenService.issue(payload)
             render json: {token: jwt, user: payload}

data/app/controllers/comee/core/client_prices_controller.rb

@@ -24,7 +24,7 @@ module Comee
       def update
         if @obj.draft?
           product_id = model_params[:product_id] || @obj.product_id
-          master_price = MasterPrice.find_by(product_id: product_id, primary: true)
+          master_price = MasterPrice.find_by(product_id:, primary: true)
           @obj.price = master_price&.selling_price
           @obj.valid_from = model_params[:valid_from] if model_params[:valid_from]
           @obj.valid_to = model_params[:valid_to] if model_params[:valid_to]
@@ -41,7 +41,7 @@ module Comee
           end
         else
           error = "Client price should be in draft state to edit."
-          render json: {success: false, error: error}, status: 422
+          render json: {success: false, error:}, status: 422
         end
       rescue StandardError => e
         render json: {success: false, error: e.message}
@@ -64,7 +64,7 @@ module Comee
         client = Client.find(params[:id])
         client_id = client.parent_id || client.id
         prices = ClientPrice.includes(:client, :product, :unit, :product_lookup)
-                            .where(client_id: client_id)
+                            .where(client_id:)
         render_content(prices)
       end
 

data/app/controllers/comee/core/customs_details_controller.rb

@@ -11,7 +11,7 @@ module Comee
       def send_customs_details
         service = BeoService.new(publish_params[:ids])
         data = service.send_customs_details
-        render json: {success: true, data: data}
+        render json: {success: true, data:}
       rescue StandardError => e
         render json: {success: false, error: e.message}, status: 422
       end
@@ -19,7 +19,7 @@ module Comee
       def generate_beo_xml
         service = BeoService.new(publish_params[:ids])
         data = service.preprocess_data(xml: true)
-        render json: {success: true, data: data}
+        render json: {success: true, data:}
       rescue StandardError => e
         render json: {success: false, error: e.message}, status: 422
       end

data/app/controllers/comee/core/sales_order_items_controller.rb

@@ -34,7 +34,7 @@ module Comee
             :item_statuses
           ],
           # sales_order: :fulfillment_center,
-          purchase_order_item: [{purchase_order: :supplier}]
+          purchase_order_item: [purchase_order: :supplier]
         ).find(params[:id])
         render_content(
           details,

data/app/models/comee/core/client_address.rb

@@ -11,10 +11,10 @@ module Comee
         return unless client && address_type && default
 
         default_count = if new_record?
-                          ClientAddress.where(address_type: address_type, client: client, default: true).count
+                          ClientAddress.where(address_type:, client:, default: true).count
                         else
-                          ClientAddress.where(address_type: address_type, client: client, default: true)
-                                       .where.not(id: id).count
+                          ClientAddress.where(address_type:, client:, default: true)
+                                       .where.not(id:).count
                         end
 
         return if default_count.zero?

data/app/models/comee/core/customer_order_item.rb

@@ -24,7 +24,7 @@ module Comee
         lookup = ProductLookup.find_by(
           itemable_id: client_id,
           itemable_type: "Comee::Core::Client",
-          product_id: product_id
+          product_id:
         )
         self.customer_item_alias = lookup&.aliases
       end

data/app/models/comee/core/goods_received_note.rb

@@ -20,7 +20,7 @@ module Comee
           number = SecureRandom.random_number(10000000)
           grn_number = "GRN-#{number}"
 
-          break grn_number unless GoodsReceivedNote.where(grn_number: grn_number).exists?
+          break grn_number unless GoodsReceivedNote.where(grn_number:).exists?
         end
       end
     end

data/app/models/comee/core/master_price.rb

@@ -21,7 +21,7 @@ module Comee
 
       def self.product_price(product_id)
         MasterPrice.find_by(
-          product_id: product_id,
+          product_id:,
           primary: true,
           status: Price.statuses[:current]
         )
@@ -30,7 +30,7 @@ module Comee
       def validate_primary_price
         return unless product && primary
 
-        price = MasterPrice.find_by(product: product, primary: true, status: Price.statuses[:current])
+        price = MasterPrice.find_by(product:, primary: true, status: Price.statuses[:current])
         return unless price && price.id != id && status == price.status
 
         errors.add(:base, "There is already a primary price entry for item '#{product.code}'")

data/app/models/comee/core/notification.rb

@@ -6,7 +6,7 @@ module Comee
       belongs_to :recipient, polymorphic: true
 
       def message
-        {id: id, read: !read_at.nil?, created_at: created_at}.merge(to_notification.message)
+        {id:, read: !read_at.nil?, created_at:}.merge(to_notification.message)
       end
 
       def self.messages(notifications)

data/app/models/comee/core/purchase_order.rb

@@ -11,7 +11,7 @@ module Comee
       validates :order_date, :delivery_address, :status, :delivery_date, presence: true
       validates :discount, numericality: {greater_than_or_equal_to: 0, less_than_or_equal_to: 100, allow_nil: true}
       validates :confirmed_discount, numericality: {greater_than_or_equal_to: 0, less_than_or_equal_to: 100, allow_nil: true}
-      enum status: {
+      enum :status, {
         draft: 0,
         submitted: 1,
         approved: 2,

data/app/models/comee/core/purchase_order_item.rb

@@ -9,7 +9,7 @@ module Comee
 
       has_one :purchase_order_item_diff
 
-      enum status: {active: 0, canceled: 1}
+      enum :status, {active: 0, canceled: 1}
 
       belongs_to :purchase_order
       belongs_to :product

data/app/models/comee/core/purchase_requisition_item.rb

@@ -5,7 +5,7 @@ module Comee
       after_save :calculate_requisition_price
       after_save :update_requisition_purchase_status, if: proc { |item| item.fully_processed? }
 
-      enum processing_status: {unprocessed: 0, partially_processed: 1, fully_processed: 2}
+      enum :processing_status, {unprocessed: 0, partially_processed: 1, fully_processed: 2}
 
       belongs_to :product
       belongs_to :unit

data/app/models/comee/core/reorder_report.rb

@@ -27,7 +27,7 @@ module Comee
           number = SecureRandom.random_number(10000000)
           reference_number = "RR-#{number}"
 
-          break reference_number unless ReorderReport.where(reference_number: reference_number).exists?
+          break reference_number unless ReorderReport.where(reference_number:).exists?
         end
       end
     end

data/app/models/comee/core/sales_order_item.rb

@@ -8,7 +8,7 @@ module Comee
       after_save :update_sales_order_purchase_status, if: proc { |item| item.fully_processed? }
       after_destroy :update_sales_order
 
-      enum processing_status: {unprocessed: 0, partially_processed: 1, fully_processed: 2}
+      enum :processing_status, {unprocessed: 0, partially_processed: 1, fully_processed: 2}
 
       belongs_to :sales_order
       belongs_to :customer_order_item

data/app/models/comee/core/stock_transfer_request.rb

@@ -12,7 +12,7 @@ module Comee
       validates :reference_number, uniqueness: true
       validates :reference_number, :reference_date, :due_date, :status, presence: true
       validate :validate_due_date_is_after_reference_date, if: -> { due_date.present? && reference_date.present? }
-      enum status: {
+      enum :status, {
         draft: 0,
         issued: 1,
         accepted: 2,
@@ -44,7 +44,7 @@ module Comee
           number = SecureRandom.random_number(10000000)
           reference_number = "STR-#{number}"
 
-          break reference_number unless StockTransferRequest.where(reference_number: reference_number).exists?
+          break reference_number unless StockTransferRequest.where(reference_number:).exists?
         end
       end
     end

data/app/models/comee/core/supplier_address.rb

@@ -9,10 +9,10 @@ module Comee
         return unless supplier && address_type && default
 
         default_count = if new_record?
-                          SupplierAddress.where(address_type: address_type, supplier: supplier, default: true).count
+                          SupplierAddress.where(address_type:, supplier:, default: true).count
                         else
-                          SupplierAddress.where(address_type: address_type, supplier: supplier, default: true)
-                                         .where.not(id: id).count
+                          SupplierAddress.where(address_type:, supplier:, default: true)
+                                         .where.not(id:).count
                         end
 
         return if default_count.zero?

data/app/notifications/comee/core/back_order_notification.rb

@@ -16,7 +16,7 @@ module Comee
             order date: #{back_order.order_date}
             delivery date: #{back_order.delivery_date}
         CONTENT
-        {title: title, date: date, content: content}
+        {title:, date:, content:}
       end
     end
   end

data/app/services/comee/core/beo_service.rb

@@ -62,7 +62,7 @@ module Comee
           customs_detail = @customs_details.find_by(sales_order_id: si.sales_order_item.sales_order_id)
           mp = Comee::Core::MasterPrice.includes(:country_of_origin).find_by(primary: true,
                                                                              product_id: si
-                                                                             .sales_order_item.product.id)
+                                                                                         .sales_order_item.product.id)
 
           position_items << {
             "warePositionsnummer": index + 1,
@@ -81,12 +81,12 @@ module Comee
             "aussenhandelsstatistikWert": (si.sales_order_item.quantity *
                                             si.sales_order_item.price * 1.05).round(2).to_i,
             "packstuck": [
-              {
-                "packstuckNummer": index + 1,
-                "packstuckAnzahl": index.zero? ? @no_of_packages : 0,
-                "packstuckVerpackungsart": @package_type,
-                "packstuckZeichenNummern": customs_detail.sales_order.customer_order.order_number
-              }
+
+              "packstuckNummer": index + 1,
+              "packstuckAnzahl": index.zero? ? @no_of_packages : 0,
+              "packstuckVerpackungsart": @package_type,
+              "packstuckZeichenNummern": customs_detail.sales_order.customer_order.order_number
+
             ]
           }
         end
@@ -109,59 +109,59 @@ module Comee
           "messageData": {
             "ausfuhr": {
               "expdat": [
-                {
-                  "kopf": {
-                    "eoriNiederlassungsnummer": "DE47897410000",
-                    "artderAnmeldung": @customs_details[0].registration_type.split(" ")[0],
-                    "artderAnmeldungAusfuhr": @customs_details[0].export_declaration_type.split(" ")[0],
-                    "ausfuhrLand": "DE",
-                    "beteiligtenKonstellation": @customs_details[0].participant_constellation.split(" ")[0],
-                    "sicherheit": @customs_details[0].registration_type.split(" ")[0] == "CO" ? 0 : 2,
-                    "container": @customs_details[0].containerized == true ? 1 : 0,
-                    "bestimmungsLand": @customs_details[0].destination_country.split(" ")[0],
-                    "referenznummerUCR": @customs_details.map(&:sales_order).map(&:customer_order).map(&:consignee).join(" "),
-                    "lrn": @customs_details.map(&:sales_order).map(&:customer_order).map(&:order_number).join(" "),
-                    "beforderungsmittelImInlandVerkehrszweig": @customs_details[0].mode_of_transport.split(" ")[0],
-                    "beforderungsmittelderGrenzeVerkehrszweig": @customs_details[0].mode_of_transport_at_border.split(" ")[0],
-                    "beforderungsmittelderGrenzeArt": @customs_details[0].mode_of_transport_type.split(" ")[0],
-                    "beforderungsmittelderGrenzeKennzeichen": "UNBEKANNT",
-                    "beforderungsmittelderGrenzeStaatszugehorigkeit": @customs_details[0].mode_of_transport_nationality.split(" ")[0],
-                    "gesamtRohmasse": @total_weight,
-                    "beforderungsmittelBeimAbgang": [
-                      {
-                        "sequenznummer": "1",
-                        "artderIdentifikation": @customs_details[0].type_of_identification.split(" ")[0],
-                        "kennzeichen": "UNBEKANNT",
-                        "staatszugehorigkeit": @customs_details[0].nationality.split(" ")[0]
-                      }
-                    ],
-                    "ausfuhrzollstelleDienststellennummer": @customs_details[0].export_customs_office.split(" ")[0],
-                    "vorgeseheneAusgangszollstelleDienststellennummer": @customs_details[0].customs_office_of_exit.split(" ")[0],
-                    "geschaftsvorgangArt": "11",
-                    "geschaftsvorgangRechnungspreis": @customs_details[0].sales_order.total_price.round(2),
-                    "geschaftsvorgangWahrung": "EUR",
-                    "beforderungsroute": {
-                      "ausgewahlteLander": @transportation_routes,
-                      "beforderungsVon": "DE",
-                      "beforderungsBis": @customs_details[0].destination_country.split(" ")[0]
-                    },
-                    "empfanger": {
-                      "tin": "",
-                      "niederlassungsNummer": "",
-                      "name": @customs_details[0].sales_order.customer_order.client.name,
-                      "strasse": @address.street,
-                      "plz": @address.postal_code,
-                      "ort": @address.city,
-                      "land": @address.country.code
-                    },
-                    "warenortArtdesOrtes": "B",
-                    "warenortArtDerOrtsbestimmung": "Y",
-                    "warenortZusatzlicheKennung": @customs_details[0].additional_identifier.split(" ")[0],
-                    "lieferbedingungIncotermCode": @customs_details[0].delivery_term_code[0, 3],
-                    "lieferbedingungOrt": "Hamburg"
+
+                "kopf": {
+                  "eoriNiederlassungsnummer": "DE47897410000",
+                  "artderAnmeldung": @customs_details[0].registration_type.split(" ")[0],
+                  "artderAnmeldungAusfuhr": @customs_details[0].export_declaration_type.split(" ")[0],
+                  "ausfuhrLand": "DE",
+                  "beteiligtenKonstellation": @customs_details[0].participant_constellation.split(" ")[0],
+                  "sicherheit": @customs_details[0].registration_type.split(" ")[0] == "CO" ? 0 : 2,
+                  "container": @customs_details[0].containerized == true ? 1 : 0,
+                  "bestimmungsLand": @customs_details[0].destination_country.split(" ")[0],
+                  "referenznummerUCR": @customs_details.map(&:sales_order).map(&:customer_order).map(&:consignee).join(" "),
+                  "lrn": @customs_details.map(&:sales_order).map(&:customer_order).map(&:order_number).join(" "),
+                  "beforderungsmittelImInlandVerkehrszweig": @customs_details[0].mode_of_transport.split(" ")[0],
+                  "beforderungsmittelderGrenzeVerkehrszweig": @customs_details[0].mode_of_transport_at_border.split(" ")[0],
+                  "beforderungsmittelderGrenzeArt": @customs_details[0].mode_of_transport_type.split(" ")[0],
+                  "beforderungsmittelderGrenzeKennzeichen": "UNBEKANNT",
+                  "beforderungsmittelderGrenzeStaatszugehorigkeit": @customs_details[0].mode_of_transport_nationality.split(" ")[0],
+                  "gesamtRohmasse": @total_weight,
+                  "beforderungsmittelBeimAbgang": [
+
+                    "sequenznummer": "1",
+                    "artderIdentifikation": @customs_details[0].type_of_identification.split(" ")[0],
+                    "kennzeichen": "UNBEKANNT",
+                    "staatszugehorigkeit": @customs_details[0].nationality.split(" ")[0]
+
+                  ],
+                  "ausfuhrzollstelleDienststellennummer": @customs_details[0].export_customs_office.split(" ")[0],
+                  "vorgeseheneAusgangszollstelleDienststellennummer": @customs_details[0].customs_office_of_exit.split(" ")[0],
+                  "geschaftsvorgangArt": "11",
+                  "geschaftsvorgangRechnungspreis": @customs_details[0].sales_order.total_price.round(2),
+                  "geschaftsvorgangWahrung": "EUR",
+                  "beforderungsroute": {
+                    "ausgewahlteLander": @transportation_routes,
+                    "beforderungsVon": "DE",
+                    "beforderungsBis": @customs_details[0].destination_country.split(" ")[0]
+                  },
+                  "empfanger": {
+                    "tin": "",
+                    "niederlassungsNummer": "",
+                    "name": @customs_details[0].sales_order.customer_order.client.name,
+                    "strasse": @address.street,
+                    "plz": @address.postal_code,
+                    "ort": @address.city,
+                    "land": @address.country.code
                   },
-                  "position": position_data
-                }
+                  "warenortArtdesOrtes": "B",
+                  "warenortArtDerOrtsbestimmung": "Y",
+                  "warenortZusatzlicheKennung": @customs_details[0].additional_identifier.split(" ")[0],
+                  "lieferbedingungIncotermCode": @customs_details[0].delivery_term_code[0, 3],
+                  "lieferbedingungOrt": "Hamburg"
+                },
+                "position": position_data
+
               ]
             }
           }

data/app/services/comee/core/customer_order_service.rb

@@ -89,7 +89,7 @@ module Comee
 
         client_price = old_price
         unless client_price
-          client_price = ClientPrice.find_by(product_id: item.product_id, client_id: client_id)
+          client_price = ClientPrice.find_by(product_id: item.product_id, client_id:)
           if client_price
             client_price = convert_price(client_price.price, client_price.unit_id, from_id)
           else
@@ -102,11 +102,11 @@ module Comee
 
         price = convert_price(client_price, from_id, to_id)
         new_quantity = convert_quantity(quantity, from_id, to_id)
-        {quantity: new_quantity, price: price, total_price: (new_quantity * price).round(2)}
+        {quantity: new_quantity, price:, total_price: (new_quantity * price).round(2)}
       end
 
       def submit(id)
-        order = CustomerOrder.find_by(id: id)
+        order = CustomerOrder.find_by(id:)
         raise(StandardError, "Customer order with id `#{id}` not found.") unless order
 
         unless CustomerOrder.statuses[order.status] == CustomerOrder.statuses[:draft]
@@ -120,7 +120,7 @@ module Comee
       end
 
       def submit_for_confirmation(id)
-        order = CustomerOrder.find_by(id: id)
+        order = CustomerOrder.find_by(id:)
         raise(StandardError, "Customer order with id `#{id}` not found.") unless order
 
         unless CustomerOrder.statuses[order.status] == CustomerOrder.statuses[:submitted]
@@ -134,7 +134,7 @@ module Comee
       end
 
       def accept(id, accepted_by = nil)
-        order = CustomerOrder.find_by(id: id)
+        order = CustomerOrder.find_by(id:)
         raise(StandardError, "Customer order with id `#{id}` not found.") unless order
 
         if CustomerOrder.statuses[order.status] == CustomerOrder.statuses[:accepted]
@@ -176,7 +176,7 @@ module Comee
           client_id = order.client.parent_id || order.client_id
           product_ids = order_items.map(&:product_id).uniq
           client_prices = ClientPrice.where(
-            client_id: client_id,
+            client_id:,
             product_id: product_ids,
             status: ClientPrice.statuses[:current]
           )
@@ -205,13 +205,13 @@ module Comee
               sales_order_id: sales_order.id,
               customer_order_item_id: item.id,
               product_id: item.product_id,
-              unit_id: unit_id,
+              unit_id:,
               serial_no: item.serial_no,
               customer_item_no: item.customer_item_no,
               customer_item_alias: item.customer_item_alias,
               customer_item_description: item.customer_item_description,
-              quantity: quantity,
-              price: price,
+              quantity:,
+              price:,
               price_diff: price - order_price,
               total_price: quantity * price,
               delivery_date: item.delivery_date,
@@ -237,7 +237,7 @@ module Comee
       end
 
       def cancel(id)
-        order = CustomerOrder.find_by(id: id)
+        order = CustomerOrder.find_by(id:)
         raise(StandardError, "Customer order with id `#{id}` not found.") unless order
 
         if CustomerOrder.statuses[order.status] == CustomerOrder.statuses[:canceled]

data/app/services/comee/core/goods_received_note_service.rb

@@ -10,9 +10,7 @@ module Comee
           raise StandardError, "Purchase Order does not exist."
         end
 
-        if GoodsReceivedNote.exists?(purchase_order: purchase_order)
-          raise StandardError, "Goods Received Note already exists for this purchase order"
-        end
+        raise StandardError, "Goods Received Note already exists for this purchase order" if GoodsReceivedNote.exists?(purchase_order:)
 
         GoodsReceivedNote.transaction do
           purchase_order_items = PurchaseOrderItem.where(purchase_order_id: purchase_order.id)
@@ -44,7 +42,7 @@ module Comee
           end
           total_quantity = calculate_grn_total_quantity(goods_received_note)
           total_price = calculate_grn_total_price(goods_received_note)
-          goods_received_note.update!(total_amount: total_price, total_quantity: total_quantity)
+          goods_received_note.update!(total_amount: total_price, total_quantity:)
         end
         goods_received_note
       rescue StandardError

data/app/services/comee/core/product_lookup_service.rb

@@ -20,17 +20,17 @@ module Comee
         raise(StandardError, error) if to.instance_of?(String) && to != ORGANIZATION
 
         if from == ORGANIZATION
-          query = ProductLookup.joins(:product).find_by(product: {code: code}, **to)
+          query = ProductLookup.joins(:product).find_by(product: {code:}, **to)
           return query
         end
 
         if to == ORGANIZATION
-          product = ProductLookup.find_by(code: code, **from).product
+          product = ProductLookup.find_by(code:, **from).product
           return product.code
         end
 
-        product = ProductLookup.find_by(code: code, **from).product
-        ProductLookup.find_by(product: product, **to)
+        product = ProductLookup.find_by(code:, **from).product
+        ProductLookup.find_by(product:, **to)
       end
     end
   end

data/app/services/comee/core/sales_order_service.rb

@@ -86,8 +86,8 @@ module Comee
       def aggregate_back_order_item(items, supplier_id, back_order_id, delivery_date)
         items.group_by { |item| item[:product_id] }.map do |product_id, aggregated_items|
           total_quantity = aggregated_items.reduce(0) { |sum, agg_item| agg_item[:requested_quantity] + sum }
-          {product_id: product_id, requested_quantity: total_quantity, supplier_quantity: total_quantity, supplier_id: supplier_id,
-           back_order_id: back_order_id, delivery_date: delivery_date}
+          {product_id:, requested_quantity: total_quantity, supplier_quantity: total_quantity, supplier_id:,
+           back_order_id:, delivery_date:}
         end
       end
 
@@ -138,7 +138,7 @@ module Comee
       end
 
       def submit(id)
-        order = SalesOrder.find_by(id: id)
+        order = SalesOrder.find_by(id:)
         raise(StandardError, "Sales order with id `#{id}` not found.") unless order
 
         raise(StandardError, "Sales order should be in draft state.") unless order.draft?
@@ -166,7 +166,7 @@ module Comee
       # end
 
       def confirm(id)
-        order = SalesOrder.find_by(id: id)
+        order = SalesOrder.find_by(id:)
         raise(StandardError, "Sales order with id `#{id}` not found.") unless order
 
         raise(StandardError, "Sales order should be in submitted state.") unless order.submitted?
@@ -180,7 +180,7 @@ module Comee
       end
 
       def accept(id)
-        order = SalesOrder.find_by(id: id)
+        order = SalesOrder.find_by(id:)
         raise(StandardError, "Sales order with id `#{id}` not found.") unless order
 
         raise(StandardError, "Sales order should be in confirmed state.") unless order.confirmed?
@@ -194,7 +194,7 @@ module Comee
       end
 
       def cancel(id)
-        order = SalesOrder.find_by(id: id)
+        order = SalesOrder.find_by(id:)
         raise(StandardError, "Sales order with id `#{id}` not found.") unless order
 
         raise(StandardError, "Sales order is already canceled.") if order.canceled?
@@ -204,7 +204,7 @@ module Comee
       end
 
       def revert(id)
-        order = SalesOrder.find_by(id: id)
+        order = SalesOrder.find_by(id:)
         raise(StandardError, "Sales order with id `#{id}` not found.") unless order
 
         raise(StandardError, "Sales order should be in draft state.") unless order.draft?

data/lib/comee/core/active_model_serializers_frozen_options_patch.rb

@@ -0,0 +1,15 @@
+module Comee
+  module Core
+    # Rails 8.1's ActiveSupport::JSON encoder freezes the options hash it passes to
+    # `as_json` (see ActiveSupport::JSON::Encoding::JSONGemEncoder#encode). active_model_serializers
+    # 0.10.x (unmaintained since 2022) mutates that options hash while building the
+    # serializable hash, which raises FrozenError. Duping here restores the old behavior
+    # without touching the gem itself.
+    module ActiveModelSerializersFrozenOptionsPatch
+      def serializable_hash(options = nil)
+        options = options.dup if options&.frozen?
+        super(options)
+      end
+    end
+  end
+end

data/lib/comee/core/engine.rb

@@ -17,6 +17,11 @@ module Comee
       initializer :append_migrations do |app|
         app.config.paths["db/migrate"].concat(config.paths["db/migrate"].expanded) unless app.root.to_s.match(root.to_s + File::SEPARATOR)
       end
+
+      initializer "comee_core.active_model_serializers_frozen_options_patch" do
+        require "comee/core/active_model_serializers_frozen_options_patch"
+        ActiveModelSerializers::Adapter::Attributes.prepend(Comee::Core::ActiveModelSerializersFrozenOptionsPatch)
+      end
     end
   end
 end

data/lib/comee/core/version.rb

@@ -1,5 +1,5 @@
 module Comee
   module Core
-    VERSION = "0.3.62".freeze
+    VERSION = "0.4.0".freeze
   end
 end

data/spec/factories/comee/core/credit_notes.rb

@@ -9,7 +9,7 @@ FactoryBot.define do
 
     after(:build) do |note, _|
       invoice = create(:invoice)
-      create(:invoice_item, invoice: invoice)
+      create(:invoice_item, invoice:)
       note.invoice ||= invoice
     end
   end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: comee_core
 version: !ruby/object:Gem::Version
-  version: 0.3.62
+  version: 0.4.0
 platform: ruby
 authors:
 - Henock L.
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-20 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
@@ -30,14 +29,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: bcrypt
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +51,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.1'
+- !ruby/object:Gem::Dependency
+  name: benchmark
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cgi
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
@@ -92,14 +119,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: noticed
   requirement: !ruby/object:Gem::Requirement
@@ -120,14 +147,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.1.0
+        version: '8.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 7.1.0
+        version: '8.1'
 - !ruby/object:Gem::Dependency
   name: ransack
   requirement: !ruby/object:Gem::Requirement
@@ -544,6 +571,7 @@ files:
 - db/migrate/20240829135433_add_serial_no_to_invoice_items.rb
 - db/migrate/20240905111934_add_additional_fields_to_pod.rb
 - lib/comee/core.rb
+- lib/comee/core/active_model_serializers_frozen_options_patch.rb
 - lib/comee/core/engine.rb
 - lib/comee/core/version.rb
 - lib/comee_core.rb
@@ -627,7 +655,6 @@ metadata:
   homepage_uri: https://www.mks.com
   source_code_uri: https://bitbucket.org
   changelog_uri: https://bitbucket.org/
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -635,15 +662,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.7
-signing_key:
+rubygems_version: 4.0.16
 specification_version: 4
 summary: An engine for the COMee ERP.
 test_files: []