comee_core 0.1.31 → 0.1.32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5cd7848381270134d19787687f958edee66f77eaaeb6a04d72d422f0fcdf1ea9
-  data.tar.gz: 32408a7fb537503ec05947ed99b4547bbb2494af12884a1e11c031e6c577d0a2
+  metadata.gz: a9b8f42b3900f864a1225399177186948e42ae9e67c48fe9b3248eb45675ad71
+  data.tar.gz: c487c5e62ef7c83ba1442773f7a19dae1a32fb40fe966e41bcce7b21c7eb80ca
 SHA512:
-  metadata.gz: fd8973d61ccb97551156b1d51707a07355ba32c8f6bd236052aac2e256af26c1477746f4bd95e71f291d4481d2f205e7de449af90afddc1dd81be336296215f1
-  data.tar.gz: 21f6968a9c21f32473eb09de2c468684c4557ea82510fe36ebe07aa6fcfe5261b93476bd5ddb2c50d9b2553c79b21cd505d03fe03a6f51d26f09227f0dd296ef
+  metadata.gz: a7079cd5b10f8b9cf68fd7ba3c764f875fd09fc827b1f67b006f91dc52b78bee029616a335664becb6f30c1b9305cf9660fafcf5e3dc493b59175f666034b539
+  data.tar.gz: 48ab1f0e3bb54c08830e73f3ce76e472f85afe5f2683d967b8c726197083b7c9a3856faedcdca5ed65edf9fa98dade94b5e78ee355e003811b1062bac5f736c4

data/app/controllers/comee/core/client_prices_controller.rb

@@ -18,7 +18,8 @@ module Comee
       private
 
       def model_params
-        params.require(:payload).permit(:valid_from, :valid_to, :price, :status, :product_id, :discount, :client_id, :previous_price)
+        params.require(:payload).permit(:valid_from, :valid_to, :price, :status, :product_id, :discount, :client_id, :previous_price,
+                                        :unit_id)
       end
     end
   end

data/app/models/comee/core/client_price.rb

@@ -1,30 +1,28 @@
 module Comee
   module Core
-    class ClientPrice < ApplicationRecord
-      enum :status, {old: 0, current: 1, future: 2}
-      belongs_to :product
+    class ClientPrice < Price
       belongs_to :client
       belongs_to :previous_price, class_name: "Comee::Core::ClientPrice", optional: true
 
-      validates :valid_from, :valid_to, :price, :status, presence: true
+      validates :price, presence: true
       validates :price, numericality: {greater_than: 0}
       validates :discount, presence: true, numericality: {greater_than_or_equal_to: 0, less_than_or_equal_to: 100}
       validates :product_id, uniqueness: {scope: %i[client_id previous_price_id]}
-      validate :validate_price_validity_dates
-
-      def validate_price_validity_dates
-        return unless valid_from && valid_to
-
-        period = Period.new(valid_from, valid_to)
-        errors.add(:base, "Price validity date range is not correct.") unless period.valid?
-      end
 
       def self.ransackable_attributes(_auth_object = nil)
-        %w[valid_from valid_to price status product_id client_id previous_price_id]
+        %w[
+          valid_from
+          valid_to
+          price
+          status
+          product_id
+          client_id
+          previous_price_id
+        ]
       end
 
       def self.ransackable_associations(_auth_object = nil)
-        []
+        %w[product client]
       end
     end
   end

data/app/models/comee/core/master_price.rb

@@ -1,38 +1,72 @@
 module Comee
   module Core
-    class MasterPrice < ApplicationRecord
-      enum :status, {old: 0, current: 1, future: 2}
+    class MasterPrice < Price
       belongs_to :supplier
-      belongs_to :product
       belongs_to :previous_price, class_name: "Comee::Core::MasterPrice", optional: true
 
-      validates :purchase_price, :status, :selling_price, :pp_valid_from, :pp_valid_to, :sp_valid_from, :sp_valid_to, presence: true
+      validates :purchase_price, :selling_price, presence: true
       validates :margin, presence: true, numericality: {greater_than_or_equal_to: 0, less_than_or_equal_to: 100}
       validates :product_id, uniqueness: {scope: %i[supplier_id previous_price_id]}
-      validate :validate_primary_price, :validate_purchase_price_validity_dates, :validate_selling_price_validity_dates
+      validate :validate_primary_price
+
+      scope :unapplied, -> { where(propagated_to_client: false).current_primary }
 
       def validate_primary_price
         return unless product && primary
 
-        count = MasterPrice.where(product: product, primary: true, status: MasterPrice.statuses[:current]).count
+        count = MasterPrice.where(product: product, primary: true, status: Price.statuses[:current]).count
         return unless count.positive? && primary && MasterPrice.statuses[status] == MasterPrice.statuses[:current]
 
-        errors.add(:base,
-                   "There is already a primary supplier for item '#{product.code}'")
+        errors.add(:base, "There is already a primary price entry for item '#{product.code}'")
       end
 
-      def validate_purchase_price_validity_dates
-        return unless pp_valid_from && pp_valid_to
+      # def update_price(new_price, from, to, margin = nil)
+      #   raise(StandardError, "Future prices cannot be updated.") if Price.statuses[status] == Price.statuses[:future]
 
-        period = Period.new(pp_valid_from, pp_valid_to)
-        errors.add(:base, "Purchase price validity date range is not correct.") unless period.valid?
-      end
+      #   margin ||= self.margin
+      #   raise(StandardError, "No changes detected. Update failed!") if purchase_price == new_price && self.margin == margin
+
+      #   period = Period.new(from, to)
+      #   raise(StandardError, "Validity date range is not correct.") unless period.valid?
+
+      #   old_period = Period.new(valid_from, valid_to)
+      #   new_period = Period.compute_next_valid_period(old_period, period)
+      #   raise(StandardError, "No valid validity period could be computed for the given validity date range.") unless new_period
 
-      def validate_selling_price_validity_dates
-        return unless sp_valid_from && sp_valid_to
+      #   price = dup
+      #   price.assign_attributes(
+      #     purchase_price: new_price,
+      #     valid_from: new_period.start,
+      #     valid_to: new_period.finish,
+      #     margin: margin,
+      #     previous_price: self,
+      #     selling_price: (new_price * (1 + margin / 100.0)).round(2)
+      #   )
+
+      #   ActiveRecord::Base.transaction do
+      #     price.previous_price.save!
+      #     price.save!
+      #   end
+      #   price
+      # rescue StandardError
+      #   raise
+      # end
+
+      def self.ransackable_attributes(_auth_object = nil)
+        %w[
+          valid_from
+          valid_to
+          purchase_price
+          selling_price
+          status
+          product_id
+          supplier_id
+          previous_price_id
+        ]
+      end
 
-        period = Period.new(sp_valid_from, sp_valid_to)
-        errors.add(:base, "Selling price validity date range is not correct.") unless period.valid?
+      def self.ransackable_associations(_auth_object = nil)
+        %w[product supplier]
       end
     end
   end

data/app/models/comee/core/price.rb

@@ -0,0 +1,38 @@
+module Comee
+  module Core
+    class Price < ApplicationRecord
+      self.abstract_class = true
+      before_save :compute_status
+
+      enum :status, {old: 0, current: 1, future: 2}
+
+      scope :current, -> { where(status: Price.statuses[:current]) }
+      scope :future, -> { where(status: Price.statuses[:future]) }
+      scope :current_primary, -> { where(primary: true).current }
+
+      belongs_to :product
+      belongs_to :unit
+
+      validates :valid_from, :valid_to, presence: true
+      validate :validate_price_validity_dates
+
+      def validate_price_validity_dates
+        return unless valid_from && valid_to
+
+        period = Period.new(valid_from, valid_to)
+        errors.add(:base, "Price validity date range is not correct.") unless period.valid?
+      end
+
+      def compute_status
+        period = Period.new(valid_from, valid_to)
+        if period.old?
+          self.status = Price.statuses[:old]
+        elsif period.current?
+          self.status = Price.statuses[:current]
+        elsif period.future?
+          self.status = Price.statuses[:future]
+        end
+      end
+    end
+  end
+end

data/app/serializers/comee/core/client_price_serializer.rb

@@ -1,7 +1,10 @@
 module Comee
   module Core
     class ClientPriceSerializer < ActiveModel::Serializer
-      attributes :id, :valid_from, :valid_to, :price, :status, :product, :client, :previous_price
+      attributes :id, :valid_from, :valid_to, :price, :status, :previous_price
+      belongs_to :product
+      belongs_to :client
+      belongs_to :unit
     end
   end
 end

data/app/utils/comee/core/period.rb

@@ -24,6 +24,24 @@ module Comee
         finish > start
       end
 
+      def current?
+        raise(StandardError, "Period must be valid.") unless valid?
+
+        start <= Date.current && finish > Date.current
+      end
+
+      def old?
+        raise(StandardError, "Period must be valid.") unless valid?
+
+        finish < Date.current
+      end
+
+      def future?
+        raise(StandardError, "Period must be valid.") unless valid?
+
+        start > Date.current
+      end
+
       def contains?(period)
         return true if start <= period.start && finish >= period.finish
 

data/db/migrate/20230813235946_create_comee_core_master_prices.rb

@@ -3,29 +3,32 @@ class CreateComeeCoreMasterPrices < ActiveRecord::Migration[7.0]
     create_table :comee_core_master_prices do |t|
       t.float :purchase_price, null: false
       t.float :selling_price, null: false
-      t.date :pp_valid_from, null: false
-      t.date :pp_valid_to, null: false
-      t.date :sp_valid_from, null: false
+      t.date :valid_from, null: false
+      t.date :valid_to, null: false
       t.float :status, null: false, default: 0
-      t.date :sp_valid_to, null: false
-      t.boolean :active, null: false
-      t.boolean :primary, null: false
+      t.boolean :primary, null: false, default: false
       t.integer :margin, null: false
       t.references :product,
                    null: false,
-                   index: {name: "product_on_ccsp_indx"},
+                   index: {name: "product_on_ccmp_indx"},
                    foreign_key: {to_table: :comee_core_products}
       t.references :supplier,
                    null: false,
-                   index: {name: "supplier_on_ccsp_indx"},
+                   index: {name: "supplier_on_ccmp_indx"},
                    foreign_key: {to_table: :comee_core_suppliers}
+      t.references :unit,
+                   null: false,
+                   index: {name: "unit_on_ccmp_indx"},
+                   foreign_key: {to_table: :comee_core_units}
       t.references :previous_price,
                    null: true,
                    index: {name: "previous_price_on_ccsp_indx"},
                    foreign_key: {to_table: :comee_core_master_prices}
+      t.boolean :propagated_to_client, null: false, default: false
 
       t.timestamps
     end
+
     add_index :comee_core_master_prices,
               %i[product_id supplier_id previous_price_id],
               unique: true,

data/db/migrate/20230814151601_create_comee_core_client_prices.rb

@@ -14,6 +14,10 @@ class CreateComeeCoreClientPrices < ActiveRecord::Migration[7.0]
                    null: false,
                    index: {name: "client_on_cccp_indx"},
                    foreign_key: {to_table: :comee_core_clients}
+      t.references :unit,
+                   null: false,
+                   index: {name: "unit_on_cccp_indx"},
+                   foreign_key: {to_table: :comee_core_units}
       t.references :previous_price,
                    null: true,
                    index: {name: "previous_price_on_cccp_indx"},

data/lib/comee/core/version.rb

@@ -1,5 +1,5 @@
 module Comee
   module Core
-    VERSION = "0.1.31".freeze
+    VERSION = "0.1.32".freeze
   end
 end

data/spec/factories/comee/core/client_prices.rb

@@ -6,6 +6,7 @@ FactoryBot.define do
     price { 100 }
     product
     client
+    unit
     discount { 0 }
     previous_price { nil }
   end

data/spec/factories/comee/core/master_prices.rb

@@ -2,16 +2,24 @@ FactoryBot.define do
   factory :master_price, class: "Comee::Core::MasterPrice" do
     purchase_price { 100.0 }
     selling_price { 90.0 }
-    pp_valid_from { Date.current.advance(months: -1) }
-    pp_valid_to { Date.current.advance(months: 1) }
-    sp_valid_from { Date.current.advance(months: -1) }
-    sp_valid_to { Date.current.advance(months: 1) }
-    active { true }
+    valid_from { Date.current.advance(months: -1) }
+    valid_to { Date.current.advance(months: 1) }
     primary { false }
     margin { 10.0 }
     product
     supplier
+    unit
     previous_price { nil }
-    status { 0 }
+    propagated_to_client { false }
+
+    trait :old do
+      valid_from { Date.current.advance(months: -2) }
+      valid_to { Date.current.advance(months: -1) }
+    end
+
+    trait :future do
+      valid_from { Date.current.advance(months: 1) }
+      valid_to { Date.current.advance(months: 2) }
+    end
   end
 end

data/spec/factories/comee/core/products.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :product, class: "Comee::Core::Product" do
-    code { Faker::Alphanumeric.alpha(number: 6) }
+    sequence(:code) { |n| "#{Faker::Alphanumeric.unique.alpha(number: 6)}-#{n}" }
     name { Faker::Name.name }
     description { Faker::Lorem.sentence }
     metadata { {} }

data/spec/factories/comee/core/suppliers.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :supplier, class: "Comee::Core::Supplier" do
-    code { Faker::Alphanumeric.alpha(number: 8) }
+    sequence(:code) { |n| "#{Faker::Alphanumeric.alpha(number: 8)}-#{n}" }
     name { Faker::Name.name }
     address { Faker::Address.full_address }
     locale { "en" }

data/spec/factories/comee/core/units.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :unit, class: "Comee::Core::Unit" do
-    code { Faker::Alphanumeric.alpha(number: 2) }
+    sequence(:code) { |n| "#{Faker::Alphanumeric.alpha(number: 2)}-#{n}" }
     name { Faker::Name.name }
     unit_type { Comee::Core::Unit.unit_types[:weight] }
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: comee_core
 version: !ruby/object:Gem::Version
-  version: 0.1.31
+  version: 0.1.32
 platform: ruby
 authors:
 - Henock L.
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-11-03 00:00:00.000000000 Z
+date: 2023-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
@@ -276,6 +276,7 @@ files:
 - app/models/comee/core/master_price.rb
 - app/models/comee/core/notification.rb
 - app/models/comee/core/order_source.rb
+- app/models/comee/core/price.rb
 - app/models/comee/core/product.rb
 - app/models/comee/core/product_lookup.rb
 - app/models/comee/core/product_type.rb