columns_on_demand 4.2.1.1 → 4.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8a8010a746904aba625f76e9cc94aea832a4d1ce
-  data.tar.gz: e56464f8d159f2432c01b2abc857223a8e4958c8
+  metadata.gz: 638b2974e1909f9b850d1e28e99ef45a309933a9
+  data.tar.gz: 5f7121e622e2bfe7bd2e3d3aecfae2653da6f6ad
 SHA512:
-  metadata.gz: 09348f00918c3892e2360a910bf43e7c73b1a46c713d2769e36164f2087ecf38ecd801605ad97f7c3524c61bf73aefa7892d22a52e83b786f9ebc9a587ef528f
-  data.tar.gz: 2c575715505105f36f57d2d315b2b991a572bf4d7866de1bd9a9fe410ef8f438ccda2ed25ff57cfc209739e8548a11e4a44f93593da1ba71462caba2f29c2140
+  metadata.gz: 9c0a220f43a19fa785ed29c5d6123d65c9a2871d4c4bce45288892e5b75ea86bd1f80edb9b2d75b3d7829f7921e8259f5c0496f58e09956e5e40095d43f344ea
+  data.tar.gz: 21e381f3de987db40cc5c2c349fb9c8bbfc90845f0f2d81aa0ff08fd75eb98226e8bde70d478e414e142f3a88d227776e1df87b3f7a3ab56fc06be4e832d1c7a

data/{README → README.md}

@@ -21,7 +21,7 @@ Compatibility
 
 Supports mysql, mysql2, postgresql, and sqlite3.
 
-Currently tested against Rails 4.2.1, 4.2.0, 4.1.5, 4.0.9, 3.2.18, on Ruby 2.1.5.
+Currently tested against Rails 4.2.3, 4.1.12, 4.0.13, 3.2.18, on Ruby 2.1.5.
 
 Was also previously tested compatible with 2.3.14, 3.0.17, and 3.1.8 on Ruby 2.0.0
 or 1.8.7 as appropriate, and may still work for them.
@@ -30,18 +30,28 @@ or 1.8.7 as appropriate, and may still work for them.
 Example
 =======
 
-# Example.all will exclude the file_data and processing_log columns from the
-# SELECT query, and example.file_data and example.processing_log will load & cache
-# that individual column value for the record instance.
-class Example
-  columns_on_demand :file_data, :processing_log
-end
+`Example.all` will exclude the `file_data` and `processing_log` columns from the
+`SELECT` query, and `example.file_data` and `example.processing_log` will load & cache
+that individual column value for the record instance:
 
-# Scans the 'examples' table columns and registers all TEXT (:text) and BLOB (:binary)
-# columns for loading on demand.
-class Example
-  columns_on_demand
-end
+```ruby
+  class Example
+    columns_on_demand :file_data, :processing_log
+  end
+```
 
+Scans the `examples` table columns and registers all TEXT (`:text`) and BLOB (`:binary`) columns for loading on demand:
+
+```ruby
+  class Example
+    columns_on_demand
+  end
+```
+
+Thanks
+======
+
+* Tim Connor (@tlconnor)
+* Tobias Matthies (@tobmatth)
 
 Copyright (c) 2008-2015 Will Bryant, Sekuda Ltd, released under the MIT license

data/lib/columns_on_demand.rb

@@ -192,8 +192,7 @@ module ColumnsOnDemand
       if select_values.empty? && klass < ColumnsOnDemand::InstanceMethods
         arel.project(*arel_columns([default_select(true)]))
       else
-        build_select_without_columns_on_demand(arel)
-        arel.project(*arel_columns(select_values.uniq))
+        build_select_without_columns_on_demand(arel)        
       end
     end
   end

data/lib/columns_on_demand/version.rb

@@ -1,3 +1,3 @@
 module ColumnsOnDemand
-  VERSION = '4.2.1.1'
+  VERSION = '4.2.2'
 end

data/test/columns_on_demand_test.rb

@@ -290,4 +290,11 @@ class ColumnsOnDemandTest < ActiveSupport::TestCase
     assert_not_loaded record, "data"
     assert_equal "replacement", record.data
   end
+
+  test "it doesn't create duplicate columns in SELECT queries" do
+    implicits = Arel::Table.new(:implicits)
+    reference_sql = implicits.project(implicits[:id]).to_sql
+    select_sql = Implicit.select("#{Implicit.quoted_table_name}.#{Implicit.connection.quote_column_name("id")}").to_sql
+    assert_equal select_sql, reference_sql
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: columns_on_demand
 version: !ruby/object:Gem::Version
-  version: 4.2.1.1
+  version: 4.2.2
 platform: ruby
 authors:
 - Will Bryant
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-17 00:00:00.000000000 Z
+date: 2015-07-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -124,7 +124,7 @@ files:
 - ".gitignore"
 - Gemfile
 - MIT-LICENSE
-- README
+- README.md
 - Rakefile
 - columns_on_demand.gemspec
 - init.rb