collector 0.0.15 → 0.0.16

data/collector.gemspec

@@ -18,4 +18,6 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
   gem.add_dependency "activesupport", "~> 3.2.8"
+  gem.add_dependency "mongo",         "~> 1.8.0"
+  gem.add_dependency "bson",          "~> 1.8.0"
 end

data/lib/collector/repository.rb

@@ -1,5 +1,6 @@
 require "active_support/inflector"
 require "active_support/core_ext/hash"
+require "bson"
 
 module Collector
   module Repository
@@ -54,6 +55,7 @@ module Collector
       end
 
       def find_by(attributes = {})
+        attributes[:_id] = normalize_id(attributes[:_id]) if attributes[:_id]
         collection.find(attributes).map do |document|
           deserialize!(document)
         end
@@ -95,6 +97,12 @@ module Collector
         end
       end
 
+    private
+
+      def normalize_id(id)
+        BSON::ObjectId.legal?(id) ? BSON::ObjectId.from_string(id) : id
+      end
+
     end
 
   end

data/lib/collector/version.rb

@@ -1,3 +1,3 @@
 module Collector
-  VERSION = "0.0.15"
+  VERSION = "0.0.16"
 end

data/test/collector/repository_spec.rb

@@ -105,6 +105,18 @@ describe Collector::Repository do
       TestRepository.expects(:collection).returns(collection)
       TestRepository.find_by
     end
+
+    it "normalizes the id into a BSON::ObjectId if it's valid ObjectId" do
+      collection = mock { expects(:find).with(_id: BSON::ObjectId("50c58f4ab392d4381a000001")).returns([]) }
+      TestRepository.expects(:collection).returns(collection)
+      TestRepository.find_by(_id: "50c58f4ab392d4381a000001")
+    end
+
+    it "does nothing with the id if it's not a valid BSON::ObjectId" do
+      collection = mock { expects(:find).with(_id: "lols").returns([]) }
+      TestRepository.expects(:collection).returns(collection)
+      TestRepository.find_by(_id: "lols")
+    end
   end
 
   describe "find_first_by" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: collector
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.16
   prerelease: 
 platform: ruby
 authors:
@@ -27,6 +27,38 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.2.8
+- !ruby/object:Gem::Dependency
+  name: mongo
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.8.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.8.0
+- !ruby/object:Gem::Dependency
+  name: bson
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.8.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.8.0
 description: An implementation of the Repository Pattern for MongoDB.
 email:
 - brandon@anti-pattern.com