coinstar 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c6537ae7c5712623af2103e58e30cc549a6c081e
-  data.tar.gz: 43c3453ffbb24b8a59f3d5c6e50146a8c497a569
+  metadata.gz: 8a2960ea4b6ebd5418cdd74ff2798a1ce619f502
+  data.tar.gz: 1940c666e1f7b8fc1db9a142749d871eca6e457c
 SHA512:
-  metadata.gz: cdaac7671b58765fa4d63c1c5a5fa45f18f292d8220568ef791d650d77c67f05d0b5a8511abbffcba5902e64044e5c456012228ba7babf1fb5f4d80970f4c84a
-  data.tar.gz: 0fead1fbb0149cd2d0fc8cb33b951be35f1ea8fac3e83e8c1a2acca5e5af2c1f888a8dee1ad0bec2bbff92b8903c6af071d09627c0ffc0e8c14a7c6a41a97f49
+  metadata.gz: df32bb6cc0d6bc85375339fc31659f24f68e802639f9e3416cb4c3485994e2b8d352372cb0cb14b952ea18a811f858ab52f453605518edd5dd1975b2d748aa2e
+  data.tar.gz: 3c6b729d1b6cff6ef7062ca6bcb5de5fbefc7cb00dbfe515c39cb07860ed116a0c8991c6acfe1c3c455012af349fd3540db58e066d33a9c52275e7adf578eac0

data/README.md

@@ -1,3 +1,38 @@
+# Coinstar
+[![Build Status](https://travis-ci.org/bswinnerton/coinstar.png)](https://travis-ci.org/bswinnerton/coinstar)
+[![Code Climate](https://codeclimate.com/github/bswinnerton/coinstar.png)](https://codeclimate.com/github/bswinnerton/coinstar)
+[![Coverage Status](https://coveralls.io/repos/bswinnerton/coinstar/badge.png?branch=master)](https://coveralls.io/r/bswinnerton/coinstar?branch=master)
+
+##### Installation
+
+Add this line to your application's Gemfile:
+
+    gem 'coinstar'
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install coinstar
+
+##### Usage
+
+Simply call `coinstar` as so:
+
+```
+$ coinstar --make_change 98
+```
+
+or
+
+```
+$ coinstar --make_cents quarters=1 dimes=2 nickels=3 pennies=4
+```
+
+#####Requirements
+
 ![GA_Logo](https://raw.github.com/generalassembly/ga-ruby-on-rails-for-devs/master/images/ga.png)
 
 
@@ -53,35 +88,3 @@ Your program should provide for the following functionality:
 - Simplicity/elegance of design (be prepared to discuss)
 - Maintainability (clean, code that is easy to understand and change)
 - Testing (We encourage RSpec)
-
-
-### Gem Documentation
-[![Build Status](https://travis-ci.org/bswinnerton/coinstar.png)](https://travis-ci.org/bswinnerton/coinstar)
-
-##### Installation
-
-Add this line to your application's Gemfile:
-
-    gem 'coinstar'
-
-And then execute:
-
-    $ bundle
-
-Or install it yourself as:
-
-    $ gem install coinstar
-
-##### Usage
-
-Simply call `coinstar` as so:
-
-```
-coinstar --make_change 98
-```
-
-or
-
-```
-coinstar --make_cents quarters=1 dimes=2 nickels=3 pennies=4
-```

data/coinstar.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'coinstar'
-  spec.version       = '0.0.3'
+  spec.version       = '0.0.4'
   spec.authors       = ['Brooks Swinnerton']
   spec.email         = ['bswinnerton@gmail.com']
   spec.description   = %q{GA Apprentice Code Challenge}
@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'coveralls'
 
   spec.add_runtime_dependency 'activesupport'
 end

data/lib/coinstar/change_machine.rb

@@ -11,18 +11,17 @@ class ChangeMachine
     calculated_change = sorted_currency.inject({}) do |change, (k,v)|
       unless cents < v
         divisible = cents / v
-        change[k] = divisible
+        change[k.to_s.pluralize.to_sym] = divisible
         cents -= (CURRENCY[k] * divisible)
       end
       change
     end
-    pluralize(calculated_change)
   end
 
   def self.make_cents(currency)
     begin
       currency.inject(0) do |cents, (k,v)|
-        cents += (CURRENCY[singularize(k)] * v)
+        cents += (CURRENCY[k.to_s.singularize.to_sym] * v)
         cents
       end
     rescue NoMethodError
@@ -35,16 +34,4 @@ class ChangeMachine
   def self.sorted_currency
     Hash[CURRENCY.sort_by{|k, v| v}.reverse]
   end
-
-  def self.pluralize(hash)
-    hash.inject({}) do |plural_hash, (k,v)|
-      plural_key = k.to_s.pluralize
-      plural_hash[plural_key.to_sym] = v
-      plural_hash
-    end
-  end
-
-  def self.singularize(symbol)
-    symbol.to_s.singularize.to_sym
-  end
 end

data/lib/coinstar/executable.rb

@@ -11,7 +11,6 @@ module Executable
     rescue NoMethodError
       raise 'Please enter either --make_change or --make_cents'
     end
-
     begin
       params = params.first.to_i if arg == :make_change
       params = params_to_hash(params) if arg == :make_cents
@@ -19,6 +18,7 @@ module Executable
       raise 'Please enter the change amount' if arg == :make_change
       raise 'Please enter the cents as quarters=25 format' if arg == :make_cents
     end
+
     {argument: arg, params: params}
   end
 
@@ -26,8 +26,8 @@ module Executable
 
   def params_to_hash(params)
     params.inject({}) do |hash, param|
-      cents = param.split('=')
-      hash[cents.first.to_sym] = cents.last.to_i
+      array = param.split('=')
+      hash[array.first.to_sym] = array.last.to_i
       hash
     end
   end

data/spec/change_machine_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-require 'pry'
 
 describe ChangeMachine do
   context 'Makes change from a given amount of cents and returns a currency set' do
@@ -26,7 +25,7 @@ describe ChangeMachine do
 
   context 'Makes change for quantities up to 100 cents' do
     it 'gracefully handles quanities larger than 100' do
-      expect { ChangeMachine.make_change(102) }.to raise_error
+      expect { ChangeMachine.make_change(102) }.to raise_error 'You\'re going to need a bigger change machine'
     end
   end
 
@@ -64,20 +63,24 @@ describe ChangeMachine do
   context 'Takes input from the command line' do
     it 'makes change' do
       clean_input = ChangeMachine.clean_input(["--make_change", "98"])
-      expect(ChangeMachine.run(clean_input)).to eq({:quarters=>3, :dimes=>2, :pennies=>3})
+      expect(ChangeMachine.run(clean_input)).to eq( {quarters: 3, dimes: 2, pennies: 3} )
     end
 
     it 'makes cents' do
       clean_input = ChangeMachine.clean_input(["--make_cents", "quarters=3", "dimes=2", "pennies=3"])
-      expect(ChangeMachine.run(clean_input)).to eq 98
+      expect(ChangeMachine.run(clean_input)).to eq( 98 )
     end
 
     it 'gracefully fails if an argument isn\'t set' do
-      expect { ChangeMachine.clean_input([]) }.to raise_error "Please enter either --make_change or --make_cents"
+      expect { ChangeMachine.clean_input([]) }.to raise_error 'Please enter either --make_change or --make_cents'
     end
 
-    it 'gracefully fails if parameters aren\'t set' do
-      expect { ChangeMachine.clean_input(["--make_change"]) }.to raise_error "Please enter the change amount"
+    it 'gracefully fails if parameters aren\'t set with make_change' do
+      expect { ChangeMachine.clean_input(["--make_change"]) }.to raise_error 'Please enter the change amount'
+    end
+
+    it 'gracefully fails if parameters aren\'t set with make_cents' do
+      expect { ChangeMachine.clean_input(["--make_cents"]) }.to raise_error 'Please enter the cents as quarters=25 format'
     end
   end
 end

data/spec/spec_helper.rb

@@ -1 +1,4 @@
-require 'coinstar'
+require 'coveralls'
+Coveralls.wear!
+
+Dir[File.dirname(__FILE__) + '/../lib/*.rb'].each { |file| require file }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coinstar
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Brooks Swinnerton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-06 00:00:00.000000000 Z
+date: 2014-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement