coinstar 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 459a18fe52d0334bbd9c18d263b5b1e6824865d6
-  data.tar.gz: 3778d65a9efc5904c25d5303d41d5d6cc234320d
+  metadata.gz: c6537ae7c5712623af2103e58e30cc549a6c081e
+  data.tar.gz: 43c3453ffbb24b8a59f3d5c6e50146a8c497a569
 SHA512:
-  metadata.gz: 209dffffc36cbd8fa5a55c8e26b1bd25b7499d09ced870b8c0dacbbeebde9f6652eec68ae703fa661e9e9d2f6fa0e6770a657c52d88643a4660a752852475422
-  data.tar.gz: 9c72d55fbbf983d0a37f64eb63affc52804af4aca7fd42d69d6384da0a9bfe6cb5bc796cb95e97cc177c41a2f8103e55a240a78f403410ad12b275a80cc593e0
+  metadata.gz: cdaac7671b58765fa4d63c1c5a5fa45f18f292d8220568ef791d650d77c67f05d0b5a8511abbffcba5902e64044e5c456012228ba7babf1fb5f4d80970f4c84a
+  data.tar.gz: 0fead1fbb0149cd2d0fc8cb33b951be35f1ea8fac3e83e8c1a2acca5e5af2c1f888a8dee1ad0bec2bbff92b8903c6af071d09627c0ffc0e8c14a7c6a41a97f49

data/bin/coinstar

@@ -1,3 +1,4 @@
 require 'coinstar'
 
-pass_arguments
+clean_input = ChangeMachine.clean_input(ARGV)
+puts ChangeMachine.run(clean_input)

data/coinstar.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'coinstar'
-  spec.version       = '0.0.2'
+  spec.version       = '0.0.3'
   spec.authors       = ['Brooks Swinnerton']
   spec.email         = ['bswinnerton@gmail.com']
   spec.description   = %q{GA Apprentice Code Challenge}

data/lib/coinstar/change_machine.rb

@@ -1,6 +1,9 @@
 require 'active_support/inflector'
+require_relative 'executable'
 
 class ChangeMachine
+  extend Executable
+
   CURRENCY = {penny: 1, nickel: 5, dime: 10, quarter: 25}
 
   def self.make_change(cents)
@@ -9,7 +12,7 @@ class ChangeMachine
       unless cents < v
         divisible = cents / v
         change[k] = divisible
-        cents = cents - (CURRENCY[k] * divisible)
+        cents -= (CURRENCY[k] * divisible)
       end
       change
     end
@@ -17,9 +20,13 @@ class ChangeMachine
   end
 
   def self.make_cents(currency)
-    currency.inject(0) do |cents, (k,v)|
-      cents += (CURRENCY[singularize(k)] * v)
-      cents
+    begin
+      currency.inject(0) do |cents, (k,v)|
+        cents += (CURRENCY[singularize(k)] * v)
+        cents
+      end
+    rescue NoMethodError
+      raise 'Unknown currency type'
     end
   end
 

data/lib/coinstar/executable.rb

@@ -0,0 +1,34 @@
+module Executable
+  def run(args)
+    self.send(args[:argument], args[:params]) if self.respond_to? args[:argument]
+  end
+
+  def clean_input(args)
+    arg, params = args.group_by { |a| a.include? '--' }.values
+
+    begin
+      arg = arg.first.gsub('--', '').to_sym
+    rescue NoMethodError
+      raise 'Please enter either --make_change or --make_cents'
+    end
+
+    begin
+      params = params.first.to_i if arg == :make_change
+      params = params_to_hash(params) if arg == :make_cents
+    rescue NoMethodError
+      raise 'Please enter the change amount' if arg == :make_change
+      raise 'Please enter the cents as quarters=25 format' if arg == :make_cents
+    end
+    {argument: arg, params: params}
+  end
+
+  private
+
+  def params_to_hash(params)
+    params.inject({}) do |hash, param|
+      cents = param.split('=')
+      hash[cents.first.to_sym] = cents.last.to_i
+      hash
+    end
+  end
+end

data/lib/coinstar.rb

@@ -1,17 +1 @@
 require 'coinstar/change_machine'
-
-def pass_arguments
-  ARGV.each_slice(2) do |method, parameter|
-    sanitized_arg = method.gsub('--', '')
-    if sanitized_arg == 'make_change'
-      puts ChangeMachine.make_change(parameter.to_i)
-    elsif sanitized_arg == 'make_cents'
-      cents = ARGV.drop(1).inject({}) do |cents, arg|
-        cent = arg.split('=')
-        cents[cent[0].to_sym] = cent[1].to_i
-        cents
-      end
-      puts ChangeMachine.make_cents(cents)
-    end
-  end
-end

data/spec/change_machine_spec.rb

@@ -1,4 +1,5 @@
 require 'spec_helper'
+require 'pry'
 
 describe ChangeMachine do
   context 'Makes change from a given amount of cents and returns a currency set' do
@@ -53,17 +54,30 @@ describe ChangeMachine do
       cents = ChangeMachine.make_cents(currency)
       expect(cents).to eq( 47 )
     end
+
+    it 'gracefully fails if the currency is unknown' do
+      currency = {pesos: 1}
+      expect { ChangeMachine.make_cents(currency) }.to raise_error 'Unknown currency type'
+    end
   end
 
   context 'Takes input from the command line' do
     it 'makes change' do
-      command_line = `ruby bin/coinstar --make_change 98`
-      expect(command_line).to include '{:quarters=>3, :dimes=>2, :pennies=>3}'
+      clean_input = ChangeMachine.clean_input(["--make_change", "98"])
+      expect(ChangeMachine.run(clean_input)).to eq({:quarters=>3, :dimes=>2, :pennies=>3})
     end
 
     it 'makes cents' do
-      command_line = `ruby bin/coinstar --make_cents quarters=3 dimes=2 pennies=3`
-      expect(command_line).to include '98'
+      clean_input = ChangeMachine.clean_input(["--make_cents", "quarters=3", "dimes=2", "pennies=3"])
+      expect(ChangeMachine.run(clean_input)).to eq 98
+    end
+
+    it 'gracefully fails if an argument isn\'t set' do
+      expect { ChangeMachine.clean_input([]) }.to raise_error "Please enter either --make_change or --make_cents"
+    end
+
+    it 'gracefully fails if parameters aren\'t set' do
+      expect { ChangeMachine.clean_input(["--make_change"]) }.to raise_error "Please enter the change amount"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coinstar
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Brooks Swinnerton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-03 00:00:00.000000000 Z
+date: 2014-01-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -97,6 +97,7 @@ files:
 - coinstar.gemspec
 - lib/coinstar.rb
 - lib/coinstar/change_machine.rb
+- lib/coinstar/executable.rb
 - spec/change_machine_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/bswinnerton/coinstar