coinkite 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 09719fb406dae1eb4e0e589a92db14b05f02fb2b
-  data.tar.gz: e0c4b67e64237221e2cc1c3ad311e90880ca5686
+  metadata.gz: a55952a8ebf27fb69ded304a66eaa464fdff884e
+  data.tar.gz: bcff1555ac106ceeed468fd6d46d6b6a0bb8bf3e
 SHA512:
-  metadata.gz: 968a0e2a3c29b7c560dc44c191628bbe1896145e2027a8deb195d96c577360131d72f137463b1c935ade405edf3c1e3f651fbd251f79b353e95ce2ea9c813e37
-  data.tar.gz: aed894aa94f9e9c005067a7f04afbfb9684434ec73d299ce8ef9c8918e6fcc7dc2fcbf1b6fd52bbfde7b6e5dd7d243c127a632fa8a0084e490eaeaa26ef85d8e
+  metadata.gz: ca4289c12b2298c407c0edd1fddcc99421f35d74a567a485e2008e5f49ef51f1b113ddccc9ba47031c476cb86ab6a8e12c2b303098b39e6844b2f338f33316c4
+  data.tar.gz: 25c85a4bee81135ba9d32fd01716f22f84549991d6dc2dfb448e1af244e47944f573ee0b05e621180743831fc44eb95b65ce6999f243ae90cd109f509957fe1c

data/README.md

@@ -1,4 +1,4 @@
-# Coinkite API Code for Ruby
+# Coinkite Bitcoin API Code for Ruby
 
 [Learn more about Coinkite's API here](https://docs.coinkite.com/)
 and visit the [Coinkite Main Site](https://coinkite.com/) to open your
@@ -17,8 +17,14 @@ Header lines you need:
 	X-CK-Timestamp: 2014-06-23T03:10:04.905376
 	X-CK-Sign: 0aa7755aaa45189a98a5a8a887a564aa55aa5aa4aa7a98aa2858aaa60a5a56aa
 
-Use the Gem for a more complete solution that also checks SSL certificates, 
-handles some errors and wraps some API calls.
+### Ruby Gems
+
+[![Gem Version](https://badge.fury.io/rb/coinkite.svg)](http://badge.fury.io/rb/coinkite)
+
+Use the [Coinkite Gem](http://rubygems.org/gems/coinkite) for a more complete solution that also checks SSL certificates, handles some errors and wraps some API calls. 
+
+_Quick install_ `gem install coinkite`
+
 
 ## How to Install
 

data/lib/coinkite.rb

@@ -26,7 +26,7 @@ module Coinkite
 
     def request(method, endpoint, params={}, headers={})
       unless api_key ||= @api_key
-        raise AuthenticationError.new('No API key provided. ' +
+        raise CoinkiteError.new('No API key provided. ' +
           'Set your API key using "Coinkite.api_key = <API-KEY>". ' +
           'You can generate API keys from the Coinkite web interface. ')
       end
@@ -137,7 +137,7 @@ module Coinkite
     end
 
     def request_headers(endpoint, force_ts=nil)
-      signature, timestamp = make_signature(endpoint, force_ts)
+      signature, timestamp = make_signature(_signable_endpoint(endpoint), force_ts)
 
       {
         'X-CK-Key' => @api_key,
@@ -197,6 +197,12 @@ module Coinkite
       endpoint = "/v1/list/#{what}"
       get_iter(endpoint)
     end
+
+    private
+    def _signable_endpoint(endpoint)
+      # return endpoint without query string
+      endpoint.split("?").first
+    end
   end
 end
 

data/lib/coinkite/version.rb

@@ -1,3 +1,3 @@
 module Coinkite
-  VERSION = '0.9.1'
+  VERSION = '0.9.2'
 end

data/spec/coinkite_spec.rb

@@ -5,6 +5,29 @@ describe Coinkite do
     @coinkite = Coinkite::Client.new(ENV['CK_API_KEY'], ENV['CK_API_SECRET'])
   end
 
+  describe "#_signable_endpoint" do
+    let(:endpoint_with_query_string) { "https://api.coinkite.com/v1/my/accounts?foo=bar" }
+    let(:endpoint_without_query_string) { "https://api.coinkite.com/v1/my/accounts" }
+
+    it "should return endpoint without query string if given one" do
+      expect(@coinkite.send(:_signable_endpoint, endpoint_with_query_string)).to eq(endpoint_without_query_string)
+    end
+
+    it "should return endpoint without query string if given none" do
+      expect(@coinkite.send(:_signable_endpoint, endpoint_without_query_string)).to eq(endpoint_without_query_string)
+    end
+  end
+
+  describe "#get" do
+    context "with query string in endpoint" do
+      it "should be retrievable" do
+        WebMock.allow_net_connect!
+        spot_quote = @coinkite.get('/v1/spot_quote?to_cct=ZAR')
+        expect(spot_quote).to have_key("result")
+      end
+    end
+  end
+
   describe "#get_accounts" do
     it "should be retrievable" do
       stub_request(:get, "https://api.coinkite.com/v1/my/accounts").to_return(body: fixture("accounts.json"))
@@ -24,7 +47,7 @@ describe Coinkite do
       @activities.next
     end
 
-     it "should return an Enumerator" do
+    it "should return an Enumerator" do
       expect(@activities).to be_kind_of(Enumerator)
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coinkite
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Ilia Lobsanov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-16 00:00:00.000000000 Z
+date: 2014-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client