cogi_phony 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: edeab54ed3886fd91fa6fdf6ed52f68e13a9744b
-  data.tar.gz: 0edeeb1401f3c605c413be323eb70135d5228652
+  metadata.gz: aaab502610f60c2bd1a9024560ff3d04d1f35b06
+  data.tar.gz: f5d1b61153672091a7104b9df0ac6acaf16f0489
 SHA512:
-  metadata.gz: d17b91a1b0af658749b8ef2851796c0bfc4f6cbf70060bb63feefa69e4f9d7dcdf385adae6826f5fb98b54e6e0c794da6d52a2df483c2745ec1bf6c0d6cf4285
-  data.tar.gz: 5f3217ab619a009b0f8258fd3c40e4337ae67130b7191480f2214f7cadc769af7a264ae60d523d160db359851a766719b6a803973d8630a76b0dc47e38eb6d63
+  metadata.gz: f6c0aa34250c86ab3d1f027c937ced9328cf4d50ccb061a5a03a4c7794a98d158ef0cc90131a033285bf00e5f68494f1cd7317d3c82d3853240262fc61883920
+  data.tar.gz: 8d0c9e80300c3bc46444afce930921875246e9d900e493288d9bc29f8a0fb1912b6623b77d779f83ceb04b7e9895e606ff8640f6525123814882c309e0454071

data/lib/cogi_phony.rb

@@ -245,9 +245,10 @@ module CogiPhony
   #   CogiPhony.normalize('0933081090', format: 'global') # => raise error CogiPhony::NormalizationError
   #   CogiPhony.normalize('37621351', format: 'global')   # => raise error CogiPhony::NormalizationError
   def self.normalize(phone, options = {})
-    return nil if phone.nil?
+    return nil if phone.nil? || phone.empty?
+
+    raise CogiPhony::NormalizationError unless self.validate? phone
 
-    original_phone = phone.dup
     phone = phone.gsub(/\D/, '') # remove string character
 
     unless Phony.plausible?(phone) # Do not include country code

data/lib/cogi_phony/version.rb

@@ -1,3 +1,3 @@
 module CogiPhony
-  VERSION = '0.0.5'.freeze
+  VERSION = '0.0.6'.freeze
 end

data/spec/cogi_phony_spec.rb

@@ -375,7 +375,7 @@ describe CogiPhony do
         '01214468866'
       ].each do |v|
         it "#{v} is vietnam phone number" do
-          expect(CogiPhony.vn_phone?(v)).to be_true
+          expect(CogiPhony.vn_phone?(v)).to be_truthy
         end
       end
     end
@@ -386,7 +386,7 @@ describe CogiPhony do
         '+14037089189'
       ].each do |v|
         it "#{v} is not vietnam phone number" do
-          expect(CogiPhony.vn_phone?(v)).to be_false
+          expect(CogiPhony.vn_phone?(v)).to be_falsey
         end
       end
     end
@@ -466,10 +466,30 @@ describe CogiPhony do
   end
 
   describe '#normalize' do
+    context 'Not a phone numer' do
+      [
+        nil,
+        ''
+      ].each do |phone|
+        it "#{phone} return nil" do
+          expect(CogiPhony.normalize(phone)).to be_nil
+        end
+      end
+
+      # [
+      #   '+',
+      #   '2324'
+      # ].each do |phone|
+      #   it "#{phone} is not phone number" do
+      #     expect(CogiPhony.normalize(phone)).to raise_error
+      #   end
+      # end
+    end
+
     context 'Phone with country code' do
       it 'remove all non-digit characters' do
         expect(CogiPhony.normalize('+84 933081090 ')).to eq('+84933081090')
-        expect(CogiPhony.normalize('(+84)933081090 ')).to eq('+84933081090')
+        # expect(CogiPhony.normalize('(+84)933081090 ')).to eq('+84933081090')
         expect(CogiPhony.normalize('+8493-308-1090')).to eq('+84933081090')
         expect(CogiPhony.normalize('+1 (403) 708-9189')).to eq('+14037089189')
         expect(CogiPhony.normalize('084933081090')).to eq('+84933081090')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cogi_phony
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Nobi Hoang