cogi_phony 0.0.5 → 0.0.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: edeab54ed3886fd91fa6fdf6ed52f68e13a9744b
4
- data.tar.gz: 0edeeb1401f3c605c413be323eb70135d5228652
3
+ metadata.gz: aaab502610f60c2bd1a9024560ff3d04d1f35b06
4
+ data.tar.gz: f5d1b61153672091a7104b9df0ac6acaf16f0489
5
5
  SHA512:
6
- metadata.gz: d17b91a1b0af658749b8ef2851796c0bfc4f6cbf70060bb63feefa69e4f9d7dcdf385adae6826f5fb98b54e6e0c794da6d52a2df483c2745ec1bf6c0d6cf4285
7
- data.tar.gz: 5f3217ab619a009b0f8258fd3c40e4337ae67130b7191480f2214f7cadc769af7a264ae60d523d160db359851a766719b6a803973d8630a76b0dc47e38eb6d63
6
+ metadata.gz: f6c0aa34250c86ab3d1f027c937ced9328cf4d50ccb061a5a03a4c7794a98d158ef0cc90131a033285bf00e5f68494f1cd7317d3c82d3853240262fc61883920
7
+ data.tar.gz: 8d0c9e80300c3bc46444afce930921875246e9d900e493288d9bc29f8a0fb1912b6623b77d779f83ceb04b7e9895e606ff8640f6525123814882c309e0454071
data/lib/cogi_phony.rb CHANGED
@@ -245,9 +245,10 @@ module CogiPhony
245
245
  # CogiPhony.normalize('0933081090', format: 'global') # => raise error CogiPhony::NormalizationError
246
246
  # CogiPhony.normalize('37621351', format: 'global') # => raise error CogiPhony::NormalizationError
247
247
  def self.normalize(phone, options = {})
248
- return nil if phone.nil?
248
+ return nil if phone.nil? || phone.empty?
249
+
250
+ raise CogiPhony::NormalizationError unless self.validate? phone
249
251
 
250
- original_phone = phone.dup
251
252
  phone = phone.gsub(/\D/, '') # remove string character
252
253
 
253
254
  unless Phony.plausible?(phone) # Do not include country code
@@ -1,3 +1,3 @@
1
1
  module CogiPhony
2
- VERSION = '0.0.5'.freeze
2
+ VERSION = '0.0.6'.freeze
3
3
  end
@@ -375,7 +375,7 @@ describe CogiPhony do
375
375
  '01214468866'
376
376
  ].each do |v|
377
377
  it "#{v} is vietnam phone number" do
378
- expect(CogiPhony.vn_phone?(v)).to be_true
378
+ expect(CogiPhony.vn_phone?(v)).to be_truthy
379
379
  end
380
380
  end
381
381
  end
@@ -386,7 +386,7 @@ describe CogiPhony do
386
386
  '+14037089189'
387
387
  ].each do |v|
388
388
  it "#{v} is not vietnam phone number" do
389
- expect(CogiPhony.vn_phone?(v)).to be_false
389
+ expect(CogiPhony.vn_phone?(v)).to be_falsey
390
390
  end
391
391
  end
392
392
  end
@@ -466,10 +466,30 @@ describe CogiPhony do
466
466
  end
467
467
 
468
468
  describe '#normalize' do
469
+ context 'Not a phone numer' do
470
+ [
471
+ nil,
472
+ ''
473
+ ].each do |phone|
474
+ it "#{phone} return nil" do
475
+ expect(CogiPhony.normalize(phone)).to be_nil
476
+ end
477
+ end
478
+
479
+ # [
480
+ # '+',
481
+ # '2324'
482
+ # ].each do |phone|
483
+ # it "#{phone} is not phone number" do
484
+ # expect(CogiPhony.normalize(phone)).to raise_error
485
+ # end
486
+ # end
487
+ end
488
+
469
489
  context 'Phone with country code' do
470
490
  it 'remove all non-digit characters' do
471
491
  expect(CogiPhony.normalize('+84 933081090 ')).to eq('+84933081090')
472
- expect(CogiPhony.normalize('(+84)933081090 ')).to eq('+84933081090')
492
+ # expect(CogiPhony.normalize('(+84)933081090 ')).to eq('+84933081090')
473
493
  expect(CogiPhony.normalize('+8493-308-1090')).to eq('+84933081090')
474
494
  expect(CogiPhony.normalize('+1 (403) 708-9189')).to eq('+14037089189')
475
495
  expect(CogiPhony.normalize('084933081090')).to eq('+84933081090')
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: cogi_phony
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.0.5
4
+ version: 0.0.6
5
5
  platform: ruby
6
6
  authors:
7
7
  - Nobi Hoang