coercible 0.0.2 → 0.1.0

data/Changelog.md

@@ -1,3 +1,7 @@
+# v0.1.0 2013-02-17
+
+* [internal] Small clean-up and improved tests (solnic)
+
 # v0.0.2 2013-02-16
 
 * [feature] Added Coercer::Object#coerced? (solnic)

data/config/flay.yml

@@ -1,3 +1,3 @@
 ---
 threshold: 20
-total_score: 176
+total_score: 245

data/lib/coercible/coercer.rb

@@ -47,7 +47,7 @@ module Coercible
 
       yield(configuration) if block_given?
 
-      super({}, configuration)
+      super(configuration)
     end
 
     # Return configuration keys for Coercer instance
@@ -81,10 +81,9 @@ module Coercible
     # @return [undefined]
     #
     # @api private
-    def initialize(coercers = {}, config = nil)
+    def initialize(config, coercers = {})
       @coercers = coercers
       @config   = config
-      initialize_default_coercer
     end
 
     # Access a specific coercer object for the given type
@@ -105,7 +104,7 @@ module Coercible
 
     private
 
-    # Initialize a new coercer instance for the give type
+    # Initialize a new coercer instance for the given type
     #
     # If a coercer class supports configuration it will receive it from the
     # global configuration object
@@ -123,15 +122,6 @@ module Coercible
         end
     end
 
-    # Initialize default coercer object
-    #
-    # @return [Coercer::Object]
-    #
-    # @api private
-    def initialize_default_coercer
-      coercers[::Object] = Coercer::Object.new(self)
-    end
-
     # Find configuration for the given coercer type
     #
     # @return [Configuration]

data/lib/coercible/coercer/configurable.rb

@@ -34,7 +34,7 @@ module Coercible
       #
       # @api public
       def config(&block)
-        configuration = Configuration.build(config_keys)
+        configuration = configuration_class.build(config_keys)
         yield configuration
         configuration
       end
@@ -45,7 +45,12 @@ module Coercible
       #
       # @api private
       def config_name
-        self.name.downcase.split('::').last.to_sym
+        name.downcase.split('::').last.to_sym
+      end
+
+      # @api private
+      def configuration_class
+        Configuration
       end
 
     end # module Configurable

data/lib/coercible/coercer/object.rb

@@ -3,7 +3,7 @@ module Coercible
 
     # Coerce Object values
     class Object
-      extend DescendantsTracker, TypeLookup, Options
+      extend TypeLookup, Options
 
       accept_options :primitive
 
@@ -29,6 +29,15 @@ module Coercible
         @coercers = coercers
       end
 
+      # Inspect the coercer object
+      #
+      # @return [String]
+      #
+      # @api public
+      def inspect
+        "#<#{self.class} primitive=#{self.class.primitive}>"
+      end
+
       # Create an Array from any Object
       #
       # @example with an object that does not respond to #to_a or #to_ary

data/lib/coercible/version.rb

@@ -1,3 +1,3 @@
 module Coercible
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end

data/lib/support/options.rb

@@ -4,6 +4,11 @@ module Coercible
   module Options
     Undefined = Class.new.freeze
 
+    # @api private
+    def self.extended(descendant)
+      descendant.extend(DescendantsTracker)
+    end
+
     # Returns default options hash for a given attribute class
     #
     # @example

data/spec/unit/coercible/coercer/configurable/config_name_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+describe Coercer::Configurable, '.config_name' do
+  subject { object.config_name }
+
+  let(:object)  {
+    Class.new {
+      extend Coercer::Configurable, Options
+      config_keys [ :one, :two ]
+
+      def self.name
+        "Some::Class::Test"
+      end
+    }
+  }
+
+  it { should be(:test) }
+end

data/spec/unit/coercible/coercer/configurable/config_spec.rb

@@ -0,0 +1,25 @@
+require 'spec_helper'
+
+describe Coercer::Configurable, '.config' do
+  subject { object.config(&block) }
+
+  let(:object)  {
+    Class.new {
+      extend Coercer::Configurable, Options
+      config_keys [ :one, :two ]
+    }
+  }
+
+  let(:block)               { Proc.new { |config| config.test } }
+  let(:configuration)       { mock('configuration') }
+  let(:configuration_class) { mock('configuration_class') }
+
+  before do
+    object.stub!(:configuration_class => configuration_class)
+    configuration_class.should_receive(:build).with(object.config_keys).
+      and_return(configuration)
+    configuration.should_receive(:test)
+  end
+
+  it { should be(configuration) }
+end

data/spec/unit/coercible/coercer/float/to_datetime_spec.rb

@@ -6,5 +6,7 @@ describe Coercer::Float, '#to_float' do
   let(:object) { described_class.new }
   let(:value)  { 1361036672.12 }
 
-  it { should be_instance_of(DateTime) }
+  specify do
+    expect(subject.strftime('%Y-%m-%d %H:%M:%S.%L')).to eql('2013-02-16 17:44:32.120')
+  end
 end

data/spec/unit/coercible/coercer/integer/to_datetime_spec.rb

@@ -6,5 +6,7 @@ describe Coercer::Integer, '#to_datetime' do
   let(:object) { described_class.new }
   let(:value)  { 1361036672 }
 
-  it { should be_instance_of(DateTime) }
+  specify do
+    expect(subject.strftime('%Y-%m-%d %H:%M:%S.%L')).to eql('2013-02-16 17:44:32.000')
+  end
 end

data/spec/unit/coercible/coercer/numeric/to_decimal_spec.rb

@@ -1,10 +1,19 @@
 require 'spec_helper'
 
 describe Coercer::Numeric, '.to_decimal' do
-  subject { object.to_decimal(numeric) }
+  subject { object.to_decimal(value) }
 
-  let(:object)  { described_class.new }
-  let(:numeric) { Rational(2, 2)  }
+  let(:object) { described_class.new }
 
-  it { should eql(BigDecimal('1.0')) }
+  context "with an object responding to #to_d" do
+    let(:value)  { Rational(2, 2)  }
+
+    it { should eql(BigDecimal('1.0')) }
+  end
+
+  context "with an object not responding to #to_d" do
+    let(:value) { Class.new { def to_s; '1'; end }.new }
+
+    it { should eql(BigDecimal('1.0')) }
+  end
 end

data/spec/unit/coercible/coercer/object/inspect_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+
+describe Coercer::Object, '#inspect' do
+  subject { object.inspect }
+
+  let(:object) { described_class.new }
+
+  it { should == '#<Coercible::Coercer::Object primitive=Object>'}
+end

data/spec/unit/coercible/coercer/string/class_methods/config_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe Coercer::String, '.config' do
+  subject { described_class.config }
+
+  its(:boolean_map) { should be(described_class::BOOLEAN_MAP) }
+end

data/spec/unit/coercible/coercer/time_coercions/to_date_spec.rb

@@ -7,6 +7,10 @@ describe Coercer::TimeCoercions, '.to_date' do
   let(:coercer) { Class.new(Coercer::Object) { include Coercer::TimeCoercions } }
   let(:value)   { mock('value') }
 
+  after do
+    Coercer::Object.descendants.delete(coercer)
+  end
+
   context 'when the value responds to #to_date' do
     before do
       value.should_receive(:to_date).and_return(Date.new(2011, 1, 1))

data/spec/unit/coercible/coercer/time_coercions/to_datetime_spec.rb

@@ -7,6 +7,10 @@ describe Coercer::TimeCoercions, '.to_datetime' do
   let(:coercer) { Class.new(Coercer::Object) { include Coercer::TimeCoercions } }
   let(:value)   { mock('value') }
 
+  after do
+    Coercer::Object.descendants.delete(coercer)
+  end
+
   context 'when the value responds to #to_datetime' do
     before do
       object.extend Coercer::TimeCoercions

data/spec/unit/coercible/coercer/time_coercions/to_string_spec.rb

@@ -7,6 +7,10 @@ describe Coercer::TimeCoercions, '.to_string' do
   let(:coercer) { Class.new(Coercer::Object) { include Coercer::TimeCoercions } }
   let(:value)   { mock('value') }
 
+  after do
+    Coercer::Object.descendants.delete(coercer)
+  end
+
   before do
     object.extend Coercer::TimeCoercions
 

data/spec/unit/coercible/coercer/time_coercions/to_time_spec.rb

@@ -7,6 +7,10 @@ describe Coercer::TimeCoercions, '.to_time' do
   let(:coercer) { Class.new(Coercer::Object) { include Coercer::TimeCoercions } }
   let(:value)   { mock('value') }
 
+  after do
+    Coercer::Object.descendants.delete(coercer)
+  end
+
   context 'when the value responds to #to_time' do
     before do
       object.extend Coercer::TimeCoercions

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coercible
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-16 00:00:00.000000000 Z
+date: 2013-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backports
@@ -96,6 +96,8 @@ files:
 - spec/unit/coercible/coercer/array/coerced_predicate_spec.rb
 - spec/unit/coercible/coercer/array/to_set_spec.rb
 - spec/unit/coercible/coercer/class_methods/new_spec.rb
+- spec/unit/coercible/coercer/configurable/config_name_spec.rb
+- spec/unit/coercible/coercer/configurable/config_spec.rb
 - spec/unit/coercible/coercer/date/coerced_predicate_spec.rb
 - spec/unit/coercible/coercer/date/to_date_spec.rb
 - spec/unit/coercible/coercer/date/to_datetime_spec.rb
@@ -111,7 +113,7 @@ files:
 - spec/unit/coercible/coercer/decimal/to_float_spec.rb
 - spec/unit/coercible/coercer/decimal/to_integer_spec.rb
 - spec/unit/coercible/coercer/decimal/to_string_spec.rb
-- spec/unit/coercible/coercer/element_reference_spec.rb
+- spec/unit/coercible/coercer/element_reader_spec.rb
 - spec/unit/coercible/coercer/false_class/coerced_predicate_spec.rb
 - spec/unit/coercible/coercer/false_class/to_string_spec.rb
 - spec/unit/coercible/coercer/float/coerced_predicate_spec.rb
@@ -139,11 +141,13 @@ files:
 - spec/unit/coercible/coercer/numeric/to_integer_spec.rb
 - spec/unit/coercible/coercer/numeric/to_string_spec.rb
 - spec/unit/coercible/coercer/object/coerced_predicate_spec.rb
+- spec/unit/coercible/coercer/object/inspect_spec.rb
 - spec/unit/coercible/coercer/object/method_missing_spec.rb
 - spec/unit/coercible/coercer/object/to_array_spec.rb
 - spec/unit/coercible/coercer/object/to_hash_spec.rb
 - spec/unit/coercible/coercer/object/to_integer_spec.rb
 - spec/unit/coercible/coercer/object/to_string_spec.rb
+- spec/unit/coercible/coercer/string/class_methods/config_spec.rb
 - spec/unit/coercible/coercer/string/coerced_predicate_spec.rb
 - spec/unit/coercible/coercer/string/to_boolean_spec.rb
 - spec/unit/coercible/coercer/string/to_constant_spec.rb
@@ -199,6 +203,8 @@ test_files:
 - spec/unit/coercible/coercer/array/coerced_predicate_spec.rb
 - spec/unit/coercible/coercer/array/to_set_spec.rb
 - spec/unit/coercible/coercer/class_methods/new_spec.rb
+- spec/unit/coercible/coercer/configurable/config_name_spec.rb
+- spec/unit/coercible/coercer/configurable/config_spec.rb
 - spec/unit/coercible/coercer/date/coerced_predicate_spec.rb
 - spec/unit/coercible/coercer/date/to_date_spec.rb
 - spec/unit/coercible/coercer/date/to_datetime_spec.rb
@@ -214,7 +220,7 @@ test_files:
 - spec/unit/coercible/coercer/decimal/to_float_spec.rb
 - spec/unit/coercible/coercer/decimal/to_integer_spec.rb
 - spec/unit/coercible/coercer/decimal/to_string_spec.rb
-- spec/unit/coercible/coercer/element_reference_spec.rb
+- spec/unit/coercible/coercer/element_reader_spec.rb
 - spec/unit/coercible/coercer/false_class/coerced_predicate_spec.rb
 - spec/unit/coercible/coercer/false_class/to_string_spec.rb
 - spec/unit/coercible/coercer/float/coerced_predicate_spec.rb
@@ -242,11 +248,13 @@ test_files:
 - spec/unit/coercible/coercer/numeric/to_integer_spec.rb
 - spec/unit/coercible/coercer/numeric/to_string_spec.rb
 - spec/unit/coercible/coercer/object/coerced_predicate_spec.rb
+- spec/unit/coercible/coercer/object/inspect_spec.rb
 - spec/unit/coercible/coercer/object/method_missing_spec.rb
 - spec/unit/coercible/coercer/object/to_array_spec.rb
 - spec/unit/coercible/coercer/object/to_hash_spec.rb
 - spec/unit/coercible/coercer/object/to_integer_spec.rb
 - spec/unit/coercible/coercer/object/to_string_spec.rb
+- spec/unit/coercible/coercer/string/class_methods/config_spec.rb
 - spec/unit/coercible/coercer/string/coerced_predicate_spec.rb
 - spec/unit/coercible/coercer/string/to_boolean_spec.rb
 - spec/unit/coercible/coercer/string/to_constant_spec.rb