codice-fiscale 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b2543562a71d442b6d26741e5dd338cf99431390
-  data.tar.gz: e484a3de63f12a69ad8f1abefed5f5e5121fbed9
+  metadata.gz: 2e072ece1130ef8f44d55c4cc5302a5f75e5a9e7
+  data.tar.gz: 0bf6f20346f36a33672630176c8da7bcc260320c
 SHA512:
-  metadata.gz: 310b201c93895dd79351a814ec941fe4ea3b2f7e5c185516ded7b1af18412a35fa863d2680d40bb8112f45b87216e1b1e5c3a919abf5f89612dc9d05028286e9
-  data.tar.gz: 4fd74e9e7480c28e18894c2cffb2e93764d62fe0d0dc4d9b266b185ead09bb800ec0348113b7dd4ad6cf047c6cb3c809ab5826ede0d4fe157b88d40704c4886c
+  metadata.gz: 552e467c8f707cbfac1204f653a2fcef45ab2e3bcdc40c52cc15aeeccbf0a20010da084922cd68befb0aaf59dc75d2f2f16a6fef5e3be07a2890da2e380ffacd
+  data.tar.gz: c97c3375af51451728abea74762ea1c87836be9a7dc9c488ca8374c297daea8cff02126aef9a6985f60fef610835ae3e496b00c7fb875da46dc360f209eeb9af

data/LICENSE

@@ -1,22 +1,21 @@
-Copyright (c) 2012 Daniele Molteni
+The MIT License (MIT)
 
-MIT License
+Copyright (c) 2012 topac
 
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
 
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
 
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -11,9 +11,15 @@ gender, birthdate and the birthplace. Read more on [wikipedia](http://en.wikiped
 ```ruby
   require 'codice_fiscale'
 
-  CodiceFiscale.calculate :name => 'Mario', :surname => 'Rossi', :gender => :male, :birthdate => Date.new(1987, 1, 1), :province_code => 'LC', :city_name => 'Abbadia Lariana'
-
-  # RSSMRA87A01A005V
+  CodiceFiscale.calculate(
+    :name          => 'Mario',
+    :surname       => 'Rossi', 
+    :gender        => :male,
+    :birthdate     => Date.new(1987, 1, 1),
+    :province_code => 'LC', 
+    :city_name     => 'Abbadia Lariana'
+  )
+  #=> RSSMRA87A01A005V
 ```
 
 ## City codes (Codici catastali)
@@ -22,11 +28,17 @@ If a person was born outside Italy, only the italian name of the county is requi
 For example, an italian citizen born in France:
 
 ```ruby
-  CodiceFiscale.calculate :name => 'Mario', :surname => 'Rossi', :gender => :male, :birthdate => Date.new(1987, 1, 1), :country_name => 'Francia'
+  CodiceFiscale.calculate(
+    :name         => 'Mario', 
+    :surname      => 'Rossi', 
+    :gender       => :male, 
+    :birthdate    => Date.new(1987, 1, 1), 
+    :country_name => 'Francia'
+  )
 ```
 
 If a person was born in Italy you have to specify the *code* of the province and the *name* of the city. These informations are actually contained in an XLS 
-document downloaded from [agenziaterritorio.it](http://www.agenziaterritorio.it/?id=721), converted to CSV and shipped with this gem.
+document downloaded from [istat.it](http://www.istat.it/it/archivio/6789), converted to CSV and shipped with this gem.
 
 **But what if you have your own table with all those codes?**
 

data/lib/codice_fiscale.rb

@@ -18,7 +18,7 @@ module CodiceFiscale
 
   def self.calculate params
     citizen = ItalianCitizen.new params
-    raise ArgumentError.new("#{citizen.errors}") unless citizen.valid?
+    raise ArgumentError.new(citizen.errors.full_messages.join(', ')) unless citizen.valid?
     citizen.fiscal_code
   end
-end
+end

data/lib/codice_fiscale/helpers.rb

@@ -1,22 +1,20 @@
 module CodiceFiscale
   module Helpers
-    def intersection string_a, string_or_array_b
-      letters_a = string_a.split ''
-      letters_b = string_or_array_b.respond_to?(:split) ? string_or_array_b.split('') : string_or_array_b
-      selected_letters = letters_a.select { |letter| letters_b.include? letter }
-      selected_letters.join ''
+
+    def multiset_intersection array_a, array_b
+      array_a.select { |letter| array_b.include? letter }
     end
 
     def consonants string
-      intersection string, Alphabet.consonants
+      multiset_intersection(string.chars, Alphabet.consonants).join
     end
 
     def first_three_consonants string
-      intersection(string, Alphabet.consonants)[0..2]
+      multiset_intersection(string.chars, Alphabet.consonants)[0..2].join
     end
 
     def first_three_vowels string
-      intersection(string, Alphabet.vowels)[0..2]
+      multiset_intersection(string.chars, Alphabet.vowels)[0..2].join
     end
 
     def truncate_and_right_pad_with_three_x string
@@ -24,10 +22,11 @@ module CodiceFiscale
     end
 
     def first_three_consonants_than_vowels string
-      string.upcase!
-      code = first_three_consonants string
-      code << first_three_vowels(string)
+      upcase_string = string.upcase
+      code = first_three_consonants upcase_string
+      code << first_three_vowels(upcase_string)
       truncate_and_right_pad_with_three_x code
     end
+
   end
-end
+end

data/lib/codice_fiscale/version.rb

@@ -1,3 +1,3 @@
 module CodiceFiscale
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/spec/lib/codice_fiscale/fiscal_code_spec.rb

@@ -110,7 +110,7 @@ describe CodiceFiscale::FiscalCode do
       end
 
       context 'when codes are fetched using csv' do
-        before { CodiceFiscale::Codes.stub!(:city).and_return('hello') }
+        before { CodiceFiscale::Codes.stub(:city).and_return('hello') }
 
         it 'returns the city code' do
           fiscal_code.birthplace_part.should == 'hello'
@@ -130,7 +130,7 @@ describe CodiceFiscale::FiscalCode do
       end
 
       context 'when codes are fetched using csv' do
-        before { CodiceFiscale::Codes.stub!(:country).and_return('Middle-Earth') }
+        before { CodiceFiscale::Codes.stub(:country).and_return('Middle-Earth') }
 
         it 'returns the country code' do
           fiscal_code.birthplace_part.should == 'Middle-Earth'

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: codice-fiscale
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - topac
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-28 00:00:00.000000000 Z
+date: 2018-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rb-fsevent
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.1
 - !ruby/object:Gem::Dependency
   name: growl
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Calculate the italian fiscal code
@@ -101,7 +101,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - Guardfile
 - LICENSE
@@ -136,17 +136,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Calculate the italian fiscal code