codestatus 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 87b7e13b35690cbbe12b7c3f2872c00e1f02842e
-  data.tar.gz: 78147b8083a665a96f7fb692717da21b2a338573
+  metadata.gz: c422e70b25fb0d3623d7b93e15695d30efae525f
+  data.tar.gz: 8624d34d7925435b19f9bb9b5a6961b2fd61894b
 SHA512:
-  metadata.gz: 821c2b8b1f0efce58896face9f9d45ca0b1b3c1e4b9a2bc73ae6d49efbfef0c50ea0f8686ab37a31a886f76e9e3707652aa46ed777ce661777400e8fc1c31c51
-  data.tar.gz: adedf790e67684c29fb72946c7e7c84a4aa77482bf88f99b80186c08e006ac7262334b3b79dec31e72e3ecfa6d9c999578a16906d7e4b2bb8ff28cd9e1728d91
+  metadata.gz: 6cf171f0b406a442f15596b4ad0d681c5bafc7d75055d4024a2ce5a1577756ee938aaafc292f51fc5af532f8028692cdba416788ea96c25c801536bf448b6239
+  data.tar.gz: 35b775075e73d08eb83a3c3a12ae89a9d6b022ac49ca6ac9b50d5344a554a4f47eaa8aa73d3db97e6607d41b41040b478b859bd62d5b5bf0b6da06b45493c036

data/.travis.yml

@@ -1,5 +1,7 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.4.1
+  - 2.4.3
+  - 2.5.0
+
 before_install: gem install bundler -v 1.16.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    codestatus (0.1.1)
+    codestatus (0.1.2)
       gems
       octokit
       rest-client

data/README.md

@@ -20,6 +20,8 @@ $ codestatus status npm/react
 success
 $ codestatus status --registry=npm react
 success
+$ codestatus status npm/@atlassian/aui
+success
 ```
 
 ```ruby

data/lib/codestatus.rb

@@ -1,23 +1,31 @@
 require "codestatus/version"
 require "codestatus/build_status"
 require "codestatus/cli"
-require "codestatus/repository_resolver"
-require "codestatus/repository_resolver/user_defined_resolver"
-require "codestatus/repository_resolver/rubygems_resolver"
-require "codestatus/repository_resolver/npm_resolver"
-require "codestatus/package_repository"
-require "codestatus/package_repository/github_repository"
+require "codestatus/package_resolvers/base"
+require "codestatus/package_resolvers/rubygems_resolver"
+require "codestatus/package_resolvers/npm_resolver"
+require "codestatus/repositories/github_repository"
+require "codestatus/repositories/bitbucket_repository"
 
 module Codestatus
-  def self.status(registry:, package:)
-    resolver = RepositoryResolver.new(registry: registry, package: package)
-
-    package_repository = resolver.repository
+  def self.status(repository: nil, registry: nil, package: nil)
+    if !repository && registry && package
+      repository = resolver(registry).resolve(package: package)
+    end
 
-    if package_repository
-      package_repository.status
+    if repository
+      repository.status
     else
       BuildStatus.new(sha: nil, status: nil)
     end
   end
+
+  def self.resolver(registry)
+    case registry
+    when /rubygems/
+      PackageResolvers::RubygemsResolver
+    when /npm/
+      PackageResolvers::NpmResolver
+    end
+  end
 end

data/lib/codestatus/build_status.rb

@@ -8,6 +8,12 @@ module Codestatus
     PENDING = 'pending'.freeze
     SUCCESS = 'success'.freeze
 
+    # Statuses defined in Bitbucket are mapped into GitHub's status
+    #   STOPPED    => ERROR
+    #   FAILED     => FAILURE
+    #   INPROGRESS => PENDING
+    #   SUCCESSFUL => SUCCESS
+
     STATUSES = [
       ERROR,
       FAILURE,

data/lib/codestatus/cli.rb

@@ -10,7 +10,7 @@ module Codestatus
         package_registry = options[:registry]
         package_name = slug
       else
-        package_registry, package_name = slug.split('/')
+        package_registry, package_name = slug.split('/', 2)
       end
 
       status = Codestatus.status(registry: package_registry, package: package_name)

data/lib/codestatus/package_resolvers/base.rb

@@ -0,0 +1,50 @@
+module Codestatus
+  module PackageResolvers
+    class Base
+      GITHUB_REPOSITORY_REGEXP = %r{(https?|git)://github.com/(?<owner>[^/]*)/(?<repo>[^/]*)(\.git)?/?.*}.freeze
+      BITBUCKET_REPOSITORY_REGEXP = %r{(https?|git)://bitbucket.org/(?<owner>[^/]*)/(?<repo>[^/]*)(\.git)?/?.*}.freeze
+
+      def self.resolve(package:)
+        self.new(package: package).resolve
+      end
+
+      def initialize(package:)
+        @package = package
+      end
+
+      attr_reader :package
+
+      def resolve
+        @package = package
+
+        github_repository || bitbucket_repository
+      end
+
+      private
+
+      def github_repository
+        urls.map { |url|
+          matched = GITHUB_REPOSITORY_REGEXP.match(url)
+          next unless matched
+
+          repo = [matched[:owner], matched[:repo]].join('/')
+          Repositories::GitHubRepository.new(repo)
+        }.compact.first
+      end
+
+      def bitbucket_repository
+        urls.map { |url|
+          matched = BITBUCKET_REPOSITORY_REGEXP.match(url)
+          next unless matched
+
+          repo = [matched[:owner], matched[:repo]].join('/')
+          Repositories::BitbucketRepository.new(repo)
+        }.compact.first
+      end
+
+      def urls
+        raise NotImplementedError
+      end
+    end
+  end
+end

data/lib/codestatus/package_resolvers/npm_resolver.rb

@@ -0,0 +1,51 @@
+require 'rest-client'
+
+module Codestatus
+  module PackageResolvers
+    class NpmResolver < Base
+      NPM_REGISTRY_ENDPOINT = 'https://registry.npmjs.org/'.freeze
+
+      private
+
+      def urls
+        [
+          bugs_url,
+          repository_url,
+          homepage_url,
+        ].compact
+      end
+
+      def bugs_url
+        package_info.dig('bugs', 'url')
+      end
+
+      def homepage_url
+        package_info.dig('homepage')
+      end
+
+      def repository_url
+        package_info.dig('repository', 'url')
+      end
+
+      def package_info
+        @package_info ||= JSON.parse(client.get(package_uri))
+      end
+
+      def client
+        RestClient
+      end
+
+      def package_uri
+        File.join(NPM_REGISTRY_ENDPOINT, slash_escaped_package)
+      end
+
+      # for scoped package
+      #   For example, to access @atlassian/aui information,
+      #   we must use https://registry.npmjs.org/@atlassian%2Faui,
+      #   not https://registry.npmjs.org/%40atlassian%2Faui.
+      def slash_escaped_package
+        package.gsub('/', CGI.escape('/'))
+      end
+    end
+  end
+end

data/lib/codestatus/package_resolvers/rubygems_resolver.rb

@@ -0,0 +1,33 @@
+require "gems"
+
+module Codestatus
+  module PackageResolvers
+    class RubygemsResolver < Base
+      private
+
+      def urls
+        [
+          source_code_uri,
+          homepage_uri,
+          bug_tracker_uri,
+        ].compact
+      end
+
+      def homepage_uri
+        gem_info['homepage_uri']
+      end
+
+      def source_code_uri
+        gem_info['source_code_uri']
+      end
+
+      def bug_tracker_uri
+        gem_info['bug_tracker_uri']
+      end
+
+      def gem_info
+        @info ||= Gems.info(package)
+      end
+    end
+  end
+end

data/lib/codestatus/repositories/bitbucket_repository.rb

@@ -0,0 +1,64 @@
+require 'rest-client'
+
+module Codestatus
+  module Repositories
+    class BitbucketRepository
+      BITBUCKET_API_ENDPOINT = 'https://api.bitbucket.org/2.0/' #repositories/atlassian/aui
+      def initialize(slug)
+        # 'atlassian/aui'
+        @slug = slug
+      end
+
+      # This combined status is generated by the rule of GitHub's
+      #   https://developer.github.com/v3/repos/statuses/#get-the-combined-status-for-a-specific-ref
+      def status(ref = main_branch)
+        statuses = statuses(ref)
+
+        sha = statuses['values'].map {|x| x.dig('commit', 'hash') }.compact.first
+        states = statuses['values'].map { |status| status['state'] }
+
+        state = if states.any? { |x| ['STOPPED', 'FAILED'].include?(x) }
+                  BuildStatus::FAILURE
+                elsif states.empty? || states.all? { |x| x == 'INPROGRESS' }
+                  BuildStatus::PENDING
+                elsif states.all? { |x| x == 'SUCCESSFUL' }
+                  BuildStatus::SUCCESS
+                else
+                  BuildStatus::UNDEFINED
+                end
+
+        BuildStatus.new(sha: sha, status: state)
+      end
+
+      attr_reader :slug
+
+      private
+
+      def main_branch
+        repository.dig('mainbranch', 'name')
+      end
+
+      def repository
+        @repository ||= JSON.parse(client.get(repository_uri))
+      end
+
+      def repository_uri
+        File.join(BITBUCKET_API_ENDPOINT, 'repositories', slug)
+      end
+
+      def client
+        RestClient
+      end
+
+      # https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/%7Busername%7D/%7Brepo_slug%7D/commit/%7Bnode%7D/statuses
+      #   example: https://api.bitbucket.org/2.0/repositories/atlassian/aui/commit/master/statuses
+      def statuses(ref)
+        @statuses ||= JSON.parse(client.get(statuses_uri(ref)))
+      end
+
+      def statuses_uri(ref)
+        File.join(BITBUCKET_API_ENDPOINT, 'repositories', slug, 'commit', ref, 'statuses')
+      end
+    end
+  end
+end

data/lib/codestatus/{package_repository → repositories}/github_repository.rb

@@ -1,27 +1,23 @@
 require "octokit"
 
 module Codestatus
-  class PackageRepository
+  module Repositories
     class GitHubRepository
       def initialize(slug)
         # 'influitive/apartment'
         @repo = slug
       end
 
-      def status
-        status_of_default_branch
-      end
-
-      private
-
       # combined status on github
       # https://developer.github.com/v3/repos/statuses/#get-the-combined-status-for-a-specific-ref
-      def status_of_default_branch
-        response = client.combined_status(@repo, default_branch)
+      def status(ref = default_branch)
+        response = client.combined_status(@repo, ref)
 
         BuildStatus.new(sha: response.sha, status: response.state)
       end
 
+      private
+
       def default_branch
         repository['default_branch']
       end

data/lib/codestatus/version.rb

@@ -1,3 +1,3 @@
 module Codestatus
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codestatus
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - meganemura
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-01 00:00:00.000000000 Z
+date: 2018-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit
@@ -159,12 +159,11 @@ files:
 - lib/codestatus.rb
 - lib/codestatus/build_status.rb
 - lib/codestatus/cli.rb
-- lib/codestatus/package_repository.rb
-- lib/codestatus/package_repository/github_repository.rb
-- lib/codestatus/repository_resolver.rb
-- lib/codestatus/repository_resolver/npm_resolver.rb
-- lib/codestatus/repository_resolver/rubygems_resolver.rb
-- lib/codestatus/repository_resolver/user_defined_resolver.rb
+- lib/codestatus/package_resolvers/base.rb
+- lib/codestatus/package_resolvers/npm_resolver.rb
+- lib/codestatus/package_resolvers/rubygems_resolver.rb
+- lib/codestatus/repositories/bitbucket_repository.rb
+- lib/codestatus/repositories/github_repository.rb
 - lib/codestatus/version.rb
 homepage: https://github.com/meganemura/codestatus
 licenses:

data/lib/codestatus/package_repository.rb

@@ -1,16 +0,0 @@
-module Codestatus
-  class PackageRepository
-    def initialize(github: nil)
-      @github = GitHubRepository.new(github) if github
-      # bitbucket, gitlab, ...
-    end
-
-    attr_reader :github
-
-    def status
-      if github
-        github.status # default branch's commit's status
-      end
-    end
-  end
-end

data/lib/codestatus/repository_resolver.rb

@@ -1,37 +0,0 @@
-module Codestatus
-  class RepositoryResolver
-    def initialize(registry:, package:)
-      @registry = registry
-      @package = package
-    end
-
-    attr_reader :registry, :package
-
-    def repository
-      @repository ||= resolve
-    end
-
-    private
-
-    def resolve
-      result = nil
-      resolvers.each do |resolver|
-        result = resolver.resolve(registry: registry, package: package)
-        break if result
-      end
-      result
-    end
-
-    def resolvers
-      @resolvers ||= resolver_classes.map(&:new)
-    end
-
-    def resolver_classes
-      @resolver_classes ||= [
-        RepositoryResolver::RubygemsResolver,
-        RepositoryResolver::NpmResolver,
-        RepositoryResolver::UserDefinedResolver,
-      ]
-    end
-  end
-end

data/lib/codestatus/repository_resolver/npm_resolver.rb

@@ -1,63 +0,0 @@
-require 'rest-client'
-
-module Codestatus
-  class RepositoryResolver
-    class NpmResolver
-      GITHUB_REPOSITORY_REGEXP = %r{(https|git)://github.com/(?<owner>[^/]*)/(?<repo>[^/]*)(\.git)?/?.*}.freeze
-      NPM_REGISTRY_ENDPOINT = 'https://registry.npmjs.org/'.freeze
-
-      def resolve(registry:, package:)
-        return unless registry.to_s == 'npm'
-        @package = package
-
-        github_repository
-      end
-
-      attr_reader :package
-
-      private
-
-      # FIXME: Copied from RubygemsResolver
-      def github_repository
-        result = nil
-        urls.each do |url|
-          matched = GITHUB_REPOSITORY_REGEXP.match(url)
-          next unless matched
-
-          repo = [matched[:owner], matched[:repo]].join('/')
-          result = Codestatus::PackageRepository.new(github: repo)
-          break
-        end
-        result
-      end
-
-      def package_info
-        @package_info ||= JSON.parse(client.get("#{NPM_REGISTRY_ENDPOINT}/#{package}"))
-      end
-
-      def urls
-        [
-          bugs_url,
-          repository_url,
-          homepage_url,
-        ].compact
-      end
-
-      def bugs_url
-        package_info.dig('bugs', 'url')
-      end
-
-      def homepage_url
-        package_info.dig('homepage')
-      end
-
-      def repository_url
-        package_info.dig('repository', 'url')
-      end
-
-      def client
-        RestClient
-      end
-    end
-  end
-end

data/lib/codestatus/repository_resolver/rubygems_resolver.rb

@@ -1,57 +0,0 @@
-require "gems"
-
-module Codestatus
-  class RepositoryResolver
-    class RubygemsResolver
-      GITHUB_REPOSITORY_REGEXP = %r{(https|git)://github.com/(?<owner>[^/]*)/(?<repo>[^/]*)(\.git)?/?.*}.freeze
-
-      def resolve(registry:, package:)
-        return unless registry.to_s == 'rubygems'
-        @package = package
-
-        github_repository
-      end
-
-      attr_reader :package
-
-      private
-
-      def github_repository
-        result = nil
-        urls.each do |url|
-          matched = GITHUB_REPOSITORY_REGEXP.match(url)
-          next unless matched
-
-          repo = [matched[:owner], matched[:repo]].join('/')
-          result = Codestatus::PackageRepository.new(github: repo)
-          break
-        end
-        result
-      end
-
-      def gem_info
-        @info ||= Gems.info(package)
-      end
-
-      def urls
-        [
-          source_code_uri,
-          homepage_uri,
-          bug_tracker_uri,
-        ].compact
-      end
-
-      def homepage_uri
-        gem_info['homepage_uri']
-      end
-
-      def source_code_uri
-        gem_info['source_code_uri']
-      end
-
-      def bug_tracker_uri
-        gem_info['bug_tracker_uri']
-      end
-    end
-  end
-end

data/lib/codestatus/repository_resolver/user_defined_resolver.rb

@@ -1,18 +0,0 @@
-module Codestatus
-  class RepositoryResolver
-    class UserDefinedResolver
-      def self.definitions
-        @definitions ||= {
-          'rubygems/apartment': Codestatus::PackageRepository.new(github: 'influitive/apartment'),
-          'rubygems/octokit': Codestatus::PackageRepository.new(github: 'octokit/octokit.rb'),
-        }
-      end
-
-      def resolve(registry:, package:)
-        key = [registry, package].join('/')
-
-        self.class.definitions[key.to_sym]
-      end
-    end
-  end
-end