coder_wally 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 09158bbcb126bc9fbb9fcfd4eaff98d646017548
-  data.tar.gz: 7dc0e8d397038d0f315263dcd530a7ace464775d
+  metadata.gz: 1ce08332a669f0fab248e145033366fab6f89a89
+  data.tar.gz: b4cc4a66611195652695244724152dfddbfc45c8
 SHA512:
-  metadata.gz: e0b7f1da6275413792bd7d23d20d430c803d191ce6643b0d00eba7c7b03ba72e06bef77a546bf06be64be0582591f1209c0eae552bd344c348cfe48eb4244e22
-  data.tar.gz: cf18c3a4a70e483dabb092eca36a8f5ba7005fb633db642ffd139d81c5579f5fa662044a7225d27b484cc5c98962d8bb7f91fa9442bb19390f70ce65abe4c7c0
+  metadata.gz: 6837d0ad987b1689ec808bdea5f1a076b633d253bc72246d87fe5ef51dcdcb27ab49b174c71adc00b247c61dda9ab55dc1c12b6430758c512faa677c70527882
+  data.tar.gz: c17ddb445161f3c4bce8b491a6f8ea7e9d46ddd1a6038ca37da31bcf5c13cb406c85239b5af35945305f0e8afd1237f43190cc68bcc9d292ba5a528e9e0ff2f6

data/README.md

@@ -1,12 +1,13 @@
 # CoderWally 
 
-[![Build Status](https://circleci.com/gh/gregstewart/coder_wally.svg?style=badge)](https://circleci.com/gh/gregstewart/coder_wally)
+[![Build Status](https://circleci.com/gh/gregstewart/coder_wally.svg?style=badge)](https://circleci.com/gh/gregstewart/coder_wally) 
 
 [![Gem Version](https://badge.fury.io/rb/coder_wally.svg)](http://badge.fury.io/rb/coder_wally)
 [![Coverage Status](https://coveralls.io/repos/gregstewart/coder_wally/badge.svg)](https://coveralls.io/r/gregstewart/coder_wally)
 [![Code Climate](https://codeclimate.com/github/gregstewart/coder_wally/badges/gpa.svg)](https://codeclimate.com/github/gregstewart/coder_wally)
 [![Dependency Status](https://gemnasium.com/gregstewart/coder_wally.svg)](https://gemnasium.com/gregstewart/coder_wally)
 [![Inline docs](https://inch-ci.org/github/gregstewart/coder_wally.svg?branch=master)](https://inch-ci.org/github/gregstewart/coder_wally)
+[![coder_wally API Documentation](https://www.omniref.com/ruby/gems/coder_wally.png)](https://www.omniref.com/ruby/gems/coder_wally)
 
 A very very simple Gem to fetch user badges from Coder Wall
 

data/coder_wally.gemspec

@@ -4,23 +4,23 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'coder_wally/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "coder_wally"
+  spec.name          = 'coder_wally'
   spec.version       = CoderWally::VERSION
-  spec.authors       = ["Greg Stewart"]
-  spec.email         = ["gregs@tcias.co.uk"]
+  spec.authors       = ['Greg Stewart']
+  spec.email         = ['gregs@tcias.co.uk']
   spec.summary       = %q{A simple gem to fetch user badges from Coder Wall}
   spec.description   = %q{A simple gem to fetch user badges from Coder Wall}
-  spec.homepage      = "https://github.com/gregstewart/coder_wally"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/gregstewart/coder_wally'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "webmock", "~>1.20.4"
-  spec.add_development_dependency "coveralls"
-  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'webmock', '~>1.20.4'
+  spec.add_development_dependency 'coveralls', '~>0.7.9'
+  spec.add_development_dependency 'rubocop', '~>0.29.0'
 end

data/lib/coder_wally/account.rb

@@ -5,9 +5,17 @@ module CoderWally
     # Dynamically create account properties
     def initialize(collection_of_accounts)
       collection_of_accounts.each do |account, value|
-        singleton_class.class_eval { attr_accessor "#{account}" }
-        instance_variable_set("@#{account}", value)
+        create_accessor account
+        set_accessor_value account, value
       end
     end
+    # create the attribute accessor
+    def create_accessor(name)
+      singleton_class.class_eval { attr_accessor "#{name}" }
+    end
+    # assign the value to the accessor
+    def set_accessor_value(name, value)
+      instance_variable_set("@#{name}", value)
+    end
   end
 end

data/lib/coder_wally/api.rb

@@ -4,15 +4,22 @@ require 'json'
 module CoderWally
   # API Class
   class API
+    attr_reader :response
+    def initialize
+      @response = {}
+    end
+
     # Fetch data from CoderWall
     def fetch(username)
-      uri = uri_for_user(username)
-      json = send_request(uri)
-
-      begin
-        JSON.parse(json.read)
-      rescue JSON::ParserError
-        raise InvalidJson, 'Received invalid json in response'
+      @response.fetch(username) do
+        uri = uri_for_user(username)
+        json = send_request(uri)
+
+        begin
+          @response[username] = JSON.parse(json.read)
+        rescue JSON::ParserError
+          raise InvalidJson, 'Received invalid json in response'
+        end
       end
     end
 
@@ -22,23 +29,7 @@ module CoderWally
     def send_request(url)
       open(url)
     rescue OpenURI::HTTPError => error
-      handle_user_not_found_error(error)
-      handle_server_error(error)
-    end
-
-    # Parse status code from error
-    def get_status_code(error)
-      error.io.status[0]
-    end
-
-    # Raise server error
-    def handle_server_error(error)
-      fail ServerError, 'Server error' if get_status_code(error) == '500'
-    end
-
-    # Raise user not found error
-    def handle_user_not_found_error(error)
-      fail UserNotFoundError, 'User not found' if get_status_code(error) == '404'
+      ExceptionHandler.new(error)
     end
 
     # Build user URI from username and api url
@@ -55,13 +46,6 @@ module CoderWally
   end
 end
 
-# Handles user not found exception
-class UserNotFoundError < StandardError
-end
-
-# Handles server exception
-class ServerError < StandardError
-end
 # Handles bad JSON
 class InvalidJson < StandardError
 end

data/lib/coder_wally/builder.rb

@@ -6,25 +6,29 @@ module CoderWally
     end
 
     # parse badges from data
-    def parse_badges(data)
-      data['badges'].map { |badge| Badge.new(badge) } if data['badges']
+    def parse_badges(badges)
+      badges.map { |badge| create_new_badge(badge) } if badges
+    end
+
+    # create a new badge object
+    def create_new_badge(badge)
+      Badge.new(badge)
     end
 
     # parse account information from data
-    def parse_accounts(data)
-      Account.new(data['accounts']) if data['accounts']
+    def parse_accounts(accounts)
+      Account.new(accounts) if accounts
     end
 
     # parse user information from data
     def parse_user(data)
-      User.new(data['name'], data['username'],
-               data['location'], data['team'], data['endorsements'])
+      User.new(data)
     end
 
     # build CoderWall object from API response
     def build(response)
-      badges = parse_badges(response)
-      accounts = parse_accounts(response)
+      badges = parse_badges(response['badges'])
+      accounts = parse_accounts(response['accounts'])
       user = parse_user(response)
 
       CoderWall.new badges, user, accounts

data/lib/coder_wally/exception_handler.rb

@@ -0,0 +1,18 @@
+module CoderWally
+  # Raises errors from the service request
+  class ExceptionHandler
+    # Initialize with the error object
+    def initialize(error)
+      status_code = StatusCodeFromError.new(error).status_code
+      fail ServerError, 'Server error' if status_code == '500'
+      fail UserNotFoundError, 'User not found' if status_code == '404'
+    end
+  end
+end
+# Handles user not found exception
+class UserNotFoundError < StandardError
+end
+
+# Handles server exception
+class ServerError < StandardError
+end

data/lib/coder_wally/status_code_from_error.rb

@@ -0,0 +1,30 @@
+# All code in the gem is namespaced under this module.
+module CoderWally
+  # return status code from error object
+  class StatusCodeFromError
+    # Initialise object
+    def initialize(error)
+      @error = error
+    end
+
+    # Get the status code
+    def status_code
+      @error.io.status[0] if error? && io? && status_code?
+    end
+
+    # Is there an error object?
+    def error?
+      true if @error
+    end
+
+    # Is there an io object?
+    def io?
+      true if @error.io
+    end
+
+    # Is there a status?
+    def status_code?
+      true if @error.io.status
+    end
+  end
+end

data/lib/coder_wally/user.rb

@@ -6,12 +6,12 @@ module CoderWally
     attr_reader :name, :username, :location, :team, :endorsements
 
     # Initialise object with a hash of values
-    def initialize(name, username, location, team, endorsements)
-      @name = name
-      @username = username
-      @location = location
-      @team = team
-      @endorsements = endorsements
+    def initialize(data)
+      @name = data['name']
+      @username = data['username']
+      @location = data['location']
+      @team = data['team']
+      @endorsements = data['endorsements']
     end
   end
 end

data/lib/coder_wally/version.rb

@@ -1,5 +1,5 @@
 # All code in the gem is namespaced under this module.
 module CoderWally
   # The current version of CoderWally.
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/lib/coder_wally.rb

@@ -4,5 +4,7 @@ require 'coder_wally/user'
 require 'coder_wally/account'
 require 'coder_wally/coder_wall'
 require 'coder_wally/api'
+require 'coder_wally/status_code_from_error'
+require 'coder_wally/exception_handler'
 require 'coder_wally/builder'
 require 'coder_wally/client'

data/test/api_test.rb

@@ -0,0 +1,38 @@
+require 'minitest/autorun'
+require 'coder_wally/api'
+
+describe 'api' do
+  describe 'memoize result' do
+    before do
+      @accept_encoding = 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3'
+      @success_fixture = File.dirname(__FILE__) + '/./fixtures/200.json'
+      @success_response = open(File.expand_path(@success_fixture)).read
+
+      stub_request(:get, 'https://coderwall.com/me.json')
+      .with(headers: { 'Accept' => '*/*',
+                       'Accept-Encoding' => @accept_encoding,
+                       'User-Agent' => 'Ruby' })
+      .to_return(status: 200, body:  @success_response, headers: {})
+    end
+
+    it 'calls the send_request method only the first time for any given username' do
+      api = CoderWally::API.new
+
+      api.fetch('me')
+      api.fetch('me')
+
+      api.response.count.must_equal 1
+
+      stub_request(:get, 'https://coderwall.com/foo.json')
+      .with(headers: { 'Accept' => '*/*',
+                       'Accept-Encoding' => @accept_encoding,
+                       'User-Agent' => 'Ruby' })
+      .to_return(status: 200, body:  @success_response, headers: {})
+
+      api.fetch('foo')
+      api.response.count.must_equal 2
+    end
+
+
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coder_wally
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Greg Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-06 00:00:00.000000000 Z
+date: 2015-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -56,30 +56,30 @@ dependencies:
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.7.9
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.7.9
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.29.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.29.0
 description: A simple gem to fetch user badges from Coder Wall
 email:
 - gregs@tcias.co.uk
@@ -108,9 +108,12 @@ files:
 - lib/coder_wally/builder.rb
 - lib/coder_wally/client.rb
 - lib/coder_wally/coder_wall.rb
+- lib/coder_wally/exception_handler.rb
+- lib/coder_wally/status_code_from_error.rb
 - lib/coder_wally/user.rb
 - lib/coder_wally/version.rb
 - test/account_test.rb
+- test/api_test.rb
 - test/coder_wally_test.rb
 - test/fixtures/200.json
 - test/fixtures/404.json
@@ -143,6 +146,7 @@ specification_version: 4
 summary: A simple gem to fetch user badges from Coder Wall
 test_files:
 - test/account_test.rb
+- test/api_test.rb
 - test/coder_wally_test.rb
 - test/fixtures/200.json
 - test/fixtures/404.json