coder_wally 0.0.7 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: defc173143b93f0b93406ef1fbde0900e59cdd76
-  data.tar.gz: ee23f5c2797c6b113101b36eb5d5bcfa5be40186
+  metadata.gz: ec3f117479a41d224184d23682f03c5756e9c312
+  data.tar.gz: b3902c02004878ad333b805bbbdae7022f3e451f
 SHA512:
-  metadata.gz: 2152878afffe135df1d5c128098ff2237a8b261d86884d443f01304986742d9f5fba42272b28db9bc9d77770dfb996b2ffbefa5c604d82c44ff33d75f1de6ec9
-  data.tar.gz: 9a683a6c26b92ed98881dd96f3193fd2c843d5bf205909a4d83a2659a6a9ad1c80e07bbca9c3ced983b6bd2fe4bce68674a57ccac9b7dcb786e10d2163bc8a46
+  metadata.gz: 24434fbdf0747f6b3ccb0173ded350e5b41649604f8d01ccf320da0c6112f9cf770328a1cce5e00c8928db4874eb61be64757e8e1d7edeaa75e1f8b62840a0fa
+  data.tar.gz: 65372cdbe3b2eb38bea2500af500253ee1a643beda3547c050882776fcf84d30f5400d4348765eea5bfec44e74c958088af5697059d9f6a2a2c74c29aee59b72

data/lib/coder_wally.rb

@@ -3,5 +3,7 @@ require 'coder_wally/badge'
 require 'coder_wally/user'
 require 'coder_wally/account'
 require 'coder_wally/coder_wall'
+require 'coder_wally/api'
+require 'coder_wally/builder'
 require 'coder_wally/client'
 

data/lib/coder_wally/api.rb

@@ -0,0 +1,67 @@
+require 'open-uri'
+require 'json'
+
+module CoderWally
+  # API Class
+  class API
+    # Fetch data from CoderWall
+    def fetch(username)
+      uri = uri_for_user(username)
+      json = send_request(uri)
+
+      begin
+        JSON.parse(json.read)
+      rescue JSON::ParserError => error
+        raise InvalidJson, 'Received invalid json in response'
+      end
+    end
+
+    private
+      # Dispatch the request
+      def send_request(url)
+        begin
+          open(url)
+        rescue OpenURI::HTTPError => error
+          handle_user_not_found_error(error)
+          handle_server_error(error)
+        end
+      end
+
+      # Parse status code from error
+      def get_status_code(error)
+        error.io.status[0]
+      end
+
+      # Raise server error
+      def handle_server_error(error)
+        raise ServerError, 'Server error' if  get_status_code(error) == '500'
+      end
+
+      # Raise user not found error
+      def handle_user_not_found_error(error)
+        raise UserNotFoundError, 'User not found' if  get_status_code(error) == '404'
+      end
+
+      # Build user URI from username and api url
+      def uri_for_user(username)
+        raise(ArgumentError, 'Please provide a username') if username.empty?
+
+        URI.parse(api_url % username)
+      end
+
+      # The URL of the API we'll use.
+      def api_url
+        'https://coderwall.com/%s.json'
+      end
+  end
+end
+# Handles user not found exception
+class UserNotFoundError < StandardError
+end
+
+# Handles server exception
+class ServerError < StandardError
+end
+# Handles bad JSON
+class InvalidJson < StandardError
+end

data/lib/coder_wally/builder.rb

@@ -0,0 +1,33 @@
+module CoderWally
+  # Builds the CoderWall object from the response
+  class Builder
+    # Instantiate class
+    def initialize
+    end
+
+    # parse badges from data
+    def parse_badges(data)
+      data['badges'].map { |badge| Badge.new(badge) } if data['badges']
+    end
+
+    # parse account information from data
+    def parse_accounts(data)
+      Account.new(data['accounts']) if data['accounts']
+    end
+
+    # parse user information from data
+    def parse_user(data)
+      User.new(data['name'], data['username'],
+               data['location'], data['team'], data['endorsements'])
+    end
+
+    # build CoderWall object from API response
+    def build response
+      badges = parse_badges(response)
+      accounts = parse_accounts(response)
+      user = parse_user(response)
+
+      CoderWall.new badges, user, accounts
+    end
+  end
+end

data/lib/coder_wally/client.rb

@@ -1,66 +1,34 @@
-require 'open-uri'
-require 'json'
-
 module CoderWally
     # Client to access the API
     class Client
-         # The URL of the API we'll use.
-        def api_url
-          'https://coderwall.com/%s.json'
-        end
-
-        # Build user URI from username and apii url
-        def uri_for_user username
-          raise(ArgumentError, 'Please provide a username') if username.empty?
-          
-          URI.parse(api_url % username)
-        end
-
-        # Dispatch the request
-        def send_request url
-          begin
-            open(url)
-          rescue OpenURI::HTTPError => error
-            raise UserNotFoundError, 'User not found' if  error.io.status[0] == '404'
-            raise ServerError, 'Server error' if  error.io.status[0] == '500'
-          end
+        # Instantiate class
+        def initialize
+          @api = API.new
+          @builder = Builder.new
         end
 
         # Get badges for given user and return has collection of `Badge`s
         def get_badges_for username
-          coder_wall = build_coder_wall(username)
+          coder_wall = build_coder_wall_from_response(username)
           coder_wall.badges
         end
         
         # Get user details for given user and return a `User` object
         def get_details_for username
-          coder_wall = build_coder_wall(username)
+          coder_wall = build_coder_wall_from_response(username)
           coder_wall.user
         end
 
         # Get all the information available for a given user, returns a `CoderWall` object
         def get_everything_for username
-          build_coder_wall(username)
+          build_coder_wall_from_response(username)
         end
 
         # Builds a CoderWall object
-        def build_coder_wall(username)
-          json_response = JSON.load(send_request(uri_for_user(username)))
+        def build_coder_wall_from_response(username)
+          json_response = @api.fetch(username)
 
-          badges = json_response['badges'].map { |badge| Badge.new(badge) }
-          accounts = Account.new(json_response['accounts'])
-          user = User.new(json_response['name'], json_response['username'],
-                   json_response['location'], json_response['team'], json_response['endorsements'])
-
-          CoderWall.new badges, user, accounts
+          @builder.build(json_response)
         end
     end
 end
-
-# Handles user not found exception
-class UserNotFoundError < StandardError
-end
-
-# Handles server exception
-class ServerError < StandardError
-end

data/lib/coder_wally/version.rb

@@ -1,4 +1,4 @@
 module CoderWally
   # The current version of CoderWally.
-  VERSION = '0.0.7'
+  VERSION = '0.1.0'
 end

data/test/coder_wally_test.rb

@@ -6,10 +6,6 @@ describe 'Coder Wally' do
     @client = CoderWally::Client.new
   end
 
-  it 'has a default api url' do
-    'https://coderwall.com/%s.json'.must_equal @client.api_url
-  end
-
   describe 'user badges' do
     describe 'valid user' do
       before do
@@ -64,11 +60,25 @@ describe 'Coder Wally' do
           to_return(:status => 500, :body => server_error, :headers => {})
       end
 
-      it 'throws a ServerError when the user is not found' do
+      it 'throws a ServerError when the server response is 500' do
         err = -> { @client.get_badges_for('me') }.must_raise ServerError
         err.message.must_match /Server error/
       end
     end
+
+    describe 'bad data' do
+      before do
+        bad_data = open(File.expand_path(File.dirname(__FILE__) + '/./fixtures/bad.json')).read
+        stub_request(:get, 'https://coderwall.com/me.json').
+          with(:headers => {'Accept' => '*/*', 'Accept-Encoding' => 'gzip;q=1.0,deflate;q=0.6,identity;q=0.3', 'User-Agent' => 'Ruby'}).
+          to_return(:status => 200, :body => bad_data, :headers => {})
+      end
+
+      it 'throws a InvalidJson exception when bad JSON is returned' do
+        err = -> { @client.get_badges_for('me') }.must_raise InvalidJson
+        err.message.must_match /invalid json/
+      end
+    end
   end
 
   describe 'user details' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: coder_wally
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.1.0
 platform: ruby
 authors:
 - Greg Stewart
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-02 00:00:00.000000000 Z
+date: 2015-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -86,7 +86,9 @@ files:
 - coder_wally.gemspec
 - lib/coder_wally.rb
 - lib/coder_wally/account.rb
+- lib/coder_wally/api.rb
 - lib/coder_wally/badge.rb
+- lib/coder_wally/builder.rb
 - lib/coder_wally/client.rb
 - lib/coder_wally/coder_wall.rb
 - lib/coder_wally/user.rb