codenamev-baseball-stats 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c417a1b413d90176dc6f70512e1ade4e5960fae3
-  data.tar.gz: 6720d67cd34ab5e2809ae2774557136c97b31f5a
+  metadata.gz: 45ebe0e703bd7bf9dee0b2ab32303330025a34ff
+  data.tar.gz: 1b7a93155365db0f0bc41510bacb6913710a8e05
 SHA512:
-  metadata.gz: 65e7b299497cf8aafa69c17e010a490cd5cb97ad89ffb39d4b05437d7dede1c775afa49d527c8552850e1e5c3300e124425ecde0d4e3e6992a196311d23c3670
-  data.tar.gz: 5feca95cba15116f0184d3b9aac2f5ba221795f78f3962f96db25f0c7b0a57aafc098ebd04c95193c50f7e84553f2d59100467a1721dc05661f129ffcb7d4c5c
+  metadata.gz: f87502b0a692b26c2ee7512bac41d05a357a9919d23ae49058eede0bdf933c1c401682e89645db055534de12dfa42eb105b976aa9b5b04c1844061b8b3e7da93
+  data.tar.gz: 1785c72149a5cbc4e925a047de3a5f14888389d79879fe59a96852e693329dc5fed107333fad50002b730ef6b164abb32a23d65516658dfc852dc395fe20386d

data/.gitignore

@@ -3,7 +3,6 @@
 *.gem
 *.rbc
 .bundle
-.config
 .yardoc
 Gemfile.lock
 InstalledFiles

data/lib/baseball_stats.rb

@@ -35,9 +35,9 @@ module BaseballStats
   end
 
   def slugging_percentage_for_team_and_year(team_id, year)
-    battings_for_team = Batting.includes(:player).with_slugging_percentage.where(team_id: team_id, year_id: year)
+    battings_for_team = Batting.includes(:player).with_slugging_percentage.where(team_id: team_id, year_id: year).order('slugging_percentage DESC')
     battings_for_team.collect {|batting|
-      { player: batting.player_name, slugging_percentage: "#{(batting.slugging_percentage.to_f * 100).round(2)}%" }
+      { player: batting.player_name, slugging_percentage: "#{batting.slugging_percentage.to_f.round(3)}" }
     }
   end
 

data/lib/baseball_stats/database.rb

@@ -15,7 +15,7 @@ module BaseballStats
     @connection       = nil
     @root_path        = File.expand_path('../../..', __FILE__).freeze
     @db_dir           = File.join(@root_path, 'db').freeze
-    @configuration    = YAML::load(IO.read("#{@db_dir}/config.yml")).freeze
+    @configuration    = YAML::load(IO.read(File.join(@db_dir, 'config.yml'))).freeze
     @migrations_paths = [File.join(@root_path, 'db/migrate')].freeze
 
     attr_accessor :configuration, :db_dir, :migrations_paths

data/lib/baseball_stats/import.rb

@@ -14,14 +14,20 @@ module BaseballStats::Import
   SEED_PLAYERS_CSV  = File.expand_path('../../../sample_data/players.csv', __FILE__)
 
   def seed_data
-    import_battings_from_csv(SEED_BATTINGS_CSV)
     import_players_from_csv(SEED_PLAYERS_CSV)
+    import_battings_from_csv(SEED_BATTINGS_CSV)
   end
 
   def import_battings_from_csv(csv_file)
     CreateBattings.up unless ActiveRecord::Base.connection.table_exists?('battings')
     CSV.foreach(csv_file, headers: true, header_converters: :symbol) do |batting|
-      new_batting                       = BaseballStats::Batting.find_or_create_by(player_id: batting[:player_id], year_id: batting[:year_id])
+      new_batting                       = BaseballStats::Batting.find_or_create_by(
+        player_id: batting[:player_id],
+        year_id: batting[:year_id],
+        league: batting[:league],
+        team_id: batting[:team_id]
+      )
+
       new_batting.league                = batting[:league]
       new_batting.team_id               = batting[:team_id]
       new_batting.appearances           = batting[:appearances]

data/lib/baseball_stats/version.rb

@@ -1,3 +1,3 @@
 module BaseballStats
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/baseball_stats_spec.rb

@@ -51,9 +51,9 @@ describe BaseballStats do
 
     it 'returns an array of hashes for every player for the team for that year and their associated slugging percentage' do
       expect(subject).to eq([
-        { player: player1.name, slugging_percentage: "22.0%" },
-        { player: player2.name, slugging_percentage: "44.0%" },
-        { player: player3.name, slugging_percentage: "68.0%" }
+        { player: player3.name, slugging_percentage: "0.68" },
+        { player: player2.name, slugging_percentage: "0.44" },
+        { player: player1.name, slugging_percentage: "0.22" }
       ])
     end
   end

data/spec/lib/import_spec.rb

@@ -16,7 +16,7 @@ describe BaseballStats::Import do
     subject                 { BaseballStats::Import.import_battings_from_csv(csv_file) }
 
     it 'imports all battings into the database' do
-      expect{ subject }.to change{ BaseballStats::Batting.count }.to 16
+      expect{ subject }.to change{ BaseballStats::Batting.count }.to 17
     end
 
     it "only imports battings that don't yet exist" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: codenamev-baseball-stats
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Valentino Stoll