codegrade 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5db65c0710cb981a6a70470a77af6483a0003067
-  data.tar.gz: fa8eb37af5f94816e754f3d114c993b72fc9152b
+  metadata.gz: ed941c70ebef8e4a85be978419dca1675e9e3c1f
+  data.tar.gz: d08d06ffcb554a7babe0f18bd336a58699ead4dd
 SHA512:
-  metadata.gz: ed5a8224328dc6347e910839b9b93ad444dfa5add89fdb0d8ee3c5eecc324e627415ca8e95c4277b6c426045373bf1081f8f1fe9238fdba483367bc6c7bd202b
-  data.tar.gz: b4722a0199d9084dcaca7695113061cd116edc40dda13b2e13a3eccb5059c40349bd9ef8fa733a58ee96508e008595cc9b116d4854001bd3102da370d9796dfc
+  metadata.gz: e0ad5baf525492fb258d847ee5903082a25f9ed3ad5dc7a26e0d5f784c2d057238b71391adfb1cff44c2651effb392d8a64b51a87a625d668d6397854eeb8346
+  data.tar.gz: de9fd150d25a7ff7423a6a8ec27c37e17abd705d05a1fc027a50a21d4aa505a923344676522c5a910187a2bc1f11ef30e6e756b9a9fc10cecc7dd01806f62edc

data/Gemfile.lock

@@ -1,3 +1,11 @@
+PATH
+  remote: .
+  specs:
+    codegrade (0.0.1)
+      jshintrb (~> 0.2)
+      rubocop (~> 0.27)
+      rugged (~> 0.21)
+
 GEM
   remote: https://rubygems.org/
   specs:
@@ -5,11 +13,18 @@ GEM
     astrolabe (1.3.0)
       parser (>= 2.2.0.pre.3, < 3.0)
     diff-lcs (1.2.5)
+    execjs (2.2.2)
+    jshintrb (0.2.4)
+      execjs
+      multi_json (>= 1.3)
+      rake
+    multi_json (1.10.1)
     parser (2.2.0.pre.8)
       ast (>= 1.1, < 3.0)
       slop (~> 3.4, >= 3.4.5)
     powerpack (0.0.9)
     rainbow (2.0.0)
+    rake (10.3.2)
     rspec (3.1.0)
       rspec-core (~> 3.1.0)
       rspec-expectations (~> 3.1.0)
@@ -36,6 +51,7 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  rspec
-  rubocop
-  rugged
+  bundler (~> 1.7)
+  codegrade!
+  rake (~> 10.0)
+  rspec (~> 3.1)

data/README.md

@@ -5,3 +5,41 @@
 CMake is required to build Rugged gem. On Mac you can install it with command:
 
     brew install cmake
+
+## Installation
+
+Add this line to your application's Gemfile:
+
+```ruby
+gem 'codegrade'
+```
+
+And then execute:
+
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install codegrade
+
+## Usage
+
+Run `codegrade` with no arguments to check your last git commit:
+
+    codegrade
+
+Pass commit sha to check this specific commit:
+
+    codegrade 08ffde9e7100f27462cf24259ab89a9ed813a14d
+
+or
+
+    codegrade 08ffde
+
+## Contributing
+
+1. Fork it ( https://github.com/[my-github-username]/test/fork )
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create a new Pull Request

data/codegrade.gemspec

@@ -23,4 +23,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency('rspec', '~> 3.1')
   spec.add_runtime_dependency('rubocop', '~> 0.27')
   spec.add_runtime_dependency('rugged', '~> 0.21')
+  spec.add_runtime_dependency('jshintrb', '~> 0.2')
 end

data/lib/codegrade/grader/jshintrb.rb

@@ -0,0 +1,23 @@
+module Codegrade
+  module Grader
+    class Jshintrb
+      attr_reader :offenses
+
+      def initialize(content)
+        @content = content
+      end
+
+      def grade
+        @offenses = ::Jshintrb.lint(@content).collect do |data|
+          category = data['raw'].downcase.gsub(
+            /\W/, '_').gsub(/_+/, '_').gsub(/_$/, '')
+
+          Codegrade::Offense.new(
+            :category       => category,
+            :line_number    => data['line'],
+            :column_number  => data['character'])
+        end
+      end
+    end
+  end
+end

data/lib/codegrade/version.rb

@@ -1,3 +1,3 @@
 module Codegrade
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/codegrade.rb

@@ -1,6 +1,7 @@
 require 'ostruct'
 require 'rubocop'
 require 'rugged'
+require 'jshintrb'
 
 require 'codegrade/commit'
 require 'codegrade/formatter'
@@ -8,3 +9,4 @@ require 'codegrade/offense'
 require 'codegrade/grader/commit_message'
 require 'codegrade/grader/grader'
 require 'codegrade/grader/rubocop'
+require 'codegrade/grader/jshintrb'

data/spec/models/grader/commit_message_spec.rb

@@ -1,21 +1,6 @@
 require 'spec_helper'
 
 describe Codegrade::Grader::CommitMessage do
-  def find_offense(grader, conditions = {})
-    grader.offenses.find do |error|
-      all_met = true
-
-      conditions.each do |key, value|
-        if error[key] != value
-          all_met = false
-          break
-        end
-      end
-
-      all_met
-    end
-  end
-
   context 'proper reference commit' do
     let(:message) do
       "Implement perfect commit

data/spec/models/grader/jshintrb_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe Codegrade::Grader::Jshintrb do
+  context 'unnamed function' do
+    let(:content) do
+      "\n\nfunction () { }"
+    end
+
+    it 'returns relevant error' do
+      grader = Codegrade::Grader::Jshintrb.new(content)
+      grader.grade
+
+      expect(find_offense(grader,
+        :category => 'missing_name_in_function_declaration',
+        :line_number => 3)).not_to be_nil
+    end
+  end
+
+  context 'missing semicolon' do
+    let(:content) do
+      "function f1 () {\n x = 1;\n y = 2 \n}"
+    end
+
+    it 'returns relevant error' do
+      grader = Codegrade::Grader::Jshintrb.new(content)
+      grader.grade
+
+      expect(find_offense(grader,
+        :category => 'missing_semicolon',
+        :line_number => 3)).not_to be_nil
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -9,3 +9,18 @@ RSpec.configure do |config|
     mocks.verify_partial_doubles = true
   end
 end
+
+def find_offense(grader, conditions = {})
+  grader.offenses.find do |error|
+    all_met = true
+
+    conditions.each do |key, value|
+      if error[key] != value
+        all_met = false
+        break
+      end
+    end
+
+    all_met
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: codegrade
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Michał Młoźniak
@@ -81,6 +81,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.21'
+- !ruby/object:Gem::Dependency
+  name: jshintrb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
 description: This tool grades your commit messages and all changes files
 email:
 - contact@visuality.pl
@@ -103,11 +117,13 @@ files:
 - lib/codegrade/formatter.rb
 - lib/codegrade/grader/commit_message.rb
 - lib/codegrade/grader/grader.rb
+- lib/codegrade/grader/jshintrb.rb
 - lib/codegrade/grader/rubocop.rb
 - lib/codegrade/offense.rb
 - lib/codegrade/version.rb
 - spec/models/grader/commit_message_spec.rb
 - spec/models/grader/grader_spec.rb
+- spec/models/grader/jshintrb_spec.rb
 - spec/models/grader/rubocop_spec.rb
 - spec/spec_helper.rb
 homepage: http://www.visuality.pl
@@ -137,5 +153,6 @@ summary: Grade your git commits
 test_files:
 - spec/models/grader/commit_message_spec.rb
 - spec/models/grader/grader_spec.rb
+- spec/models/grader/jshintrb_spec.rb
 - spec/models/grader/rubocop_spec.rb
 - spec/spec_helper.rb