codeclimate 0.26.0 → 0.27.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d43c699da6eae6069acb8272502c1f14f21314b
-  data.tar.gz: 831177029f49803b8196bc87ae215825856833af
+  metadata.gz: 9527caedfb7602bda076c88af7a6c5d776a66697
+  data.tar.gz: ba274a662e0f68a8479fe0a3f196720a5316ab56
 SHA512:
-  metadata.gz: 011ea2bf09e8c6f49439546fe49cf18b55473163ba2b9b62b676b3054411db336870d9ccafa5387cb7cf25820de4a770f80ab722c2f7c6148effbb6e296fe7ed
-  data.tar.gz: 37f30fe06ba2ac1c65874837fef499effe1f9eab80a7522f65061e0294428afce0b9101125afaa7d97172184544e8571e29a23c6b8f8d461e95b0ed54b45ebf3
+  metadata.gz: 5743efcfa4ee9acc4ee8b4de0949884a3a83af56146cdfa3330d896b0b607a0cc38384380a31c1f1a734afcb199badd9d51bba790ad816b591fd450bad58e6d6
+  data.tar.gz: 10a3d50fa006ee8c17eadd13d1028c776e4f4afe4f2a36ab5695d2a63d663106e27b33036a64c8534ee7759c6c8a31c55780bb3c526c878118bd38b3eb9182c2

data/lib/cc/analyzer.rb

@@ -31,6 +31,8 @@ module CC
     autoload :MountedPath, "cc/analyzer/mounted_path"
     autoload :RaisingContainerListener, "cc/analyzer/raising_container_listener"
     autoload :SourceBuffer, "cc/analyzer/source_buffer"
+    autoload :SourceExtractor, "cc/analyzer/source_extractor"
+    autoload :SourceFingerprint, "cc/analyzer/source_fingerprint"
     autoload :StatsdContainerListener, "cc/analyzer/statsd_container_listener"
     autoload :Validation, "cc/analyzer/validation"
 

data/lib/cc/analyzer/issue.rb

@@ -34,25 +34,21 @@ module CC
         end
       end
 
+      def path
+        parsed_output.fetch("location", {}).fetch("path", "")
+      end
+
       private
 
       attr_reader :output
 
       def default_fingerprint
-        digest = Digest::MD5.new
-        digest << path
-        digest << "|"
-        digest << check_name.to_s
-        digest.to_s
+        SourceFingerprint.new(self).compute
       end
 
       def parsed_output
         @parsed_output ||= JSON.parse(output)
       end
-
-      def path
-        parsed_output.fetch("location", {}).fetch("path", "")
-      end
     end
   end
 end

data/lib/cc/analyzer/source_extractor.rb

@@ -0,0 +1,79 @@
+module CC
+  module Analyzer
+    class SourceExtractor
+      InvalidLocationPositions = Class.new(StandardError)
+
+      def initialize(source)
+        @source = source
+      end
+
+      def extract(location)
+        if (lines = location["lines"])
+          extract_from_lines(lines)
+        elsif (positions = location["positions"])
+          extract_from_positions(positions)
+        end
+      end
+
+      private
+
+      attr_reader :location, :source
+
+      def extract_from_lines(lines)
+        begin_index = lines.fetch("begin") - 1
+        end_index = lines.fetch("end") - 1
+        range = (begin_index..end_index)
+
+        source.each_line.with_object("").with_index do |(source_line, memo), index|
+          memo << source_line if range.include?(index)
+        end
+      end
+
+      def extract_from_positions(positions)
+        positions = convert_to_offsets(positions)
+        begin_offset = positions.fetch("begin").fetch("offset")
+        end_offset = positions.fetch("end").fetch("offset")
+        length = end_offset - begin_offset
+
+        source[begin_offset, length + 1]
+      end
+
+      def convert_to_offsets(positions)
+        positions.each do |key, value|
+          next if value["offset"]
+
+          validate_position_format!(value)
+
+          positions[key] = {
+            "offset" => to_offset(value["line"] - 1, value["column"] - 1),
+          }
+        end
+
+        positions
+      end
+
+      def validate_position_format!(position)
+        unless position.key?("line") && position.key?("column")
+          message = "Location positions must have either line/column or offset form"
+
+          raise InvalidLocationPositions, message
+        end
+      end
+
+      def to_offset(line, column, offset = 0)
+        source.each_line.with_index do |source_line, index|
+          offset +=
+            if line == index
+              column
+            else
+              source_line.length
+            end
+
+          break if index >= line
+        end
+
+        offset
+      end
+    end
+  end
+end

data/lib/cc/analyzer/source_fingerprint.rb

@@ -0,0 +1,32 @@
+require "digest/md5"
+
+module CC
+  module Analyzer
+    class SourceFingerprint
+      def initialize(issue)
+        @issue = issue
+      end
+
+      def compute
+        md5 = Digest::MD5.new
+        md5 << issue.path
+        md5 << issue.check_name.to_s
+        md5 << relevant_source.gsub(/\s+/, "") if relevant_source
+        md5.hexdigest
+      end
+
+      private
+
+      attr_reader :issue
+
+      def relevant_source
+        source = SourceExtractor.new(raw_source).extract(issue.location)
+        source if source && !source.empty?
+      end
+
+      def raw_source
+        @raw_source ||= File.read(issue.path)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.26.0
+  version: 0.27.0.rc1
 platform: ruby
 authors:
 - Code Climate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-18 00:00:00.000000000 Z
+date: 2016-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -184,6 +184,8 @@ files:
 - lib/cc/analyzer/mounted_path.rb
 - lib/cc/analyzer/raising_container_listener.rb
 - lib/cc/analyzer/source_buffer.rb
+- lib/cc/analyzer/source_extractor.rb
+- lib/cc/analyzer/source_fingerprint.rb
 - lib/cc/analyzer/statsd_container_listener.rb
 - lib/cc/analyzer/validation.rb
 - lib/cc/cli.rb
@@ -226,9 +228,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.5