codeclimate 0.2.4 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3dbff022149c78ea083976a0acf56e1da6d5b1d8
-  data.tar.gz: 2d6297f56bf20b11b0159cb661f4123841a600e9
+  metadata.gz: 5d22f3f348dc789674ada7a4873bcde294a7b278
+  data.tar.gz: 65f5b34f666a35b6fcf9e69968e7597c3ae0318a
 SHA512:
-  metadata.gz: e3f1a4161715e07abde090de18b58b219d9a538440b5fc59482d225c8a221d6c4ac8204a1771407f7588d4e82cdc7d3a4cb13123369aabc39b1ee99a4db367d6
-  data.tar.gz: ecd82f39eaabca068d9793158b6d060d7a364e382bf851e41bd3b2d8f4a1b2b3ce2f0c8d26791aad65d6bce2e9b429118af75fd84ff6f1c45ce3efe0ea7b14b7
+  metadata.gz: 6fbe2daeb6327989f76ef44b242633107fcad116433fdf21f58cdc0d338e8a77c5b4c4adbe8736cc53b0965d813f56edf11e5bc5391eec48e6d8e2a472bade75
+  data.tar.gz: 517de74c052b220eab45ebd736623da94d5523b223deebb0a8108c8320df0543960c74c75529f816f2ee9ce05c4cd5dd18588ee7850a3141f5e4f85a49a5f3e1

data/lib/cc/analyzer/engine_registry.rb

@@ -21,6 +21,11 @@ module CC
         @config
       end
 
+      def exists?(engine_name)
+        return true if dev_mode?
+        list.keys.include?(engine_name)
+      end
+
       private
 
       def dev_mode?

data/lib/cc/cli/analyze.rb

@@ -12,8 +12,10 @@ module CC
       def run
         require_codeclimate_yml
 
-        runner = EnginesRunner.new(registry, formatter, source_dir, config)
-        runner.run
+        Dir.chdir(ENV['FILESYSTEM_DIR']) do
+          runner = EnginesRunner.new(registry, formatter, source_dir, config)
+          runner.run
+        end
 
       rescue EnginesRunner::InvalidEngineName => ex
         fatal(ex.message)

data/lib/cc/cli/command.rb

@@ -60,6 +60,10 @@ module CC
       def terminal
         @terminal ||= HighLine.new($stdin, $stdout)
       end
+
+      def engine_registry
+        @engine_registry ||= CC::Analyzer::EngineRegistry.new
+      end
     end
   end
 end

data/lib/cc/cli/console.rb

@@ -1,12 +1,10 @@
 module CC
   module CLI
     class Console < Command
-
       def run
         require "pry"
         binding.pry(quiet: true, prompt: Pry::SIMPLE_PROMPT, output: $stdout)
       end
-
     end
   end
 end

data/lib/cc/cli/engines/engine_command.rb

@@ -33,11 +33,11 @@ module CC
         end
 
         def engine_exists?
-          engines_registry_list.keys.include?(engine_name)
+          engine_registry.exists?(engine_name)
         end
 
-        def engines_registry_list
-          @engines_registry_list ||= CC::Analyzer::EngineRegistry.new.list
+        def engine_registry_list
+          engine_registry.list
         end
       end
     end

data/lib/cc/cli/engines/install.rb

@@ -1,5 +1,3 @@
-require "cc/analyzer"
-
 module CC
   module CLI
     module Engines
@@ -17,7 +15,7 @@ module CC
 
         def pull_docker_images
           engine_names.each do |name|
-            if engine_exists?(name)
+            if engine_registry.exists?(name)
               image = engine_image(name)
               pull_engine_image(image)
             else
@@ -30,12 +28,8 @@ module CC
           @engine_names ||= parsed_yaml.engine_names
         end
 
-        def engine_exists?(engine_name)
-          engines_registry_list.keys.include?(engine_name)
-        end
-
         def engine_image(engine_name)
-          engines_registry_list[engine_name]["image"]
+          engine_registry_list[engine_name]["image"]
         end
 
         def pull_engine_image(engine_image)

data/lib/cc/cli/engines/list.rb

@@ -4,7 +4,7 @@ module CC
       class List < EngineCommand
         def run
           say "Available engines:"
-          engines_registry_list.sort_by { |name, _| name }.each do |name, attributes|
+          engine_registry_list.sort_by { |name, _| name }.each do |name, attributes|
             say "- #{name}: #{attributes["description"]}"
           end
         end

data/lib/cc/cli/init.rb

@@ -52,7 +52,7 @@ module CC
       end
 
       def eligible_engines
-        CC::Analyzer::EngineRegistry.new.list.each_with_object({}) do |(engine_name, config), result|
+        engine_registry.list.each_with_object({}) do |(engine_name, config), result|
           if engine_eligible?(config)
             result[engine_name] = config
           end

data/lib/cc/cli/validate_config.rb

@@ -6,6 +6,8 @@ module CC
       include CC::Analyzer
       include CC::Yaml
 
+      VALID_CONFIG_MESSAGE = "No errors or warnings found in .codeclimate.yml file.".freeze
+
       def run
         require_codeclimate_yml
         verify_yaml
@@ -17,12 +19,12 @@ module CC
         if any_issues?
           display_issues
         else
-          puts colorize("No errors or warnings found in .codeclimate.yml file.", :green)
+          puts colorize(VALID_CONFIG_MESSAGE, :green)
         end
       end
 
       def any_issues?
-        parsed_yaml.errors? || parsed_yaml.nested_warnings.any? || parsed_yaml.warnings?
+        parsed_yaml.errors? || parsed_yaml.nested_warnings.any? || parsed_yaml.warnings? || invalid_engines.any?
       end
 
       def yaml_content
@@ -48,28 +50,47 @@ module CC
       def display_issues
         display_errors
         display_warnings
+        display_invalid_engines
         display_nested_warnings
       end
 
       def display_errors
         errors.each do |error|
-          puts colorize("ERROR: " + error, :red)
+          puts colorize("ERROR: #{error}", :red)
         end
       end
 
       def display_nested_warnings
         nested_warnings.each do |nested_warning|
           if nested_warning[0][0]
-            puts colorize("WARNING in " + nested_warning[0][0] + ": " + nested_warning[1], :red)
+            puts colorize("WARNING in #{nested_warning[0][0]}: #{nested_warning[1]}", :red)
           end
         end
       end
 
       def display_warnings
         warnings.each do |warning|
-          puts colorize("WARNING: " + warning, :red)
+          puts colorize("WARNING: #{warning}", :red)
         end
       end
+
+      def display_invalid_engines
+        invalid_engines.each do |engine_name|
+          puts colorize("WARNING: unknown engine <#{engine_name}>", :red)
+        end
+      end
+
+      def invalid_engines
+        @invalid_engines ||= engine_names.reject { |engine_name| engine_registry.exists? engine_name }
+      end
+
+      def engine_names
+        @engine_names ||= engines.keys
+      end
+
+      def engines
+        @engines ||= parsed_yaml.engines || {}
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.6
 platform: ruby
 authors:
 - Code Climate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-31 00:00:00.000000000 Z
+date: 2015-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport