codeclimate 0.15.2 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38fc838beaa355436f6099d39a452cfc6f2c5dae
-  data.tar.gz: 41ef4793422c385e2322a284b48742e385d98d87
+  metadata.gz: c76b70967c771d965edd6504b4668dece09abf13
+  data.tar.gz: 287482f7b12f57a51bbeace56e80484b2d0760b7
 SHA512:
-  metadata.gz: c9245515c8bb799f1f830bc07841250e7849cd4d7104e9f0b70ecb2b77c3dfd69cbf39338085bd1266d4ef83395fa68725a44cb1727d3668beea1eec32025f3a
-  data.tar.gz: 8795ed1791812a57ab280718477bdc6acd34647c736897ca084157f2b5caab501658cd170ca9c83ee985175a4a2291f9ae34551b49a555f86d12fcaf1b4e4144
+  metadata.gz: 7ebe59fd88a28aaa4c97faeae185b36047b4e6d226be314994ad93f07eda1c568182ca70e6bce9922d46ac3367b84d65a81f1f2b7a7b48a1dee1a43ccbebabda
+  data.tar.gz: 9c7340ec09a4c869153f5d41f3d185287dee5ce388c9154e1f28070d0ff155bbc973c8671714474333d7ee744f3581b72ec78d0e726a9e582be308dece89400e

data/lib/cc/analyzer.rb

@@ -5,6 +5,7 @@ module CC
     autoload :Container, "cc/analyzer/container"
     autoload :ContainerListener, "cc/analyzer/container_listener"
     autoload :Engine, "cc/analyzer/engine"
+    autoload :EngineOutput, "cc/analyzer/engine_output"
     autoload :EngineOutputFilter, "cc/analyzer/engine_output_filter"
     autoload :EngineRegistry, "cc/analyzer/engine_registry"
     autoload :EnginesConfigBuilder, "cc/analyzer/engines_config_builder"
@@ -12,6 +13,7 @@ module CC
     autoload :Filesystem, "cc/analyzer/filesystem"
     autoload :Formatters, "cc/analyzer/formatters"
     autoload :IncludePathsBuilder, "cc/analyzer/include_paths_builder"
+    autoload :Issue, "cc/analyzer/issue"
     autoload :IssueSorter, "cc/analyzer/issue_sorter"
     autoload :LocationDescription, "cc/analyzer/location_description"
     autoload :LoggingContainerListener, "cc/analyzer/logging_container_listener"

data/lib/cc/analyzer/engine.rb

@@ -33,9 +33,11 @@ module CC
           listener: composite_listener,
         )
 
-        container.on_output("\0") do |output|
+        container.on_output("\0") do |raw_output|
+          output = EngineOutput.new(raw_output)
+
           unless output_filter.filter?(output)
-            stdout_io.write(output) || container.stop
+            stdout_io.write(output.to_json) || container.stop
           end
         end
 

data/lib/cc/analyzer/engine_output.rb

@@ -0,0 +1,32 @@
+module CC
+  module Analyzer
+    class EngineOutput
+      delegate :blank?, to: :raw_output
+      delegate :to_json, to: :as_issue
+
+      def initialize(raw_output)
+        @raw_output = raw_output
+      end
+
+      def issue?
+        parsed_output &&
+          parsed_output["type"].present? &&
+          parsed_output["type"].downcase == "issue"
+      end
+
+      def as_issue
+        Issue.new(raw_output)
+      end
+
+      private
+
+      attr_accessor :raw_output
+
+      def parsed_output
+        JSON.parse(raw_output)
+      rescue JSON::ParserError
+        nil
+      end
+    end
+  end
+end

data/lib/cc/analyzer/engine_output_filter.rb

@@ -8,41 +8,21 @@ module CC
       end
 
       def filter?(output)
-        return true unless output.present?
-
-        if (json = parse_as_json(output))
-          issue?(json) && ignore_issue?(json)
-        else
-          false
-        end
+        output.blank? || (output.issue? && ignore_issue?(output.as_issue))
       end
 
       private
 
-      def parse_as_json(output)
-        JSON.parse(output)
-      rescue JSON::ParserError
-        nil
-      end
-
-      def issue?(json)
-        json["type"] && json["type"].downcase == ISSUE_TYPE
-      end
-
-      def ignore_issue?(json)
-        check_disabled?(json) || ignore_fingerprint?(json)
+      def ignore_issue?(issue)
+        check_disabled?(issue) || ignore_fingerprint?(issue)
       end
 
-      def check_disabled?(json)
-        !check_config(json["check_name"]).fetch("enabled", true)
+      def check_disabled?(issue)
+        !check_config(issue.check_name).fetch("enabled", true)
       end
 
-      def ignore_fingerprint?(json)
-        if (fingerprint = json["fingerprint"])
-          @config.fetch("exclude_fingerprints", []).include?(fingerprint)
-        else
-          false
-        end
+      def ignore_fingerprint?(issue)
+        @config.fetch("exclude_fingerprints", []).include?(issue.fingerprint)
       end
 
       def check_config(check_name)

data/lib/cc/analyzer/issue.rb

@@ -0,0 +1,58 @@
+module CC
+  module Analyzer
+    class Issue
+      SPEC_ISSUE_ATTRIBUTES = %w[
+        categories
+        check_name
+        content
+        description
+        location
+        other_locations
+        remediation_points
+        severity
+        type
+      ]
+
+      def initialize(output)
+        @output = output
+      end
+
+      def as_json(*)
+        parsed_output.reverse_merge!(
+          "fingerprint" => fingerprint,
+        )
+      end
+
+      def fingerprint
+        parsed_output.fetch("fingerprint", default_fingerprint)
+      end
+
+      # Allow access to hash keys as methods
+      SPEC_ISSUE_ATTRIBUTES.each do |key|
+        define_method(key) do
+          parsed_output[key]
+        end
+      end
+
+      private
+
+      attr_reader :output
+
+      def default_fingerprint
+        digest = Digest::MD5.new
+        digest << path
+        digest << "|"
+        digest << check_name.to_s
+        digest.to_s
+      end
+
+      def parsed_output
+        @parsed_output ||= JSON.parse(output)
+      end
+
+      def path
+        parsed_output.fetch("location", {}).fetch("path", "")
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.15.2
+  version: 0.16.0
 platform: ruby
 authors:
 - Code Climate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-10 00:00:00.000000000 Z
+date: 2015-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -204,6 +204,7 @@ files:
 - lib/cc/analyzer/container.rb
 - lib/cc/analyzer/container_listener.rb
 - lib/cc/analyzer/engine.rb
+- lib/cc/analyzer/engine_output.rb
 - lib/cc/analyzer/engine_output_filter.rb
 - lib/cc/analyzer/engine_registry.rb
 - lib/cc/analyzer/engines_config_builder.rb
@@ -215,6 +216,7 @@ files:
 - lib/cc/analyzer/formatters/plain_text_formatter.rb
 - lib/cc/analyzer/formatters/spinner.rb
 - lib/cc/analyzer/include_paths_builder.rb
+- lib/cc/analyzer/issue.rb
 - lib/cc/analyzer/issue_sorter.rb
 - lib/cc/analyzer/location_description.rb
 - lib/cc/analyzer/logging_container_listener.rb