codeclimate 0.14.1 → 0.14.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7d10a3e340b114a674a576928f4fcfecf003804
-  data.tar.gz: f457eb3fc54b3e7e63aeb3d64010b57736c4165d
+  metadata.gz: 72cddaaaf2d406b672e5dcf23810a2c3c12d5bf1
+  data.tar.gz: 8d59b60cd8907a9ac2f797c355aaf74cc8c28e1e
 SHA512:
-  metadata.gz: 7abfdf98943e97e6a5c43cb5a63f767e15b98a5b2b67ad2353ed417e3ce2835f8478dbe7b38f7de025128c5f79245db70c67e2faacbff2538e7a237cb0e00265
-  data.tar.gz: f97c25a43e0e1b44b1f05c6e5bbff19fbbbe5a018bd4008dcadadf28ff233c9951c981c6c7a556cae2ef23a540792854afc22ef74a3f0c8c147b045e724c09e0
+  metadata.gz: dcae9739365b050502e5dbeded10610040236b0f9c8ca84b5a5559955f28c34101be489363874bd469748ec61218365f8cfd4fa0b89e6f67dfba122ae72b6609
+  data.tar.gz: ffa9d0a75f6fdd2e615e5c1dc02b156c03f35e3f723d40845b9063f4016dbc4d09435fb0c43603cbeaf7cd9905378106bca83fb28409e0b630d8204a0c45ebb0

data/config/engines.yml

@@ -12,9 +12,11 @@
 brakeman:
   image: codeclimate/codeclimate-brakeman
   description: Static analysis tool which checks Ruby on Rails applications for security vulnerabilities.
-  community: true
+  community: false
+  upgrade_languages:
+    - Ruby
   enable_regexps:
-    - \.rb$
+    - ^script\/rails$
   default_ratings_paths:
     - "app/**"
     - "**.rb"
@@ -114,7 +116,9 @@ nodesecurity:
 pep8:
   image: codeclimate/codeclimate-pep8
   description: Static analysis tool to check Python code against the style conventions outlined in PEP-8.
-  community: true
+  community: false
+  upgrade_languages:
+    - Python
   enable_regexps:
     - \.py$
   default_ratings_paths:
@@ -150,7 +154,9 @@ phpmd:
 radon:
   image: codeclimate/codeclimate-radon
   description: Python tool used to compute Cyclomatic Complexity.
-  community: true
+  community: false
+  upgrade_languages:
+    - Python
   enable_regexps:
     - \.py$
   default_ratings_paths:

data/lib/cc/analyzer/container.rb

@@ -1,4 +1,5 @@
 require "posix/spawn"
+require "thread"
 
 module CC
   module Analyzer
@@ -11,9 +12,17 @@ module CC
         :stderr,        # stderr, for a finished event
       )
       ImageRequired = Class.new(StandardError)
-      Result = Struct.new(:exit_status, :timed_out?, :duration, :stderr)
+      Result = Struct.new(
+        :exit_status,
+        :timed_out?,
+        :duration,
+        :maximum_output_exceeded?,
+        :output_byte_count,
+        :stderr,
+      )
 
       DEFAULT_TIMEOUT = 15 * 60 # 15m
+      DEFAULT_MAXIMUM_OUTPUT_BYTES = 500_000_000
 
       def initialize(image:, name:, command: nil, listener: ContainerListener.new)
         raise ImageRequired if image.blank?
@@ -24,7 +33,10 @@ module CC
         @output_delimeter = "\n"
         @on_output = ->(*) {}
         @timed_out = false
+        @maximum_output_exceeded = false
         @stderr_io = StringIO.new
+        @output_byte_count = 0
+        @counter_mutex = Mutex.new
       end
 
       def on_output(delimeter = "\n", &block)
@@ -43,14 +55,23 @@ module CC
         t_timeout = timeout_thread
 
         _, status = Process.waitpid2(pid)
+
         if @timed_out
-          @listener.timed_out(container_data(duration: timeout))
-          Result.new(status.exitstatus, true, timeout, @stderr_io.string)
+          duration = timeout
+          @listener.timed_out(container_data(duration: duration))
         else
           duration = ((Time.now - started) * 1000).round
           @listener.finished(container_data(duration: duration, status: status))
-          Result.new(status.exitstatus, false, duration, @stderr_io.string)
         end
+
+        Result.new(
+          status.exitstatus,
+          @timed_out,
+          duration,
+          @maximum_output_exceeded,
+          output_byte_count,
+          @stderr_io.string,
+        )
       ensure
         t_timeout.kill if t_timeout
         if @timed_out
@@ -71,6 +92,8 @@ module CC
 
       private
 
+      attr_reader :output_byte_count, :counter_mutex
+
       def docker_run_command(options)
         [
           "docker", "run",
@@ -88,13 +111,17 @@ module CC
             output = chunk.chomp(@output_delimeter)
 
             @on_output.call(output)
+            check_output_bytes(output.bytesize)
           end
         end
       end
 
       def read_stderr(err)
         Thread.new do
-          err.each_line { |line| @stderr_io.write(line) }
+          err.each_line do |line|
+            @stderr_io.write(line)
+            check_output_bytes(line.bytesize)
+          end
         end
       end
 
@@ -106,6 +133,17 @@ module CC
         end
       end
 
+      def check_output_bytes(last_read_byte_count)
+        counter_mutex.synchronize do
+          @output_byte_count += last_read_byte_count
+        end
+
+        if output_byte_count > maximum_output_bytes
+          @maximum_output_exceeded = true
+          stop
+        end
+      end
+
       def container_data(duration: nil, status: nil)
         ContainerData.new(@image, @name, duration, status, @stderr_io.string)
       end
@@ -116,7 +154,11 @@ module CC
       end
 
       def timeout
-        (ENV["CONTAINER_TIMEOUT_SECONDS"] || DEFAULT_TIMEOUT).to_i
+        ENV.fetch("CONTAINER_TIMEOUT_SECONDS", DEFAULT_TIMEOUT).to_i
+      end
+
+      def maximum_output_bytes
+        ENV.fetch("CONTAINER_MAXIMUM_OUTPUT_BYTES", DEFAULT_MAXIMUM_OUTPUT_BYTES).to_i
       end
     end
   end

data/lib/cc/analyzer/include_paths_builder.rb

@@ -49,8 +49,8 @@ module CC
           tmp.write(File.read(".gitignore")) if File.file?(".gitignore")
           tmp << @cc_exclude_paths.join("\n")
           tmp.close
-          tracked_and_ignored = `git ls-files -zi -X #{tmp.path}`.split("\0")
-          untracked_and_ignored = `git ls-files -zio -X #{tmp.path}`.split("\0")
+          tracked_and_ignored = `git ls-files -zi -X #{tmp.path} 2>/dev/null`.split("\0")
+          untracked_and_ignored = `git ls-files -zio -X #{tmp.path} 2>/dev/null`.split("\0")
           tracked_and_ignored + untracked_and_ignored
         end
       end

data/lib/cc/cli/config_generator.rb

@@ -2,7 +2,7 @@ module CC
   module CLI
     class ConfigGenerator
       CODECLIMATE_YAML = Command::CODECLIMATE_YAML
-      AUTO_EXCLUDE_PATHS = %w(config/ db/ features/ node_modules/ script/ spec/ test/ vendor/).freeze
+      AUTO_EXCLUDE_PATHS = %w(config/ db/ features/ node_modules/ script/ spec/ test/ tests/ vendor/).freeze
 
       def self.for(filesystem, engine_registry, upgrade_requested)
         if upgrade_requested && upgrade_needed?(filesystem)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.14.1
+  version: 0.14.2
 platform: ruby
 authors:
 - Code Climate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-09 00:00:00.000000000 Z
+date: 2015-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport