codeclimate 0.14.0 → 0.14.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d13448b3cac119e109b7c8803f6a9ad3d40c7cfc
-  data.tar.gz: ca2b0a4d9ce066010654c5c4b33f648e671c80f1
+  metadata.gz: f7d10a3e340b114a674a576928f4fcfecf003804
+  data.tar.gz: f457eb3fc54b3e7e63aeb3d64010b57736c4165d
 SHA512:
-  metadata.gz: af40f37bcad31b287e4e89cd903a327381c435d9925343aff88a05d3c15816e4f99a4c8cceb2de1f635bedbfc11544375fbabf662436473eb818069d3a6e43e1
-  data.tar.gz: 0ebed34277ebffadb88133ffc92a61ec07c14f732ae3c67bb9d6e496cdf40590d40219d53d8f2c919cc4d5d79315b2110d7abf69bc2ed529e742936959698174
+  metadata.gz: 7abfdf98943e97e6a5c43cb5a63f767e15b98a5b2b67ad2353ed417e3ce2835f8478dbe7b38f7de025128c5f79245db70c67e2faacbff2538e7a237cb0e00265
+  data.tar.gz: f97c25a43e0e1b44b1f05c6e5bbff19fbbbe5a018bd4008dcadadf28ff233c9951c981c6c7a556cae2ef23a540792854afc22ef74a3f0c8c147b045e724c09e0

data/bin/codeclimate

@@ -4,5 +4,6 @@ $LOAD_PATH.unshift(File.expand_path(File.join(File.dirname(__FILE__), "../lib"))
 require "cc/cli"
 
 ENV["FILESYSTEM_DIR"] ||= "."
+ENV["CODE_PATH"] ||= ENV["PWD"]
 
 CC::CLI::Runner.run(ARGV)

data/config/coffeelint/coffeelint.json

@@ -0,0 +1,129 @@
+{
+  "arrow_spacing": {
+    "level": "ignore"
+  },
+  "braces_spacing": {
+    "level": "ignore",
+    "spaces": 0,
+    "empty_object_spaces": 0
+  },
+  "camel_case_classes": {
+    "level": "error"
+  },
+  "coffeescript_error": {
+    "level": "error"
+  },
+  "colon_assignment_spacing": {
+    "level": "ignore",
+    "spacing": {
+      "left": 0,
+      "right": 0
+    }
+  },
+  "cyclomatic_complexity": {
+    "value": 10,
+    "level": "ignore"
+  },
+  "duplicate_key": {
+    "level": "error"
+  },
+  "empty_constructor_needs_parens": {
+    "level": "ignore"
+  },
+  "ensure_comprehensions": {
+    "level": "warn"
+  },
+  "eol_last": {
+    "level": "ignore"
+  },
+  "indentation": {
+    "value": 2,
+    "level": "error"
+  },
+  "line_endings": {
+    "level": "ignore",
+    "value": "unix"
+  },
+  "max_line_length": {
+    "value": 80,
+    "level": "error",
+    "limitComments": true
+  },
+  "missing_fat_arrows": {
+    "level": "ignore",
+    "is_strict": false
+  },
+  "newlines_after_classes": {
+    "value": 3,
+    "level": "ignore"
+  },
+  "no_backticks": {
+    "level": "error"
+  },
+  "no_debugger": {
+    "level": "warn",
+    "console": false
+  },
+  "no_empty_functions": {
+    "level": "ignore"
+  },
+  "no_empty_param_list": {
+    "level": "ignore"
+  },
+  "no_implicit_braces": {
+    "level": "ignore",
+    "strict": true
+  },
+  "no_implicit_parens": {
+    "strict": true,
+    "level": "ignore"
+  },
+  "no_interpolation_in_single_quotes": {
+    "level": "ignore"
+  },
+  "no_plusplus": {
+    "level": "ignore"
+  },
+  "no_stand_alone_at": {
+    "level": "ignore"
+  },
+  "no_tabs": {
+    "level": "error"
+  },
+  "no_this": {
+    "level": "ignore"
+  },
+  "no_throwing_strings": {
+    "level": "error"
+  },
+  "no_trailing_semicolons": {
+    "level": "error"
+  },
+  "no_trailing_whitespace": {
+    "level": "error",
+    "allowed_in_comments": false,
+    "allowed_in_empty_lines": true
+  },
+  "no_unnecessary_double_quotes": {
+    "level": "ignore"
+  },
+  "no_unnecessary_fat_arrows": {
+    "level": "warn"
+  },
+  "non_empty_constructor_needs_parens": {
+    "level": "ignore"
+  },
+  "prefer_english_operator": {
+    "level": "ignore",
+    "doubleNotLevel": "ignore"
+  },
+  "space_operators": {
+    "level": "ignore"
+  },
+  "spacing_after_comma": {
+    "level": "ignore"
+  },
+  "transform_messes_up_line_numbers": {
+    "level": "warn"
+  }
+}

data/lib/cc/analyzer/engine.rb

@@ -63,6 +63,7 @@ module CC
 
       def config_file
         path = File.join("/tmp/cc", SecureRandom.uuid)
+        FileUtils.mkdir_p("/tmp/cc")
         File.write(path, @config.to_json)
         path
       end

data/lib/cc/cli.rb

@@ -12,6 +12,7 @@ module CC
     autoload :Help, "cc/cli/help"
     autoload :Init, "cc/cli/init"
     autoload :Runner, "cc/cli/runner"
+    autoload :Test, "cc/cli/test"
     autoload :ValidateConfig, "cc/cli/validate_config"
     autoload :Version, "cc/cli/version"
   end

data/lib/cc/cli/test.rb

@@ -0,0 +1,270 @@
+require "shellwords"
+require "cc/yaml"
+
+module CC
+  module CLI
+    class Marker
+      def self.from_text(engine_name, test_file, line_number, text)
+        marker = Marker.new(line_number, text)
+        attrs = attrs_from_marker(text.sub(/^.*\[issue\] ?/, ""))
+
+        marker.issue = attrs.merge(
+          "engine_name" => engine_name,
+          "location" => {
+            "path" => test_file,
+            "lines" => {
+              "begin" => line_number + 1,
+              "end" => line_number + 1,
+            },
+          },
+        )
+
+        if marker.issue["category"]
+          marker.issue["categories"] = Array.wrap(marker.issue["category"])
+          marker.issue.delete("category")
+        end
+
+        marker
+      end
+
+      def self.attrs_from_marker(text)
+        if text.blank?
+          {}
+        else
+          matches = text.scan(/([a-z\._-]+)=(?:(")((?:\\.|[^"])*)"|([^\s]*))/).map(&:compact)
+
+          key_values = matches.map do |match|
+            munge_match(match)
+          end
+
+          Hash[key_values]
+        end
+      end
+
+      def self.munge_match(match)
+        if match.size == 3 # Quoted
+          key, _, value = match
+          value = '"' + value + '"'
+        else
+          key, value = match
+        end
+
+        [key, munge_value(value)]
+      end
+
+      def self.munge_value(value)
+        JSON.load(value)
+      rescue JSON::ParserError
+        value
+      end
+
+      attr_reader :line, :line_text
+      attr_accessor :issue
+
+      def initialize(line, line_text)
+        @line = line
+        @line_text = line_text
+        @issue = issue
+      end
+    end
+
+    class Test < Command
+      def run
+        @engine_name = @args.first
+
+        if @engine_name.blank?
+          fatal "Usage: codeclimate test #{rainbow.wrap('engine_name').underline}"
+        end
+
+        test_engine
+      end
+
+      def test_engine
+        within_tempdir do
+          prepare_working_dir
+          unpack_tests
+          run_tests
+        end
+      ensure
+        remove_null_container
+      end
+
+      def within_tempdir
+        tmpdir = create_tmpdir
+
+        Dir.chdir(tmpdir) do
+          yield
+        end
+      ensure
+        FileUtils.rm_rf(tmpdir)
+      end
+
+      def unpack_tests
+        test_paths.each do |test_path|
+          unpack(test_path)
+        end
+      end
+
+      def run_tests
+        Dir["**/*"].each do |test_file|
+          next unless File.file?(test_file)
+          process_file(test_file)
+        end
+      end
+
+      def process_file(test_file)
+        markers = markers_in(test_file)
+
+        actual_issues = issues_in(test_file)
+        compare_issues(actual_issues, markers)
+      end
+
+      def compare_issues(actual_issues, markers)
+        markers.each do |marker|
+          validate_issue(marker, actual_issues)
+        end
+
+        validate_unexpected_issues(actual_issues)
+      end
+
+      def validate_issue(marker, actual_issues)
+        if (index = locate_match(actual_issues, marker))
+          announce_pass(marker)
+          actual_issues.delete_at(index)
+        else
+          announce_fail(marker, actual_issues)
+          fatal "Expected issue not found."
+        end
+      end
+
+      def locate_match(actual_issues, marker)
+        actual_issues.each_with_index do |actual, index|
+          if fuzzy_match(marker.issue, actual)
+            return index
+          end
+        end
+
+        nil
+      end
+
+      def announce_pass(marker)
+        say format("PASS %3d: %s", marker.line, marker.line_text)
+      end
+
+      def announce_fail(marker, actual_issues)
+        say colorize(format("FAIL %3d: %s", marker.line, marker.line_text), :red)
+        say colorize("Expected:", :yellow)
+        say colorize(JSON.pretty_generate(marker.issue), :yellow)
+        say "\n"
+        say colorize("Actual:", :yellow)
+        say colorize(JSON.pretty_generate(actual_issues), :yellow)
+      end
+
+      def validate_unexpected_issues(actual_issues)
+        if actual_issues.any?
+          say colorize("Actuals not empty after matching.", :red)
+          say
+          say colorize("#{actual_issues.size} remaining:", :yellow)
+          say colorize(JSON.pretty_generate(actual_issues), :yellow)
+          fatal "Unexpected issue found."
+        end
+      end
+
+      def fuzzy_match(expected, actual)
+        expected.all? do |key, value|
+          actual[key] == value
+        end
+      end
+
+      def issues_in(test_file)
+        issue_docs = capture_stdout do
+          codeclimate_analyze(test_file)
+        end
+
+        JSON.parse(issue_docs)
+      end
+
+      def codeclimate_analyze(relative_path)
+        codeclimate_path = File.expand_path(File.join(File.dirname(__FILE__), "../../../bin/codeclimate"))
+
+        system([
+          "unset CODE_PATH &&",
+          "unset FILESYSTEM_DIR &&",
+          Shellwords.escape(codeclimate_path),
+          "analyze",
+          "--engine", Shellwords.escape(@engine_name),
+          "-f", "json",
+          Shellwords.escape(relative_path)
+        ].join(" "))
+      end
+
+      def prepare_working_dir
+        `git init`
+
+        File.open(".codeclimate.yml", "w") do |config|
+          config.write("engines:\n  #{@engine_name}:\n    enabled: true")
+        end
+      end
+
+      def markers_in(test_file)
+        lines = File.readlines(test_file)
+
+        [].tap do |markers|
+          lines.each_with_index do |line, index|
+            if line =~ /\[issue\].*/
+              markers << Marker.from_text(@engine_name, test_file, index + 1, line)
+            end
+          end
+        end
+      end
+
+      def create_tmpdir
+        tmpdir = File.join("/tmp/cc", SecureRandom.uuid)
+        FileUtils.mkdir_p(tmpdir)
+        tmpdir
+      end
+
+      def unpack(path)
+        system("docker cp #{null_container_id}:#{path} .")
+      end
+
+      def null_container_id
+        # docker cp only works with containers, not images so
+        # workaround it by creating a throwaway container
+        @null_container_id = `docker run -d #{engine_image} false`.chomp
+      end
+
+      def remove_null_container
+        `docker rm -f #{null_container_id}` if null_container_id
+      end
+
+      def test_paths
+        Array.wrap(engine_spec["test_paths"])
+      end
+
+      def engine_spec
+        @engine_spec ||= JSON.parse(`docker run --rm #{engine_image} cat /engine.json`)
+      end
+
+      def engine_image
+        engine_registry[@engine_name]["image"]
+      end
+
+      # Stolen from ActiveSupport (where it was deprecated)
+      def capture_stdout
+        captured_stream = Tempfile.new("stdout")
+        origin_stream = $stdout.dup
+        $stdout.reopen(captured_stream)
+
+        yield
+
+        $stdout.rewind
+        return captured_stream.read
+      ensure
+        captured_stream.close
+        captured_stream.unlink
+        $stdout.reopen(origin_stream)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.14.1
 platform: ruby
 authors:
 - Code Climate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-05 00:00:00.000000000 Z
+date: 2015-11-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -50,14 +50,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.5.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: 0.5.0
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -193,6 +193,7 @@ files:
 - bin/codeclimate-init
 - bin/prep-release
 - bin/release
+- config/coffeelint/coffeelint.json
 - config/csslint/.csslintrc
 - config/engines.yml
 - config/eslint/.eslintrc
@@ -237,6 +238,7 @@ files:
 - lib/cc/cli/help.rb
 - lib/cc/cli/init.rb
 - lib/cc/cli/runner.rb
+- lib/cc/cli/test.rb
 - lib/cc/cli/upgrade_config_generator.rb
 - lib/cc/cli/validate_config.rb
 - lib/cc/cli/version.rb
@@ -261,7 +263,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Code Climate CLI