codeclimate 0.9.7 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b5ec325a3de6407e16d0ec265e3512751dc98d16
-  data.tar.gz: 6902de17324c521e01d589e65fdedaf12b893808
+  metadata.gz: e7e316d10f1c30a533dd6bf12bec7489f950922a
+  data.tar.gz: 86754e8553d9286b76ade07489d0a3561e979d2f
 SHA512:
-  metadata.gz: 40ad03e9e1d47bd3fc36d1e079d5d215493515518eb1f95a52869b514dc0bc6a1a668af0b84ee68359ebd351a7f0f711a5a339d7f90abcbf551ce8e0af573330
-  data.tar.gz: 0fa3d26b50dbceeef4819d30db2d3cf0a9c6f5385cad4186d03c68b47b5ce3c6cbd103628043a04ab0f831a22a52cd9e011785e255bb66218f694669b161ec77
+  metadata.gz: e4a5711db9e980d5f061a40e207ae56d3882d1c540da778afc2cab5652e7fdd5c5ae217bae3f920e8f3095ee161976b0fd347598739e2db15babd899285ac5ad
+  data.tar.gz: 88b6924d353f1c61ac3dc59aae914ad809e1fdccb9683a01d8fa4f47dd6b35cf7a0e9b6cde45b9febb304e01a37619b9eb700fdc2029601d571b9c6726682f15

data/bin/prep-release

@@ -14,6 +14,7 @@ fi
 
 version=$1
 old_version=$(< VERSION)
+branch="release-$version"
 
 if ! bundle exec rake; then
   echo "test failure, not releasing" >&2
@@ -24,13 +25,13 @@ printf "RELEASE %s => %s\n" "$old_version" "$version"
 git checkout master
 git pull
 
-git checkout -b "release-$version"
+git checkout -b $branch
 
 printf "%s\n" "$version" > VERSION
 bundle
 git add VERSION Gemfile.lock
 git commit -m "Release v$version"
-git push
+git push origin $branch
 
 if command -v gh > /dev/null 2>&1; then
   gh pull-request -m "Release v$version"

data/config/engines.yml

@@ -25,6 +25,12 @@ duplication:
   community: false
   enable_regexps:
   default_ratings_paths:
+  default_config:
+    languages:
+      - ruby
+      - javascript
+      - python
+      - php
 gofmt:
   image: codeclimate/codeclimate-gofmt
   description: gofmt
@@ -134,7 +140,8 @@ fixme:
   description: Find FIXME, TODO, HACK, etc. comments
   community: false
   enable_regexps:
-  default_ratings_paths:
+    - .+
+  default_ratings_paths: []
 foodcritic:
   image: codeclimate/codeclimate-foodcritic
   description: Lint tool for Chef cookbooks

data/lib/cc/analyzer/config.rb

@@ -5,7 +5,7 @@ module CC
     # TODO: replace each use of this with CC::Yaml and remove it
     class Config
       def initialize(config_body)
-        @config = YAML.safe_load(config_body) || {"engines"=> {} }
+        @config = YAML.safe_load(config_body) || { "engines" => {} }
         @config["engines"] ||= {}
 
         expand_shorthand
@@ -35,7 +35,10 @@ module CC
         if engine_present?(engine_name)
           @config["engines"][engine_name]["enabled"] = true
         else
-          @config["engines"][engine_name] = { "enabled" => true }
+          @config["engines"][engine_name] = {
+            "enabled" => true,
+            "config" => default_config(engine_name),
+          }
         end
       end
 
@@ -59,7 +62,7 @@ module CC
         @config.to_yaml
       end
 
-    private
+      private
 
       def expand_shorthand
         @config["engines"].each do |name, engine_config|
@@ -68,6 +71,16 @@ module CC
           end
         end
       end
+
+      def default_config(engine_name)
+        if (engine_config = engine_registry[engine_name])
+          engine_config["default_config"]
+        end
+      end
+
+      def engine_registry
+        @engine_registry ||= CC::Analyzer::EngineRegistry.new
+      end
     end
   end
 end

data/lib/cc/analyzer/container.rb

@@ -28,7 +28,7 @@ module CC
         @listener = listener
         @timeout = timeout
         @output_delimeter = "\n"
-        @on_output = ->(*) { }
+        @on_output = ->(*) {}
         @timed_out = false
         @stderr_io = StringIO.new
       end
@@ -68,7 +68,7 @@ module CC
 
       def stop
         # Prevents the processing of more output after first error
-        @on_output = ->(*) { }
+        @on_output = ->(*) {}
 
         reap_running_container
       end
@@ -82,7 +82,7 @@ module CC
           "--name", @name,
           options,
           @image,
-          @command,
+          @command
         ].flatten.compact
       end
 

data/lib/cc/analyzer/engine.rb

@@ -53,7 +53,7 @@ module CC
           "--net", "none",
           "--volume", "#{@code_path}:/code:ro",
           "--volume", "#{config_file}:/config.json:ro",
-          "--user", "9000:9000",
+          "--user", "9000:9000"
         ]
       end
 

data/lib/cc/analyzer/engine_registry.rb

@@ -36,4 +36,3 @@ module CC
     end
   end
 end
-

data/lib/cc/analyzer/engines.rb

@@ -28,7 +28,7 @@ module CC
       def engine_config(raw_engine_config)
         config = raw_engine_config.merge(
           exclude_paths: exclude_paths,
-          include_paths: include_paths
+          include_paths: include_paths,
         )
         # The yaml gem turns a config file string into a hash, but engines
         # expect the string. So we (for now) need to turn it into a string in

data/lib/cc/analyzer/engines_runner.rb

@@ -37,7 +37,7 @@ module CC
           config: @config,
           container_label: @container_label,
           source_dir: @source_dir,
-          requested_paths: @requested_paths
+          requested_paths: @requested_paths,
         )
       end
 

data/lib/cc/analyzer/filesystem.rb

@@ -1,7 +1,6 @@
 module CC
   module Analyzer
     class Filesystem
-
       def initialize(root)
         @root = root
       end
@@ -40,7 +39,7 @@ module CC
       def file_paths
         @file_paths ||= Dir.chdir(@root) do
           `find . -type f -print0`.strip.split("\0").map do |path|
-            path.sub(/^\.\//, "")
+            path.sub(%r{^\.\/}, "")
           end
         end
       end

data/lib/cc/analyzer/formatters.rb

@@ -1,9 +1,9 @@
 module CC
   module Analyzer
     module Formatters
-      autoload :Formatter,  "cc/analyzer/formatters/formatter"
+      autoload :Formatter, "cc/analyzer/formatters/formatter"
       autoload :JSONFormatter, "cc/analyzer/formatters/json_formatter"
-      autoload :PlainTextFormatter,  "cc/analyzer/formatters/plain_text_formatter"
+      autoload :PlainTextFormatter, "cc/analyzer/formatters/plain_text_formatter"
       autoload :Spinner, "cc/analyzer/formatters/spinner"
 
       FORMATTERS = {
@@ -12,7 +12,7 @@ module CC
       }.freeze
 
       def self.resolve(name)
-        FORMATTERS[name.to_sym] or raise InvalidFormatterError, "'#{name}' is not a valid formatter. Valid options are: #{FORMATTERS.keys.join(", ")}"
+        FORMATTERS[name.to_sym] or raise InvalidFormatterError, "'#{name}' is not a valid formatter. Valid options are: #{FORMATTERS.keys.join(', ')}"
       end
     end
   end

data/lib/cc/analyzer/formatters/formatter.rb

@@ -7,7 +7,7 @@ module CC
           @output = output
         end
 
-        def write(data)
+        def write(_data)
         end
 
         def started
@@ -26,7 +26,7 @@ module CC
         def close
         end
 
-        def failed(output)
+        def failed(_output)
         end
 
         InvalidFormatterError = Class.new(StandardError)

data/lib/cc/analyzer/formatters/json_formatter.rb

@@ -2,7 +2,6 @@ module CC
   module Analyzer
     module Formatters
       class JSONFormatter < Formatter
-
         def initialize(filesystem)
           @filesystem = filesystem
           @has_begun = false

data/lib/cc/analyzer/formatters/plain_text_formatter.rb

@@ -6,7 +6,6 @@ module CC
   module Analyzer
     module Formatters
       class PlainTextFormatter < Formatter
-
         def started
           puts colorize("Starting analysis", :green)
         end
@@ -21,7 +20,7 @@ module CC
           when "warning"
             warnings << json
           else
-            raise "Invalid type found: #{json["type"]}"
+            raise "Invalid type found: #{json['type']}"
           end
         end
 
@@ -29,24 +28,24 @@ module CC
           puts
 
           issues_by_path.each do |path, file_issues|
-            puts colorize("== #{path} (#{pluralize(file_issues.size, "issue")}) ==", :yellow)
+            puts colorize("== #{path} (#{pluralize(file_issues.size, 'issue')}) ==", :yellow)
 
             IssueSorter.new(file_issues).by_location.each do |issue|
-              if location = issue["location"]
+              if (location = issue["location"])
                 source_buffer = @filesystem.source_buffer_for(location["path"])
                 print(colorize(LocationDescription.new(source_buffer, location, ": "), :cyan))
               end
 
               print(issue["description"])
-              print(colorize(" [#{issue["engine_name"]}]", "#333333"))
+              print(colorize(" [#{issue['engine_name']}]", "#333333"))
               puts
             end
             puts
           end
 
-          print(colorize("Analysis complete! Found #{pluralize(issues.size, "issue")}", :green))
+          print(colorize("Analysis complete! Found #{pluralize(issues.size, 'issue')}", :green))
           if warnings.size > 0
-            print(colorize(" and #{pluralize(warnings.size, "warning")}", :green))
+            print(colorize(" and #{pluralize(warnings.size, 'warning')}", :green))
           end
           puts(colorize(".", :green))
         end
@@ -93,7 +92,7 @@ module CC
         end
 
         def issues_by_path
-          issues.group_by { |i| i['location']['path'] }.sort
+          issues.group_by { |i| i["location"]["path"] }.sort
         end
 
         def warnings

data/lib/cc/analyzer/source_buffer.rb

@@ -13,29 +13,28 @@ module CC
       def decompose_position(position)
         line_no, line_begin = line_for(position)
 
-        [ 1 + line_no, position - line_begin ]
+        [1 + line_no, position - line_begin]
       end
 
       def line_count
         @source.lines.count
       end
 
-    private
+      private
 
       def line_for(position)
-        line_begins.bsearch do |line, line_begin|
+        line_begins.bsearch do |_, line_begin|
           line_begin <= position
         end
       end
 
       def line_begins
         unless @line_begins
-          @line_begins, index = [ [ 0, 0 ] ], 1
+          @line_begins = [[0, 0]]
+          index = 1
 
           @source.each_char do |char|
-            if char == "\n"
-              @line_begins.unshift [ @line_begins.length, index ]
-            end
+            @line_begins.unshift [@line_begins.length, index] if char == "\n"
 
             index += 1
           end
@@ -43,7 +42,6 @@ module CC
 
         @line_begins
       end
-
     end
   end
 end

data/lib/cc/cli/analyze.rb

@@ -15,7 +15,7 @@ module CC
       def run
         require_codeclimate_yml
 
-        Dir.chdir(ENV['FILESYSTEM_DIR']) do
+        Dir.chdir(ENV["FILESYSTEM_DIR"]) do
           runner = EnginesRunner.new(registry, formatter, source_dir, config, path_options)
           runner.run
         end
@@ -32,13 +32,13 @@ module CC
       attr_reader :engine_options, :path_options
 
       def process_args
-        while arg = @args.shift
+        while (arg = @args.shift)
           case arg
-          when '-f'
+          when "-f"
             @formatter = Formatters.resolve(@args.shift).new(filesystem)
-          when '-e', '--engine'
+          when "-e", "--engine"
             @engine_options << @args.shift
-          when '--dev'
+          when "--dev"
             @dev_mode = true
           else
             @path_options << arg
@@ -86,7 +86,7 @@ module CC
           if config.engines.include?(engine)
             config.engines[engine].enabled = true
           else
-            config.engines[engine] = CC::Yaml::Nodes::Engine.new(config.engines).with_value({ "enabled" => true })
+            config.engines[engine] = CC::Yaml::Nodes::Engine.new(config.engines).with_value("enabled" => true)
           end
         end
       end

data/lib/cc/cli/command.rb

@@ -17,7 +17,7 @@ module CC
       end
 
       def self.command_name
-        name[/[^:]*$/].split(/(?=[A-Z])/).map(&:downcase).join('-')
+        name[/[^:]*$/].split(/(?=[A-Z])/).map(&:downcase).join("-")
       end
 
       def execute
@@ -38,7 +38,7 @@ module CC
       end
 
       def require_codeclimate_yml
-        if !filesystem.exist?(CODECLIMATE_YAML)
+        unless filesystem.exist?(CODECLIMATE_YAML)
           fatal("No '.codeclimate.yml' file found. Run 'codeclimate init' to generate a config file.")
         end
       end
@@ -54,7 +54,7 @@ module CC
       end
 
       def filesystem
-        @filesystem ||= CC::Analyzer::Filesystem.new(ENV['FILESYSTEM_DIR'])
+        @filesystem ||= CC::Analyzer::Filesystem.new(ENV["FILESYSTEM_DIR"])
       end
 
       def terminal

data/lib/cc/cli/config.rb

@@ -5,7 +5,7 @@ module CC
       def initialize
         @config = {
           "engines" => {},
-          "ratings" => { "paths" => [] }
+          "ratings" => { "paths" => [] },
         }
       end
 

data/lib/cc/cli/engines/install.rb

@@ -33,7 +33,7 @@ module CC
         end
 
         def pull_engine_image(engine_image)
-          if !system("docker pull #{engine_image}")
+          unless system("docker pull #{engine_image}")
             raise ImagePullFailure, "unable to pull image #{engine_image}"
           end
         end

data/lib/cc/cli/engines/list.rb

@@ -5,7 +5,7 @@ module CC
         def run
           say "Available engines:"
           engine_registry_list.sort_by { |name, _| name }.each do |name, attributes|
-            say "- #{name}: #{attributes["description"]}"
+            say "- #{name}: #{attributes['description']}"
           end
         end
       end

data/lib/cc/cli/help.rb

@@ -24,12 +24,12 @@ module CC
           "help",
           "init",
           "validate-config",
-          "version"
+          "version",
         ].freeze
       end
 
       def underline(string)
-        return Rainbow.new.wrap(string).underline
+        Rainbow.new.wrap(string).underline
       end
     end
   end

data/lib/cc/cli/init.rb

@@ -1,6 +1,6 @@
-require 'cc/cli/config'
-require 'cc/cli/config_generator'
-require 'cc/cli/upgrade_config_generator'
+require "cc/cli/config"
+require "cc/cli/config_generator"
+require "cc/cli/upgrade_config_generator"
 
 module CC
   module CLI
@@ -54,7 +54,7 @@ module CC
           Dir.glob("#{engine_directory}/*", File::FNM_DOTMATCH)
         end
 
-        all_paths.reject { |path| ['.', '..'].include?(File.basename(path)) }
+        all_paths.reject { |path| [".", ".."].include?(File.basename(path)) }
       end
 
       def engines_enabled?

data/lib/cc/cli/runner.rb

@@ -5,7 +5,6 @@ require "safe_yaml"
 module CC
   module CLI
     class Runner
-
       def self.run(argv)
         new(argv).run
       rescue => ex
@@ -44,8 +43,8 @@ module CC
 
       def command_name
         case command
-        when nil, '-h', '-?', '--help' then 'Help'
-        when '-v', '--version'         then 'Version'
+        when nil, "-h", "-?", "--help" then "Help"
+        when "-v", "--version"         then "Version"
         else command.sub(":", "::").underscore.camelize
         end
       end
@@ -57,7 +56,6 @@ module CC
       def command
         @args.first
       end
-
     end
   end
 end

data/lib/cc/cli/version.rb

@@ -6,6 +6,7 @@ module CC
       end
 
       private
+
       def version
         path = File.expand_path("../../../../VERSION", __FILE__)
         @version ||= File.read(path)

data/lib/file_utils_ext.rb

@@ -1,4 +1,4 @@
-require 'fileutils'
+require "fileutils"
 
 module FileUtils
   def self.readable_by_all?(path)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate
 version: !ruby/object:Gem::Version
-  version: 0.9.7
+  version: 0.10.0
 platform: ruby
 authors:
 - Code Climate
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-27 00:00:00.000000000 Z
+date: 2015-10-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport