codeclimate-test-reporter 0.4.6 → 0.4.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d6cb4bd493e9044da7771edbc3eb80ac49035b29
-  data.tar.gz: af1b2bfb800eea09cf7488dedc1f3c61e5615e40
+  metadata.gz: 3d80115d91ce3bf26fef3af83ae706d0189e23f4
+  data.tar.gz: ba43164b6d9949e4ee9e3906bc4508081f08c15b
 SHA512:
-  metadata.gz: ac5031cb96a6ac7deda24bbb6d029e28bf096dec535a911e16cdfd3a846087e28db1f9f652e7f9de7e7299d3f37f0d6d3479e26981073663fca5ef51d47e47dd
-  data.tar.gz: b932b84c1c80fb03abd9297604caa1c038ecc442904481189af49d0e644b02838c70c736b3d13f22182460b5aa26a7e675d3561c1752eb04940aeae24c3a1ffe
+  metadata.gz: 0ec8e55c4755c63dec00a679770f00aa8b9a908aef572dd8a5aa9fce8752dfc74f4b32214c79b0668dc33cc7bec00a1432abb2bfce81b3b3755510182a7ea267
+  data.tar.gz: aeccf37e8ba8c7af1ee8edcf65185135bc5333f45e666e2af733b2e9778db70db77ca324440009150ec568cdfb4d639eb5260c21337b5cc1ac0d91ffd30fd63f

data/lib/code_climate/test_reporter/git.rb

@@ -45,7 +45,7 @@ module CodeClimate
         end
 
         def git(command)
-          `git --git-dir=#{git_dir}/.git #{command}`
+          `git --git-dir="#{git_dir}/.git" #{command}`
         end
 
         def git_dir
@@ -58,7 +58,7 @@ module CodeClimate
         end
 
         def rails_git_dir_present?
-          defined?(Rails) && !Rails.root.nil? &&
+          const_defined?(:Rails) && Rails.respond_to?(:root) && !Rails.root.nil? &&
             File.directory?(File.expand_path('.git', Rails.root))
         end
       end

data/lib/code_climate/test_reporter/version.rb

@@ -1,5 +1,5 @@
 module CodeClimate
   module TestReporter
-    VERSION = "0.4.6"
+    VERSION = "0.4.7"
   end
 end

data/spec/lib/git_spec.rb

@@ -14,6 +14,50 @@ module CodeClimate::TestReporter
       end
     end
 
+    describe 'git' do
+      it 'should quote the git repository directory' do
+        path = '/path/to/foo bar'
+
+        allow(CodeClimate::TestReporter.configuration).to receive(:git_dir).and_return path
+        expect(Git).to receive(:`).once.with "git --git-dir=\"#{path}/.git\" help"
+
+        Git.send :git, 'help'
+      end
+
+      context 'ensure logic that replies on Rails is robust in non-rails environments' do
+        before :all do
+          module ::Rails; end
+        end
+
+        after :all do
+          Object.send(:remove_const, :Rails)
+        end
+
+        after :each do
+          Git.send :git, 'help'
+        end
+
+        it 'will check if constant Rails is defined' do
+          expect(Git).to receive(:configured_git_dir).once.and_return(nil)
+        end
+
+        it 'will not call method "root" (a 3rd time) if constant Rails is defined but does not respond to root' do
+          expect(Git).to receive(:configured_git_dir).once.and_return(nil)
+          expect(Rails).to receive(:root).twice.and_return('/path')
+        end
+
+        it 'will call rails root if constant Rails is defined and root method is defined' do
+          module ::Rails
+            def self.root
+              '/path'
+            end
+          end
+          expect(Git).to receive(:configured_git_dir).once.and_return(nil)
+          expect(Rails).to receive(:root).twice.and_return('/path')
+        end
+      end
+    end
+
     describe 'branch_from_git_or_ci' do
       it 'returns the branch from ci' do
         allow(Ci).to receive(:service_data).and_return({branch: 'ci-branch'})

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate-test-reporter
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors:
 - Bryan Helmkamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-22 00:00:00.000000000 Z
+date: 2015-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: simplecov