codeclimate-services 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 284a96fe4285fcc34d367b9dd24abdf4cb51b43a
-  data.tar.gz: e60dd3be41f2ed70a13602b260a4f7364c7b9656
+  metadata.gz: e927c485d5023eb5431b788445cfe75fe27320ae
+  data.tar.gz: a4407d4b1c9cdd98d4c795e771848046e888e92a
 SHA512:
-  metadata.gz: 7e33711b3282b2870de63ef36e7fe520ebe7276949c44fd33f020a84eb30fb0afa4dfeec7113d939b6921f7d96e1ca2cbf26d0aa1e7b4830ae8f137c5bd91ab1
-  data.tar.gz: 44d1e4c810e0392b32ba9aadb6cd79bf963bb67d227607340ca1620728e7c47c4e8fcd30be328e9177d57d23cf705a6e8f1b7ec530a43556eccd167a36e99842
+  metadata.gz: 7dcbe79bc6a2ae60dda8636fdde2c5fadae2c29274c931e43bec38efd22cf4e809051248fd4b3cb0c93f6e02f27273bac4365c16c202f503b2a141604003e13b
+  data.tar.gz: 3df6b8145d1bfcd49595420111532c66f119c2fc528b1336aa95c2f4383d709199c26ff3a69ffdffd0bfdd122557b8bd71755055477f93b1a53202d62eef768d

data/lib/cc/services/asana.rb

@@ -54,7 +54,7 @@ class CC::Service::Asana < CC::Service
 
 private
 
-  def create_task(name, notes = nil)
+  def create_task(name, notes = "")
     params = generate_params(name, notes)
     authenticate_http
     http.headers["Content-Type"] = "application/json"

data/lib/cc/services/github_pull_requests.rb

@@ -7,7 +7,8 @@ class CC::Service::GitHubPullRequests < CC::Service
       description: "A personal OAuth token with permissions for the repo."
     attribute :update_status, Axiom::Types::Boolean,
       label: "Update status?",
-      description: "Update the pull request status after analyzing?"
+      description: "Update the pull request status after analyzing?",
+      default: true
     attribute :base_url, Axiom::Types::String,
       label: "Github API Base URL",
       description: "Base URL for the Github API",

data/lib/cc/services/version.rb

@@ -1,5 +1,5 @@
 module CC
   module Services
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

data/test/asana_test.rb

@@ -58,7 +58,7 @@ class TestAsana < CC::Service::TestCase
 
   private
 
-  def assert_asana_receives(event_data, name, notes = nil)
+  def assert_asana_receives(event_data, name, notes = "")
     @stubs.post '/api/1.0/tasks' do |env|
       body = JSON.parse(env[:body])
       data = body["data"]

data/test/github_pull_requests_test.rb

@@ -103,7 +103,7 @@ class TestGitHubPullRequests < CC::Service::TestCase
   def test_no_status_update_for_skips_when_update_status_config_is_falsey
     # With no POST expectation, test will fail if request is made.
 
-    receive_pull_request({}, {
+    receive_pull_request({ update_status: false }, {
       github_slug: "pbrisbin/foo",
       commit_sha:  "abc123",
       state:       "skipped",
@@ -113,7 +113,7 @@ class TestGitHubPullRequests < CC::Service::TestCase
   def test_no_status_update_for_pending_when_update_status_config_is_falsey
     # With no POST expectation, test will fail if request is made.
 
-    receive_pull_request({}, {
+    receive_pull_request({ update_status: false }, {
       github_slug: "pbrisbin/foo",
       commit_sha:  "abc123",
       state:       "pending",
@@ -123,7 +123,7 @@ class TestGitHubPullRequests < CC::Service::TestCase
   def test_no_status_update_for_error_when_update_status_config_is_falsey
     # With no POST expectation, test will fail if request is made.
 
-    receive_pull_request({}, {
+    receive_pull_request({ update_status: false }, {
       github_slug: "pbrisbin/foo",
       commit_sha:  "abc123",
       state:       "error",
@@ -158,7 +158,7 @@ class TestGitHubPullRequests < CC::Service::TestCase
   end
 
   def test_pull_request_nothing_happened
-    response = receive_pull_request({}, { state: "success" })
+    response = receive_pull_request({ update_status: false }, { state: "success" })
 
     assert_equal({ ok: false, message: "Nothing happened" }, response)
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: codeclimate-services
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Bryan Helmkamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-15 00:00:00.000000000 Z
+date: 2016-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday