code_ownership 1.32.6 → 1.32.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 51a1c1b52a35af9d0c7c7a48101ccd18cd120577bfd038ce83e6552e8b40e878
-  data.tar.gz: dc7ed2634d7adf107d59b4a4d9480429894e168b203c9ddc12767743ba52e12e
+  metadata.gz: 76d700471a2e895926f184939c856b08ac75d5240a0d924a8e4474ac733a7204
+  data.tar.gz: 3b62947009df98089b522614022643762c4c51d82af4f90f957606bcedfe60bc
 SHA512:
-  metadata.gz: 0aa8dd88901d526386ea1f3aae175f013e32e77cbfe7e36b2113ea8c3efccc4e8950f12f09bb01f9b3756a8de9cbe03ae470eee8de5a8bf64d599e8dab1eebf1
-  data.tar.gz: be6d7103274d1c628db0d28d1497b62364b5998540ba5e69bcd6ba0d9c2a5d5f834fe3b7aaa70654db7cfb9bbbd3af88c3c1ac9b055de0cf8475d1a9971f1435
+  metadata.gz: df833467c3721e6b7d67aebd0732d59c46073589210251bd0859cb05979103741876264dd336df10401005360bca7a2937c65e861044b22abd698a2b8b65a20d
+  data.tar.gz: 1b8f489aa18295cd8c534f3d5bcb3e2ab569553f26ec7e5a9445faff90da3aee3860bd3d7a02d6e91b80815d65b96680b0f54b085770ba85a54efa13aa0109b1

data/lib/code_ownership/private/codeowners_file.rb

@@ -56,14 +56,15 @@ module CodeOwnership
           ownership_map_cache.each do |path, code_team|
             team_mapping = github_team_map[code_team.name]
             next if team_mapping.nil?
-            next if ignored_teams.include?(code_team.name)
-            entry = "/#{path} #{team_mapping}"
-            # In order to use the codeowners file as a proper cache, we'll need to insert commented out entries for ignored teams
-            # entry = if ignored_teams.include?(code_team.name)
-            #   "# /#{path} #{team_mapping}"
-            # else
-            #   "/#{path} #{team_mapping}"
-            # end
+
+            # Leaving a commented out entry has two major benefits:
+            # 1) It allows the CODEOWNERS file to be used as a cache for validations
+            # 2) It allows users to specifically see what their team will not be notified about.
+            entry = if ignored_teams.include?(code_team.name)
+              "# /#{path} #{team_mapping}"
+            else
+              "/#{path} #{team_mapping}"
+            end
             ownership_entries << entry
           end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_ownership
 version: !ruby/object:Gem::Version
-  version: 1.32.6
+  version: 1.32.7
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-04-10 00:00:00.000000000 Z
+date: 2023-04-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_teams