code_driven_development 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c144f5b085c9dd8d557b3603539d0d48d20a9e7b
-  data.tar.gz: d3efd3ac64d9c9ce5f68d26db313468dc75705db
+  metadata.gz: b09b6d5336aaa29537662229c0c204572ee2e81d
+  data.tar.gz: 610a995a3c9012fbd5d6ff374b096793e6fbf259
 SHA512:
-  metadata.gz: 59908017bb8718d06e375823a82cc6e621492748ce239b588b0bdf163f66957c206a35cd29742ebd8286cb7f595480427e676f832758976f4af1bfc12e94fe9d
-  data.tar.gz: 743edeb664f209fcfc5aec2c827b7b9a899a57b1c8a2308b6d6c2a73e3122553d8bb50bee47dbb9daff1988c22822c516551971beacdca031971feaae5d3d761
+  metadata.gz: e83e416be1af608df38ae343b34e7c10dc6775a98f8b3290348eeb4bc4634a83c39beb0aaca10498697ba8761ef89672ff7985f021ee5ee6754b5522af94884d
+  data.tar.gz: 900dd1f8ce764b77eec4126e39d66d5c5d2028696bd24a3cb7d6d7ef749f9d631408639bd0c30bb672413c481c724506398264343bbb7f43907f49bade1c3076

data/README.md

@@ -13,6 +13,7 @@ class Bunker < ActiveRecord::Base
   end
 
   def alert_president
+    alert_staff
     SecretService.stand_down
     President.alert
   end
@@ -22,25 +23,32 @@ end
 And this is what CDD thinks of it:
 
 ``` ruby
+
 describe Bunker do
   it { should validate_secure_of :password }
   it { should validate_protected_of :location }
-  
+
   describe "#alert_staff" do
+    let(:obj) { described_class.new }
     before do
       allow(Staff).to receive :alert_all
-      described_class.new.alert_staff
+      obj.alert_staff
     end
     it "calls Staff.alert_all" do
       expect(Staff).to have_received :alert_all
     end
   end
-  
+
   describe "#alert_president" do
+    let(:obj) { described_class.new }
     before do
+      allow(obj).to receive :alert_staff
       allow(SecretService).to receive :stand_down
       allow(President).to receive :alert
-      described_class.new.alert_president
+      obj.alert_president
+    end
+    it "calls #alert_staff" do
+      expect(obj).to have_received :alert_staff
     end
     it "calls SecretService.stand_down" do
       expect(SecretService).to have_received :stand_down

data/code_driven_development.gemspec

@@ -23,4 +23,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "pry"
 end

data/lib/code_driven_development.rb

@@ -8,10 +8,12 @@ require "code_driven_development/test_component/test"
 require "code_driven_development/test_component/one_line_test"
 require "code_driven_development/test_component/context"
 require "code_driven_development/test_component/blank_slate"
+require "code_driven_development/test_component/let"
 
 require "code_driven_development/rule/abstract_rule"
 require "code_driven_development/rule/set"
-require "code_driven_development/rule/method_call"
+require "code_driven_development/rule/constant_method_call"
+require "code_driven_development/rule/instance_method_call"
 require "code_driven_development/rule/default"
 require "code_driven_development/rule/class"
 require "code_driven_development/rule/validation"

data/lib/code_driven_development/code_driven_development.rb

@@ -23,7 +23,8 @@ module CodeDrivenDevelopment
         Rule::Class,
         Rule::Validation,
         Rule::InstanceMethod,
-        Rule::MethodCall,
+        Rule::ConstantMethodCall,
+        Rule::InstanceMethodCall,
         default: Rule::Default
       )
     end

data/lib/code_driven_development/rule/constant_method_call.rb

@@ -0,0 +1,35 @@
+module CodeDrivenDevelopment
+  module Rule
+    class ConstantMethodCall < AbstractRule
+      def capable?
+        code.sexp_type == :call &&
+          method_name != :validate &&
+          receiver_type == :const
+      end
+
+      def test
+        test_context.befores << "allow(#{receiver_value}).to receive :#{method_name}"
+        body = ["expect(#{receiver_value}).to have_received :#{method_name}"]
+        test_context << TestComponent::Test.new("calls #{receiver_value}.#{method_name}", body)
+      end
+
+      private
+
+      def receiver_value
+        receiver.value
+      end
+
+      def receiver_type
+        receiver && receiver.sexp_type
+      end
+
+      def receiver
+        code[1]
+      end
+
+      def method_name
+        code[2]
+      end
+    end
+  end
+end

data/lib/code_driven_development/rule/instance_method.rb

@@ -11,7 +11,8 @@ module CodeDrivenDevelopment
         test_context << new_context
 
         # Do this last so that the method invocation is the last line in the before.
-        new_context.befores << "described_class.new.#{method_name}"
+        new_context.befores << "obj.#{method_name}"
+        new_context.lets << TestComponent::Let.new(:obj, "described_class.new")
       end
 
       private

data/lib/code_driven_development/rule/instance_method_call.rb

@@ -0,0 +1,35 @@
+module CodeDrivenDevelopment
+  module Rule
+    class InstanceMethodCall < AbstractRule
+      def capable?
+        code.sexp_type == :call &&
+          method_name != :validate &&
+          receiver_type.nil?
+      end
+
+      def test
+        test_context.befores << "allow(#{receiver_value}).to receive :#{method_name}"
+        body = ["expect(#{receiver_value}).to have_received :#{method_name}"]
+        test_context << TestComponent::Test.new("calls ##{method_name}", body)
+      end
+
+      private
+
+      def receiver_value
+        "obj"
+      end
+
+      def receiver_type
+        receiver && receiver.sexp_type
+      end
+
+      def receiver
+        code[1]
+      end
+
+      def method_name
+        code[2]
+      end
+    end
+  end
+end

data/lib/code_driven_development/test_component/context.rb

@@ -1,11 +1,11 @@
 module CodeDrivenDevelopment
   module TestComponent
     class Context
-      def initialize(description = nil, befores = [], tests = [])
-        @description, @befores, @tests = description, befores, tests
+      def initialize(description = nil, befores = [], tests = [], lets = [])
+        @description, @befores, @tests, @lets = description, befores, tests, lets
       end
 
-      attr_reader :tests, :befores
+      attr_reader :tests, :befores, :lets
       attr_accessor :description
 
       def << child
@@ -16,6 +16,9 @@ module CodeDrivenDevelopment
         io << ""
         io << "describe #@description do"
         io.indented do
+          lets.each do |let|
+            let.indented_output(io)
+          end
           if befores.any?
             io << "before do"
             io.indented do

data/lib/code_driven_development/test_component/let.rb

@@ -0,0 +1,13 @@
+module CodeDrivenDevelopment
+  module TestComponent
+    class Let
+      def initialize(name, value)
+        @name, @value = name, value
+      end
+
+      def indented_output(io)
+        io << "let(:#@name) { #@value }"
+      end
+    end
+  end
+end

data/lib/code_driven_development/version.rb

@@ -1,3 +1,3 @@
 module CodeDrivenDevelopment
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/samples/{validations.rb → president.rb}

@@ -7,6 +7,7 @@ class Bunker < ActiveRecord::Base
   end
 
   def alert_president
+    alert_staff
     SecretService.stand_down
     President.alert
   end

data/spec/my_spec.rb

@@ -9,6 +9,14 @@ describe CodeDrivenDevelopment::CodeDrivenDevelopment do
         def i_call_things
           CentralBureaucracy.file_report
         end
+
+        def i_call_instance_methods
+          meth
+        end
+
+        def weigh_options
+          should_i_stay || should_i_go
+        end
       end
     EOT
 
@@ -23,14 +31,42 @@ describe CodeDrivenDevelopment::CodeDrivenDevelopment do
     expect(@test).to match /^\tit.*should.*validate_presence_of.*:cuteness/
   end
 
-  it "stubs out method calls" do
+  it "stubs out method calls to constants" do
     expect(@test).to have_consecutive_lines_matching [
       /^\tdescribe.*"#i_call_things"/,
       /^\t\tbefore/,
       /^\t\t\tallow.CentralBureaucracy..to.*receive.*:file_report/,
-      /^\t\t\tdescribed_class.new.i_call_things/,
+      /^\t\t\tobj.i_call_things/,
       /^\t\tit.*calls Central.*do/,
       /^\t\t\texpect.CentralBureaucracy..to.*have_received.*:file_report/
     ]
   end
+
+  it "stubs out instance method calls" do
+    expect(@test).to have_consecutive_lines_matching [
+      /^\tdescribe.*"#i_call_instance_methods"/,
+      /^\t\tlet.:obj.*described_class.new/,
+      /^\t\tbefore/,
+      /^\t\t\tallow.obj..to.*receive.*:meth/,
+      /^\t\t\tobj.i_call_instance_methods/,
+      /^\t\tit.*calls #meth.*do/,
+      /^\t\t\texpect.obj..to.*have_received.*:meth/
+    ]
+  end
+
+  it "handles ORs with aplomb" do
+    expect(@test).to have_consecutive_lines_matching [
+      /^\tdescribe.*"#weigh_options"/,
+      /^\t\tlet.:obj.*described_class.new/,
+      /^\t\tbefore/,
+      /^\t\t\tallow.obj..to.*receive.*:should_i_stay/,
+      /^\t\t\tallow.obj..to.*receive.*:should_i_go/,
+      /^\t\tcontext.*when.*should_i_stay.*truthy/,
+      /^\t\tbefore do/,
+      /^\t\t\t
+      /^\t\t\tobj.weigh_options/,
+      /^\t\tit.*calls #meth.*do/,
+      /^\t\t\texpect.obj..to.*have_received.*:meth/
+    ]
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_driven_development
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Dan Finnie
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-02 00:00:00.000000000 Z
+date: 2014-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby_parser
@@ -66,6 +66,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Automatically generate stubby tests from your implementation.
 email:
 - dan@danfinnie.com
@@ -87,17 +101,19 @@ files:
 - lib/code_driven_development/indented_output.rb
 - lib/code_driven_development/rule/abstract_rule.rb
 - lib/code_driven_development/rule/class.rb
+- lib/code_driven_development/rule/constant_method_call.rb
 - lib/code_driven_development/rule/default.rb
 - lib/code_driven_development/rule/instance_method.rb
-- lib/code_driven_development/rule/method_call.rb
+- lib/code_driven_development/rule/instance_method_call.rb
 - lib/code_driven_development/rule/set.rb
 - lib/code_driven_development/rule/validation.rb
 - lib/code_driven_development/test_component/blank_slate.rb
 - lib/code_driven_development/test_component/context.rb
+- lib/code_driven_development/test_component/let.rb
 - lib/code_driven_development/test_component/one_line_test.rb
 - lib/code_driven_development/test_component/test.rb
 - lib/code_driven_development/version.rb
-- samples/validations.rb
+- samples/president.rb
 - spec/my_spec.rb
 - spec/spec_helper.rb
 - spec/support/have_consecutive_lines_matching_matcher.rb

data/lib/code_driven_development/rule/method_call.rb

@@ -1,26 +0,0 @@
-module CodeDrivenDevelopment
-  module Rule
-    class MethodCall < AbstractRule
-      def capable?
-        code.sexp_type == :call &&
-          method_name != :validate
-      end
-
-      def test
-        test_context.befores << "allow(#{receiver}).to receive :#{method_name}"
-        body = ["expect(#{receiver}).to have_received :#{method_name}"]
-        test_context << TestComponent::Test.new("calls #{receiver}.#{method_name}", body)
-      end
-
-      private
-
-      def receiver
-        code[1].value
-      end
-
-      def method_name
-        code[2]
-      end
-    end
-  end
-end