code_analyzer 0.5.1 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 792496737344902c984457c4a153f5e7e5717e7f9568f130cdc039c1779e9627
-  data.tar.gz: 8b15a24c9ede966353b1100328fe1d5dcc14937fc6d2a4401a455cfe42176d27
+  metadata.gz: 5a68561649e1e345495d4a494530dc7abb9ca256dc5a999d1aa71b1c567b0e66
+  data.tar.gz: d21414e33aa72bbb23571985b9eaa00e177057f7781cbb3f1398476119f38c69
 SHA512:
-  metadata.gz: 2bd9cd8d09ffaab831f417207e0003082408ddb61e8a513884a0d137adb567c1c6f3aed5f68d2460d58a5799ef56a514cb49af4d1c5f2b92b017500193709e54
-  data.tar.gz: dd4bf2b587ca333c7eeabcd088586eeebc421c9e41931d1637a7dd0bb3f1b403959b95c0cc697eb81cd6d818e198f4648b1fc8e1d585c8896600f528ec2511fe
+  metadata.gz: 99369336e083dd38d76e7436ee9d824565108760339d3da59b057649341917da4649e68c78f01a29ba45c09c95a2ca71c1b2392d9c2a252826cb81abb2580131
+  data.tar.gz: cbba861e5caa35dcd4a0e887159ae0a14bb166a21f2b0bb8b5e33f188c346f9b71b6b11bbee253e9ee2b18b4fc7be039801d438168d43d00b4f007b0541698d8

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.6.4
+  - 2.6.6
+  - 2.7.1

data/code_analyzer.gemspec

@@ -1,4 +1,5 @@
-# -*- encoding: utf-8 -*-
+# frozen_string_literal: true
+
 require File.expand_path('../lib/code_analyzer/version', __FILE__)
 
 Gem::Specification.new do |gem|

data/lib/code_analyzer.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require 'ripper'
 require 'code_analyzer/version'
 require 'code_analyzer/nil'

data/lib/code_analyzer/analyzer_exception.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer
   class AnalyzerException < Exception; end
 end

data/lib/code_analyzer/checker.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer
   # A checker class that takes charge of checking the sexp.
   class Checker
@@ -28,8 +29,7 @@ module CodeAnalyzer
     # @param [Sexp] node
     def node_start(node)
       @node = node
-      self.class.get_callbacks("start_#{node.sexp_type}".to_sym)
-        .each { |block| self.instance_exec(node, &block) }
+      self.class.get_callbacks("start_#{node.sexp_type}".to_sym).each { |block| self.instance_exec(node, &block) }
     end
 
     # delegate to end_### according to the sexp_type, like
@@ -40,9 +40,7 @@ module CodeAnalyzer
     # @param [Sexp] node
     def node_end(node)
       @node = node
-      self.class.get_callbacks("end_#{node.sexp_type}".to_sym).each do |block|
-        self.instance_exec(node, &block)
-      end
+      self.class.get_callbacks("end_#{node.sexp_type}".to_sym).each { |block| self.instance_exec(node, &block) }
     end
 
     # add an warning.
@@ -50,13 +48,8 @@ module CodeAnalyzer
     # @param [String] message, is the warning message
     # @param [String] filename, is the filename of source code
     # @param [Integer] line_number, is the line number of the source code which is reviewing
-    def add_warning(
-      message, filename = @node.file, line_number = @node.line_number
-    )
-      warnings <<
-        Warning.new(
-          filename: filename, line_number: line_number, message: message
-        )
+    def add_warning(message, filename = @node.file, line_number = @node.line_number)
+      warnings << Warning.new(filename: filename, line_number: line_number, message: message)
     end
 
     # all warnings.

data/lib/code_analyzer/checking_visitor.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer
   module CheckingVisitor
     autoload :Base, 'code_analyzer/checking_visitor/base'

data/lib/code_analyzer/checking_visitor/base.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer::CheckingVisitor
   # Base class for checking visitor.
   class Base

data/lib/code_analyzer/checking_visitor/default.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer::CheckingVisitor
   # This is the default checking visitor to check ruby sexp nodes.
   class Default < Base
@@ -39,9 +40,7 @@ module CodeAnalyzer::CheckingVisitor
     def parse(filename, content)
       Sexp.from_array(Ripper::SexpBuilder.new(content).parse)
     rescue Exception
-      raise AnalyzerException.new(
-              "#{filename} looks like it's not a valid Ruby file.  Skipping..."
-            )
+      raise AnalyzerException.new("#{filename} looks like it's not a valid Ruby file.  Skipping...")
     end
 
     # recursively check ruby sexp node.
@@ -51,20 +50,14 @@ module CodeAnalyzer::CheckingVisitor
     # 3. it triggers the interesting checkers' end callbacks.
     def check_node(node)
       checkers = @checks[node.sexp_type]
-      if checkers
-        checkers.each do |checker|
-          checker.node_start(node) if checker.parse_file?(node.file)
-        end
-      end
+
+      checkers.each { |checker| checker.node_start(node) if checker.parse_file?(node.file) } if checkers
       node.children.each do |child_node|
         child_node.file = node.file
         check_node(child_node)
       end
-      if checkers
-        checkers.each do |checker|
-          checker.node_end(node) if checker.parse_file?(node.file)
-        end
-      end
+
+      checkers.each { |checker| checker.node_end(node) if checker.parse_file?(node.file) } if checkers
     end
   end
 end

data/lib/code_analyzer/checking_visitor/plain.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer::CheckingVisitor
   # This is the checking visitor to check ruby plain code.
   class Plain < Base
@@ -7,9 +8,7 @@ module CodeAnalyzer::CheckingVisitor
     # @param [String] filename is the filename of ruby code.
     # @param [String] content is the content of ruby file.
     def check(filename, content)
-      @checkers.each do |checker|
-        checker.check(filename, content) if checker.parse_file?(filename)
-      end
+      @checkers.each { |checker| checker.check(filename, content) if checker.parse_file?(filename) }
     end
   end
 end

data/lib/code_analyzer/nil.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer
   # Fake nil.
   class Nil

data/lib/code_analyzer/sexp.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 require 'sexp'
 
 class Sexp
@@ -13,21 +14,23 @@ class Sexp
   #
   #     s(:@ident, "test", s(2, 12)
   #       => 2
+
   def line_number
     case sexp_type
-    when :def, :defs, :command, :command_call, :call, :fcall, :method_add_arg, :method_add_block,
-         :var_ref, :vcall, :const_ref, :const_path_ref, :class, :module, :if, :unless,
-         :elsif, :ifop, :if_mod, :unless_mod, :binary, :alias, :symbol_literal, :symbol,
-         :aref, :hash, :assoc_new, :string_literal, :massign, :var_field
+    when :def, :defs, :command, :command_call, :call, :fcall, :method_add_arg, :method_add_block, :var_ref, :vcall,
+         :const_ref, :top_const_ref, :const_path_ref, :class, :module, :if, :unless, :elsif, :ifop, :if_mod, :unless_mod, :binary, :alias,
+         :symbol_literal, :symbol, :aref, :hash, :assoc_new, :string_literal, :massign, :var_field, :assign, :paren, :dot2, :dot3
       self[1].line_number
     when :assoclist_from_args, :bare_assoc_hash
       self[1][0].line_number
-    when :string_add, :opassign
+    when :string_add, :opassign, :unary, :stmts_add
       self[2].line_number
     when :array
       array_values.first.line_number
     when :mlhs_add
       self.last.line_number
+    when :params
+      self[1][0].line_number if self[1].is_a? Array
     else
       self.last.first if self.last.is_a? Array
     end
@@ -68,45 +71,16 @@ class Sexp
     to_s = options[:to_s]
     self.recursive_children do |child|
       if (
-         !sexp_type ||
-           (
-             if sexp_type.is_a?(Array)
-               sexp_type.include?(child.sexp_type)
-             else
-               sexp_type == child.sexp_type
-             end
-           )
-       ) &&
-         (
-           !receiver ||
-             (
-               if receiver.is_a?(Array)
-                 receiver.include?(child.receiver.to_s)
-               else
-                 receiver == child.receiver.to_s
-               end
-             )
-         ) &&
-         (
-           !message ||
-             (
-               if message.is_a?(Array)
-                 message.include?(child.message.to_s)
-               else
-                 message == child.message.to_s
-               end
-             )
+           !sexp_type || (sexp_type.is_a?(Array) ? sexp_type.include?(child.sexp_type) : sexp_type == child.sexp_type)
          ) &&
-         (
-           !to_s ||
-             (
-               if to_s.is_a?(Array)
-                 to_s.include?(child.to_s)
-               else
-                 to_s == child.to_s
-               end
-             )
-         )
+           (
+             !receiver ||
+               (receiver.is_a?(Array) ? receiver.include?(child.receiver.to_s) : receiver == child.receiver.to_s)
+           ) &&
+           (
+             !message || (message.is_a?(Array) ? message.include?(child.message.to_s) : message == child.message.to_s)
+           ) &&
+           (!to_s || (to_s.is_a?(Array) ? to_s.include?(child.to_s) : to_s == child.to_s))
         yield child
       end
     end
@@ -391,14 +365,12 @@ class Sexp
   def all_conditions
     nodes = []
     if :binary == sexp_type && %w[&& || and or].include?(self[2].to_s)
-      if :binary == self[1].sexp_type &&
-         %w[&& || and or].include?(self[1][2].to_s)
+      if :binary == self[1].sexp_type && %w[&& || and or].include?(self[1][2].to_s)
         nodes += self[1].all_conditions
       else
         nodes << self[1]
       end
-      if :binary == self[3].sexp_type &&
-         %w[&& || and or].include?(self[3][2].to_s)
+      if :binary == self[3].sexp_type && %w[&& || and or].include?(self[3][2].to_s)
         nodes += self[3].all_conditions
       else
         nodes << self[3]
@@ -418,6 +390,7 @@ class Sexp
   #         => s(:@ident, "show", s(1, 4)),
   #
   # @return [Sexp] method name node
+
   def method_name
     case sexp_type
     when :def
@@ -455,6 +428,7 @@ class Sexp
   #            )
   #
   # @return [Sexp] body node
+
   def body
     case sexp_type
     when :else
@@ -571,6 +545,7 @@ class Sexp
   def exception_classes
     if :rescue == sexp_type
       return [] unless self[1]
+
       if :mrhs_add == self[1].sexp_type
         exceptions = Array.new(self[1][2])
         arg_nodes = self[1][1][1]
@@ -621,11 +596,8 @@ class Sexp
       else
 
       end
-    if pair_nodes
-      pair_nodes.size.times do |i|
-        return pair_nodes[i][2] if key == pair_nodes[i][1].to_s
-      end
-    end
+
+    pair_nodes.size.times { |i| return pair_nodes[i][2] if key == pair_nodes[i][1].to_s } if pair_nodes
     CodeAnalyzer::Nil.new
   end
 
@@ -734,12 +706,9 @@ class Sexp
       if first_node
         while true
           array_size += 1
-          first_node =
-            s(:args_new) == first_node[1] ? first_node[2] : first_node[1]
+          first_node = s(:args_new) == first_node[1] ? first_node[2] : first_node[1]
           if :args_add != first_node.sexp_type
-            if :array == first_node.sexp_type
-              array_size += first_node.array_size
-            end
+            array_size += first_node.array_size if :array == first_node.sexp_type
             break
           end
         end
@@ -765,13 +734,9 @@ class Sexp
   def array_values
     case sexp_type
     when :array
-      if nil == self[1] ||
-         %i[words_new qwords_new symbols_new qsymbols_new].include?(
-           self[1].sexp_type
-         )
+      if nil == self[1] || %i[words_new qwords_new symbols_new qsymbols_new].include?(self[1].sexp_type)
         []
-      elsif %i[words_add qwords_add symbols_add qsymbols_add].include? self[1]
-                                                                    .sexp_type
+      elsif %i[words_add qwords_add symbols_add qsymbols_add].include? self[1].sexp_type
         self[1].array_values
       else
         arguments.all
@@ -780,12 +745,10 @@ class Sexp
       values = []
       node = self
       while true
-        if %i[words_add qwords_add symbols_add qsymbols_add].include? node
-                                                                   .sexp_type
+        if %i[words_add qwords_add symbols_add qsymbols_add].include? node.sexp_type
           values.unshift node[2]
           node = node[1]
-        elsif %i[words_new qwords_new symbols_new qsymbols_new].include? node
-                                                                      .sexp_type
+        elsif %i[words_new qwords_new symbols_new qsymbols_new].include? node.sexp_type
           break
         end
       end
@@ -842,9 +805,8 @@ class Sexp
   # @return [String] to_s
   def to_s
     case sexp_type
-    when :string_literal, :xstring_literal, :string_content, :const_ref,
-         :symbol_literal, :symbol, :args_add_block, :var_ref, :vcall, :var_field,
-         :@ident, :@tstring_content, :@const, :@ivar, :@kw, :@gvar, :@cvar, :@period
+    when :string_literal, :xstring_literal, :string_content, :const_ref, :symbol_literal, :symbol, :args_add_block, :var_ref,
+         :vcall, :var_field, :@ident, :@tstring_content, :@const, :@ivar, :@kw, :@gvar, :@cvar, :@period
       self[1].to_s
     when :string_add
       s(:string_content) == self[1] ? self[2].to_s : self[1].to_s
@@ -871,11 +833,7 @@ class Sexp
 
   # check if the self node is a const.
   def const?
-    :@const == self.sexp_type ||
-      (
-        %i[var_ref vcall].include?(self.sexp_type) &&
-          :@const == self[1].sexp_type
-      )
+    :@const == self.sexp_type || (%i[var_ref vcall].include?(self.sexp_type) && :@const == self[1].sexp_type)
   end
 
   # true
@@ -892,14 +850,10 @@ class Sexp
   def remove_line_and_column
     node = self.clone
     last_node = node.last
-    if Sexp === last_node && last_node.size == 2 &&
-       last_node.first.is_a?(Integer) &&
-       last_node.last.is_a?(Integer)
+    if Sexp === last_node && last_node.size == 2 && last_node.first.is_a?(Integer) && last_node.last.is_a?(Integer)
       node.delete_at(-1)
     end
-    node.sexp_body.each_with_index do |child, index|
-      node[index + 1] = child.remove_line_and_column if Sexp === child
-    end
+    node.sexp_body.each_with_index { |child, index| node[index + 1] = child.remove_line_and_column if Sexp === child }
     node
   end
 
@@ -922,9 +876,7 @@ class Sexp
     class_eval <<-EOS
       alias_method :origin_#{method}, :#{method}
 
-      def #{
-      method
-    }
+      def #{method}
         ret = origin_#{
       method
     }

data/lib/code_analyzer/version.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer
-  VERSION = '0.5.1'
+  VERSION = '0.5.2'
 end

data/lib/code_analyzer/warning.rb

@@ -1,4 +1,5 @@
-# encoding: utf-8
+# frozen_string_literal: true
+
 module CodeAnalyzer
   # Warning is the violation.
   #

data/spec/code_analyzer/checker_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module CodeAnalyzer
@@ -28,16 +30,12 @@ module CodeAnalyzer
 
     context '#parse_file?' do
       it 'should return true if node_file matches pattern' do
-        allow(checker).to receive(:interesting_files).and_return(
-          [%r{spec\/.*\.rb}, %r{lib\/.*\.rb}]
-        )
+        allow(checker).to receive(:interesting_files).and_return([%r{spec\/.*\.rb}, %r{lib\/.*\.rb}])
         expect(checker.parse_file?('lib/code_analyzer.rb')).to be true
       end
 
       it "should return false if node_file doesn't match pattern" do
-        allow(checker).to receive(:interesting_files).and_return(
-          [%r{spec\/.*\.rb}]
-        )
+        allow(checker).to receive(:interesting_files).and_return([%r{spec\/.*\.rb}])
         expect(checker.parse_file?('lib/code_analyzer.rb')).to be false
       end
     end

data/spec/code_analyzer/checking_visitor/base_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module CodeAnalyzer

data/spec/code_analyzer/checking_visitor/default_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module CodeAnalyzer::CheckingVisitor

data/spec/code_analyzer/checking_visitor/plain_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module CodeAnalyzer::CheckingVisitor

data/spec/code_analyzer/nil_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module CodeAnalyzer

data/spec/code_analyzer/sexp_spec.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Sexp do
-  describe 'line' do
+  describe 'line_number' do
     before :each do
       content = <<-EOF
       class Demo
@@ -18,9 +20,12 @@ describe Sexp do
         end
         def condition
           if success?
-            puts "unknown" if output?
+            puts "unknown" if !output?
           elsif fail?
+            1..2
+            3...4
           end
+          pp ::Rails.application
         end
       end
       EOF
@@ -39,6 +44,10 @@ describe Sexp do
       expect(@node.grep_node(sexp_type: :const_ref).line_number).to eq 1
     end
 
+    it 'should return top const line' do
+      expect(@node.grep_node(sexp_type: :top_const_ref).line_number).to eq 20
+    end
+
     it 'should return const path line' do
       expect(@node.grep_node(sexp_type: :const_path_ref).line_number).to eq 3
     end
@@ -70,6 +79,79 @@ describe Sexp do
     it 'should return if_mod line' do
       expect(@node.grep_node(sexp_type: :if_mod).line_number).to eq 15
     end
+
+    it 'should return unary line' do
+      expect(@node.grep_node(sexp_type: :unary).line_number).to eq 15
+    end
+
+    it 'should return assign line' do
+      expect(@node.grep_node(sexp_type: :assign).line_number).to eq 6
+    end
+
+    it 'should return paren line' do
+      expect(@node.grep_node(sexp_type: :paren).line_number).to eq 10
+    end
+
+    it 'should return dot2 line' do
+      expect(@node.grep_node(sexp_type: :dot2).line_number).to eq 17
+    end
+
+    it 'should return dot3 line' do
+      expect(@node.grep_node(sexp_type: :dot3).line_number).to eq 18
+    end
+
+    it 'should return params line' do
+      expect(@node.grep_node(sexp_type: :params).line_number).to be_nil
+    end
+
+    it 'should return params line if not empty' do
+      @node = parse_content(<<~CODE)
+        # @see Foo
+        def foo(a, b)
+        end
+      CODE
+      expect(@node.grep_node(sexp_type: :params).line_number).to eq 2
+    end
+
+    it 'should return stmts_add line' do
+      expect(@node.grep_node(sexp_type: :stmts_add).line_number).to eq 13
+    end
+
+    context 'when a complex code is given' do
+      before :each do
+        @node = parse_content(<<~CODE)
+          def foo(num)
+            unless (num == 0 ? :zero, :other) || !@opts.right?
+              @bar = {}
+            end
+          end
+        CODE
+      end
+
+      it 'should return unless line' do
+        expect(@node.grep_node(sexp_type: :unless).line_number).to eq 2
+      end
+
+      it 'should return paren line' do
+        expect(@node.grep_node(sexp_type: :paren).line_number).to eq 1
+      end
+
+      it 'should return stmts_add line' do
+        expect(@node.grep_node(sexp_type: :stmts_add).line_number).to eq 2
+      end
+
+      it 'should return binary line' do
+        expect(@node.grep_node(sexp_type: :binary).line_number).to eq 2
+      end
+
+      it 'should return unary line' do
+        expect(@node.grep_node(sexp_type: :unary).line_number).to eq 2
+      end
+
+      it 'should return assign line' do
+        expect(@node.grep_node(sexp_type: :assign).line_number).to eq 3
+      end
+    end
   end
 
   describe 'grep_nodes' do
@@ -84,14 +166,12 @@ describe Sexp do
 
     it 'should get the call nodes with receiver current_user' do
       nodes = []
-      @node.grep_nodes(sexp_type: :call, receiver: 'current_user') do |node|
-        nodes << node
-      end
+      @node.grep_nodes(sexp_type: :call, receiver: 'current_user') { |node| nodes << node }
       expect(nodes).to eq [
            s(
              :call,
              s(:vcall, s(:@ident, 'current_user', s(2, 8))),
-             s(:@period, ".", s(2, 20)),
+             s(:@period, '.', s(2, 20)),
              s(:@ident, 'posts', s(2, 21))
            )
          ]
@@ -99,25 +179,23 @@ describe Sexp do
 
     it 'should get the call nodes with different messages' do
       nodes = []
-      @node.grep_nodes(sexp_type: :call, message: %w[posts find]) do |node|
-        nodes << node
-      end
+      @node.grep_nodes(sexp_type: :call, message: %w[posts find]) { |node| nodes << node }
       expect(nodes).to eq [
            s(
              :call,
              s(
                :call,
                s(:vcall, s(:@ident, 'current_user', s(2, 8))),
-               s(:@period, ".", s(2, 20)),
+               s(:@period, '.', s(2, 20)),
                s(:@ident, 'posts', s(2, 21))
              ),
-             s(:@period, ".", s(2, 26)),
+             s(:@period, '.', s(2, 26)),
              s(:@ident, 'find', s(2, 27))
            ),
            s(
              :call,
              s(:vcall, s(:@ident, 'current_user', s(2, 8))),
-             s(:@period, ".", s(2, 20)),
+             s(:@period, '.', s(2, 20)),
              s(:@ident, 'posts', s(2, 21))
            )
          ]
@@ -125,9 +203,7 @@ describe Sexp do
 
     it 'should get the vcall node with to_s' do
       nodes = []
-      @node.grep_nodes(sexp_type: :vcall, to_s: 'current_user') do |node|
-        nodes << node
-      end
+      @node.grep_nodes(sexp_type: :vcall, to_s: 'current_user') { |node| nodes << node }
       expect(nodes).to eq [s(:vcall, s(:@ident, 'current_user', s(2, 8)))]
     end
   end
@@ -147,7 +223,7 @@ describe Sexp do
       expect(node).to eq s(
            :call,
            s(:vcall, s(:@ident, 'current_user', s(2, 8))),
-           s(:@period, ".", s(2, 20)),
+           s(:@period, '.', s(2, 20)),
            s(:@ident, 'posts', s(2, 21))
          )
     end
@@ -170,8 +246,7 @@ describe Sexp do
 
   describe 'receiver' do
     it 'should get receiver of assign node' do
-      node =
-        parse_content('user.name = params[:name]').grep_node(sexp_type: :assign)
+      node = parse_content('user.name = params[:name]').grep_node(sexp_type: :assign)
       receiver = node.receiver
       expect(receiver.sexp_type).to eq :field
       expect(receiver.receiver.to_s).to eq 'user'
@@ -179,8 +254,7 @@ describe Sexp do
     end
 
     it 'should get receiver of field node' do
-      node =
-        parse_content('user.name = params[:name]').grep_node(sexp_type: :field)
+      node = parse_content('user.name = params[:name]').grep_node(sexp_type: :field)
       expect(node.receiver.to_s).to eq 'user'
     end
 
@@ -204,16 +278,12 @@ describe Sexp do
     end
 
     it 'should get receiver of method_add_arg' do
-      node =
-        parse_content('Post.find(:all)').grep_node(sexp_type: :method_add_arg)
+      node = parse_content('Post.find(:all)').grep_node(sexp_type: :method_add_arg)
       expect(node.receiver.to_s).to eq 'Post'
     end
 
     it 'should get receiver of method_add_block' do
-      node =
-        parse_content('Post.save do; end').grep_node(
-          sexp_type: :method_add_block
-        )
+      node = parse_content('Post.save do; end').grep_node(sexp_type: :method_add_block)
       expect(node.receiver.to_s).to eq 'Post'
     end
   end
@@ -234,10 +304,7 @@ describe Sexp do
 
   describe 'base_class' do
     it 'should get base class of class node' do
-      node =
-        parse_content('class User < ActiveRecord::Base; end').grep_node(
-          sexp_type: :class
-        )
+      node = parse_content('class User < ActiveRecord::Base; end').grep_node(sexp_type: :class)
       expect(node.base_class.to_s).to eq 'ActiveRecord::Base'
     end
   end
@@ -263,10 +330,7 @@ describe Sexp do
     end
 
     it 'should get the message of command_call' do
-      node =
-        parse_content('map.resources :posts do; end').grep_node(
-          sexp_type: :command_call
-        )
+      node = parse_content('map.resources :posts do; end').grep_node(sexp_type: :command_call)
       expect(node.message.to_s).to eq 'resources'
     end
 
@@ -291,46 +355,34 @@ describe Sexp do
     end
 
     it 'should get the message of method_add_arg' do
-      node =
-        parse_content('Post.find(:all)').grep_node(sexp_type: :method_add_arg)
+      node = parse_content('Post.find(:all)').grep_node(sexp_type: :method_add_arg)
       expect(node.message.to_s).to eq 'find'
     end
 
     it 'should get the message of method_add_block' do
-      node =
-        parse_content('Post.save do; end').grep_node(
-          sexp_type: :method_add_block
-        )
+      node = parse_content('Post.save do; end').grep_node(sexp_type: :method_add_block)
       expect(node.message.to_s).to eq 'save'
     end
   end
 
   describe 'arguments' do
     it 'should get the arguments of command' do
-      node =
-        parse_content('resources :posts do; end').grep_node(sexp_type: :command)
+      node = parse_content('resources :posts do; end').grep_node(sexp_type: :command)
       expect(node.arguments.sexp_type).to eq :args_add_block
     end
 
     it 'should get the arguments of command_call' do
-      node =
-        parse_content('map.resources :posts do; end').grep_node(
-          sexp_type: :command_call
-        )
+      node = parse_content('map.resources :posts do; end').grep_node(sexp_type: :command_call)
       expect(node.arguments.sexp_type).to eq :args_add_block
     end
 
     it 'should get the arguments of method_add_arg' do
-      node =
-        parse_content('User.find(:all)').grep_node(sexp_type: :method_add_arg)
+      node = parse_content('User.find(:all)').grep_node(sexp_type: :method_add_arg)
       expect(node.arguments.sexp_type).to eq :args_add_block
     end
 
     it 'should get the arguments of method_add_block' do
-      node =
-        parse_content('Post.save(false) do; end').grep_node(
-          sexp_type: :method_add_block
-        )
+      node = parse_content('Post.save(false) do; end').grep_node(sexp_type: :method_add_block)
       expect(node.arguments.sexp_type).to eq :args_add_block
     end
   end
@@ -344,49 +396,30 @@ describe Sexp do
 
   describe 'all' do
     it 'should get all arguments' do
-      node =
-        parse_content("puts 'hello', 'world'").grep_node(
-          sexp_type: :args_add_block
-        )
+      node = parse_content("puts 'hello', 'world'").grep_node(sexp_type: :args_add_block)
       expect(node.all.map(&:to_s)).to eq %w[hello world]
     end
 
     it 'should get all arguments with &:' do
-      node =
-        parse_content('user.posts.map(&:title)').grep_node(
-          sexp_type: :args_add_block
-        )
+      node = parse_content('user.posts.map(&:title)').grep_node(sexp_type: :args_add_block)
       expect(node.all.map(&:to_s)).to eq %w[title]
     end
 
     it 'should get all arguments with command_call node' do
-      node =
-        parse_content('options_for_select(Account.get_business current_user)')
-          .grep_node(sexp_type: :args_add)
+      node = parse_content('options_for_select(Account.get_business current_user)').grep_node(sexp_type: :args_add)
       expect(node.all).to eq [
            s(
              :command_call,
              s(:var_ref, s(:@const, 'Account', s(1, 19))),
-             s(:@period, ".", s(1, 26)),
+             s(:@period, '.', s(1, 26)),
              s(:@ident, 'get_business', s(1, 27)),
-             s(
-               :args_add_block,
-               s(
-                 :args_add,
-                 s(:args_new),
-                 s(:vcall, s(:@ident, 'current_user', s(1, 40)))
-               ),
-               false
-             )
+             s(:args_add_block, s(:args_add, s(:args_new), s(:vcall, s(:@ident, 'current_user', s(1, 40)))), false)
            )
          ]
     end
 
     it 'no error for args_add_star' do
-      node =
-        parse_content("send(:\"\#{route}_url\", *args)").grep_node(
-          sexp_type: :args_add_block
-        )
+      node = parse_content("send(:\"\#{route}_url\", *args)").grep_node(sexp_type: :args_add_block)
       expect { node.all }.not_to raise_error
     end
   end
@@ -403,8 +436,7 @@ describe Sexp do
     end
 
     it 'should get conditional statement of elsif' do
-      node =
-        parse_content('if true; elsif false; end').grep_node(sexp_type: :elsif)
+      node = parse_content('if true; elsif false; end').grep_node(sexp_type: :elsif)
       expect(node.conditional_statement.to_s).to eq 'false'
     end
 
@@ -414,8 +446,7 @@ describe Sexp do
     end
 
     it 'should get conditional statement of unless_mod' do
-      node =
-        parse_content("'OK' unless false").grep_node(sexp_type: :unless_mod)
+      node = parse_content("'OK' unless false").grep_node(sexp_type: :unless_mod)
       expect(node.conditional_statement.to_s).to eq 'false'
     end
 
@@ -427,9 +458,7 @@ describe Sexp do
 
   describe 'all_conditions' do
     it 'should get all conditions' do
-      node =
-        parse_content('user == current_user && user.valid? || user.admin?')
-          .grep_node(sexp_type: :binary)
+      node = parse_content('user == current_user && user.valid? || user.admin?').grep_node(sexp_type: :binary)
       expect(node.all_conditions.size).to eq 3
     end
   end
@@ -463,8 +492,7 @@ describe Sexp do
     end
 
     it 'should get body of module' do
-      node =
-        parse_content('module Enumerable; end').grep_node(sexp_type: :module)
+      node = parse_content('module Enumerable; end').grep_node(sexp_type: :module)
       expect(node.body.sexp_type).to eq :bodystmt
     end
 
@@ -474,22 +502,17 @@ describe Sexp do
     end
 
     it 'should get body of elsif' do
-      node =
-        parse_content("if true; elsif true; 'OK'; end").grep_node(
-          sexp_type: :elsif
-        )
+      node = parse_content("if true; elsif true; 'OK'; end").grep_node(sexp_type: :elsif)
       expect(node.body.sexp_type).to eq :stmts_add
     end
 
     it 'should get body of unless' do
-      node =
-        parse_content("unless true; 'OK'; end").grep_node(sexp_type: :unless)
+      node = parse_content("unless true; 'OK'; end").grep_node(sexp_type: :unless)
       expect(node.body.sexp_type).to eq :stmts_add
     end
 
     it 'should get body of else' do
-      node =
-        parse_content("if true; else; 'OK'; end").grep_node(sexp_type: :else)
+      node = parse_content("if true; else; 'OK'; end").grep_node(sexp_type: :else)
       expect(node.body.sexp_type).to eq :stmts_add
     end
 
@@ -499,8 +522,7 @@ describe Sexp do
     end
 
     it 'should get body of unless_mod' do
-      node =
-        parse_content("'OK' unless false").grep_node(sexp_type: :unless_mod)
+      node = parse_content("'OK' unless false").grep_node(sexp_type: :unless_mod)
       expect(node.body.to_s).to eq 'OK'
     end
 
@@ -512,9 +534,7 @@ describe Sexp do
 
   describe 'block' do
     it 'sould get block of method_add_block node' do
-      node =
-        parse_content('resources :posts do; resources :comments; end')
-          .grep_node(sexp_type: :method_add_block)
+      node = parse_content('resources :posts do; resources :comments; end').grep_node(sexp_type: :method_add_block)
       expect(node.block_node.sexp_type).to eq :do_block
     end
   end
@@ -522,40 +542,29 @@ describe Sexp do
   describe 'statements' do
     it 'should get statements of do_block node' do
       node =
-        parse_content(
-          'resources :posts do; resources :comments; resources :like; end'
-        )
-          .grep_node(sexp_type: :do_block)
+        parse_content('resources :posts do; resources :comments; resources :like; end').grep_node(sexp_type: :do_block)
       expect(node.statements.size).to eq 2
     end
 
     it 'should get statements of bodystmt node' do
-      node =
-        parse_content('class User; def login?; end; def admin?; end; end')
-          .grep_node(sexp_type: :bodystmt)
+      node = parse_content('class User; def login?; end; def admin?; end; end').grep_node(sexp_type: :bodystmt)
       expect(node.statements.size).to eq 2
     end
   end
 
   describe 'exception_classes' do
     it 'should get exception classes of rescue node' do
-      node =
-        parse_content('def test; rescue CustomException; end').grep_node(
-          sexp_type: :rescue
-        )
+      node = parse_content('def test; rescue CustomException; end').grep_node(sexp_type: :rescue)
       expect(node.exception_classes.first.to_s).to eq 'CustomException'
     end
 
     it 'should get empty of empty rescue node' do
-      node =
-        parse_content('def test; rescue; end').grep_node(sexp_type: :rescue)
+      node = parse_content('def test; rescue; end').grep_node(sexp_type: :rescue)
       expect(node.exception_classes.first.to_s).to eq ''
     end
 
     it 'should get exception classes of rescue node for multiple exceptions' do
-      node =
-        parse_content('def test; rescue StandardError, CustomException; end')
-          .grep_node(sexp_type: :rescue)
+      node = parse_content('def test; rescue StandardError, CustomException; end').grep_node(sexp_type: :rescue)
       expect(node.exception_classes.first.to_s).to eq 'StandardError'
       expect(node.exception_classes.last.to_s).to eq 'CustomException'
     end
@@ -563,36 +572,28 @@ describe Sexp do
 
   describe 'exception_variable' do
     it 'should get exception varible of rescue node' do
-      node =
-        parse_content('def test; rescue => e; end').grep_node(
-          sexp_type: :rescue
-        )
+      node = parse_content('def test; rescue => e; end').grep_node(sexp_type: :rescue)
       expect(node.exception_variable.to_s).to eq 'e'
     end
 
     it 'should get empty of empty rescue node' do
-      node =
-        parse_content('def test; rescue; end').grep_node(sexp_type: :rescue)
+      node = parse_content('def test; rescue; end').grep_node(sexp_type: :rescue)
       expect(node.exception_variable.to_s).to eq ''
     end
   end
 
   describe 'hash_value' do
     it 'should get value for hash node' do
-      node =
-        parse_content("{first_name: 'Richard', last_name: 'Huang'}").grep_node(
-          sexp_type: :hash
-        )
+      node = parse_content("{first_name: 'Richard', last_name: 'Huang'}").grep_node(sexp_type: :hash)
       expect(node.hash_value('first_name').to_s).to eq 'Richard'
       expect(node.hash_value('last_name').to_s).to eq 'Huang'
     end
 
     it 'should get value for bare_assoc_hash' do
       node =
-        parse_content(
-          "add_user :user, first_name: 'Richard', last_name: 'Huang'"
+        parse_content("add_user :user, first_name: 'Richard', last_name: 'Huang'").grep_node(
+          sexp_type: :bare_assoc_hash
         )
-          .grep_node(sexp_type: :bare_assoc_hash)
       expect(node.hash_value('first_name').to_s).to eq 'Richard'
       expect(node.hash_value('last_name').to_s).to eq 'Huang'
     end
@@ -600,67 +601,52 @@ describe Sexp do
 
   describe 'hash_size' do
     it 'should get value for hash node' do
-      node =
-        parse_content("{first_name: 'Richard', last_name: 'Huang'}").grep_node(
-          sexp_type: :hash
-        )
+      node = parse_content("{first_name: 'Richard', last_name: 'Huang'}").grep_node(sexp_type: :hash)
       expect(node.hash_size).to eq 2
     end
 
     it 'should get value for bare_assoc_hash' do
       node =
-        parse_content(
-          "add_user :user, first_name: 'Richard', last_name: 'Huang'"
+        parse_content("add_user :user, first_name: 'Richard', last_name: 'Huang'").grep_node(
+          sexp_type: :bare_assoc_hash
         )
-          .grep_node(sexp_type: :bare_assoc_hash)
       expect(node.hash_size).to eq 2
     end
   end
 
   describe 'hash_keys' do
     it 'should get hash_keys for hash node' do
-      node =
-        parse_content("{first_name: 'Richard', last_name: 'Huang'}").grep_node(
-          sexp_type: :hash
-        )
+      node = parse_content("{first_name: 'Richard', last_name: 'Huang'}").grep_node(sexp_type: :hash)
       expect(node.hash_keys).to eq %w[first_name last_name]
     end
 
     it 'should get hash_keys for bare_assoc_hash' do
       node =
-        parse_content(
-          "add_user :user, first_name: 'Richard', last_name: 'Huang'"
+        parse_content("add_user :user, first_name: 'Richard', last_name: 'Huang'").grep_node(
+          sexp_type: :bare_assoc_hash
         )
-          .grep_node(sexp_type: :bare_assoc_hash)
       expect(node.hash_keys).to eq %w[first_name last_name]
     end
   end
 
   describe 'hash_values' do
     it 'should get hash_values for hash node' do
-      node =
-        parse_content("{first_name: 'Richard', last_name: 'Huang'}").grep_node(
-          sexp_type: :hash
-        )
+      node = parse_content("{first_name: 'Richard', last_name: 'Huang'}").grep_node(sexp_type: :hash)
       expect(node.hash_values.map(&:to_s)).to eq %w[Richard Huang]
     end
 
     it 'should get hash_values for bare_assoc_hash' do
       node =
-        parse_content(
-          "add_user :user, first_name: 'Richard', last_name: 'Huang'"
+        parse_content("add_user :user, first_name: 'Richard', last_name: 'Huang'").grep_node(
+          sexp_type: :bare_assoc_hash
         )
-          .grep_node(sexp_type: :bare_assoc_hash)
       expect(node.hash_values.map(&:to_s)).to eq %w[Richard Huang]
     end
   end
 
   describe 'array_size' do
     it 'should get array size' do
-      node =
-        parse_content("['first_name', 'last_name']").grep_node(
-          sexp_type: :array
-        )
+      node = parse_content("['first_name', 'last_name']").grep_node(sexp_type: :array)
       expect(node.array_size).to eq 2
     end
 
@@ -672,10 +658,7 @@ describe Sexp do
 
   describe 'array_values' do
     it 'should get array values' do
-      node =
-        parse_content("['first_name', 'last_name']").grep_node(
-          sexp_type: :array
-        )
+      node = parse_content("['first_name', 'last_name']").grep_node(sexp_type: :array)
       expect(node.array_values.map(&:to_s)).to eq %w[first_name last_name]
     end
 
@@ -685,8 +668,7 @@ describe Sexp do
     end
 
     it 'should get array value with array and words_add' do
-      node =
-        parse_content('%W{day week fortnight}').grep_node(sexp_type: :array)
+      node = parse_content('%W{day week fortnight}').grep_node(sexp_type: :array)
       expect(node.array_values.map(&:to_s)).to eq %w[day week fortnight]
     end
 
@@ -696,8 +678,7 @@ describe Sexp do
     end
 
     it 'should get array value with array and qwords_add' do
-      node =
-        parse_content('%w(first_name last_name)').grep_node(sexp_type: :array)
+      node = parse_content('%w(first_name last_name)').grep_node(sexp_type: :array)
       expect(node.array_values.map(&:to_s)).to eq %w[first_name last_name]
     end
 
@@ -708,8 +689,7 @@ describe Sexp do
 
     if RUBY_VERSION.to_i > 1
       it 'should get array value with array and symbols_add' do
-        node =
-          parse_content('%I(first_name last_name)').grep_node(sexp_type: :array)
+        node = parse_content('%I(first_name last_name)').grep_node(sexp_type: :array)
         expect(node.array_values.map(&:to_s)).to eq %w[first_name last_name]
       end
 
@@ -719,8 +699,7 @@ describe Sexp do
       end
 
       it 'should get array value with array and qsymbols_add' do
-        node =
-          parse_content('%i(first_name last_name)').grep_node(sexp_type: :array)
+        node = parse_content('%i(first_name last_name)').grep_node(sexp_type: :array)
         expect(node.array_values.map(&:to_s)).to eq %w[first_name last_name]
       end
 
@@ -733,9 +712,7 @@ describe Sexp do
 
   describe 'alias' do
     context 'method' do
-      before do
-        @node = parse_content('alias new old').grep_node(sexp_type: :alias)
-      end
+      before { @node = parse_content('alias new old').grep_node(sexp_type: :alias) }
 
       it 'should get old_method' do
         expect(@node.old_method.to_s).to eq 'old'
@@ -747,9 +724,7 @@ describe Sexp do
     end
 
     context 'symbol' do
-      before do
-        @node = parse_content('alias :new :old').grep_node(sexp_type: :alias)
-      end
+      before { @node = parse_content('alias :new :old').grep_node(sexp_type: :alias) }
 
       it 'should get old_method' do
         expect(@node.old_method.to_s).to eq 'old'
@@ -763,10 +738,7 @@ describe Sexp do
 
   describe 'to_object' do
     it 'should to array' do
-      node =
-        parse_content("['first_name', 'last_name']").grep_node(
-          sexp_type: :array
-        )
+      node = parse_content("['first_name', 'last_name']").grep_node(sexp_type: :array)
       expect(node.to_object).to eq %w[first_name last_name]
     end
 
@@ -776,8 +748,7 @@ describe Sexp do
     end
 
     it 'should to array with symbols' do
-      node =
-        parse_content('[:first_name, :last_name]').grep_node(sexp_type: :array)
+      node = parse_content('[:first_name, :last_name]').grep_node(sexp_type: :array)
       expect(node.to_object).to eq %w[first_name last_name]
     end
 
@@ -819,16 +790,12 @@ describe Sexp do
     end
 
     it 'should get to_s for class with module' do
-      node =
-        parse_content('ActiveRecord::Base').grep_node(
-          sexp_type: :const_path_ref
-        )
+      node = parse_content('ActiveRecord::Base').grep_node(sexp_type: :const_path_ref)
       expect(node.to_s).to eq 'ActiveRecord::Base'
     end
 
     it 'should get to_s for label' do
-      node =
-        parse_content("{first_name: 'Richard'}").grep_node(sexp_type: :@label)
+      node = parse_content("{first_name: 'Richard'}").grep_node(sexp_type: :@label)
       expect(node.to_s).to eq 'first_name'
     end
 
@@ -876,15 +843,11 @@ describe Sexp do
 
   describe 'remove_line_and_column' do
     it 'should remove' do
-      s(:@ident, 'test', s(2, 12)).remove_line_and_column.should_equal s(
-                                                                      :@ident,
-                                                                      'test'
-                                                                    )
+      s(:@ident, 'test', s(2, 12)).remove_line_and_column.should_equal s(:@ident, 'test')
     end
 
     it 'should remove child nodes' do
-      s(:const_ref, s(:@const, 'Demo', s(1, 12)))
-        .remove_line_and_column.should_equal s(:const_def, s(:@const, 'Demo'))
+      s(:const_ref, s(:@const, 'Demo', s(1, 12))).remove_line_and_column.should_equal s(:const_def, s(:@const, 'Demo'))
     end
   end
 end

data/spec/code_analyzer/warning_spec.rb

@@ -1,15 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 module CodeAnalyzer
   describe Warning do
     it 'should return error with filename, line number and message' do
       expect(
-        Warning.new(
-          filename: 'app/models/user.rb',
-          line_number: '100',
-          message: 'not good'
-        )
-          .to_s
+        Warning.new(filename: 'app/models/user.rb', line_number: '100', message: 'not good').to_s
       ).to eq 'app/models/user.rb:100 - not good'
     end
   end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: code_analyzer
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Richard Huang
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-28 00:00:00.000000000 Z
+date: 2020-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sexp_processor
@@ -91,7 +91,7 @@ homepage: https://github.com/flyerhzm/code_analyzer
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -106,8 +106,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: a code analyzer helps you build your own code analyzer tool.
 test_files: