cocooned 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e43afc0b47e21fabcc8bb5c81642df49c72d1932a0ab3a2338c9dadeed2b48b
-  data.tar.gz: 5dc1efd9e0f72570ec2b45d9b89b8a060f9110eae96cd414282bad1c681e6799
+  metadata.gz: 4b263ee9e9f62225ffda1bf6023baf4b2f26643ca3951bffe3789c251a3da267
+  data.tar.gz: b390024eaa76fd227ac9e32b292aaf75987e9a3f42200069e51d02440cdd9ea9
 SHA512:
-  metadata.gz: ffc721aa5f32c5fa8195155fb319b14d533a5a40eb3daeb475c86c54d3e4cd1c59627736f10bf488f73ec3f54638ea75dd42e8d9121bd9036699aad550d4115f
-  data.tar.gz: 548162a0067e73797892b53d16a5013d77e3c89abe4f4ead07b54893c706d798ae8cc805670afd5ac09dedee8dfca1abab06bdabdb42e0cafb47868a6b3bd44c
+  metadata.gz: 35f0aecab1c7b427c52b99cf8d1665ac3a06a5d8bcb980a33d2577e18bdef322897ea080da60a05d7218b90977c53cc919cc14e967c314247c0ff4cd76f83d8e
+  data.tar.gz: ff5d977c74da72179fa80cc2b62ad65bd709f7cce6734ebbd4f82123ac7f3349c6a865f030f035a5d32af6dc9f1522142a0705b1f7b610f6d7bd064bbbaf85fd

data/CHANGELOG.md

@@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+## Version 2.0.4 (2023-11-23)
+
+### Fixed
+
+*  Fix multiple callback executions in nested containers (#50)
+
 ## Version 2.0.3 (2023-10-13)
 
 ### Fixed

data/app/assets/javascripts/cocooned.js

@@ -673,14 +673,27 @@
   }
 
   function delegatedClickHandler (selector, callback) {
+    const handler = clickHandler$1(callback);
+
     return e => {
       const { target } = e;
       if (target.closest(selector) === null) {
         return
       }
 
-      e.preventDefault();
-      callback(e);
+      handler(e);
+    }
+  }
+
+  function itemDelegatedClickHandler (container, selector, callback) {
+    const delegatedHandler = delegatedClickHandler(selector, callback);
+
+    return e => {
+      if (!container.contains(e.target)) {
+        return
+      }
+
+      delegatedHandler(e);
     }
   }
 
@@ -707,7 +720,7 @@
 
       this.container.addEventListener(
         'click',
-        delegatedClickHandler(this._selector('triggers.remove'), (e) => {
+        itemDelegatedClickHandler(this, this._selector('triggers.remove'), (e) => {
           const trigger = new Remove(e.target, this);
           trigger.handle(e);
         })
@@ -866,8 +879,8 @@
     }
   }
 
-  function clickHandler (selector, cocooned, TriggerClass) {
-    return delegatedClickHandler(selector, (e) => {
+  function clickHandler (cocooned, selector, TriggerClass) {
+    return itemDelegatedClickHandler(cocooned, selector, (e) => {
       const trigger = new TriggerClass(e.target, cocooned);
       trigger.handle(e);
     })
@@ -900,8 +913,8 @@
         form.addEventListener('submit', e => this._reindexer.reindex(e));
       }
 
-      this.container.addEventListener('click', clickHandler(this._selector('triggers.up'), this, Up));
-      this.container.addEventListener('click', clickHandler(this._selector('triggers.down'), this, Down));
+      this.container.addEventListener('click', clickHandler(this, this._selector('triggers.up'), Up));
+      this.container.addEventListener('click', clickHandler(this, this._selector('triggers.down'), Down));
     }
 
     /* Protected and private attributes and methods */

data/lib/cocooned/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Cocooned
-  VERSION = '2.0.3'
+  VERSION = '2.0.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cocooned
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Gaël-Ian Havard
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-13 00:00:00.000000000 Z
+date: 2023-11-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails