cocoapods-why 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf607f5706da9f9cffa9cdac50e702f3c9e2fbf305f2674121102dfda5b80a01
-  data.tar.gz: 07625dc6f38f2728f818bc4890d4809d19d51e9899ca9065d320c7ae0d461407
+  metadata.gz: 6c3cff85c9714857f4d2291c3abb3478cabc3564c31398ec078a8a681b3b2786
+  data.tar.gz: 1a87098be80cc339392007248aecd0f8b2dd92259e2e978217ab512c6157275e
 SHA512:
-  metadata.gz: 43a3893be1ee319fdced20be09c9ad7e751e5c0b4d2d76ce0704878c69fcb0b9be34956ac3326611ff156cf5dc9bfb36af2edfc405ab22af274b8e7e7befc7fe
-  data.tar.gz: 5ba60b6bc840b2c23edea06b345cab24d8c03bd9db0dc11e1344da578cedd361deb311e7b84fbb74bc782cefca4bc465739f7e50c89c482db8282ed659225145
+  metadata.gz: ee8d9a9bb28c0e180a124d22ae99cdc37c25983c284ae003bb4e57834306999f05c172c145852283361a9fdf3f746dc3a54c52f07cc6bb2d5da6d52b02e3533c
+  data.tar.gz: c173fc047350aa91f209eb90b3a239ac81ee9950af471a4054f910d1b570edfc20fd2193f5b78e0870b20aee11017d96be0ea7f4525a6a5110cfafdbc5326149

data/lib/cocoapods_why.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CocoaPodsWhy
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/lib/pod/command/why.rb

@@ -80,8 +80,9 @@ module Pod
       # @return [Hash<String,Array<String>>] a mapping of pod names to their direct dependencies
       def all_dependencies(targets)
         targets.to_h do |target|
-          target_dependencies = target[:dependencies].delete_if { |dep| dep.include? '/' } # Remove subspecs
-          [target[:name], target_dependencies]
+          deps = target[:dependencies] || []
+          deps = deps.delete_if { |dep| dep.include? '/' } # Remove subspecs
+          [target[:name], deps]
         end
       end
 
@@ -101,10 +102,16 @@ module Pod
       end
 
       # Computes and returns all possible paths between a source vertex and a target vertex in a directed graph.
-      # It does this by performing a DFS and, whenever the target is discovered (or re-discovered), the current
-      # DFS stack is captured as one of the possible paths.
       #
-      # @note Back edges are ignored because the input graph is assumed to be acyclic.
+      # It does this by performing a recursive walk through the graph (like DFS). After returning from a recursive
+      # descent through all of a vertex's edges, the vertex is prepended to each returned path and in this way the
+      # list of all paths is built up. The recursion stops when the target vertex is discovered.
+      #
+      # The algorithm described above is exponential in running time, so memoization is used to speed it up.
+      # After all paths from a vertex are discovered, the results are stored in a hash. Before processing a vertex,
+      # this hash is queried for a previously stored result, which if found is returned instead of recomputed.
+      #
+      # @note The input graph is assumed to be acyclic.
       #
       # @param [String] source
       #        The vertex at which to begin the search.
@@ -115,20 +122,16 @@ module Pod
       #
       # @return [Array<Array<String>>] a list of all paths from source to target
       def all_paths(source, target, graph)
-        dfs_stack = [source] # RGL uses recursion for DFS and does not expose a stack, so we build one as we go.
-        all_paths = []
-        visitor = RGL::DFSVisitor.new(graph)
-        visitor.set_tree_edge_event_handler do |_, v|
-          dfs_stack << v
-          all_paths << dfs_stack.dup if v == target
-        end
-        visitor.set_forward_edge_event_handler do |_, v|
-          dfs_stack << v
-          all_paths << dfs_stack.dup if v == target
-          dfs_stack.pop
+
+        def search(source, target, graph, all_paths)
+          return all_paths[source] if all_paths.key?(source)
+          return [[target]] if source == target
+          source_paths = []
+          graph.each_adjacent(source) { |v| source_paths += search(v, target, graph, all_paths) }
+          all_paths[source] = source_paths.map { |path| [source] + path }
         end
-        graph.depth_first_visit(source, visitor) { dfs_stack.pop }
-        all_paths
+
+        search(source, target, graph, {})
       end
 
       # Converts a list of dependency paths into a graph. The vertices in the paths are

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-why
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Trevor Harmon
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-24 00:00:00.000000000 Z
+date: 2020-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler