cocoapods-plugins 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7c552838da447d326048d02eec308967695cec8f
-  data.tar.gz: 2b0144ca6eea883bdb3e05bd847fa5e61fbea201
+  metadata.gz: 627b3a781e5eb3dcd8bab22e1c54fab8cd28195f
+  data.tar.gz: df053120c04bba449b761518c619f5843eac54ba
 SHA512:
-  metadata.gz: dce8fd8cb5e3e86461b77ac2c8e23ea46282bbd2b9f319f06857db96d0749eb993dc2a65cad4159baf7827e84eb01db6905879e751afff5381229ca7034faa72
-  data.tar.gz: 89da3e37f4788a30393fd6bae3f99657bb7a25d77ab9ff6fa0f4eb567878f1c41a1f299537ff62ab333df7557d0a173b3d63c9821177638b52a8a4c2414e4ce8
+  metadata.gz: 6cd540ae5191ef202aebf16877f9ba09e10213162eefa8abd3787a2f1a2fda32cf82c417a799b3ed0e910956477cf3556ffbadab168a1b58ef2060b7fa2c0cab
+  data.tar.gz: ee7c74aa53ab71e6be6b5652dfb165215a596cb4aa5f64f7ab625b5ff56f0b5eb12c21a0ddc91241677c8d8d30f71284c83f3ef079f794d804bcf08f5a7d98b1

data/.rubocop-cocoapods.yml

@@ -44,18 +44,18 @@ Lambda:
 # Allow for `should.match /regexp/`.
 AmbiguousRegexpLiteral:
   Exclude:
-    - spec/**
+    - spec/**/*
 
 # Allow `object.should == object` syntax.
 Void:
   Exclude:
-    - spec/**
+    - spec/**/*
 
 ClassAndModuleChildren:
   Exclude:
-    - spec/**
+    - spec/**/*
 
 UselessComparison:
   Exclude:
-    - spec/**
+    - spec/**/*
 

data/CHANGELOG.md

@@ -1,5 +1,16 @@
 # Cocoapods::Plugins Changelog
 
+## 0.2.0
+
+* Migrating to new syntax of CLAide::Command#arguments (fix #23)
+  [Olivier Halligon](https://github.com/AliSoftware)
+
+* Printing URL of template used (fixes #21)  [Olivier Halligon]
+  [Olivier Halligon](https://github.com/AliSoftware)
+
+* `create` subcommand now prefixes the given name if not already (fix #20)
+  [Olivier Halligon](https://github.com/AliSoftware)
+
 ## 0.1.1
 
 * Making `pod plugins` an abstract command, with `list` the default subcommand (#11, #12)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cocoapods-plugins (0.1.1)
+    cocoapods-plugins (0.2.0)
       nap
 
 GEM

data/Rakefile

@@ -1,41 +1,59 @@
-require 'bundler/gem_tasks'
-
-task :default => 'spec'
-
 # Bootstrap
 #-----------------------------------------------------------------------------#
 
 task :bootstrap do
-  sh 'bundle install'
+  if system('which bundle')
+    sh 'bundle install'
+  else
+    $stderr.puts "\033[0;31m" \
+      "[!] Please install the bundler gem manually:\n" \
+      "    $ [sudo] gem install bundler" \
+      "\e[0m"
+    exit 1
+  end
 end
 
-# Spec
-#-----------------------------------------------------------------------------#
+begin
 
-desc 'Runs all the specs'
-task :spec do
-  start_time = Time.now
-  sh "bundle exec bacon #{specs('**')}"
-  duration = Time.now - start_time
-  puts "Tests completed in #{duration}s"
-  Rake::Task['rubocop'].invoke
-end
+  require 'bundler/gem_tasks'
 
-def specs(dir)
-  FileList["spec/#{dir}/*_spec.rb"].shuffle.join(' ')
-end
+  task :default => 'spec'
 
-# Rubocop
-#-----------------------------------------------------------------------------#
 
-desc 'Checks code style'
-task :rubocop do
-  if RUBY_VERSION >= '1.9.3'
-    require 'rubocop'
-    cli = Rubocop::CLI.new
-    result = cli.run(FileList['{spec,lib}/**/*.rb'])
-    abort('RuboCop failed!') unless result == 0
-  else
-    puts '[!] Ruby > 1.9 is required to run style checks'
+  # Spec
+  #-----------------------------------------------------------------------------#
+
+  desc 'Runs all the specs'
+  task :spec do
+    start_time = Time.now
+    sh "bundle exec bacon #{specs('**')}"
+    duration = Time.now - start_time
+    puts "Tests completed in #{duration}s"
+    Rake::Task['rubocop'].invoke
+  end
+
+  def specs(dir)
+    FileList["spec/#{dir}/*_spec.rb"].shuffle.join(' ')
   end
+
+  # Rubocop
+  #-----------------------------------------------------------------------------#
+
+  desc 'Checks code style'
+  task :rubocop do
+    if RUBY_VERSION >= '1.9.3'
+      require 'rubocop'
+      cli = Rubocop::CLI.new
+      result = cli.run(FileList['{spec,lib}/**/*.rb'])
+      abort('RuboCop failed!') unless result == 0
+    else
+      puts '[!] Ruby > 1.9 is required to run style checks'
+    end
+  end
+
+rescue LoadError
+  $stderr.puts "\033[0;31m" \
+    '[!] Some Rake tasks haven been disabled because the environment' \
+    ' couldn’t be loaded. Be sure to run `rake bootstrap` first.' \
+    "\e[0m"
 end

data/lib/cocoapods_plugins.rb

@@ -2,5 +2,5 @@
 # The namespace of the Cocoapods plugins plugin.
 #
 module CocoapodsPlugins
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

data/lib/pod/command/plugins/create.rb

@@ -6,6 +6,8 @@ module Pod
       # template
       #
       class Create < Plugins
+        NAME_PREFIX = 'cocoapods-'
+
         self.summary = 'Creates a new plugin'
         self.description = <<-DESC
                 Creates a scaffold for the development of a new plugin
@@ -16,10 +18,16 @@ module Pod
                 in place of the default one.
         DESC
 
-        self.arguments = 'NAME [TEMPLATE_URL]'
+        self.arguments = [
+          ['NAME', :required],
+          ['TEMPLATE_URL', :optional]
+        ]
 
         def initialize(argv)
           @name = argv.shift_argument
+          unless @name.nil? || @name.empty? || @name.index(NAME_PREFIX) == 0
+            @name = @name.dup.prepend(NAME_PREFIX)
+          end
           @template_url = argv.shift_argument
           super
         end
@@ -59,7 +67,8 @@ module Pod
         # @return [void]
         #
         def clone_template
-          UI.section("Creating `#{@name}` plugin") do
+          UI.section("-> Creating `#{@name}` plugin") do
+            UI.notice "using template '#{template_repo_url}'"
             git! "clone '#{template_repo_url}' #{@name}"
           end
         end
@@ -69,7 +78,7 @@ module Pod
         # @return [void]
         #
         def configure_template
-          UI.section('Configuring template') do
+          UI.section('-> Configuring template') do
             Dir.chdir(@name) do
               if File.file? 'configure'
                 system "./configure #{@name}"

data/lib/pod/command/plugins/search.rb

@@ -16,7 +16,9 @@ module Pod
                 With --full, it also searches by author and description.
         DESC
 
-        self.arguments = 'QUERY'
+        self.arguments = [
+          ['QUERY', :required]
+        ]
 
         def self.options
           [

data/spec/command/plugins/create_spec.rb

@@ -1,4 +1,5 @@
 require File.expand_path('../../../spec_helper', __FILE__)
+require 'tmpdir'
 
 # The CocoaPods namespace
 #
@@ -19,29 +20,45 @@ module Pod
 
     it 'should require a name is passed in' do
       @command = create_command
-      # rubocop:disable Lambda
-      lambda { @command.validate! }
-      .should.raise(CLAide::Help)
-      .message.should.match(/A name for the plugin is required./)
-      # rubocop:enable Lambda
+      should.raise(CLAide::Help) do
+        @command.validate!
+      end.message.should.match(/A name for the plugin is required./)
     end
 
     it 'should require a non-empty name is passed in' do
       @command = create_command('')
-      # rubocop:disable Lambda
-      lambda { @command.validate! }
-      .should.raise(CLAide::Help)
-      .message.should.match(/A name for the plugin is required./)
-      # rubocop:enable Lambda
+      should.raise(CLAide::Help) do
+        @command.validate!
+      end.message.should.match(/A name for the plugin is required./)
     end
 
     it 'should require the name does not have spaces' do
       @command = create_command('my gem')
-      # rubocop:disable Lambda
-      lambda { @command.validate! }
-      .should.raise(CLAide::Help)
-      .message.should.match(/The plugin name cannot contain spaces./)
-      # rubocop:enable Lambda
+      should.raise(CLAide::Help) do
+        @command.validate!
+      end.message.should.match(/The plugin name cannot contain spaces./)
+    end
+
+    #--- Naming
+
+    it 'should prefix the given name if not already' do
+      @command = create_command('unprefixed')
+      Dir.mktmpdir do |tmpdir|
+        Dir.chdir(tmpdir) do
+          @command.run
+        end
+      end
+      UI.output.should.include('Creating `cocoapods-unprefixed` plugin')
+    end
+
+    it 'should not prefix the name if already prefixed' do
+      @command = create_command('cocoapods-prefixed')
+      Dir.mktmpdir do |tmpdir|
+        Dir.chdir(tmpdir) do
+          @command.run
+        end
+      end
+      UI.output.should.include('Creating `cocoapods-prefixed` plugin')
     end
 
     #--- Template download

data/spec/command/plugins/search_spec.rb

@@ -20,20 +20,16 @@ module Pod
 
     it 'should require a non-empty query' do
       @command = search_command
-      # rubocop:disable Lambda
-      lambda { @command.validate! }
-      .should.raise(CLAide::Help)
-      .message.should.match(/A search query is required./)
-      # rubocop:enable Lambda
+      should.raise(CLAide::Help) do
+        @command.validate!
+      end.message.should.match(/A search query is required./)
     end
 
     it 'should require a valid RegExp as query' do
       @command = search_command('[invalid')
-      # rubocop:disable Lambda
-      lambda { @command.validate! }
-      .should.raise(CLAide::Help)
-      .message.should.match(/A valid regular expression is required./)
-      # rubocop:enable Lambda
+      should.raise(CLAide::Help) do
+        @command.validate!
+      end.message.should.match(/A valid regular expression is required./)
     end
 
     #--- Output printing

data/spec/command/plugins_helper_spec.rb

@@ -16,21 +16,18 @@ module Pod
 
     it 'handles empty/bad JSON' do
       stub_plugins_json_request 'This is not JSON'
-      # rubocop:disable Lambda
-      lambda { Command::PluginsHelper.download_json }
-      .should.raise(Pod::Informative)
-      .message.should.match(/Invalid plugins list from cocoapods.org/)
-      # rubocop:enable Lambda
+      expected_error = /Invalid plugins list from cocoapods.org/
+      should.raise(Pod::Informative) do
+        Command::PluginsHelper.download_json
+      end.message.should.match(expected_error)
     end
 
     it 'notifies the user if the download fails' do
       stub_plugins_json_request '', [404, 'Not Found']
-      # rubocop:disable Lambda
-      lambda { Command::PluginsHelper.download_json }
-      .should.raise(Pod::Informative)
-      .message.should
-      .match(/Could not download plugins list from cocoapods.org/)
-      # rubocop:enable Lambda
+      expected_error = /Could not download plugins list from cocoapods.org/
+      should.raise(Pod::Informative) do
+        Command::PluginsHelper.download_json
+      end.message.should.match(expected_error)
     end
 
     it 'detects if a gem is installed' do

data/spec/spec_helper.rb

@@ -56,7 +56,7 @@ module Pod
         @output << "#{message}\n"
       end
 
-      def warn(message = '', actions = [])
+      def warn(message = '', _actions = [])
         @warnings << "#{message}\n"
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-plugins
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - David Grandinetti
@@ -9,48 +9,48 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-02 00:00:00.000000000 Z
+date: 2014-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nap
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: |2
@@ -63,10 +63,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rubocop-cocoapods.yml
-- .rubocop.yml
-- .travis.yml
+- ".gitignore"
+- ".rubocop-cocoapods.yml"
+- ".rubocop.yml"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -98,17 +98,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: CocoaPods plugin which shows info about available CocoaPods plugins.
@@ -120,3 +120,4 @@ test_files:
 - spec/command/plugins_spec.rb
 - spec/fixtures/plugins.json
 - spec/spec_helper.rb
+has_rdoc: