cocoapods-core 0.32.1 → 0.33.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e65de23fab7eda8ee9fcb101341196de5efd0ab
-  data.tar.gz: 4b0380f9e82363c6837aa7c8b307ea4d1ff40c3b
+  metadata.gz: 3027dc0811cd3a77bff386f6d4588b713ef62fa4
+  data.tar.gz: 018a952724e184ff563060d930a652f6afd269d6
 SHA512:
-  metadata.gz: a6a8aba3bbba2e3d08965c77b03bc4c09984d411055f3928fe2f0e098f7692f60c9ccd26bb193c601bd33a57adf3b31971a3a76979a85c2bba3b106ebdbce9a8
-  data.tar.gz: bead4903cc06f2a8652bd0deeef587f3ec5228e5f2d247965857ff3116931d3e3551153bf9e2de41aa8a9b7d5fee37ec63db1d45990d8e9c77b1c255eb5e79ae
+  metadata.gz: 3e0758fa6d998b89ec79a5be08cef619183d069df347e4dca359b4469b63ece30b4a53c9ce19ccf77bc01442d8f8e6de0e17b781f622ef7f462c448c633f66e1
+  data.tar.gz: e153cf162558e21c9ab134e0476bfc666c6e85798d228fdd0942a6a6c6a0e38acef489f4e2b17218440832ba95e382ea4a2f96a0717980b3d7f32a8e0927e3d2

data/README.md

@@ -1,8 +1,8 @@
 # CocoaPods Core
 
-[![Build Status](https://travis-ci.org/CocoaPods/Core.svg?branch=master)](https://travis-ci.org/CocoaPods/Core)
-[![Coverage Status](https://img.shields.io/coveralls/CocoaPods/Core.svg)](https://coveralls.io/r/CocoaPods/Core)
-[![Code Climate](https://img.shields.io/codeclimate/github/CocoaPods/Core.svg)](https://codeclimate.com/github/CocoaPods/Core)
+[![Build Status](https://img.shields.io/travis/CocoaPods/Core/master.svg?style=flat)](https://travis-ci.org/CocoaPods/Core)
+[![Coverage](https://img.shields.io/codeclimate/coverage/github/CocoaPods/Core.svg?style=flat)](https://codeclimate.com/github/CocoaPods/Core)
+[![Code Climate](https://img.shields.io/codeclimate/github/CocoaPods/Core.svg?style=flat)](https://codeclimate.com/github/CocoaPods/Core)
 
 The CocoaPods-Core gem provides support to work with the models of CocoaPods.
 It is intended to be used in place of the CocoaPods when the installation

data/lib/cocoapods-core.rb

@@ -21,6 +21,7 @@ module Pod
   autoload :CoreUI,         'cocoapods-core/core_ui'
   autoload :DSLError,       'cocoapods-core/standard_error'
   autoload :GitHub,         'cocoapods-core/github'
+  autoload :HTTP,           'cocoapods-core/http'
   autoload :Lockfile,       'cocoapods-core/lockfile'
   autoload :Platform,       'cocoapods-core/platform'
   autoload :Podfile,        'cocoapods-core/podfile'

data/lib/cocoapods-core/dependency.rb

@@ -71,7 +71,7 @@ module Pod
       if requirements.last.is_a?(Hash)
         @external_source = requirements.pop
         unless requirements.empty?
-          raise Informative, "A dependency with an external source may not " \
+          raise Informative, 'A dependency with an external source may not ' \
             "specify version requirements (#{name})."
         end
 
@@ -79,7 +79,7 @@ module Pod
         @head = true
         requirements.pop
         unless requirements.empty?
-          raise Informative, "A `:head` dependency may not specify version " \
+          raise Informative, 'A `:head` dependency may not specify version ' \
             "requirements (#{name})."
         end
       end

data/lib/cocoapods-core/gem_version.rb

@@ -1,5 +1,5 @@
 module Pod
   # The version of the cocoapods-core.
   #
-  CORE_VERSION = '0.32.1' unless defined? Pod::CORE_VERSION
+  CORE_VERSION = '0.33.0' unless defined? Pod::CORE_VERSION
 end

data/lib/cocoapods-core/http.rb

@@ -0,0 +1,76 @@
+module Pod
+  # Handles HTTP requests
+  #
+  module HTTP
+    # Resolve potential redirects and return the final URL.
+    #
+    # @return [string]
+    #
+    def self.get_actual_url(url)
+      redirects = 0
+
+      loop do
+        response = perform_head_request(url)
+
+        if [301, 302, 303, 307, 308].include? response.status_code
+          location = response.headers['location'].first
+
+          if location =~ /:\/\//
+            url = location
+          else
+            url = URI.join(url, location).to_s
+          end
+
+          redirects += 1
+        else
+          break
+        end
+
+        break unless redirects < MAX_HTTP_REDIRECTS
+      end
+
+      url
+    end
+
+    # Performs validation of a URL
+    #
+    # @return [REST::response]
+    #
+    def self.validate_url(url)
+      return nil unless url =~ /^#{URI.regexp}$/
+
+      begin
+        url = get_actual_url(url)
+        resp = perform_head_request(url)
+      rescue SocketError
+        resp = nil
+      end
+
+      resp
+    end
+
+    #-------------------------------------------------------------------------#
+
+    private
+
+    # Does a HEAD request and in case of any errors a GET request
+    #
+    # @return [REST::response]
+    #
+    def self.perform_head_request(url)
+      require 'rest'
+
+      resp = ::REST.head(url)
+
+      if resp.status_code >= 400
+        resp = ::REST.get(url)
+      end
+
+      resp
+    end
+
+    MAX_HTTP_REDIRECTS = 3
+
+    #-------------------------------------------------------------------------#
+  end
+end

data/lib/cocoapods-core/lockfile.rb

@@ -141,7 +141,7 @@ module Pod
 
       unless dep && version
         raise StandardError, "Attempt to lock the `#{name}` Pod without an " \
-          "known dependency."
+          'known dependency.'
       end
 
       locked_dependency = dep.dup

data/lib/cocoapods-core/podfile/dsl.rb

@@ -37,7 +37,7 @@ module Pod
       #   The Podfile specifies the dependencies of each user target.
       #
       #   * `pod` is the way to declare a specific dependency.
-      #   * `podspec` provides an easy creation API for local podspecs.
+      #   * `podspec` provides an easy API for the creation of podspecs.
       #   * `target` allows you to scope your dependencies to specific
       #   targets in your Xcode projects.
 
@@ -151,8 +151,8 @@ module Pod
       #
       def pod(name = nil, *requirements, &block)
         if block
-          raise StandardError, "Inline specifications are deprecated. " \
-            "Please store the specification in a `podspec` file."
+          raise StandardError, 'Inline specifications are deprecated. ' \
+            'Please store the specification in a `podspec` file.'
         end
 
         unless name
@@ -164,7 +164,9 @@ module Pod
 
       # Use the dependencies of a Pod defined in the given podspec file. If no
       # arguments are passed the first podspec in the root of the Podfile is
-      # used. It is intended to be used by the project of a library.
+      # used. It is intended to be used by the project of a library. Note:
+      # this does not include the sources derived from the podspec just the
+      # CocoaPods infrastructure.
       #
       # @example
       #   podspec

data/lib/cocoapods-core/podfile/target_definition.rb

@@ -352,7 +352,7 @@ module Pod
       def set_platform(name, target = nil)
         unless [:ios, :osx].include?(name)
           raise StandardError, "Unsupported platform `#{name}`. Platform " \
-            "must be `:ios` or `:osx`."
+            'must be `:ios` or `:osx`.'
         end
 
         if target
@@ -414,7 +414,7 @@ module Pod
       def store_podspec(options = nil)
         if options
           unless options.keys.all? { |key| [:name, :path].include?(key) }
-            raise StandardError, "Unrecognized options for the podspec " \
+            raise StandardError, 'Unrecognized options for the podspec ' \
               "method `#{options}`"
           end
           get_hash_value('podspecs', []) << options

data/lib/cocoapods-core/source.rb

@@ -219,7 +219,7 @@ module Pod
               texts << s.description
             rescue
               CoreUI.warn "Skipping `#{set.name}` because the podspec " \
-                "contains errors."
+                'contains errors.'
             end
             texts.grep(regexp_query).empty?
           end
@@ -293,7 +293,7 @@ module Pod
       specification(name, version) if version
     rescue Informative
       Pod::CoreUI.warn "Skipping `#{name}` because the podspec " \
-        "contains errors."
+        'contains errors.'
       nil
     end
 

data/lib/cocoapods-core/source/acceptor.rb

@@ -51,31 +51,6 @@ module Pod
       # @!group Private helpers
       #-----------------------------------------------------------------------#
 
-      MAX_HTTP_REDIRECTS = 3
-
-      # Resolve potential redirects and return the final URL.
-      #
-      # @return [string]
-      #
-      def get_actual_url(url)
-        redirects = 0
-        loop do
-          require 'rest'
-          response = REST.head(url)
-
-          if [301, 302, 303, 307, 308].include? response.status_code
-            url = response.headers['location'].first
-            redirects += 1
-          else
-            break
-          end
-
-          break unless redirects < MAX_HTTP_REDIRECTS
-        end
-
-        url
-      end
-
       # Checks whether the source of the proposed specification is different
       # from the one of the reference specification.
       #
@@ -84,6 +59,8 @@ module Pod
       # @return [void]
       #
       def check_spec_source_change(spec, errors)
+        require 'cocoapods-core/http'
+
         return unless spec
         return if spec.source[:http]
         return unless reference_spec(spec)
@@ -91,12 +68,12 @@ module Pod
         source = spec.source.values_at(*keys).compact.first
         old_source = reference_spec(spec).source.values_at(*keys).compact.first
         unless source == old_source
-          source = get_actual_url(source)
-          old_source = get_actual_url(old_source)
+          source = HTTP.get_actual_url(source)
+          old_source = HTTP.get_actual_url(old_source)
           unless source == old_source
             message = "The source of the spec doesn't match with the recorded "
             message << "ones. Source: `#{source}`. Previous: `#{old_source}`.\n "
-            message << 'Please contact the specs repo maintainers if the'
+            message << 'Please contact the specs repo maintainers if the '
             message << 'library changed location.'
             errors << message
           end
@@ -117,8 +94,8 @@ module Pod
           s.version != '0.0.1'
         end
         if has_tagged_spec
-          errors << "There is already at least one versioned specification " \
-            "so untagged versions cannot be accepted."
+          errors << 'There is already at least one versioned specification ' \
+            'so untagged versions cannot be accepted.'
         end
       end
 
@@ -145,7 +122,7 @@ module Pod
           set = source.search(dep)
           unless set && set.specification
             errors << "Unable to find a specification for the `#{dep}` " \
-              "dependency."
+              'dependency.'
           end
         end
       end

data/lib/cocoapods-core/source/aggregate.rb

@@ -131,7 +131,7 @@ module Pod
         end
         if result.empty?
           extra = ', author, summary, or description' if full_text_search
-          raise Informative, "Unable to find a pod with name" \
+          raise Informative, 'Unable to find a pod with name' \
             "#{extra} matching `#{query}'"
         end
         result
@@ -229,7 +229,7 @@ module Pod
         result
       rescue
         CoreUI.warn "Skipping `#{set.name}` because the podspec contains " \
-          "errors."
+          'errors.'
         result
       end
 

data/lib/cocoapods-core/source/file_system_data_provider.rb

@@ -58,7 +58,13 @@ module Pod
         return unless pod_dir.exist?
         pod_dir.children.map do |v|
           basename = v.basename.to_s
-          Version.new(basename) if v.directory? && basename[0, 1] != '.'
+          begin
+            Version.new(basename) if v.directory? && basename[0, 1] != '.'
+          rescue ArgumentError => e
+            raise Informative, 'An unexpected version directory ' \
+             "`#{basename}` was encountered for the " \
+             "`#{pod_dir}` Pod in the `#{name}` repository."
+          end
         end.compact.sort.reverse.map(&:to_s)
       end
 

data/lib/cocoapods-core/specification.rb

@@ -64,8 +64,6 @@ module Pod
       # self.class === other &&
       #   attributes_hash == other.attributes_hash &&
       #   subspecs == other.subspecs &&
-      #   pre_install_callback == other.pre_install_callback &&
-      #   post_install_callback == other.post_install_callback
       to_s == other.to_s
     end
 
@@ -124,10 +122,10 @@ module Pod
     def self.name_and_version_from_string(string_representation)
       match_data = string_representation.match(/(\S*) \((.*)\)/)
       unless match_data
-        raise Informative, "Invalid string representation for a " \
+        raise Informative, 'Invalid string representation for a ' \
           "Specification: `#{string_representation}`." \
-          "String representation should include the name and " \
-          "the version of a pod."
+          'String representation should include the name and ' \
+          'the version of a pod.'
       end
       name = match_data[1]
       vers = Version.new(match_data[2])
@@ -207,32 +205,35 @@ module Pod
         subspec_name = remainder.split('/').shift
         subspec = subspecs.find { |s| s.base_name == subspec_name }
         unless subspec
-          raise Informative, "Unable to find a specification named " \
+          raise Informative, 'Unable to find a specification named ' \
             "`#{relative_name}` in `#{name} (#{version})`."
         end
         subspec.subspec_by_name(remainder)
       end
     end
 
-    # @return [String] the name of the default subspec if provided.
+    # @return [Array] the name of the default subspecs if provided.
     #
-    def default_subspec
-      attributes_hash['default_subspec']
+    def default_subspecs
+      # TODO: remove singular form and update the JSON specs.
+      Array(attributes_hash['default_subspecs'] || attributes_hash['default_subspec'])
     end
 
     # Returns the dependencies on subspecs.
     #
     # @note   A specification has a dependency on either the
-    #         {#default_subspec} or each of its children subspecs that are
+    #         {#default_subspecs} or each of its children subspecs that are
     #         compatible with its platform.
     #
     # @return [Array<Dependency>] the dependencies on subspecs.
     #
     def subspec_dependencies(platform = nil)
-      if default_subspec
-        specs = [root.subspec_by_name("#{name}/#{default_subspec}")]
-      else
+      if default_subspecs.empty?
         specs = subspecs.compact
+      else
+        specs = default_subspecs.map do |subspec_name|
+          root.subspec_by_name("#{name}/#{subspec_name}")
+        end
       end
       if platform
         specs = specs.select { |s| s.supported_on_platform?(platform) }
@@ -377,55 +378,8 @@ module Pod
 
     public
 
-    # @!group Deprecated Hooks support
-    #-------------------------------------------------------------------------#
-
-    # @return [Proc] the pre install callback if defined.
-    #
-    attr_reader :pre_install_callback
-
-    # @return [Proc] the post install callback if defined.
-    #
-    attr_reader :post_install_callback
-
-    # Calls the pre install callback if defined.
-    #
-    # @param  [Pod::LocalPod] pod
-    #         the local pod instance that manages the files described by this
-    #         specification.
-    #
-    # @param  [Podfile::TargetDefinition] target_definition
-    #         the target definition that required this specification as a
-    #         dependency.
-    #
-    # @return [Bool] whether a pre install callback was specified and it was
-    #         called.
-    #
-    def pre_install!(pod, target_definition)
-      return false unless @pre_install_callback
-      @pre_install_callback.call(pod, target_definition)
-      true
-    end
-
-    # Calls the post install callback if defined.
-    #
-    # @param  [Pod::TargetInstaller] target_installer
-    #         the target installer that is performing the installation of the
-    #         pod.
-    #
-    # @return [Bool] whether a post install callback was specified and it was
-    #         called.
-    #
-    def post_install!(target_installer)
-      return false unless @post_install_callback
-      @post_install_callback.call(target_installer)
-      true
-    end
-
     #-------------------------------------------------------------------------#
 
-    public
-
     # @!group DSL attribute writers
 
     # Sets the value for the attribute with the given name.

data/lib/cocoapods-core/specification/dsl.rb

@@ -526,8 +526,8 @@ module Pod
       #           The deployment target of the platform.
       #
       def deployment_target=(*args)
-        raise Informative, "The deployment target can be declared only per " \
-          "platform."
+        raise Informative, 'The deployment target can be declared only per ' \
+          'platform.'
       end
 
       #-----------------------------------------------------------------------#
@@ -574,7 +574,7 @@ module Pod
         name, *version_requirements = args
         if name == self.name
           raise Informative, "A specification can't require itself as a " \
-            "subspec"
+            'subspec'
         end
         if @parent
           composed_name = ''
@@ -582,7 +582,7 @@ module Pod
             composed_name << component
             if name == composed_name
               raise Informative, "A subspec can't require one of its " \
-                "parents specifications"
+                'parents specifications'
             else
               composed_name << '/'
             end
@@ -1192,9 +1192,9 @@ module Pod
 
       #------------------#
 
-      # @!method default_subspec=(subspec_name)
+      # @!method default_subspecs=(subspec_array)
       #
-      #   The name of the subspec that should be used as preferred dependency.
+      #   An array of subspecs names that should be used as preferred dependency.
       #   If not specified a specifications requires all its subspecs as
       #   dependencies.
       #
@@ -1209,13 +1209,19 @@ module Pod
       #   they trigger dependencies on other libraries).
       #
       #   @example
-      #     spec.default_subspec = 'Pod/Core'
       #
-      #   @param  [String] subspec_name
-      #           the name of the subspec that should be inherited as
+      #     spec.default_subspec = 'Core'
+      #
+      #   @example
+      #     spec.default_subspecs = 'Core', 'UI'
+      #
+      #   @param  [Array<String>] subspec_names
+      #           An array of subspec names that should be inherited as
       #           dependency.
       #
-      attribute :default_subspec,
+      attribute :default_subspecs,
+                :container => Array,
+                :singularize => true,
                 :multi_platform => false
 
       #-----------------------------------------------------------------------#

data/lib/cocoapods-core/specification/dsl/deprecations.rb

@@ -5,47 +5,33 @@ module Pod
       #
       module Deprecations
         def preferred_dependency=(name)
-          self.default_subspec = name
+          self.default_subspecs = [name]
           CoreUI.warn "[#{self}] `preferred_dependency` has been renamed "\
-            "to `default_subspec`."
+            'to `default_subspecs`.'
         end
 
         def singleton_method_added(method)
-          if method == :pre_install
-            CoreUI.warn "[#{self}] The use of `#{method}` by overriding " \
-              "the method is deprecated."
-            @pre_install_callback = proc do |pod, target_definition|
-              pre_install(pod, target_definition)
-            end
-
-          elsif method == :post_install
-            CoreUI.warn "[#{self}] The use of `#{method}` by overriding the " \
-              "method is deprecated."
-            @post_install_callback = proc do |target_installer|
-              post_install(target_installer)
-            end
-
-          elsif method == :header_mappings
+          if method == :header_mappings
             raise Informative, "[#{self}] The use of the `header_mappings` " \
               "hook has been deprecated.\n Use the `header_dir` and the " \
-                "`header_mappings_dir` attributes."
+                '`header_mappings_dir` attributes.'
 
           elsif method == :copy_header_mapping
             raise Informative, "[#{self}] The use of the " \
               "`copy_header_mapping` hook has been deprecated.\nUse" \
-                "the `header_dir` and the `header_mappings_dir` attributes."
+                'the `header_dir` and the `header_mappings_dir` attributes.'
           end
         end
 
         def documentation=(value)
           CoreUI.warn "[#{self}] The `documentation` DSL directive of the " \
-            "podspec format has been deprecated."
+            'podspec format has been deprecated.'
         end
 
         def clean_paths=(value)
           raise Informative, "[#{self}] Clean paths are deprecated. " \
-            "CocoaPods now cleans unused files by default. Use the " \
-              "`preserve_paths` attribute if needed."
+            'CocoaPods now cleans unused files by default. Use the ' \
+              '`preserve_paths` attribute if needed.'
         end
 
         DEPRECATED_METHODS = [
@@ -60,78 +46,6 @@ module Pod
               "`#{method.to_s[0..-2]}` has been deprecated."
           end
         end
-
-        # @!group Hooks
-        #
-        #   The specification class provides hooks which are called by
-        #   CocoaPods when a Pod is installed.
-
-        #-----------------------------------------------------------------------#
-
-        # This is a convenience method which gets called after all pods have
-        # been downloaded but before they have been installed, and the Xcode
-        # project and related files have been generated. Note that this hook is
-        # called for each Pods library and only for installations where the Pod
-        # is installed.
-        #
-        # This hook should be used to generate and modify the files of the Pod.
-        #
-        # It receives the
-        # [`Pod::Hooks::PodRepresentation`](http://docs.cocoapods.org/cocoapods/pod/hooks/podrepresentation/)
-        # and the
-        # [`Pod::Hooks::LibraryRepresentation`](http://docs.cocoapods.org/cocoapods/pod/hooks/libraryrepresentation/)
-        # instances.
-        #
-        # Override this to, for instance, to run any build script.
-        #
-        # @example
-        #
-        #   spec.pre_install do |pod, target_definition|
-        #     Dir.chdir(pod.root){ `sh make.sh` }
-        #   end
-        #
-        def pre_install(&block)
-          CoreUI.warn "[#{self}] The pre install hook of the specification " \
-            "DSL has been deprecated, use the `resource_bundles` or the " \
-            "`prepare_command` attributes."
-          CoreUI.warn "[#{self}] The pre_install hook will be removed in " \
-            "the next release"
-          @pre_install_callback = block
-        end
-
-        # This is a convenience method which gets called after all pods have been
-        # downloaded, installed, and the Xcode project and related files have
-        # been generated. Note that this hook is called for each Pods library and
-        # only for installations where the Pod is installed.
-        #
-        # To modify and generate files for the Pod the pre install hook should be
-        # used instead of this one.
-        #
-        # It receives a
-        # [`Pod::Hooks::LibraryRepresentation`](http://docs.cocoapods.org/cocoapods/pod/hooks/libraryrepresentation/)
-        # instance for the current target.
-        #
-        # Override this to, for instance, add to the prefix header.
-        #
-        # @example
-        #
-        #   spec.post_install do |library_representation|
-        #     prefix_header = library_representation.prefix_header_path
-        #     prefix_header.open('a') do |file|
-        #       file.puts('#ifdef __OBJC__\n#import "SSToolkitDefines.h"\n#endif')
-        #     end
-        #   end
-        #
-        def post_install(&block)
-          CoreUI.warn "[#{self}] The post install hook of the specification " \
-            "DSL has been deprecated, use the `resource_bundles` or the " \
-            "`prepare_command` attributes."
-          CoreUI.warn "[#{self}] The post_install hook will be removed in " \
-            "the next release"
-          @post_install_callback = block
-        end
-
-        #-----------------------------------------------------------------------#
       end
     end
   end

data/lib/cocoapods-core/specification/json.rb

@@ -24,8 +24,10 @@ module Pod
       # @return [Bool] Whether the specification can be converted to a hash
       #         without loss of information.
       #
+      # TODO: remove
+      #
       def safe_to_hash?
-        pre_install_callback.nil? && post_install_callback.nil?
+        true
       end
     end
 

data/lib/cocoapods-core/specification/linter.rb

@@ -50,7 +50,8 @@ module Pod
           run_root_validation_hooks
           perform_all_specs_analysis
         else
-          error "The specification defined in `#{file}` could not be loaded." \
+          error "[spec] The specification defined in `#{file}` could not be" \
+          ' loaded.' \
             "\n\n#{@raise_message}"
         end
         results.empty?
@@ -91,9 +92,9 @@ module Pod
           next unless attr.required?
           unless value && (!value.respond_to?(:empty?) || !value.empty?)
             if attr.name == :license
-              warning("Missing required attribute `#{attr.name}`.")
+              warning("[attributes] Missing required attribute `#{attr.name}`.")
             else
-              error("Missing required attribute `#{attr.name}`.")
+              error("[attributes] Missing required attribute `#{attr.name}`.")
             end
           end
         end
@@ -173,24 +174,25 @@ module Pod
           ]
           names_match = acceptable_names.include?(file.basename.to_s)
           unless names_match
-            error 'The name of the spec should match the name of the file.'
+            error '[name] The name of the spec should match the name of the \
+                    file.'
           end
 
           if spec.root.name =~ /\s/
-            error 'The name of a spec should not contain whitespace.'
+            error '[name] The name of a spec should not contain whitespace.'
           end
 
           if spec.root.name[0, 1] == '.'
-            error 'The name of a spec should not begin with a period.'
+            error '[name] The name of a spec should not begin with a period.'
           end
         end
       end
 
       def _validate_version(v)
         if v.to_s.empty?
-          error 'A version is required.'
+          error '[version] A version is required.'
         elsif v <= Version::ZERO
-          error 'The version of the spec should be higher than 0.'
+          error '[version] The version of the spec should be higher than 0.'
         end
       end
 
@@ -198,11 +200,11 @@ module Pod
       #
       def _validate_summary(s)
         if s.length > 140
-          warning "The summary should be a short version of `description` " \
-            "(max 140 characters)."
+          warning '[summary] The summary should be a short version of' \
+          '`description` (max 140 characters).'
         end
         if s =~ /A short description of/
-          warning 'The summary is not meaningful.'
+          warning '[summary] The summary is not meaningful.'
         end
       end
 
@@ -210,13 +212,13 @@ module Pod
       #
       def _validate_description(d)
         if d =~ /An optional longer description of/
-          warning 'The description is not meaningful.'
+          warning '[description] The description is not meaningful.'
         end
         if d == spec.summary
-          warning 'The description is equal to the summary.'
+          warning '[description] The description is equal to the summary.'
         end
         if d.length < spec.summary.length
-          warning 'The description is shorter than the summary.'
+          warning '[description] The description is shorter than the summary.'
         end
       end
 
@@ -224,7 +226,7 @@ module Pod
       #
       def _validate_homepage(h)
         if h =~ %r{http://EXAMPLE}
-          warning 'The homepage has not been updated from default'
+          warning '[homepage] The homepage has not been updated from default'
         end
       end
 
@@ -232,7 +234,7 @@ module Pod
       #
       def _validate_frameworks(frameworks)
         if frameworks_invalid?(frameworks)
-          error 'A framework should only be specified by its name'
+          error '[frameworks] A framework should only be specified by its name'
         end
       end
 
@@ -240,7 +242,8 @@ module Pod
       #
       def _validate_weak_frameworks(frameworks)
         if frameworks_invalid?(frameworks)
-          error 'A weak framework should only be specified by its name'
+          error '[weak_frameworks] A weak framework should only be specified' \
+          'by its name'
         end
       end
 
@@ -250,15 +253,18 @@ module Pod
         libs.each do |lib|
           lib = lib.downcase
           if lib.end_with?('.a') || lib.end_with?('.dylib')
-            error "Libraries should not include the extension (`#{lib}`)"
+            error '[libraries] Libraries should not include the extension ' \
+            "(`#{lib}`)"
           end
 
           if lib.start_with?('lib')
-            error "Libraries should omit the `lib` prefix (`#{lib}`)"
+            error '[libraries] Libraries should omit the `lib` prefix' \
+            " (`#{lib}`)"
           end
 
           if lib.include?(',')
-            error "Libraries should not include comas (`#{lib}`)"
+            error '[libraries] Libraries should not include comas' \
+            "(`#{lib}`)"
           end
         end
       end
@@ -268,13 +274,13 @@ module Pod
       def _validate_license(l)
         type = l[:type]
         if type.nil?
-          warning 'Missing license type.'
+          warning '[license] Missing license type.'
         end
         if type && type.gsub(' ', '').gsub("\n", '').empty?
-          warning 'Invalid license type.'
+          warning '[license] Invalid license type.'
         end
         if type && type =~ /\(example\)/
-          error 'Sample license type.'
+          error '[license] Sample license type.'
         end
       end
 
@@ -286,20 +292,21 @@ module Pod
           version = spec.version.to_s
 
           if git =~ %r{http://EXAMPLE}
-            error 'The Git source still contains the example URL.'
+            error '[source] The Git source still contains the example URL.'
           end
           if commit && commit.downcase =~ /head/
-            error 'The commit of a Git source cannot be `HEAD`.'
+            error '[source] The commit of a Git source cannot be `HEAD`.'
           end
           if tag && !tag.to_s.include?(version)
-            warning 'The version should be included in the Git tag.'
+            warning '[source] The version should be included in the Git tag.'
           end
           if version == '0.0.1'
             if commit.nil? && tag.nil?
-              error 'Git sources should specify either a commit or a tag.'
+              error '[source] Git sources should specify either a commit or' \
+              'a tag.'
             end
           else
-            warning 'Git sources should specify a tag.' if tag.nil?
+            warning '[source] Git sources should specify a tag.' if tag.nil?
           end
         end
 
@@ -314,12 +321,18 @@ module Pod
         if git = s[:git]
           return unless git =~ /^#{URI.regexp}$/
           git_uri = URI.parse(git)
+          if git_uri.host == 'www.github.com'
+            warning '[github_sources] Github repositories should not use' \
+            '`www` in URL.'
+          end
           if git_uri.host == 'github.com' || git_uri.host == 'gist.github.com'
             unless git.end_with?('.git')
-              warning 'Github repositories should end in `.git`.'
+              warning '[github_sources] Github repositories should end in' \
+              '`.git`.'
             end
             unless git_uri.scheme == 'https'
-              warning 'Github repositories should use `https` link.'
+              warning '[github_sources] Github repositories should use' \
+              '`https` link.'
             end
           end
         end
@@ -329,7 +342,8 @@ module Pod
       #
       def _validate_social_media_url(s)
         if s =~ %r{https://twitter.com/EXAMPLE}
-          warning 'The social media URL has not been updated from default'
+          warning '[social_media_url] The social media URL has not been' \
+          'updated from default'
         end
       end
 
@@ -343,7 +357,8 @@ module Pod
       #
       def _validate_compiler_flags(flags)
         if flags.join(' ').split(' ').any? { |flag| flag.start_with?('-Wno') }
-          warning "Warnings must not be disabled (`-Wno' compiler flags)."
+          warning '[compiler_flags] Warnings must not be disabled' \
+          '(`-Wno compiler` flags).'
         end
       end
 

data/lib/cocoapods-core/specification/linter/analyzer.rb

@@ -15,7 +15,6 @@ module Pod
           validate_file_patterns
           check_tmp_arc_not_nil
           check_if_spec_is_empty
-          check_install_hooks
         end
 
         private
@@ -35,8 +34,8 @@ module Pod
             end
             patterns.each do |pattern|
               if pattern.start_with?('/')
-                error "File patterns must be relative and cannot start with a " \
-                "slash (#{attrb.name})."
+                error '[File Patterns] File patterns must be relative ' \
+                "and cannot start with a slash (#{attrb.name})."
               end
             end
           end
@@ -55,8 +54,9 @@ module Pod
           end
 
           unless declared
-            warning "A value for `requires_arc` should be specified until the " \
-            "migration to a `true` default."
+            warning '[requires_arc] A value for `requires_arc` should be' \
+            ' specified until the ' \
+            'migration to a `true` default.'
           end
         end
 
@@ -68,23 +68,11 @@ module Pod
           empty_patterns = methods.all? { |m| consumer.send(m).empty? }
           empty = empty_patterns && consumer.spec.subspecs.empty?
           if empty
-            error "The #{consumer.spec} spec is empty (no source files, " \
-            "resources, resource_bundles, preserve paths, vendored_libraries, " \
-              "vendored_frameworks dependencies or subspecs)."
-          end
-        end
-
-        # Check the hooks
-        #
-        def check_install_hooks
-          unless consumer.spec.pre_install_callback.nil?
-            warning "The pre install hook has been deprecated, " \
-            "use the `resource_bundles` or the  `prepare_command` attributes."
-          end
-
-          unless consumer.spec.post_install_callback.nil?
-            warning "The post install hook has been deprecated, " \
-            "use the `resource_bundles` or the  `prepare_command` attributes."
+            error "[File Patterns] The #{consumer.spec} spec is empty"
+            '(no source files, ' \
+            'resources, resource_bundles, preserve paths,' \
+            'vendored_libraries, vendored_frameworks dependencies' \
+            'or subspecs).'
           end
         end
       end

data/lib/cocoapods-core/specification/set.rb

@@ -61,10 +61,10 @@ module Pod
         dependencies << dependency
 
         if acceptable_versions.empty?
-          message = "Unable to satisfy the following requirements:\n"
+          message = "Unable to satisfy the following requirements:\n\n"
           dependencies_by_requirer_name.each do |name, dependencies|
             dependencies.each do |dep|
-              message << "- `#{dep}` required by `#{name}`"
+              message << "- `#{dep}` required by `#{name}`\n"
             end
           end
           raise Informative, message

data/lib/cocoapods-core/yaml_helper.rb

@@ -76,7 +76,7 @@ module Pod
         when Array      then process_array(value)
         when Hash       then process_hash(value, hash_keys_hint)
         else
-          raise StandardError, "Unsupported class for YAML conversion " \
+          raise StandardError, 'Unsupported class for YAML conversion ' \
             "#{value.class}"
         end
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cocoapods-core
 version: !ruby/object:Gem::Version
-  version: 0.32.1
+  version: 0.33.0
 platform: ruby
 authors:
 - Eloy Duran
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-15 00:00:00.000000000 Z
+date: 2014-05-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -18,9 +18,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.15
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -28,9 +25,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.15
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '4'
 - !ruby/object:Gem::Dependency
   name: nap
   requirement: !ruby/object:Gem::Requirement
@@ -105,6 +99,7 @@ files:
 - lib/cocoapods-core/dependency.rb
 - lib/cocoapods-core/gem_version.rb
 - lib/cocoapods-core/github.rb
+- lib/cocoapods-core/http.rb
 - lib/cocoapods-core/lockfile.rb
 - lib/cocoapods-core/platform.rb
 - lib/cocoapods-core/podfile.rb