cocaine 0.4.1 → 0.4.2

data/NEWS.md

@@ -1,3 +1,8 @@
+New for 0.4.2:
+
+* Loggers that don't understand `tty?`, like `ActiveSupport::BufferedLogger`
+  will still work.
+
 New for 0.4.1:
 
 * Introduce FakeRunner for testing, so you don't really run commands.

data/cocaine.gemspec

@@ -21,5 +21,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency('mocha')
   s.add_development_dependency('rake')
   s.add_development_dependency('posix-spawn')
+  s.add_development_dependency('active_support')
+  s.add_development_dependency('pry')
 end
 

data/lib/cocaine/command_line.rb

@@ -95,7 +95,7 @@ module Cocaine
     private
 
     def colored(text, ansi_color = "\e[32m")
-      if @logger && @logger.tty?
+      if @logger && @logger.respond_to?(:tty?) && @logger.tty?
         "#{ansi_color}#{text}\e[0m"
       else
         text

data/lib/cocaine/version.rb

@@ -1,3 +1,3 @@
 module Cocaine
-  VERSION = "0.4.1".freeze
+  VERSION = "0.4.2".freeze
 end

data/spec/cocaine/command_line_spec.rb

@@ -179,6 +179,15 @@ describe Cocaine::CommandLine do
     logger.entries.should include("\e[32mCommand\e[0m :: echo 'Logging!' 'bar'")
   end
 
+  it 'can still take something that does not respond to tty as a logger' do
+    output_buffer = StringIO.new
+    logger = ActiveSupport::BufferedLogger.new(output_buffer)
+    logger.should_not respond_to(:tty?)
+    Cocaine::CommandLine.new("echo", "'Logging!' :foo", :logger => logger).run(:foo => "bar")
+    output_buffer.rewind
+    output_buffer.read.should == "Command :: echo 'Logging!' 'bar'\n"
+  end
+
   it "logs the command to a supplied logger" do
     logger = FakeLogger.new
     Cocaine::CommandLine.new("echo", "'Logging!' :foo", :logger => logger).run(:foo => "bar")

data/spec/spec_helper.rb

@@ -4,6 +4,8 @@ require 'bourne'
 require 'cocaine'
 require 'timeout'
 require 'tempfile'
+require 'pry'
+require 'active_support/buffered_logger'
 
 Dir[File.dirname(__FILE__) + "/support/**.rb"].each{|support_file| require support_file }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cocaine
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
   prerelease: 
 platform: ruby
 authors:
@@ -91,6 +91,38 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: active_support
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A small library for doing (command) lines
 email: jyurek@thoughtbot.com
 executables: []