cobra_commander 0.12.0 → 0.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8461ea231fa9be478360d33fbadfb8983512172687831ac7c17ac1f927614200
-  data.tar.gz: 0b36b28eadecb6e0bc6e7ee8c3e6db951f7dc7d74be67c91b97659dc7bd52c5e
+  metadata.gz: 4eb007805f5f11954ed14e349409c7486fc6b52d0a041f8066c75c47f8d045b8
+  data.tar.gz: 68ac383fb087d118a276e5aed0199b51fd09b05c110d7ff4539f18097b1ea367
 SHA512:
-  metadata.gz: 39a0956db1750d63553d87e4d13ad75246f4f4633b3d6a42de621c45f11a515506ab5f0d7f14343d61f183d03df7e8218dee8f93a439da023e442d70c7f3b681
-  data.tar.gz: 227acbdb961e2903cdaacd44ed4bdd7b07a48e7298737bbe5b6228bd28df8aa6c7aea6a6949de2a3eea999287b633e9bfcd32b7b9e108e3f7f4fcaa7385e2806
+  metadata.gz: 6a5f69e411bf49bd1de717934f27c0d364378e07ce1728855b2783de0c73dff791be433565b689656d4481b2ad294086fc43118beafc16ca445a2c91ea7916c9
+  data.tar.gz: afdf327649c953bc155f5e01a6db9f4cef12ed625f7c791534e7ae65ac0d05c2260bfd20b03f382eac9aaee9f2e84612806c050327491c2f806223d7e612aa67

data/.github/workflows/ci.yml

@@ -40,10 +40,7 @@ jobs:
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: 3.0
-    - uses: reviewdog/action-rubocop@v1
-      with:
-        rubocop_version: 0.88.0
-        filter_mode: nofilter
-        fail_on_error: true
-        rubocop_extensions: ""
-        github_token: ${{ secrets.github_token }}
+    - name: Bundle
+      run: bundle
+    - name: Run standard
+      run: bundle exec rake standard

data/.github/workflows/release.yml

@@ -10,7 +10,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Release Gem
         uses: cadwallion/publish-rubygems-action@master
         if: contains(github.ref, 'refs/tags/v')

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+## Version 0.13.0 - 2021-10-21
+
+* Sorts the interactive UI alphabetically with failures first [#66](https://github.com/powerhome/cobra_commander/pull/66)
+* Switch linter to standardrb [#67](https://github.com/powerhome/cobra_commander/pull/67)
+
 ## Version 0.12.0 - 2021-09-21
 
 * Add interactive UI and Markdown output to `cobra exec` [#63](https://github.com/powerhome/cobra_commander/pull/63)

data/Rakefile

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
-
+require "standard/rake"
 require "rspec/core/rake_task"
-RSpec::Core::RakeTask.new(:spec)
 
-require "rubocop/rake_task"
-RuboCop::RakeTask.new
+RSpec::Core::RakeTask.new(:spec)
 
-task default: %i[spec rubocop]
+task default: %i[spec standard]

data/cobra_commander.gemspec

@@ -5,32 +5,32 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "cobra_commander/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "cobra_commander"
-  spec.version       = CobraCommander::VERSION
-  spec.authors       = [
+  spec.name = "cobra_commander"
+  spec.version = CobraCommander::VERSION
+  spec.authors = [
     "Ben Langfeld",
     "Garett Arrowood",
-    "Carlos Palhares",
+    "Carlos Palhares"
   ]
   spec.email = [
     "blangfeld@powerhrg.com",
     "garett.arrowood@powerhrg.com",
-    "carlos.palhares@powerhrg.com",
+    "carlos.palhares@powerhrg.com"
   ]
-  spec.summary       = "Tools for working with Component Based Rails Apps"
-  spec.description   = <<~DESCRIPTION
+  spec.summary = "Tools for working with Component Based Rails Apps"
+  spec.description = <<~DESCRIPTION
     Tools for working with Component Based Rails Apps (see http://shageman.github.io/cbra.info/).
     Includes tools for graphing the components of an app and their relationships, as well as selectively
     testing components based on changes made.
   DESCRIPTION
-  spec.homepage      = "http://tech.powerhrg.com/cobra_commander/"
-  spec.license       = "MIT"
+  spec.homepage = "http://tech.powerhrg.com/cobra_commander/"
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.bindir = "exe"
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_dependency "bundler"
@@ -47,5 +47,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "pry"
   spec.add_development_dependency "rake", ">= 12.3.3"
   spec.add_development_dependency "rspec", "~> 3.5"
-  spec.add_development_dependency "rubocop", "0.88.0"
+  spec.add_development_dependency "standard", ">= 1.3.0"
 end

data/lib/cobra_commander/affected.rb

@@ -25,21 +25,18 @@ module CobraCommander
       @transitively.map(&method(:affected_component))
     end
 
-    def json_representation # rubocop:disable Metrics/MethodLength
+    def json_representation
       {
         changed_files: @changes,
         directly_affected_components: directly,
         transitively_affected_components: transitively,
         test_scripts: scripts,
         component_names: names,
-        languages: {
-          ruby: contains_ruby?,
-          javascript: contains_js?,
-        },
+        languages: {ruby: contains_ruby?, javascript: contains_js?}
       }.to_json
     end
 
-  private
+    private
 
     def run!
       @transitively = Set.new
@@ -68,7 +65,7 @@ module CobraCommander
       {
         name: component.name,
         path: component.root_paths,
-        type: component.sources.keys.map(&:to_s).map(&:capitalize).join(" & "),
+        type: component.sources.keys.map(&:to_s).map(&:capitalize).join(" & ")
       }
     end
 

data/lib/cobra_commander/change.rb

@@ -28,7 +28,7 @@ module CobraCommander
       puts e.message
     end
 
-  private
+    private
 
     def show_full
       changes_since_last_commit

data/lib/cobra_commander/cli/filters.rb

@@ -9,7 +9,7 @@ module CobraCommander
       method_option :self, type: :boolean, default: true, desc: "Include the own component"
     end
 
-  private
+    private
 
     def find_component(name)
       return umbrella.root unless name

data/lib/cobra_commander/cli.rb

@@ -28,7 +28,7 @@ module CobraCommander
 
     desc "ls [component]", "Lists the components in the context of a given component or umbrella"
     filter_options dependents: "Lists all dependents of a given component",
-                   dependencies: "Lists all dependencies of a given component"
+      dependencies: "Lists all dependencies of a given component"
     method_option :total, type: :boolean, aliases: "-t", desc: "Prints the total count of components"
     def ls(component = nil)
       components = components_filtered(component)
@@ -38,17 +38,17 @@ module CobraCommander
     desc "exec [component] <command>", "Executes the command in the context of a given component or set thereof. " \
                                        "Defaults to all components."
     filter_options dependents: "Run the command on each dependent of a given component",
-                   dependencies: "Run the command on each dependency of a given component"
+      dependencies: "Run the command on each dependency of a given component"
     method_option :concurrency, type: :numeric, default: DEFAULT_CONCURRENCY, aliases: "-c",
                                 desc: "Max number of jobs to run concurrently"
     method_option :interactive, type: :boolean, default: true, aliases: "-i",
-                                desc: "Runs in interactive mode to allow the user to inspect the output of each component"
+                                desc: "Runs in interactive mode to allow the user to inspect the output of each " \
+                                      "component"
     def exec(command_or_component, command = nil)
       results = CobraCommander::Executor.exec(
         components: components_filtered(command && command_or_component),
         command: command || command_or_component,
-        concurrency: options.concurrency,
-        status_output: $stderr
+        concurrency: options.concurrency, status_output: $stderr
       )
       if options.interactive && results.size > 1
         CobraCommander::Output::InteractivePrinter.run(results, $stdout)
@@ -83,7 +83,7 @@ module CobraCommander
       Change.new(umbrella, options.results, options.branch).run!
     end
 
-  private
+    private
 
     def umbrella
       @umbrella ||= CobraCommander.umbrella(options.app, yarn: options.js, bundler: options.ruby)

data/lib/cobra_commander/component.rb

@@ -45,8 +45,8 @@ module CobraCommander
 
     def dependencies
       @dependencies ||= @dependency_names.sort
-                                         .map(&@umbrella.method(:find))
-                                         .compact
+        .map(&@umbrella.method(:find))
+        .compact
     end
   end
 end

data/lib/cobra_commander/dependencies/bundler.rb

@@ -21,11 +21,11 @@ module CobraCommander
 
       def components
         components_source.specs.map do |spec|
-          { path: spec.loaded_from, name: spec.name, dependencies: spec.dependencies.map(&:name) }
+          {path: spec.loaded_from, name: spec.name, dependencies: spec.dependencies.map(&:name)}
         end
       end
 
-    private
+      private
 
       def lockfile
         @lockfile ||= ::Bundler::LockfileParser.new(::Bundler.read_file(path))

data/lib/cobra_commander/dependencies/yarn/package.rb

@@ -24,10 +24,10 @@ module CobraCommander
 
         def dependencies
           json.fetch("dependencies", {})
-              .merge(json.fetch("devDependencies", {}))
+            .merge(json.fetch("devDependencies", {}))
         end
 
-      private
+        private
 
         def json
           @json ||= JSON.parse(File.read(@path))

data/lib/cobra_commander/dependencies/yarn_workspace.rb

@@ -28,11 +28,11 @@ module CobraCommander
 
       def components
         @repo.specs.map do |spec|
-          { path: spec.path, name: untag(spec.name), dependencies: spec.dependencies.keys.map(&method(:untag)) }
+          {path: spec.path, name: untag(spec.name), dependencies: spec.dependencies.keys.map(&method(:untag))}
         end
       end
 
-    private
+      private
 
       def load_workspace_packages
         workspace_spec.map do |_name, spec|

data/lib/cobra_commander/executor/concurrent.rb

@@ -23,7 +23,7 @@ module CobraCommander
         @results
       end
 
-    private
+      private
 
       def pastel
         @pastel ||= Pastel.new
@@ -33,7 +33,7 @@ module CobraCommander
         @spinner_options ||= {
           format: :bouncing,
           success_mark: pastel.green("[DONE]"),
-          error_mark: pastel.red("[ERROR]"),
+          error_mark: pastel.red("[ERROR]")
         }
       end
 

data/lib/cobra_commander/executor/context.rb

@@ -4,6 +4,8 @@ require "tty-command"
 
 module CobraCommander
   module Executor
+    # Represents a component context to execute a command
+    # @private
     class Context
       attr_reader :component, :command
 
@@ -33,7 +35,7 @@ module CobraCommander
         results.join("\n")
       end
 
-    private
+      private
 
       def isolate_bundle(&block)
         if Bundler.respond_to?(:with_unbundled_env)

data/lib/cobra_commander/executor.rb

@@ -8,7 +8,7 @@ module CobraCommander
   module Executor
     def self.exec(components:, command:, concurrency:, status_output:)
       Concurrent.new(components, concurrency: concurrency, spin_output: status_output)
-                .exec(command)
+        .exec(command)
     end
   end
 end

data/lib/cobra_commander/output/ascii_tree.rb

@@ -6,9 +6,9 @@ module CobraCommander
   module Output
     # Prints the tree in a nice tree form
     class AsciiTree
-      SPACE  = "    "
-      BAR    = "│   "
-      TEE    = "├── "
+      SPACE = "    "
+      BAR = "│   "
+      TEE = "├── "
       CORNER = "└── "
 
       def initialize(component)
@@ -22,7 +22,7 @@ module CobraCommander
         end.string
       end
 
-    private
+      private
 
       def list_dependencies(io, component, outdents = [])
         component.dependencies.each do |dep|

data/lib/cobra_commander/output/graph_viz.rb

@@ -17,7 +17,7 @@ module CobraCommander
       end
 
       private_class_method def self.extract_format(output)
-        format = output[-3..-1]
+        format = output[-3..-1] # standard:disable Style/SlicingWithRange
         return format if %w[png dot].include?(format)
 
         raise ArgumentError, "output format must be 'png' or 'dot'"

data/lib/cobra_commander/output/interactive_printer.rb

@@ -6,26 +6,42 @@ require "tty-prompt"
 module CobraCommander
   module Output
     # Runs an interactive output printer
-    module InteractivePrinter
+    class InteractivePrinter
       pastel = Pastel.new
-      SUCCESS = "#{pastel.green("✔")} %s".freeze
-      ERROR = "#{pastel.red("✖")} %s".freeze
-      BYE = pastel.decorate("👋 Bye!", :white, :on_black, :bold).freeze
+      SUCCESS = "#{pastel.green("✔")} %s"
+      ERROR = "#{pastel.red("✖")} %s"
+      BYE = pastel.decorate("\n\n👋 Bye!", :white, :on_black, :bold).freeze
 
       def self.run(contexts, output)
-        prompt = TTY::Prompt.new
-        context_options = contexts.reduce({}) do |options, context|
+        new(contexts).run(output)
+      end
+
+      def initialize(contexts)
+        @prompt = TTY::Prompt.new
+        @options = contexts.sort(&method(:sort_contexts))
+          .reduce({}) do |options, context|
           template = context.success? ? SUCCESS : ERROR
-          options.merge(
-            format(template, context.component_name) => context
-          )
+          options.merge format(template, context.component_name) => context
         end
+      end
+
+      def run(output)
         loop do
-          context = prompt.select("Print output?", context_options)
+          context = @prompt.select("Print output?", @options)
           output.puts context.output
         end
       rescue TTY::Reader::InputInterrupt
-        output.puts "\n\n", BYE
+        output.puts BYE
+      end
+
+      private
+
+      def sort_contexts(context_a, context_b)
+        if context_a.success? == context_b.success?
+          context_a.component_name <=> context_b.component_name
+        else
+          context_a.success? ? 1 : -1
+        end
       end
     end
   end

data/lib/cobra_commander/output/markdown_printer.rb

@@ -7,9 +7,9 @@ module CobraCommander
   module Output
     # Prints the given CobraCommander::Executor::Context to [output] collection in markdown
     module MarkdownPrinter
-      SUCCESS = "\n## ✔ %s\n".freeze
-      ERROR = "\n## ✖ %s\n".freeze
-      OUTPUT = "\n```\n$ %s\n\n%s\n```\n".freeze
+      SUCCESS = "\n## ✔ %s\n"
+      ERROR = "\n## ✖ %s\n"
+      OUTPUT = "\n```\n$ %s\n\n%s\n```\n"
 
       def self.run(contexts, output)
         contexts.each do |context|

data/lib/cobra_commander/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CobraCommander
-  VERSION = "0.12.0"
+  VERSION = "0.13.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cobra_commander
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.13.0
 platform: ruby
 authors:
 - Ben Langfeld
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-09-21 00:00:00.000000000 Z
+date: 2021-10-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -201,19 +201,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.5'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: standard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.88.0
+        version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.88.0
+        version: 1.3.0
 description: |
   Tools for working with Component Based Rails Apps (see http://shageman.github.io/cbra.info/).
   Includes tools for graphing the components of an app and their relationships, as well as selectively